Re: [RFC][PATCH] drm: kirin: Fix dsi probe/attach logic

2019-09-14 Thread Rob Clark
On Wed, Sep 11, 2019 at 7:39 PM John Stultz wrote: > > On Wed, Sep 4, 2019 at 3:26 AM Andrzej Hajda wrote: > > On 03.09.2019 18:18, John Stultz wrote: > > > On Mon, Sep 2, 2019 at 6:22 AM Andrzej Hajda wrote: > > >> On 30.08.2019 19:00, Rob Clark wrote: > > >>> On Thu, Aug 29, 2019 at 11:52 PM

Re: [RFC][PATCH] drm: kirin: Fix dsi probe/attach logic

2019-09-13 Thread John Stultz
On Fri, Sep 13, 2019 at 1:47 AM Andrzej Hajda wrote: > On 12.09.2019 16:18, Matt Redfearn wrote: > > On 12/09/2019 14:21, Andrzej Hajda wrote: > >> On 12.09.2019 04:38, John Stultz wrote: > >>> Should I resubmit the kirin fix for the adv7511 regression here? > >>> Or do we revert the adv7511

Re: [RFC][PATCH] drm: kirin: Fix dsi probe/attach logic

2019-09-13 Thread Andrzej Hajda
On 12.09.2019 16:18, Matt Redfearn wrote: > > On 12/09/2019 14:21, Andrzej Hajda wrote: >> On 12.09.2019 04:38, John Stultz wrote: >>> On Wed, Sep 4, 2019 at 3:26 AM Andrzej Hajda wrote: On 03.09.2019 18:18, John Stultz wrote: > On Mon, Sep 2, 2019 at 6:22 AM Andrzej Hajda wrote: >>

Re: [RFC][PATCH] drm: kirin: Fix dsi probe/attach logic

2019-09-12 Thread Matt Redfearn
On 12/09/2019 14:21, Andrzej Hajda wrote: > On 12.09.2019 04:38, John Stultz wrote: >> On Wed, Sep 4, 2019 at 3:26 AM Andrzej Hajda wrote: >>> On 03.09.2019 18:18, John Stultz wrote: On Mon, Sep 2, 2019 at 6:22 AM Andrzej Hajda wrote: > On 30.08.2019 19:00, Rob Clark wrote: >> On

Re: [RFC][PATCH] drm: kirin: Fix dsi probe/attach logic

2019-09-12 Thread Andrzej Hajda
On 12.09.2019 04:38, John Stultz wrote: > On Wed, Sep 4, 2019 at 3:26 AM Andrzej Hajda wrote: >> On 03.09.2019 18:18, John Stultz wrote: >>> On Mon, Sep 2, 2019 at 6:22 AM Andrzej Hajda wrote: On 30.08.2019 19:00, Rob Clark wrote: > On Thu, Aug 29, 2019 at 11:52 PM Andrzej Hajda >

Re: [RFC][PATCH] drm: kirin: Fix dsi probe/attach logic

2019-09-11 Thread John Stultz
On Wed, Sep 4, 2019 at 3:26 AM Andrzej Hajda wrote: > On 03.09.2019 18:18, John Stultz wrote: > > On Mon, Sep 2, 2019 at 6:22 AM Andrzej Hajda wrote: > >> On 30.08.2019 19:00, Rob Clark wrote: > >>> On Thu, Aug 29, 2019 at 11:52 PM Andrzej Hajda > >>> wrote: > Of course it seems you have

Re: [RFC][PATCH] drm: kirin: Fix dsi probe/attach logic

2019-09-04 Thread Andrzej Hajda
On 03.09.2019 18:18, John Stultz wrote: > On Mon, Sep 2, 2019 at 6:22 AM Andrzej Hajda wrote: >> On 30.08.2019 19:00, Rob Clark wrote: >>> On Thu, Aug 29, 2019 at 11:52 PM Andrzej Hajda wrote: Of course it seems you have different opinion what is the right thing in this case, so if you

Re: [RFC][PATCH] drm: kirin: Fix dsi probe/attach logic

2019-09-03 Thread John Stultz
On Mon, Sep 2, 2019 at 6:22 AM Andrzej Hajda wrote: > On 30.08.2019 19:00, Rob Clark wrote: > > On Thu, Aug 29, 2019 at 11:52 PM Andrzej Hajda wrote: > >> Of course it seems you have different opinion what is the right thing in > >> this case, so if you convince us that your approach is better

Re: [RFC][PATCH] drm: kirin: Fix dsi probe/attach logic

2019-09-03 Thread Rob Clark
On Mon, Sep 2, 2019 at 6:22 AM Andrzej Hajda wrote: > > On 30.08.2019 19:00, Rob Clark wrote: > > On Thu, Aug 29, 2019 at 11:52 PM Andrzej Hajda wrote: > >> On 29.08.2019 19:39, Rob Clark wrote: > >>> On Wed, Aug 28, 2019 at 11:06 PM John Stultz > >>> wrote: > Since commit 83f35bc3a852

Re: [RFC][PATCH] drm: kirin: Fix dsi probe/attach logic

2019-09-02 Thread Andrzej Hajda
On 30.08.2019 19:00, Rob Clark wrote: > On Thu, Aug 29, 2019 at 11:52 PM Andrzej Hajda wrote: >> On 29.08.2019 19:39, Rob Clark wrote: >>> On Wed, Aug 28, 2019 at 11:06 PM John Stultz wrote: Since commit 83f35bc3a852 ("drm/bridge: adv7511: Attach to DSI host at probe time") landed in

Re: [RFC][PATCH] drm: kirin: Fix dsi probe/attach logic

2019-08-30 Thread Rob Clark
On Thu, Aug 29, 2019 at 11:52 PM Andrzej Hajda wrote: > > On 29.08.2019 19:39, Rob Clark wrote: > > On Wed, Aug 28, 2019 at 11:06 PM John Stultz wrote: > >> Since commit 83f35bc3a852 ("drm/bridge: adv7511: Attach to DSI > >> host at probe time") landed in -next the HiKey board would fail > >> to

Re: [RFC][PATCH] drm: kirin: Fix dsi probe/attach logic

2019-08-30 Thread Andrzej Hajda
On 29.08.2019 19:39, Rob Clark wrote: > On Wed, Aug 28, 2019 at 11:06 PM John Stultz wrote: >> Since commit 83f35bc3a852 ("drm/bridge: adv7511: Attach to DSI >> host at probe time") landed in -next the HiKey board would fail >> to boot, looping: > No, please revert 83f35bc3a852.. that is going in

Re: [RFC][PATCH] drm: kirin: Fix dsi probe/attach logic

2019-08-29 Thread Rob Clark
On Wed, Aug 28, 2019 at 11:06 PM John Stultz wrote: > > Since commit 83f35bc3a852 ("drm/bridge: adv7511: Attach to DSI > host at probe time") landed in -next the HiKey board would fail > to boot, looping: No, please revert 83f35bc3a852.. that is going in the *complete* wrong direction. We

Re: [RFC][PATCH] drm: kirin: Fix dsi probe/attach logic

2019-08-29 Thread Andrzej Hajda
On 29.08.2019 08:05, John Stultz wrote: > Since commit 83f35bc3a852 ("drm/bridge: adv7511: Attach to DSI > host at probe time") landed in -next the HiKey board would fail > to boot, looping: > > adv7511 2-0039: failed to find dsi host > > messages over and over. Andrzej Hajda suggested this is

[RFC][PATCH] drm: kirin: Fix dsi probe/attach logic

2019-08-29 Thread John Stultz
Since commit 83f35bc3a852 ("drm/bridge: adv7511: Attach to DSI host at probe time") landed in -next the HiKey board would fail to boot, looping: adv7511 2-0039: failed to find dsi host messages over and over. Andrzej Hajda suggested this is due to a circular dependency issue, and that the