Re: [Linaro-mm-sig] Re: [RFC] drm/scheduler: Unwrap job dependencies

2023-12-06 Thread Christian König
Am 05.12.23 um 18:14 schrieb Rob Clark: On Tue, Dec 5, 2023 at 8:56 AM Rob Clark wrote: On Tue, Dec 5, 2023 at 7:58 AM Christian König wrote: Am 05.12.23 um 16:41 schrieb Rob Clark: On Mon, Dec 4, 2023 at 10:46 PM Christian König wrote: Am 04.12.23 um 22:54 schrieb Rob Clark: On Thu,

Re: [RFC] drm/scheduler: Unwrap job dependencies

2023-12-05 Thread Rob Clark
On Tue, Dec 5, 2023 at 8:56 AM Rob Clark wrote: > > On Tue, Dec 5, 2023 at 7:58 AM Christian König > wrote: > > > > Am 05.12.23 um 16:41 schrieb Rob Clark: > > > On Mon, Dec 4, 2023 at 10:46 PM Christian König > > > wrote: > > >> Am 04.12.23 um 22:54 schrieb Rob Clark: > > >>> On Thu, Mar 23,

Re: [RFC] drm/scheduler: Unwrap job dependencies

2023-12-05 Thread Rob Clark
On Tue, Dec 5, 2023 at 7:58 AM Christian König wrote: > > Am 05.12.23 um 16:41 schrieb Rob Clark: > > On Mon, Dec 4, 2023 at 10:46 PM Christian König > > wrote: > >> Am 04.12.23 um 22:54 schrieb Rob Clark: > >>> On Thu, Mar 23, 2023 at 2:30 PM Rob Clark wrote: > [SNIP] > >>> So, this patch

Re: [RFC] drm/scheduler: Unwrap job dependencies

2023-12-05 Thread Christian König
Am 05.12.23 um 16:41 schrieb Rob Clark: On Mon, Dec 4, 2023 at 10:46 PM Christian König wrote: Am 04.12.23 um 22:54 schrieb Rob Clark: On Thu, Mar 23, 2023 at 2:30 PM Rob Clark wrote: [SNIP] So, this patch turns out to blow up spectacularly with dma_fence refcnt underflows when I enable

Re: [RFC] drm/scheduler: Unwrap job dependencies

2023-12-05 Thread Rob Clark
On Mon, Dec 4, 2023 at 10:46 PM Christian König wrote: > > Am 04.12.23 um 22:54 schrieb Rob Clark: > > On Thu, Mar 23, 2023 at 2:30 PM Rob Clark wrote: > >> [SNIP] > > So, this patch turns out to blow up spectacularly with dma_fence > > refcnt underflows when I enable DRIVER_SYNCOBJ_TIMELINE ..

Re: [RFC] drm/scheduler: Unwrap job dependencies

2023-12-04 Thread Christian König
Am 04.12.23 um 22:54 schrieb Rob Clark: On Thu, Mar 23, 2023 at 2:30 PM Rob Clark wrote: [SNIP] So, this patch turns out to blow up spectacularly with dma_fence refcnt underflows when I enable DRIVER_SYNCOBJ_TIMELINE .. I think, because it starts unwrapping fence chains, possibly in parallel

Re: [RFC] drm/scheduler: Unwrap job dependencies

2023-12-04 Thread Rob Clark
On Thu, Mar 23, 2023 at 2:30 PM Rob Clark wrote: > > On Thu, Mar 23, 2023 at 7:03 AM Christian König > wrote: > > > > Am 23.03.23 um 14:54 schrieb Rob Clark: > > > On Thu, Mar 23, 2023 at 12:35 AM Christian König > > > wrote: > > >> Am 22.03.23 um 23:44 schrieb Rob Clark: > > >>> From: Rob

Re: [RFC] drm/scheduler: Unwrap job dependencies

2023-03-23 Thread Rob Clark
On Thu, Mar 23, 2023 at 7:03 AM Christian König wrote: > > Am 23.03.23 um 14:54 schrieb Rob Clark: > > On Thu, Mar 23, 2023 at 12:35 AM Christian König > > wrote: > >> Am 22.03.23 um 23:44 schrieb Rob Clark: > >>> From: Rob Clark > >>> > >>> Container fences have burner contexts, which makes

Re: [RFC] drm/scheduler: Unwrap job dependencies

2023-03-23 Thread Christian König
Am 23.03.23 um 14:54 schrieb Rob Clark: On Thu, Mar 23, 2023 at 12:35 AM Christian König wrote: Am 22.03.23 um 23:44 schrieb Rob Clark: From: Rob Clark Container fences have burner contexts, which makes the trick to store at most one fence per context somewhat useless if we don't unwrap

Re: [RFC] drm/scheduler: Unwrap job dependencies

2023-03-23 Thread Rob Clark
On Thu, Mar 23, 2023 at 12:35 AM Christian König wrote: > > Am 22.03.23 um 23:44 schrieb Rob Clark: > > From: Rob Clark > > > > Container fences have burner contexts, which makes the trick to store at > > most one fence per context somewhat useless if we don't unwrap array or > > chain fences. >

Re: [RFC] drm/scheduler: Unwrap job dependencies

2023-03-23 Thread Christian König
Am 22.03.23 um 23:44 schrieb Rob Clark: From: Rob Clark Container fences have burner contexts, which makes the trick to store at most one fence per context somewhat useless if we don't unwrap array or chain fences. Mhm, we intentionally kept them not unwrapped since this way they only

[RFC] drm/scheduler: Unwrap job dependencies

2023-03-22 Thread Rob Clark
From: Rob Clark Container fences have burner contexts, which makes the trick to store at most one fence per context somewhat useless if we don't unwrap array or chain fences. Signed-off-by: Rob Clark --- tbh, I'm not sure why we weren't doing this already, unless there is something I'm