[RFC 2/2] drm/exynos: mixer: configure layers once in mixer_atomic_flush()

2016-09-20 Thread Andrzej Hajda
On 20.09.2016 16:09, Tobias Jakobi wrote: > Hi Andrzej, > > > Andrzej Hajda wrote: >> On 20.09.2016 14:34, Andrzej Hajda wrote: >>> On 20.09.2016 13:23, Tobias Jakobi wrote: Hello Andrzej, first of all, I've noticed an error myself. mixer_disable() calls mixer_disable_plane(),

[RFC 2/2] drm/exynos: mixer: configure layers once in mixer_atomic_flush()

2016-09-20 Thread Andrzej Hajda
On 20.09.2016 14:34, Andrzej Hajda wrote: > On 20.09.2016 13:23, Tobias Jakobi wrote: >> Hello Andrzej, >> >> first of all, I've noticed an error myself. mixer_disable() calls >> mixer_disable_plane(), so it should also be modified. I'll send a v2 later. >> >> Now to your points... >> >> >>

[RFC 2/2] drm/exynos: mixer: configure layers once in mixer_atomic_flush()

2016-09-20 Thread Andrzej Hajda
On 20.09.2016 13:23, Tobias Jakobi wrote: > Hello Andrzej, > > first of all, I've noticed an error myself. mixer_disable() calls > mixer_disable_plane(), so it should also be modified. I'll send a v2 later. > > Now to your points... > > > Andrzej Hajda wrote: >> On 19.09.2016 16:16, Tobias Jakobi

[RFC 2/2] drm/exynos: mixer: configure layers once in mixer_atomic_flush()

2016-09-20 Thread Tobias Jakobi
Hello Andrzej, first of all, I've noticed an error myself. mixer_disable() calls mixer_disable_plane(), so it should also be modified. I'll send a v2 later. Now to your points... Andrzej Hajda wrote: > On 19.09.2016 16:16, Tobias Jakobi wrote: >> Only manipulate the MXR_CFG and MXR_LAYER_CFG

[RFC 2/2] drm/exynos: mixer: configure layers once in mixer_atomic_flush()

2016-09-20 Thread Andrzej Hajda
On 19.09.2016 16:16, Tobias Jakobi wrote: > Only manipulate the MXR_CFG and MXR_LAYER_CFG registers once > in mixer_cfg_layer(). > Trigger this via atomic flush. > > Signed-off-by: Tobias Jakobi > --- > drivers/gpu/drm/exynos/exynos_mixer.c | 104 > ++ >

[RFC 2/2] drm/exynos: mixer: configure layers once in mixer_atomic_flush()

2016-09-19 Thread Tobias Jakobi
Only manipulate the MXR_CFG and MXR_LAYER_CFG registers once in mixer_cfg_layer(). Trigger this via atomic flush. Signed-off-by: Tobias Jakobi --- drivers/gpu/drm/exynos/exynos_mixer.c | 104 ++ drivers/gpu/drm/exynos/regs-mixer.h | 2 + 2 files changed, 69