Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-10-03 Thread Rafael J. Wysocki
On Tuesday, October 1, 2019 12:00:50 PM CEST Karol Herbst wrote: > On Tue, Oct 1, 2019 at 11:11 AM Mika Westerberg > wrote: > > > > On Tue, Oct 01, 2019 at 10:56:39AM +0200, Karol Herbst wrote: > > > On Tue, Oct 1, 2019 at 10:47 AM Mika Westerberg > > > wrote: > > > > > > > > On Mon, Sep 30,

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-10-02 Thread Rafael J. Wysocki
On Tue, Oct 1, 2019 at 9:34 PM Bjorn Helgaas wrote: > > On Tue, Oct 01, 2019 at 06:21:28PM +0200, Karol Herbst wrote: > > On Tue, Oct 1, 2019 at 3:27 PM Bjorn Helgaas wrote: > > > On Mon, Sep 30, 2019 at 06:36:12PM +0200, Karol Herbst wrote: > > > > On Mon, Sep 30, 2019 at 6:30 PM Mika

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-10-01 Thread Bjorn Helgaas
On Tue, Oct 01, 2019 at 06:21:28PM +0200, Karol Herbst wrote: > On Tue, Oct 1, 2019 at 3:27 PM Bjorn Helgaas wrote: > > On Mon, Sep 30, 2019 at 06:36:12PM +0200, Karol Herbst wrote: > > > On Mon, Sep 30, 2019 at 6:30 PM Mika Westerberg > > > wrote: > > > > > > > > On Mon, Sep 30, 2019 at

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-10-01 Thread Karol Herbst
On Tue, Oct 1, 2019 at 3:27 PM Bjorn Helgaas wrote: > > On Mon, Sep 30, 2019 at 06:36:12PM +0200, Karol Herbst wrote: > > On Mon, Sep 30, 2019 at 6:30 PM Mika Westerberg > > wrote: > > > > > > On Mon, Sep 30, 2019 at 06:05:14PM +0200, Karol Herbst wrote: > > > > still happens with your patch

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-10-01 Thread Bjorn Helgaas
On Mon, Sep 30, 2019 at 06:36:12PM +0200, Karol Herbst wrote: > On Mon, Sep 30, 2019 at 6:30 PM Mika Westerberg > wrote: > > > > On Mon, Sep 30, 2019 at 06:05:14PM +0200, Karol Herbst wrote: > > > still happens with your patch applied. The machine simply gets shut down. > > > > > > dmesg can be

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-10-01 Thread Karol Herbst
On Tue, Oct 1, 2019 at 11:11 AM Mika Westerberg wrote: > > On Tue, Oct 01, 2019 at 10:56:39AM +0200, Karol Herbst wrote: > > On Tue, Oct 1, 2019 at 10:47 AM Mika Westerberg > > wrote: > > > > > > On Mon, Sep 30, 2019 at 06:36:12PM +0200, Karol Herbst wrote: > > > > On Mon, Sep 30, 2019 at 6:30

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-10-01 Thread Mika Westerberg
On Tue, Oct 01, 2019 at 10:56:39AM +0200, Karol Herbst wrote: > On Tue, Oct 1, 2019 at 10:47 AM Mika Westerberg > wrote: > > > > On Mon, Sep 30, 2019 at 06:36:12PM +0200, Karol Herbst wrote: > > > On Mon, Sep 30, 2019 at 6:30 PM Mika Westerberg > > > wrote: > > > > > > > > On Mon, Sep 30, 2019

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-10-01 Thread Karol Herbst
On Tue, Oct 1, 2019 at 10:47 AM Mika Westerberg wrote: > > On Mon, Sep 30, 2019 at 06:36:12PM +0200, Karol Herbst wrote: > > On Mon, Sep 30, 2019 at 6:30 PM Mika Westerberg > > wrote: > > > > > > On Mon, Sep 30, 2019 at 06:05:14PM +0200, Karol Herbst wrote: > > > > still happens with your patch

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-10-01 Thread Mika Westerberg
On Mon, Sep 30, 2019 at 06:36:12PM +0200, Karol Herbst wrote: > On Mon, Sep 30, 2019 at 6:30 PM Mika Westerberg > wrote: > > > > On Mon, Sep 30, 2019 at 06:05:14PM +0200, Karol Herbst wrote: > > > still happens with your patch applied. The machine simply gets shut down. > > > > > > dmesg can be

[RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-09-30 Thread Karol Herbst
Fixes state transitions of Nvidia Pascal GPUs from D3cold into higher device states. v2: convert to pci_dev quirk put a proper technical explenation of the issue as a in-code comment RFC comment (copied from last sent): We are quite sure that there is a higher amount of bridges affected by

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-09-30 Thread Karol Herbst
On Mon, Sep 30, 2019 at 6:30 PM Mika Westerberg wrote: > > On Mon, Sep 30, 2019 at 06:05:14PM +0200, Karol Herbst wrote: > > still happens with your patch applied. The machine simply gets shut down. > > > > dmesg can be found here: > >

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-09-30 Thread Mika Westerberg
On Mon, Sep 30, 2019 at 06:05:14PM +0200, Karol Herbst wrote: > still happens with your patch applied. The machine simply gets shut down. > > dmesg can be found here: >

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-09-30 Thread Karol Herbst
still happens with your patch applied. The machine simply gets shut down. dmesg can be found here: https://gist.githubusercontent.com/karolherbst/40eb091c7b7b33ef993525de660f1a3b/raw/2380e31f566e93e5ba7c87ef545420965d4c492c/gistfile1.txt If there are no other things to try out, I will post the

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-09-30 Thread Mika Westerberg
On Mon, Sep 30, 2019 at 11:15:48AM +0200, Karol Herbst wrote: > On Mon, Sep 30, 2019 at 10:05 AM Mika Westerberg > wrote: > > > > Hi Karol, > > > > On Fri, Sep 27, 2019 at 11:53:48PM +0200, Karol Herbst wrote: > > > > What exactly is the serious issue? I guess it's that the rescan > > > >

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-09-30 Thread Karol Herbst
On Mon, Sep 30, 2019 at 10:05 AM Mika Westerberg wrote: > > Hi Karol, > > On Fri, Sep 27, 2019 at 11:53:48PM +0200, Karol Herbst wrote: > > > What exactly is the serious issue? I guess it's that the rescan > > > doesn't detect the GPU, which means it's not responding to config > > > accesses?

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-09-30 Thread Mika Westerberg
Hi Karol, On Fri, Sep 27, 2019 at 11:53:48PM +0200, Karol Herbst wrote: > > What exactly is the serious issue? I guess it's that the rescan > > doesn't detect the GPU, which means it's not responding to config > > accesses? Is there any timing component here, e.g., maybe we're > > missing some

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-09-27 Thread Karol Herbst
On Fri, Sep 27, 2019 at 11:42 PM Bjorn Helgaas wrote: > > [+cc Rafael, Mika, linux-pm] > > On Fri, Sep 27, 2019 at 04:44:21PM +0200, Karol Herbst wrote: > > Fixes runpm breakage mainly on Nvidia GPUs as they are not able to resume. > > I don't know what runpm is. Some userspace utility? Module

Re: [RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-09-27 Thread Bjorn Helgaas
[+cc Rafael, Mika, linux-pm] On Fri, Sep 27, 2019 at 04:44:21PM +0200, Karol Herbst wrote: > Fixes runpm breakage mainly on Nvidia GPUs as they are not able to resume. I don't know what runpm is. Some userspace utility? Module parameter? > Works perfectly with this workaround applied. > >

[RFC PATCH] pci: prevent putting pcie devices into lower device states on certain intel bridges

2019-09-27 Thread Karol Herbst
Fixes runpm breakage mainly on Nvidia GPUs as they are not able to resume. Works perfectly with this workaround applied. RFC comment: We are quite sure that there is a higher amount of bridges affected by this, but I was only testing it on my own machine for now. I've stresstested runpm by