Re: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest

2019-09-21 Thread Frank Rowand
On 9/20/19 9:57 AM, Rob Herring wrote: > Following up from LPC discussions... > > On Thu, Mar 21, 2019 at 8:30 PM Brendan Higgins > wrote: >> >> On Thu, Mar 21, 2019 at 5:22 PM Frank Rowand wrote: >>> >>> On 2/27/19 7:52 PM, Brendan Higgins wrote: On Wed, Feb 20, 2019 at 12:45 PM Frank

Re: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest

2019-09-20 Thread Rob Herring
Following up from LPC discussions... On Thu, Mar 21, 2019 at 8:30 PM Brendan Higgins wrote: > > On Thu, Mar 21, 2019 at 5:22 PM Frank Rowand wrote: > > > > On 2/27/19 7:52 PM, Brendan Higgins wrote: > > > On Wed, Feb 20, 2019 at 12:45 PM Frank Rowand > > > wrote: > > >> > > >> On 2/18/19 2:25

Re: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest

2019-03-25 Thread Brendan Higgins
On Thu, Mar 21, 2019 at 6:34 PM Frank Rowand wrote: > > On 3/21/19 5:22 PM, Frank Rowand wrote: > > On 2/27/19 7:52 PM, Brendan Higgins wrote: > > < snip > > > >> Now I know that, hermeticity especially, but other features as well > >> (test suite summary, error on unused test case function, etc)

Re: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest

2019-03-25 Thread Brendan Higgins
On Thu, Mar 21, 2019 at 6:47 PM Frank Rowand wrote: > > On 3/21/19 6:30 PM, Brendan Higgins wrote: > > On Thu, Mar 21, 2019 at 5:22 PM Frank Rowand wrote: > >> > >> On 2/27/19 7:52 PM, Brendan Higgins wrote: > > < snip > but thanks for the comments in the snipped section. > > > >> > >> Thanks

Re: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest

2019-03-24 Thread Frank Rowand
On 3/21/19 5:22 PM, Frank Rowand wrote: > On 2/27/19 7:52 PM, Brendan Higgins wrote: < snip > >> Now I know that, hermeticity especially, but other features as well >> (test suite summary, error on unused test case function, etc) are not >> actually in KUnit as it is under consideration here.

Re: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest

2019-03-24 Thread Frank Rowand
On 2/27/19 7:52 PM, Brendan Higgins wrote: > On Wed, Feb 20, 2019 at 12:45 PM Frank Rowand wrote: >> >> On 2/18/19 2:25 PM, Frank Rowand wrote: >>> On 2/15/19 2:56 AM, Brendan Higgins wrote: On Thu, Feb 14, 2019 at 6:05 PM Frank Rowand wrote: > > On 2/14/19 4:56 PM, Brendan

Re: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest

2019-03-24 Thread Frank Rowand
On 3/21/19 6:30 PM, Brendan Higgins wrote: > On Thu, Mar 21, 2019 at 5:22 PM Frank Rowand wrote: >> >> On 2/27/19 7:52 PM, Brendan Higgins wrote: < snip > but thanks for the comments in the snipped section. >> >> Thanks for leaving 18/19 and 19/19 off in v4. > > Sure, no problem. It was

Re: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest

2019-03-21 Thread Brendan Higgins
On Thu, Mar 21, 2019 at 5:22 PM Frank Rowand wrote: > > On 2/27/19 7:52 PM, Brendan Higgins wrote: > > On Wed, Feb 20, 2019 at 12:45 PM Frank Rowand > > wrote: > >> > >> On 2/18/19 2:25 PM, Frank Rowand wrote: > >>> On 2/15/19 2:56 AM, Brendan Higgins wrote: > On Thu, Feb 14, 2019 at 6:05

Re: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest

2019-02-27 Thread Brendan Higgins
On Wed, Feb 20, 2019 at 12:45 PM Frank Rowand wrote: > > On 2/18/19 2:25 PM, Frank Rowand wrote: > > On 2/15/19 2:56 AM, Brendan Higgins wrote: > >> On Thu, Feb 14, 2019 at 6:05 PM Frank Rowand > >> wrote: > >>> > >>> On 2/14/19 4:56 PM, Brendan Higgins wrote: > On Thu, Feb 14, 2019 at

Re: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest

2019-02-21 Thread Frank Rowand
On 2/18/19 2:25 PM, Frank Rowand wrote: > On 2/15/19 2:56 AM, Brendan Higgins wrote: >> On Thu, Feb 14, 2019 at 6:05 PM Frank Rowand wrote: >>> >>> On 2/14/19 4:56 PM, Brendan Higgins wrote: On Thu, Feb 14, 2019 at 3:57 PM Frank Rowand wrote: > > On 12/5/18 3:54 PM, Brendan

Re: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest

2019-02-21 Thread Frank Rowand
On 2/20/19 12:44 PM, Frank Rowand wrote: > On 2/18/19 2:25 PM, Frank Rowand wrote: >> On 2/15/19 2:56 AM, Brendan Higgins wrote: >>> On Thu, Feb 14, 2019 at 6:05 PM Frank Rowand wrote: On 2/14/19 4:56 PM, Brendan Higgins wrote: > On Thu, Feb 14, 2019 at 3:57 PM Frank Rowand >

Re: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest

2019-02-19 Thread Frank Rowand
On 2/15/19 2:56 AM, Brendan Higgins wrote: > On Thu, Feb 14, 2019 at 6:05 PM Frank Rowand wrote: >> >> On 2/14/19 4:56 PM, Brendan Higgins wrote: >>> On Thu, Feb 14, 2019 at 3:57 PM Frank Rowand wrote: On 12/5/18 3:54 PM, Brendan Higgins wrote: > On Tue, Dec 4, 2018 at 2:58 AM

Re: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest

2019-02-18 Thread Frank Rowand via dri-devel
On 2/14/19 4:56 PM, Brendan Higgins wrote: > On Thu, Feb 14, 2019 at 3:57 PM Frank Rowand wrote: >> >> On 12/5/18 3:54 PM, Brendan Higgins wrote: >>> On Tue, Dec 4, 2018 at 2:58 AM Frank Rowand wrote: Hi Brendan, On 11/28/18 11:36 AM, Brendan Higgins wrote: > Split out a

Re: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest

2019-02-18 Thread Frank Rowand via dri-devel
On 12/5/18 3:54 PM, Brendan Higgins wrote: > On Tue, Dec 4, 2018 at 2:58 AM Frank Rowand wrote: >> >> Hi Brendan, >> >> On 11/28/18 11:36 AM, Brendan Higgins wrote: >>> Split out a couple of test cases that these features in base.c from the >>> unittest.c monolith. The intention is that we will

Re: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest

2019-02-16 Thread Brendan Higgins via dri-devel
On Thu, Feb 14, 2019 at 6:05 PM Frank Rowand wrote: > > On 2/14/19 4:56 PM, Brendan Higgins wrote: > > On Thu, Feb 14, 2019 at 3:57 PM Frank Rowand wrote: > >> > >> On 12/5/18 3:54 PM, Brendan Higgins wrote: > >>> On Tue, Dec 4, 2018 at 2:58 AM Frank Rowand > >>> wrote: > > Hi

Re: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest

2019-02-16 Thread Brendan Higgins via dri-devel
On Thu, Feb 14, 2019 at 3:57 PM Frank Rowand wrote: > > On 12/5/18 3:54 PM, Brendan Higgins wrote: > > On Tue, Dec 4, 2018 at 2:58 AM Frank Rowand wrote: > >> > >> Hi Brendan, > >> > >> On 11/28/18 11:36 AM, Brendan Higgins wrote: > >>> Split out a couple of test cases that these features in

Re: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest

2018-12-06 Thread Brendan Higgins
On Tue, Dec 4, 2018 at 2:58 AM Frank Rowand wrote: > > Hi Brendan, > > On 11/28/18 11:36 AM, Brendan Higgins wrote: > > Split out a couple of test cases that these features in base.c from the > > unittest.c monolith. The intention is that we will eventually split out > > all test cases and group

Re: [RFC v3 18/19] of: unittest: split out a couple of test cases from unittest

2018-12-05 Thread Frank Rowand
Hi Brendan, On 11/28/18 11:36 AM, Brendan Higgins wrote: > Split out a couple of test cases that these features in base.c from the > unittest.c monolith. The intention is that we will eventually split out > all test cases and group them together based on what portion of device > tree they test.

[RFC v3 18/19] of: unittest: split out a couple of test cases from unittest

2018-11-29 Thread Brendan Higgins
Split out a couple of test cases that these features in base.c from the unittest.c monolith. The intention is that we will eventually split out all test cases and group them together based on what portion of device tree they test. Signed-off-by: Brendan Higgins --- drivers/of/Makefile |