[libdrm][PATCH 3/2] Fix always true comparison.

2015-03-02 Thread Jan Vesely
On Wed, 2015-02-25 at 18:41 +, Emil Velikov wrote: > On 25/02/15 17:11, Jan Vesely wrote: > > gentle ping > > > Afaics it's very had to get in this code nowadays - drm_server_info is > set only via the legacy (?) function drmSetServerInfo. With the latter > only(?) used by the xserver when

[libdrm][PATCH 3/2] Fix always true comparison.

2015-02-25 Thread Emil Velikov
On 25/02/15 17:11, Jan Vesely wrote: > gentle ping > Afaics it's very had to get in this code nowadays - drm_server_info is set only via the legacy (?) function drmSetServerInfo. With the latter only(?) used by the xserver when working with dri1 modules. So testing this is likely to be very

[libdrm][PATCH 3/2] Fix always true comparison.

2015-02-25 Thread Jan Vesely
gentle ping On Mon, 2015-02-09 at 19:10 -0500, Jan Vesely wrote: > The only user I found is xserver, it can return -1 under certain conditions. > So check for -1 explicitly. > > Signed-off-by: Jan Vesely > --- > > I could not find whether it's actually legal to return encoded negative values

[libdrm][PATCH 3/2] Fix always true comparison.

2015-02-09 Thread Jan Vesely
The only user I found is xserver, it can return -1 under certain conditions. So check for -1 explicitly. Signed-off-by: Jan Vesely --- I could not find whether it's actually legal to return encoded negative values in get_perm. This is a quick fix to detect the one case that I found. xf86drm.c