On 07/09/2020 14:57, Paul Cercueil wrote:
>
>
> Le dim. 30 août 2020 à 22:28, Sam Ravnborg a écrit :
>> Hi Laurent.
>>
>>> >
>>> > Please read the cover letter, it explains why it's done this way. The
>>> > whole point of this patchset is to merge DSI and DBI frameworks in a
>>> > way that
Le dim. 30 août 2020 à 22:28, Sam Ravnborg a
écrit :
Hi Laurent.
>
> Please read the cover letter, it explains why it's done this way.
The
> whole point of this patchset is to merge DSI and DBI frameworks
in a
> way that can be maintained.
I think this proves the point that the
Hi Leon,
Le dim. 30 août 2020 à 16:36, 何小龙 (Leon He)
a écrit :
+struct ili9341 {
+ struct drm_panel panel;
+ struct mipi_dsi_device *dsi;
+ const struct ili9341_pdata *pdata;
+
+ struct gpio_desc*reset_gpiod;
+ u32 rotation;
+};
+
Hi Paul, you
Hi Laurent.
> >
> > Please read the cover letter, it explains why it's done this way. The
> > whole point of this patchset is to merge DSI and DBI frameworks in a
> > way that can be maintained.
>
> I think this proves the point that the proposed naming is confusing. At
> least a rename would
Hi Paul,
On Sun, Aug 30, 2020 at 06:48:12PM +0200, Paul Cercueil wrote:
> Le dim. 30 août 2020 à 16:36, 何小龙 (Leon He) a écrit :
> >> +struct ili9341 {
> >> + struct drm_panel panel;
> >> + struct mipi_dsi_device *dsi;
> >> + const struct ili9341_pdata *pdata;
> >> +
> >> +
> +struct ili9341 {
> + struct drm_panel panel;
> + struct mipi_dsi_device *dsi;
> + const struct ili9341_pdata *pdata;
> +
> + struct gpio_desc*reset_gpiod;
> + u32 rotation;
> +};
> +
Hi Paul, you put the mipi_dsi_device inside the struct. I think it maybe
