Re: Build regressions/improvements in v5.18-rc1
Geert Uytterhoeven writes: > On Mon, Apr 4, 2022 at 8:39 PM Kalle Valo wrote: >> Geert Uytterhoeven writes: >> >> /kisskb/src/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c: >> >> error: case label does not reduce to an integer constant: => 3798:2, >> >> 3809:2 >> > >> > arm64-gcc5.4/arm64-allmodconfig >> > powerpc-gcc5/powerpc-allmodconfig >> > powerpc-gcc5/ppc64_book3e_allmodconfig >> >> After v5.17 there were two commits to brcmfmac/sdio.c: >> >> $ git log --oneline v5.17.. >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c >> ed26edf7bfd9 brcmfmac: Add BCM43454/6 support >> 6d766d8cb505 brcmfmac: pcie: Declare missing firmware files in pcie.c >> >> I can't see how either of them could cause this warning. Could something >> else cause this or am I missing something? > > Doh, I should not have reduced the CC list in the xfs subthread... > > The builds above are all gcc-5 builds, so they are affected by the same > issue as XFS: unsigned constants that don't fit in int are lacking a > "U" suffix. > > I assume Arnd's patch for > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > fixes this? > https://lore.kernel.org/all/cak8p3a0wris03imdxk2wbgonkssczegde-ue5ubf6uyyde9...@mail.gmail.com Great, thanks. I assume Arnd will submit it officially at some point. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: Build regressions/improvements in v5.18-rc1
Hi Kalle,
On Mon, Apr 4, 2022 at 8:39 PM Kalle Valo wrote:
> Geert Uytterhoeven writes:
> >> /kisskb/src/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:
> >> error: case label does not reduce to an integer constant: => 3798:2,
> >> 3809:2
> >
> > arm64-gcc5.4/arm64-allmodconfig
> > powerpc-gcc5/powerpc-allmodconfig
> > powerpc-gcc5/ppc64_book3e_allmodconfig
>
> After v5.17 there were two commits to brcmfmac/sdio.c:
>
> $ git log --oneline v5.17..
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
> ed26edf7bfd9 brcmfmac: Add BCM43454/6 support
> 6d766d8cb505 brcmfmac: pcie: Declare missing firmware files in pcie.c
>
> I can't see how either of them could cause this warning. Could something
> else cause this or am I missing something?
Doh, I should not have reduced the CC list in the xfs subthread...
The builds above are all gcc-5 builds, so they are affected by the same
issue as XFS: unsigned constants that don't fit in int are lacking a
"U" suffix.
I assume Arnd's patch for
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
fixes this?
https://lore.kernel.org/all/cak8p3a0wris03imdxk2wbgonkssczegde-ue5ubf6uyyde9...@mail.gmail.com
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: Build regressions/improvements in v5.18-rc1
Geert Uytterhoeven writes: >> /kisskb/src/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c: >> error: case label does not reduce to an integer constant: => 3798:2, >> 3809:2 > > arm64-gcc5.4/arm64-allmodconfig > powerpc-gcc5/powerpc-allmodconfig > powerpc-gcc5/ppc64_book3e_allmodconfig After v5.17 there were two commits to brcmfmac/sdio.c: $ git log --oneline v5.17.. drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c ed26edf7bfd9 brcmfmac: Add BCM43454/6 support 6d766d8cb505 brcmfmac: pcie: Declare missing firmware files in pcie.c I can't see how either of them could cause this warning. Could something else cause this or am I missing something? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: Build regressions/improvements in v5.18-rc1
On Mon, Apr 04, 2022 at 10:16:08AM +0200, Geert Uytterhoeven wrote:
> On Mon, 4 Apr 2022, Geert Uytterhoeven wrote:
> > Below is the list of build error/warning regressions/improvements in
> > v5.18-rc1[1] compared to v5.17[2].
> >
> > Summarized:
> > - build errors: +36/-15
> > - build warnings: +5/-38
> >
> > Happy fixing! ;-)
Well
> > + /kisskb/src/fs/xfs/xfs_buf.h: error: initializer element is not
> > constant: => 46:23
Looking at:
http://kisskb.ellerman.id.au/kisskb/buildresult/14714961/
The build error is:
/kisskb/src/fs/xfs/./xfs_trace.h:432:2: note: in expansion of macro 'TP_printk'
TP_printk("dev %d:%d daddr 0x%llx bbcount 0x%x hold %d pincount %d "
^
/kisskb/src/fs/xfs/./xfs_trace.h:440:5: note: in expansion of macro
'__print_flags'
__print_flags(__entry->flags, "|", XFS_BUF_FLAGS),
^
/kisskb/src/fs/xfs/xfs_buf.h:67:4: note: in expansion of macro 'XBF_UNMAPPED'
{ XBF_UNMAPPED, "UNMAPPED" }
^
/kisskb/src/fs/xfs/./xfs_trace.h:440:40: note: in expansion of macro
'XFS_BUF_FLAGS'
__print_flags(__entry->flags, "|", XFS_BUF_FLAGS),
^
/kisskb/src/fs/xfs/./xfs_trace.h: In function
'trace_raw_output_xfs_buf_flags_class':
/kisskb/src/fs/xfs/xfs_buf.h:46:23: error: initializer element is not constant
#define XBF_UNMAPPED (1 << 31)/* do not map the buffer */
This doesn't make a whole lotta sense to me. It's blown up in a
tracepoint macro in XFS that was not changed at all in 5.18-rc1, nor
was any of the surrounding XFS code or contexts. Perhaps something
outside XFS changed to cause this on these platforms?
Can you bisect this, please?
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
Re: Build regressions/improvements in v5.18-rc1
On Mon, 4 Apr 2022, Geert Uytterhoeven wrote: Below is the list of build error/warning regressions/improvements in v5.18-rc1[1] compared to v5.17[2]. Summarized: - build errors: +36/-15 - build warnings: +5/-38 Happy fixing! ;-) Thanks to the linux-next team for providing the build service. [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/3123109284176b1532874591f7c81f3837bbdc17/ (all 96 configs) [2] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/f443e374ae131c168a065ea1748feac6b2e76613/ (all 96 configs) *** ERRORS *** 36 error regressions: + /kisskb/src/arch/m68k/include/asm/bitops.h: error: array subscript 2 is above array bounds of 'long unsigned int[1]' [-Werror=array-bounds]: => 329:20 m68k-gcc8/m68k-allmodconfig (assumed gcc8 bug) + /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S: Error: .cfi_endproc without corresponding .cfi_startproc: => 32 + /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S: Error: bad or irreducible absolute expression: => 16 + /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S: Error: junk at end of line, first unrecognized character is `:': => 16 + /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S: Error: no such instruction: `be 0x100(%sr2,%r0)': => 29 + /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S: Error: no such instruction: `ldi 0,%r20': => 30 + /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S: Error: no such instruction: `ldw 0(%sp),%r31': => 26 + /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S: Error: no such instruction: `ble 0x100(%sr2,%r0)': => 51, 46 + /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S: Error: no such instruction: `ldi 0,%r25': => 44 + /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S: Error: no such instruction: `ldi 1,%r25': => 49 + /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S: Error: no such instruction: `ldi 173,%r20': => 45, 50 + /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S: Error: unknown pseudo-op: `.callinfo': => 40 + /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S: Error: unknown pseudo-op: `.entry': => 41 + /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S: Error: unknown pseudo-op: `.exit': => 54 + /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S: Error: unknown pseudo-op: `.proc': => 39 + /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S: Error: unknown pseudo-op: `.procend': => 55 + /kisskb/src/arch/parisc/kernel/vdso32/sigtramp.S: Error: unknown pseudo-op: `.stringz': => 76 parisc64-gcc8/generic-64bit_defconfig parisc-gcc8/generic-32bit_defconfig parisc-gcc8/parisc-allmodconfig parisc-gcc8/parisc-allnoconfig + /kisskb/src/arch/sparc/kernel/irq_32.c: error: array subscript [16, 79] is outside array bounds of 'struct tt_entry[1]' [-Werror=array-bounds]: => 262:14, 261:46, 259:14, 258:14, 263:14 sparc64-gcc11/sparc-allmodconfig + /kisskb/src/drivers/gpu/drm/r128/r128_cce.c: error: case label does not reduce to an integer constant: => 417:2, 418:2 arm64-gcc5.4/arm64-allmodconfig mipsel/mips-allmodconfig powerpc-gcc5/powerpc-allmodconfig powerpc-gcc5/powerpc-allyesconfig powerpc-gcc5/ppc32_allmodconfig powerpc-gcc5/ppc64_book3e_allmodconfig powerpc-gcc5/ppc64le_allmodconfig + /kisskb/src/drivers/infiniband/hw/qib/qib_wc_x86_64.c: error: 'X86_VENDOR_AMD' undeclared (first use in this function): => 149:37 + /kisskb/src/drivers/infiniband/hw/qib/qib_wc_x86_64.c: error: 'struct cpuinfo_um' has no member named 'x86_vendor': => 149:22 + /kisskb/src/drivers/infiniband/hw/qib/qib_wc_x86_64.c: error: control reaches end of non-void function [-Werror=return-type]: => 150:1 + /kisskb/src/drivers/infiniband/sw/rdmavt/qp.c: error: 'struct cpuinfo_um' has no member named 'x86_cache_size': => 88:22 + /kisskb/src/drivers/infiniband/sw/rdmavt/qp.c: error: control reaches end of non-void function [-Werror=return-type]: => 89:1 + /kisskb/src/drivers/infiniband/sw/rdmavt/qp.c: error: implicit declaration of function '__copy_user_nocache' [-Werror=implicit-function-declaration]: => 100:2 um-x86_64/um-allmodconfig um-x86_64/um-allyesconfig + /kisskb/src/drivers/media/platform/nxp/imx-pxp.h: error: initializer element is not constant: => 582:38 arm64-gcc5.4/arm64-allmodconfig powerpc-gcc5/powerpc-allmodconfig + /kisskb/src/drivers/misc/habanalabs/common/memory.c: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]: => 153:49, 153:7 mipsel/mips-allmodconfig mips-gcc8/mips-allmodconfig sparc64/sparc-allmodconfig xtensa-gcc11/xtensa-allmodconfig + /kisskb/src/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c: error: case label does not reduce to an integer constant: => 4917:4 + /kisskb/src/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c: error: case label does not reduce to an integer constant: => 3798:2, 3809:2 arm64-gcc5.4/arm64-allmodconfig powerpc-gcc5/powerpc-allmodconfig powerpc-gcc5/ppc64_book3e_allmodconfig +
