Re: Fwd: [PATCH] drm: panel-orientation-quirks: Get rid of superfluous (void *) casting

2019-02-14 Thread Jani Nikula via dri-devel
On Wed, 13 Feb 2019, Thierry Reding wrote: > On Wed, Feb 13, 2019 at 11:13:23AM +0100, David Santamaría Rogado wrote: >> Sorry previous one wasn't signed off by. > > And now you've got this comment in the commit message that's going to > confuse people looking at the log. > > It's usually to put t

Fwd: [PATCH] drm: panel-orientation-quirks: Get rid of superfluous (void *) casting

2019-02-14 Thread David Santamaría Rogado via dri-devel
Sorry previous one wasn't signed off by. The (void *) casting in the driver_data variable assignment is superfluous. Spotted by Jani Nikula. Signed-off-by: David Santamaría Rogado --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 +- 1 file changed, 9 insertions(+), 9 dele

Re: Fwd: [PATCH] drm: panel-orientation-quirks: Get rid of superfluous (void *) casting

2019-02-13 Thread Thierry Reding via dri-devel
On Wed, Feb 13, 2019 at 11:13:23AM +0100, David Santamaría Rogado wrote: > Sorry previous one wasn't signed off by. And now you've got this comment in the commit message that's going to confuse people looking at the log. It's usually to put this kind of comment below the --- line... > The (void