Re: [PATCH] io-mapping: Indicate mapping failure
On Tue, Jul 21, 2020 at 10:16:41AM -0400, Michael J. Ruhl wrote:
> Sometimes it is good to know when your mapping failed.
Can you elaborate...
> Fixes: cafaf14a5d8f ("io-mapping: Always create a struct to hold metadata
> about the io-mapping"
...especially taking into account that Fixes implies regression / bug?
--
With Best Regards,
Andy Shevchenko
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] io-mapping: Indicate mapping failure
On Tue, Jul 21, 2020 at 03:00:41PM +, Ruhl, Michael J wrote:
> >-Original Message-
> >From: Andy Shevchenko
> >Sent: Tuesday, July 21, 2020 10:47 AM
> >To: Ruhl, Michael J
> >Cc: dri-devel@lists.freedesktop.org; Andrew Morton >foundation.org>; Mike Rapoport ; Chris Wilson
> >; sta...@vger.kernel.org
> >Subject: Re: [PATCH] io-mapping: Indicate mapping failure
> >
> >On Tue, Jul 21, 2020 at 10:16:41AM -0400, Michael J. Ruhl wrote:
> >> Sometimes it is good to know when your mapping failed.
I was going to say it's always a good idea ;-)
> >Can you elaborate...
>
> Sure, guess I was too glib.
>
> Currently the io_mapping_init_wc (the !ATOMIC_IOMAP version), function will
> always return success.
>
> If the setting of the iomem (from ioremap_wc) fails, the only way for the
> caller to know is to check the value of iomap->iomem.
>
> Since all of the callers expect a NULL return on error, and check for a NULL,
> I felt this needed a fixes (i.e. unexpected behavior).
>
> >> Fixes: cafaf14a5d8f ("io-mapping: Always create a struct to hold metadata
> >about the io-mapping"
> >
> >...especially taking into account that Fixes implies regression / bug?
>
> The failure (in my case a crash) is not revealed until the address is accessed
> long after the init.
>
> I will update the commit.
>
> Mike
>
> >--
> >With Best Regards,
> >Andy Shevchenko
> >
>
--
Sincerely yours,
Mike.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
RE: [PATCH] io-mapping: Indicate mapping failure
>-Original Message-
>From: Andy Shevchenko
>Sent: Tuesday, July 21, 2020 10:47 AM
>To: Ruhl, Michael J
>Cc: dri-devel@lists.freedesktop.org; Andrew Morton foundation.org>; Mike Rapoport ; Chris Wilson
>; sta...@vger.kernel.org
>Subject: Re: [PATCH] io-mapping: Indicate mapping failure
>
>On Tue, Jul 21, 2020 at 10:16:41AM -0400, Michael J. Ruhl wrote:
>> Sometimes it is good to know when your mapping failed.
>
>Can you elaborate...
Sure, guess I was too glib.
Currently the io_mapping_init_wc (the !ATOMIC_IOMAP version), function will
always return success.
If the setting of the iomem (from ioremap_wc) fails, the only way for the
caller to know is to check the value of iomap->iomem.
Since all of the callers expect a NULL return on error, and check for a NULL,
I felt this needed a fixes (i.e. unexpected behavior).
>> Fixes: cafaf14a5d8f ("io-mapping: Always create a struct to hold metadata
>about the io-mapping"
>
>...especially taking into account that Fixes implies regression / bug?
The failure (in my case a crash) is not revealed until the address is accessed
long after the init.
I will update the commit.
Mike
>--
>With Best Regards,
>Andy Shevchenko
>
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
