Re: [PATCH 11/20] drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param 'doorbell_index'
Applied. Thanks! On Thu, Aug 24, 2023 at 4:35 AM Sharma, Shashank wrote: > > [AMD Official Use Only - General] > > Reviewed-by: : Shashank Sharma > > Regards > Shashank > -Original Message- > From: Lee Jones > Sent: Thursday, August 24, 2023 9:37 AM > To: l...@kernel.org > Cc: linux-ker...@vger.kernel.org; Deucher, Alexander > ; Koenig, Christian ; > Pan, Xinhui ; David Airlie ; Daniel > Vetter ; Sharma, Shashank ; > amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Subject: [PATCH 11/20] drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct > misdocumented param 'doorbell_index' > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c:123: warning: Function > parameter or member 'doorbell_index' not described in > 'amdgpu_doorbell_index_on_bar' > drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c:123: warning: Excess > function parameter 'db_index' description in 'amdgpu_doorbell_index_on_bar' > > Signed-off-by: Lee Jones > --- > Cc: Alex Deucher > Cc: "Christian König" > Cc: "Pan, Xinhui" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Shashank Sharma > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c > index da4be0bbb4466..d0249ada91d30 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c > @@ -113,7 +113,7 @@ void amdgpu_mm_wdoorbell64(struct amdgpu_device *adev, > u32 index, u64 v) > * > * @adev: amdgpu_device pointer > * @db_bo: doorbell object's bo > - * @db_index: doorbell relative index in this doorbell object > + * @doorbell_index: doorbell relative index in this doorbell object > * > * returns doorbell's absolute index in BAR > */ > -- > 2.42.0.rc1.204.g551eb34607-goog >
RE: [PATCH 11/20] drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param 'doorbell_index'
[AMD Official Use Only - General] Reviewed-by: : Shashank Sharma Regards Shashank -Original Message- From: Lee Jones Sent: Thursday, August 24, 2023 9:37 AM To: l...@kernel.org Cc: linux-ker...@vger.kernel.org; Deucher, Alexander ; Koenig, Christian ; Pan, Xinhui ; David Airlie ; Daniel Vetter ; Sharma, Shashank ; amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: [PATCH 11/20] drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param 'doorbell_index' Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c:123: warning: Function parameter or member 'doorbell_index' not described in 'amdgpu_doorbell_index_on_bar' drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c:123: warning: Excess function parameter 'db_index' description in 'amdgpu_doorbell_index_on_bar' Signed-off-by: Lee Jones --- Cc: Alex Deucher Cc: "Christian König" Cc: "Pan, Xinhui" Cc: David Airlie Cc: Daniel Vetter Cc: Shashank Sharma Cc: amd-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c index da4be0bbb4466..d0249ada91d30 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c @@ -113,7 +113,7 @@ void amdgpu_mm_wdoorbell64(struct amdgpu_device *adev, u32 index, u64 v) * * @adev: amdgpu_device pointer * @db_bo: doorbell object's bo - * @db_index: doorbell relative index in this doorbell object + * @doorbell_index: doorbell relative index in this doorbell object * * returns doorbell's absolute index in BAR */ -- 2.42.0.rc1.204.g551eb34607-goog
