Re: [v1] drm/msm/disp/dpu1: add support for hierarchical flush for dspp in sc7280

2022-09-02 Thread Dmitry Baryshkov
On Fri, 2 Sept 2022 at 12:35, Kalyan Thota wrote: > > > > >-Original Message- > >From: Dmitry Baryshkov > >Sent: Friday, August 26, 2022 5:02 PM > >To: Kalyan Thota ; Kalyan Thota (QUIC) > >; diand...@chromium.org > >Cc: dri-devel@lists.freedesktop.org; linux-arm-...@vger.kernel.org; >

RE: [v1] drm/msm/disp/dpu1: add support for hierarchical flush for dspp in sc7280

2022-09-02 Thread Kalyan Thota
>-Original Message- >From: Dmitry Baryshkov >Sent: Friday, August 26, 2022 5:02 PM >To: Kalyan Thota ; Kalyan Thota (QUIC) >; diand...@chromium.org >Cc: dri-devel@lists.freedesktop.org; linux-arm-...@vger.kernel.org; >freedr...@lists.freedesktop.org; devicet...@vger.kernel.org; linux-

Re: [v1] drm/msm/disp/dpu1: add support for hierarchical flush for dspp in sc7280

2022-08-26 Thread Dmitry Baryshkov
On 08/08/2022 13:44, Kalyan Thota wrote: -Original Message- From: Dmitry Baryshkov Sent: Thursday, August 4, 2022 9:29 PM To: Kalyan Thota (QUIC) Cc: dri-devel@lists.freedesktop.org; linux-arm-...@vger.kernel.org; freedr...@lists.freedesktop.org; devicet...@vger.kernel.org; linux-

Re: [v1] drm/msm/disp/dpu1: add support for hierarchical flush for dspp in sc7280

2022-08-08 Thread Doug Anderson
Hi, On Mon, Aug 8, 2022 at 3:44 AM Kalyan Thota wrote: > > >I'd like to land at least patches 6-8 from [1] next cycle. They clean up the > >CTL > >interface. Could you please rebase your patch on top of them? > > > > Sure I'll wait for the series to rebase. @Doug can you comment if this is >

RE: [v1] drm/msm/disp/dpu1: add support for hierarchical flush for dspp in sc7280

2022-08-08 Thread Kalyan Thota
>-Original Message- >From: Dmitry Baryshkov >Sent: Thursday, August 4, 2022 9:29 PM >To: Kalyan Thota (QUIC) >Cc: dri-devel@lists.freedesktop.org; linux-arm-...@vger.kernel.org; >freedr...@lists.freedesktop.org; devicet...@vger.kernel.org; linux- >ker...@vger.kernel.org;

Re: [v1] drm/msm/disp/dpu1: add support for hierarchical flush for dspp in sc7280

2022-08-04 Thread Dmitry Baryshkov
On Thu, 4 Aug 2022 at 13:29, Kalyan Thota wrote: > > Flush mechanism for DSPP blocks has changed in sc7280 family, it > allows individual sub blocks to be flushed in coordination with > master flush control. > > representation: master_flush && (PCC_flush | IGC_flush .. etc ) > > This change adds

Re: [v1] drm/msm/disp/dpu1: add support for hierarchical flush for dspp in sc7280

2022-08-04 Thread Doug Anderson
On Thu, Aug 4, 2022 at 3:29 AM Kalyan Thota wrote: > > +static void dpu_hw_ctl_set_dspp_hierarchical_flush(struct dpu_hw_ctl *ctx, > + enum dpu_dspp dspp, enum dpu_dspp_sub_blk dspp_sub_blk) > +{ > + uint32_t flushbits = 0, active = 0; nit: don't init to 0 since you just override