Re: [PATCH] drm/radeon: Add support for userspace fence waits

2012-02-01 Thread Christian König
On 01.02.2012 12:31, Simon Farnsworth wrote: Christian, You said elsewhere that you have half-finished patches that illustrate the interface Jerome prefers - if you send them to me, I can work on finishing them. Responding to the rest of the message: Well it's probably easier to type that down

Re: [PATCH] drm/radeon: Add support for userspace fence waits

2012-02-01 Thread Marek Olšák
2012/2/1 Michel Dänzer : > On Die, 2012-01-31 at 22:08 +0100, Marek Olšák wrote: >> 2012/1/31 Jerome Glisse : >> > On Tue, Jan 31, 2012 at 06:56:01PM +0100, Michel Dänzer wrote: >> >> On Die, 2012-01-31 at 16:59 +, Simon Farnsworth wrote: >> >> > Userspace currently busywaits for fences to comp

Re: [PATCH] drm/radeon: Add support for userspace fence waits

2012-02-01 Thread Simon Farnsworth
Christian, You said elsewhere that you have half-finished patches that illustrate the interface Jerome prefers - if you send them to me, I can work on finishing them. Responding to the rest of the message: On Tuesday 31 January 2012, Jerome Glisse wrote: > On Tue, Jan 31, 2012 at 01:55:43PM -05

Re: [PATCH] drm/radeon: Add support for userspace fence waits

2012-02-01 Thread Michel Dänzer
On Die, 2012-01-31 at 22:08 +0100, Marek Olšák wrote: > 2012/1/31 Jerome Glisse : > > On Tue, Jan 31, 2012 at 06:56:01PM +0100, Michel Dänzer wrote: > >> On Die, 2012-01-31 at 16:59 +, Simon Farnsworth wrote: > >> > Userspace currently busywaits for fences to complete; on my workload, > >> >

Re: Re: [PATCH] drm/radeon: Add support for userspace fence waits

2012-01-31 Thread Christian König
On -10.01.-28163 20:59, Jerome Glisse wrote: On Tue, Jan 31, 2012 at 02:13:00PM -0500, Alex Deucher wrote: On Tue, Jan 31, 2012 at 2:07 PM, Jerome Glisse wrote: On Tue, Jan 31, 2012 at 01:55:43PM -0500, David Airlie wrote: Some comments below. + struct radeon_device *rdev = dev->dev_priv

Re: [PATCH] drm/radeon: Add support for userspace fence waits

2012-01-31 Thread Marek Olšák
2012/1/31 Jerome Glisse : > On Tue, Jan 31, 2012 at 06:56:01PM +0100, Michel Dänzer wrote: >> On Die, 2012-01-31 at 16:59 +, Simon Farnsworth wrote: >> > Userspace currently busywaits for fences to complete; on my workload, this >> > busywait consumes 10% of the available CPU time. >> > >> > Pr

Re: [PATCH] drm/radeon: Add support for userspace fence waits

2012-01-31 Thread Jerome Glisse
On Tue, Jan 31, 2012 at 02:13:00PM -0500, Alex Deucher wrote: > On Tue, Jan 31, 2012 at 2:07 PM, Jerome Glisse wrote: > > On Tue, Jan 31, 2012 at 01:55:43PM -0500, David Airlie wrote: > >> > >> > >> Some comments below. > >> > >> > +   struct radeon_device *rdev = dev->dev_private; > >> > +   stru

Re: [PATCH] drm/radeon: Add support for userspace fence waits

2012-01-31 Thread Alex Deucher
On Tue, Jan 31, 2012 at 2:07 PM, Jerome Glisse wrote: > On Tue, Jan 31, 2012 at 01:55:43PM -0500, David Airlie wrote: >> >> >> Some comments below. >> >> > +   struct radeon_device *rdev = dev->dev_private; >> > +   struct drm_gem_object *gobj; >> > +   struct radeon_bo *robj; >> > +   void *buffe

Re: [PATCH] drm/radeon: Add support for userspace fence waits

2012-01-31 Thread Jerome Glisse
On Tue, Jan 31, 2012 at 01:55:43PM -0500, David Airlie wrote: > > > Some comments below. > > > + struct radeon_device *rdev = dev->dev_private; > > + struct drm_gem_object *gobj; > > + struct radeon_bo *robj; > > + void *buffer_data; > > + uint32_t *fence_data; > > + int r = 0; > > +

Re: [PATCH] drm/radeon: Add support for userspace fence waits

2012-01-31 Thread Jerome Glisse
On Tue, Jan 31, 2012 at 06:56:01PM +0100, Michel Dänzer wrote: > On Die, 2012-01-31 at 16:59 +, Simon Farnsworth wrote: > > Userspace currently busywaits for fences to complete; on my workload, this > > busywait consumes 10% of the available CPU time. > > > > Provide an ioctl so that userspac

Re: [PATCH] drm/radeon: Add support for userspace fence waits

2012-01-31 Thread David Airlie
Some comments below. > + struct radeon_device *rdev = dev->dev_private; > + struct drm_gem_object *gobj; > + struct radeon_bo *robj; > + void *buffer_data; > + uint32_t *fence_data; > + int r = 0; > + long timeout; > + int ring = RADEON_RING_TYPE_GFX_INDEX; > + >

Re: [PATCH] drm/radeon: Add support for userspace fence waits

2012-01-31 Thread Michel Dänzer
On Die, 2012-01-31 at 16:59 +, Simon Farnsworth wrote: > Userspace currently busywaits for fences to complete; on my workload, this > busywait consumes 10% of the available CPU time. > > Provide an ioctl so that userspace can wait for an EOP interrupt that > corresponds to a previous EVENT_WR

Re: [PATCH] drm/radeon: Add support for userspace fence waits

2012-01-31 Thread Simon Farnsworth
Alex Deucher pointed out an error on IRC; I'm not using radeon_irq_kms_sw_irq_get and put to manage the IRQ enablement. I've fixed this up (as per the partial hunk below), and my bug goes away. I will be cleaning these patches up for proper submission. Simon On Tuesday 31 January 2012, Simon Far