[PATCH AUTOSEL 4.19 15/15] drm/lease: fix WARNING in idr_destroy

2020-03-26 Thread Sasha Levin
From: Qiujun Huang [ Upstream commit b216a8e7908cd750550c0480cf7d2b3a37f06954 ] drm_lease_create takes ownership of leases. And leases will be released by drm_master_put. drm_master_put ->drm_master_destroy ->idr_destroy So we needn't call idr_destroy again.

[PATCH AUTOSEL 5.4 19/19] drm/lease: fix WARNING in idr_destroy

2020-03-26 Thread Sasha Levin
From: Qiujun Huang [ Upstream commit b216a8e7908cd750550c0480cf7d2b3a37f06954 ] drm_lease_create takes ownership of leases. And leases will be released by drm_master_put. drm_master_put ->drm_master_destroy ->idr_destroy So we needn't call idr_destroy again.

[PATCH AUTOSEL 5.5 28/28] drm/lease: fix WARNING in idr_destroy

2020-03-26 Thread Sasha Levin
From: Qiujun Huang [ Upstream commit b216a8e7908cd750550c0480cf7d2b3a37f06954 ] drm_lease_create takes ownership of leases. And leases will be released by drm_master_put. drm_master_put ->drm_master_destroy ->idr_destroy So we needn't call idr_destroy again.

Re: [PATCH v2] drm/lease: fix WARNING in idr_destroy

2020-03-18 Thread Daniel Vetter
On Wed, Mar 18, 2020 at 03:53:50PM +0800, Qiujun Huang wrote: > drm_lease_create takes ownership of leases. And leases will be released > by drm_master_put. > > drm_master_put > ->drm_master_destroy > ->idr_destroy > > So we needn't call idr_destroy again. > >

Re: WARNING in idr_destroy

2020-03-18 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+05835159fe322770f...@syzkaller.appspotmail.com Tested on: commit: b1289238 drm/lease: fix WARNING in idr_destroy git tree: https://github.com/hqj/hqjagain_test.git

Re: WARNING in idr_destroy

2020-03-18 Thread Qiujun Huang
#syz test: https://github.com/hqj/hqjagain_test.git idr_destroy ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v2] drm/lease: fix WARNING in idr_destroy

2020-03-18 Thread Qiujun Huang
drm_lease_create takes ownership of leases. And leases will be released by drm_master_put. drm_master_put ->drm_master_destroy ->idr_destroy So we needn't call idr_destroy again. Reported-and-tested-by: syzbot+05835159fe322770f...@syzkaller.appspotmail.com Signed-off-by: Qiujun

Re: [PATCH] drm/lease: fix WARNING in idr_destroy

2020-03-17 Thread Qiujun Huang
On Wed, Mar 18, 2020 at 12:57 AM Daniel Vetter wrote: > > On Mon, Mar 16, 2020 at 11:36:08AM +0800, Qiujun Huang wrote: > > leases has been destroyed: > > drm_master_put > > ->drm_master_destroy > > ->idr_destroy > > > > so the "out_lessee" needn't to call idr_destroy again. > > >

Re: [PATCH] drm/lease: fix WARNING in idr_destroy

2020-03-17 Thread Daniel Vetter
On Mon, Mar 16, 2020 at 11:36:08AM +0800, Qiujun Huang wrote: > leases has been destroyed: > drm_master_put > ->drm_master_destroy > ->idr_destroy > > so the "out_lessee" needn't to call idr_destroy again. > > Reported-and-tested-by:

[PATCH] drm/lease: fix WARNING in idr_destroy

2020-03-16 Thread Qiujun Huang
leases has been destroyed: drm_master_put ->drm_master_destroy ->idr_destroy so the "out_lessee" needn't to call idr_destroy again. Reported-and-tested-by: syzbot+05835159fe322770f...@syzkaller.appspotmail.com Signed-off-by: Qiujun Huang --- drivers/gpu/drm/drm_lease.c | 5

Re: WARNING in idr_destroy

2020-03-15 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: WARNING in idr_destroy RBP: 0076bf20 R08: R09: R10: R11: 0246 R12: 0004 R13: 0203 R14: 004c3e56 R15

Re: WARNING in idr_destroy

2020-03-15 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: WARNING in idr_destroy RBP: 0076bf20 R08: R09: R10: R11: 0246 R12: 0004 R13: 0203 R14: 004c3e56 R15

Re: WARNING in idr_destroy

2020-03-15 Thread Qiujun Huang
We need to get idr_mutex first for idr_alloc. diff --git a/drivers/gpu/drm/drm_lease.c b/drivers/gpu/drm/drm_lease.c index b481cafdde28..aa72c8344ec7 100644 --- a/drivers/gpu/drm/drm_lease.c +++ b/drivers/gpu/drm/drm_lease.c @@ -420,6 +420,7 @@ static int fill_object_idr(struct drm_device *dev,

Re: WARNING in idr_destroy

2020-03-11 Thread syzbot
syzbot has bisected this bug to: commit 5b3709793d151e6e12eb6a38a5da3f7fc2923d3a Author: Thomas Zimmermann Date: Wed May 8 08:26:19 2019 + drm/ast: Convert AST driver to |struct drm_gem_vram_object| bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=15a66fb5e0 start

WARNING in idr_destroy

2020-03-03 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:63623fd4 Merge tag 'for-linus' of git://git.kernel.org/pub.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=10e978e3e0 kernel config: https://syzkaller.appspot.com/x/.config?x=5d2e033af114153f