Re: drm/msm/mdp5: negative x/y in cursor move

2018-07-16 Thread Rob Clark
On Tue, Jul 10, 2018 at 1:18 PM, Carsten Behling wrote: > I found the solution: > > ROI has to be recalculated for negative x/y indicating using the lower/right > corner of the cursor buffer. Further, MDP5_LM_CURSOR_XY_SRC_Y and > MDP5_LM_CURSOR_XY_SRC_X mus be calculated for the hotspot: oh, sor

Re: drm/msm/mdp5: negative x/y in cursor move

2018-07-11 Thread Carsten Behling
I found the solution: ROI has to be recalculated for negative x/y indicating using the lower/right corner of the cursor buffer. Further, MDP5_LM_CURSOR_XY_SRC_Y and MDP5_LM_CURSOR_XY_SRC_X mus be calculated for the hotspot: Index: kernel-source/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c ===

drm/msm/mdp5: negative x/y in cursor move

2018-07-11 Thread Carsten Behling
Hi, modesetting X11 driver may provide negative x/y cordinates in mdp5_crtc_cursor_move(...) call when rotation is enabled. Because of static int mdp5_crtc_cursor_move(struct drm_crtc *crtc, int x, int y) { ... mdp5_crtc->cursor.x = x = max(x, 0); mdp5_crtc->cursor.y = y = max(y, 0); ... } x/y