drm: fix blob pointer check

2016-03-14 Thread Dan Carpenter
On Fri, Mar 11, 2016 at 11:52:44AM +, Lionel Landwerlin wrote: > Hi Dan, > > Thanks a lot for pointing this out. I saw you previous comment but > didn't realize the issue. > I'll set the pointer to NULL. > > I don't if there is an agreement on this, but do you think the > unref/free

drm: fix blob pointer check

2016-03-11 Thread Dan Carpenter
Hi Lionel Landwerlin, The patch 562c5b4d8986: "drm: fix blob pointer check" from Mar 10, 2016, has a problem. drivers/gpu/drm/drm_atomic_helper.c 2924 blob = drm_property_create_blob(dev, 2925 sizeof(struct drm_color_lut) * si

drm: fix blob pointer check

2016-03-11 Thread David Herrmann
Hey On Fri, Mar 11, 2016 at 12:52 PM, Lionel Landwerlin wrote: > Thanks a lot for pointing this out. I saw you previous comment but didn't > realize the issue. > I'll set the pointer to NULL. > > I don't if there is an agreement on this, but do you think the unref/free > functions should check

drm: fix blob pointer check

2016-03-11 Thread Lionel Landwerlin
wrote: > Hi Lionel Landwerlin, > > The patch 562c5b4d8986: "drm: fix blob pointer check" from Mar 10, > 2016, has a problem. > > drivers/gpu/drm/drm_atomic_helper.c >2924 blob = drm_property_create_blob(dev, >2925

[Intel-gfx] [PATCH] drm: fix blob pointer check

2016-03-10 Thread Daniel Vetter
On Thu, Mar 10, 2016 at 12:10:30PM +, Daniel Stone wrote: > On 10 March 2016 at 12:04, Lionel Landwerlin > wrote: > > Check properly that the allocated blob's pointer is valid. > > > > Signed-off-by: Lionel Landwerlin > > Reported-by: Dan Carpenter > > Cc: Daniel Stone > > Reviewed-by:

[Intel-gfx] [PATCH] drm: fix blob pointer check

2016-03-10 Thread Daniel Stone
On 10 March 2016 at 12:04, Lionel Landwerlin wrote: > Check properly that the allocated blob's pointer is valid. > > Signed-off-by: Lionel Landwerlin > Reported-by: Dan Carpenter > Cc: Daniel Stone Reviewed-by: Daniel Stone

[PATCH] drm: fix blob pointer check

2016-03-10 Thread Lionel Landwerlin
Check properly that the allocated blob's pointer is valid. Signed-off-by: Lionel Landwerlin Reported-by: Dan Carpenter Cc: Daniel Stone Cc: Daniel Vetter Cc: Matt Roper Cc: dri-devel at lists.freedesktop.org --- drivers/gpu/drm/drm_atomic_helper.c | 4 ++-- 1 file changed, 2 insertions(+),