Re: [R300][PATCH] Add/fix COS SIN + FP fixes

2007-02-12 Thread Roland Scheidegger
Rune Petersen Ok commited. I didn't look too closely at this but I've a couple of comments. - COS looks too complicated broken. If you'd want to get 2 with a LOG2, you'd need 0.25 as source. But even using RCP instead, that's 5 instructions before performing the sine, for something you can

Re: [R300][PATCH] Add/fix COS SIN + FP fixes

2007-02-12 Thread Roland Scheidegger
Roland Scheidegger wrote: Rune Petersen Ok commited. I didn't look too closely at this but I've a couple of comments. - COS looks too complicated broken. If you'd want to get 2 with a LOG2, you'd need 0.25 as source. But even using RCP instead, that's 5 instructions before performing the

Re: Hown compile and install linux-agp-compat

2007-02-12 Thread Sergio Monteiro Basto
On Tue, 2007-02-06 at 21:46 +, Sergio Monteiro Basto wrote: Does your kernel config enable agpgart and intel-agp as modules? no , is compiled into kernel CONFIG_AGP=y CONFIG_AGP_ALI=y CONFIG_AGP_ATI=y CONFIG_AGP_AMD=y CONFIG_AGP_AMD64=y CONFIG_AGP_INTEL=y CONFIG_AGP_NVIDIA=y

Re: Hown compile and install linux-agp-compat

2007-02-12 Thread Thomas Hellström
Sergio Monteiro Basto wrote: On Tue, 2007-02-06 at 21:46 +, Sergio Monteiro Basto wrote: Does your kernel config enable agpgart and intel-agp as modules? no , is compiled into kernel CONFIG_AGP=y CONFIG_AGP_ALI=y CONFIG_AGP_ATI=y CONFIG_AGP_AMD=y CONFIG_AGP_AMD64=y

Re: [R300][PATCH] Add/fix COS SIN + FP fixes

2007-02-12 Thread Rune Petersen
Roland Scheidegger wrote: Roland Scheidegger wrote: Rune Petersen Ok commited. I didn't look too closely at this but I've a couple of comments. - COS looks too complicated broken. If you'd want to get 2 with a LOG2, you'd need 0.25 as source. But even using RCP instead, that's 5