[PATCH] convert proc files to seq_file

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/drm_proc.c | 726 1 files changed, 266 insertions(+), 460 deletions(-) diff --git a/drivers/gpu/drm/drm_proc.c b/drivers/gpu/drm/drm_proc.c index 8df849f..b949e89 100644 --- a/drivers/gpu/drm/drm_proc.c +++ b/drivers/gpu/drm/drm_pr

[PATCH] create/remove debugfs roots during driver init/cleanup

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/drm_drv.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index febb517..9b74efb 100644 --- a/drivers/gpu/drm/drm_drv.c +++ b/drivers/gpu/drm/drm_drv.c @@ -46,9 +46,11 @@ * OTHER DEALINGS

Re: [PATCH] Proc to debugfs migration

2009-01-14 Thread Ben Gamari
Bah, naturally just as I sent this out I realized that anholt sent me comments on the last iteration of this patch set. I'll incorporate his proposed changes and any others I receive in the next few hours and send it out again. Sorry about the spam, - Ben On Wed, 2009-01-14 at 19:27 -0500, Ben G

[PATCH] remove i915 proc hooks

2009-01-14 Thread Ben Gamari
These are going into debugfs. There is no reason why they need to be in proc. --- drivers/gpu/drm/i915/Makefile|1 - drivers/gpu/drm/i915/i915_drv.c |2 - drivers/gpu/drm/i915/i915_drv.h |2 - drivers/gpu/drm/i915/i915_gem_proc.c | 334 ---

[PATCH] Move proc/debugfs info functions into separate files

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/Makefile |2 +- drivers/gpu/drm/drm_debugfs.c | 61 +--- drivers/gpu/drm/drm_info.c| 351 + drivers/gpu/drm/drm_info.h| 13 ++ drivers/gpu/drm/drm_proc.c| 314 + 5 files c

[PATCH] add debugfs hooks to drm_driver struct

2009-01-14 Thread Ben Gamari
--- include/drm/drmP.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/drm/drmP.h b/include/drm/drmP.h index 8933f9d..48a240a 100644 --- a/include/drm/drmP.h +++ b/include/drm/drmP.h @@ -765,6 +765,8 @@ struct drm_driver { int (*proc_init)(struct drm_min

[PATCH] Proc to debugfs migration, 2nd attempt

2009-01-14 Thread Ben Gamari
Hey everyone, Here is my procfs cleanup patchset. As you can see, the first two patches attempt to clean up the existing proc file creation code and port the files' implementations to the seq_file interface. The remaining patches focus on implementing a similar system for debugfs files. Fe

[PATCH] add debugfs declarations

2009-01-14 Thread Ben Gamari
--- include/drm/drmP.h | 38 +- 1 files changed, 37 insertions(+), 1 deletions(-) diff --git a/include/drm/drmP.h b/include/drm/drmP.h index efe50b6..1484797 100644 --- a/include/drm/drmP.h +++ b/include/drm/drmP.h @@ -800,6 +800,27 @@ struct drm_driver { #d

[PATCH] Integrate former ring buffer dumping code

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/i915/i915_gem_debugfs.c | 573 +++ 1 files changed, 573 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_debugfs.c b/drivers/gpu/drm/i915/i915_gem_debugfs.c index ccc6d5f..cc91461 100644 --- a/drivers/gpu/drm/i915/i915_gem_

[PATCH] add former proc files to debugfs as well

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/drm_debugfs.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c index e6f0725..e03457c 100644 --- a/drivers/gpu/drm/drm_debugfs.c +++ b/drivers/gpu/drm/drm_debugfs.c @@ -10,6 +10,14 @@

[PATCH] Output a hex dump of each instruction

2009-01-14 Thread Ben Gamari
Output a hex dump of each instruction we dump from the ring buffer to aid more complex debugging situations. --- drivers/gpu/drm/i915/i915_gem_debugfs.c | 25 - 1 files changed, 16 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_debugfs.c b/driv

[PATCH] Correctly implement batchbuffer dumping

2009-01-14 Thread Ben Gamari
We need to map the batch buffer before we attempt to dump it. Also, break dumping out into a separate function to make error handling a bit cleaner. --- drivers/gpu/drm/i915/i915_gem_debugfs.c | 63 -- 1 files changed, 50 insertions(+), 13 deletions(-) diff --git a/d

[PATCH] add debugfs sources to Makefile

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/Makefile |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 30022c4..2aeaf02 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -10,7 +10,8 @@ drm-y :=drm_auth.o

[PATCH] convert proc files to seq_file

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/drm_proc.c | 726 1 files changed, 266 insertions(+), 460 deletions(-) diff --git a/drivers/gpu/drm/drm_proc.c b/drivers/gpu/drm/drm_proc.c index 8df849f..b949e89 100644 --- a/drivers/gpu/drm/drm_proc.c +++ b/drivers/gpu/drm/drm_pr

[PATCH] add memory type of batch buffer to ring dump output

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/i915/i915_gem_debugfs.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_debugfs.c b/drivers/gpu/drm/i915/i915_gem_debugfs.c index cc91461..10ca9ae 100644 --- a/drivers/gpu/drm/i915/i915_gem_debugfs.c +++ b/drivers/g

[PATCH] add proc structure definitions to header

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/drm_stub.c |2 +- include/drm/drmP.h | 24 +++- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c index 5ca132a..566847d 100644 --- a/drivers/gpu/drm/drm_stub.c +++ b/drivers

[PATCH] Implement gem object search by gtt offset

2009-01-14 Thread Ben Gamari
When dumping a batch buffer, we need to find its gem object so that we may pin it. Here we look through active_list, inactive_list, and flushing_list looking for an object with a valid and matching gtt_offset --- drivers/gpu/drm/i915/i915_gem_debugfs.c | 47 +-- 1 fil

[RFC] [PATCH] Ring buffer dumping

2009-01-14 Thread Ben Gamari
Hey again everyone, Here is my latest attempt at implementing batch buffer dumping in GEM. The patches have changed relatively little except for the fact that they now work. At this point, reading from the debugfs file will dump not only the ring buffer but also any batch buffers still valid and

[PATCH] Remove obj_priv->gtt_bound

2009-01-14 Thread Ben Gamari
gtt_bound isn't used anywhere in the driver. Remove it on keithp's suggestion. Use obj_priv->gtt_space != NULL to test whether an object is mapped into the GTT. --- drivers/gpu/drm/i915/i915_drv.h |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_

[PATCH] add i915 debugfs implementation

2009-01-14 Thread Ben Gamari
Port old i915-specific proc file entries to debugfs --- drivers/gpu/drm/i915/Makefile |1 + drivers/gpu/drm/i915/i915_drv.c |4 + drivers/gpu/drm/i915/i915_drv.h |4 + drivers/gpu/drm/i915/i915_gem_debugfs.c | 205 +++ 4 files chan

[PATCH] Add drm core debugfs implementation

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/drm_debugfs.c | 268 + drivers/gpu/drm/drm_stub.c| 13 ++ 2 files changed, 281 insertions(+), 0 deletions(-) create mode 100644 drivers/gpu/drm/drm_debugfs.c diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugf

[PATCH] add debugfs file implementations

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/drm_debugfs.c | 268 + 1 files changed, 268 insertions(+), 0 deletions(-) create mode 100644 drivers/gpu/drm/drm_debugfs.c diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c new file mode 100644 index 000..1

[PATCH] add DRM_DEBUGFS Kconfig option

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/Kconfig |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 5130b72..5b3ed46 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -18,6 +18,13 @@ menuconfig DRM details

[PATCH] add debugfs sources to Makefile

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/Makefile |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 30022c4..2aeaf02 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -10,7 +10,8 @@ drm-y :=drm_auth.o

[PATCH] add debugfs declarations

2009-01-14 Thread Ben Gamari
add drm_debugfs_node stuct, drm_debugfs_root, debugfs entries to drm_minor. Also add debugfs function declarations --- include/drm/drmP.h | 36 1 files changed, 36 insertions(+), 0 deletions(-) diff --git a/include/drm/drmP.h b/include/drm/drmP.h index efa79

[PATCH] add debugfs init hooks

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/drm_stub.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c index 566847d..eb5d100 100644 --- a/drivers/gpu/drm/drm_stub.c +++ b/drivers/gpu/drm/drm_stub.c @@ -50,6 +50,7 @@ struct idr d

[PATCH] add proc structure definitions to header

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/drm_stub.c |2 +- include/drm/drmP.h | 24 +++- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c index 5ca132a..566847d 100644 --- a/drivers/gpu/drm/drm_stub.c +++ b/drivers

[PATCH] remove last remnants of i915 proc implementations

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/i915/Makefile|1 - drivers/gpu/drm/i915/i915_gem_proc.c | 334 -- 2 files changed, 0 insertions(+), 335 deletions(-) delete mode 100644 drivers/gpu/drm/i915/i915_gem_proc.c diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/d

[PATCH] remove i915 proc hooks

2009-01-14 Thread Ben Gamari
These are going into debugfs. There is no reason why they need to be in proc. --- drivers/gpu/drm/i915/Makefile|1 - drivers/gpu/drm/i915/i915_drv.c |2 - drivers/gpu/drm/i915/i915_drv.h |2 - drivers/gpu/drm/i915/i915_gem_proc.c | 334 ---

[PATCH] add debugfs hooks to drm_driver struct

2009-01-14 Thread Ben Gamari
--- include/drm/drmP.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/drm/drmP.h b/include/drm/drmP.h index 3f45fb7..c318736 100644 --- a/include/drm/drmP.h +++ b/include/drm/drmP.h @@ -765,6 +765,8 @@ struct drm_driver { int (*proc_init)(struct drm_min

[PATCH] add debugfs declarations

2009-01-14 Thread Ben Gamari
add drm_debugfs_node stuct, drm_debugfs_root, debugfs entries to drm_minor. Also add debugfs function declarations --- include/drm/drmP.h | 36 1 files changed, 36 insertions(+), 0 deletions(-) diff --git a/include/drm/drmP.h b/include/drm/drmP.h index efa79

[PATCH] remove declarations of proc hooks

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/i915/i915_drv.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 467572a..9158a94 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -575,8 +575,6

[PATCH] declare debugfs init/cleanup hooks

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/i915/i915_drv.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 9158a94..ff6f1e5 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -611,6 +611

[PATCH] add i915 debugfs implementation

2009-01-14 Thread Ben Gamari
Port old i915-specific proc file entries to debugfs --- drivers/gpu/drm/i915/Makefile |1 + drivers/gpu/drm/i915/i915_drv.c |4 + drivers/gpu/drm/i915/i915_drv.h |4 + drivers/gpu/drm/i915/i915_gem_debugfs.c | 205 +++ 4 files chan

[PATCH] add former proc files to debugfs as well

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/drm_debugfs.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c index fc03a45..e523069 100644 --- a/drivers/gpu/drm/drm_debugfs.c +++ b/drivers/gpu/drm/drm_debugfs.c @@ -10,6 +10,14 @@

[PATCH] Proc to debugfs migration

2009-01-14 Thread Ben Gamari
Hey everyone, Here is my procfs cleanup patchset. As you can see, the first two patches attempt to clean up the existing proc file creation code and port the files' implementations to the seq_file interface. The remaining patches focus on implementing a similar system for debugfs files. Fe

[PATCH] create/remove debugfs roots during driver init/cleanup

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/drm_drv.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index febb517..9b74efb 100644 --- a/drivers/gpu/drm/drm_drv.c +++ b/drivers/gpu/drm/drm_drv.c @@ -46,9 +46,11 @@ * OTHER DEALINGS

[PATCH] Move proc/debugfs info functions into separate files

2009-01-14 Thread Ben Gamari
--- drivers/gpu/drm/Makefile |2 +- drivers/gpu/drm/drm_debugfs.c | 61 +--- drivers/gpu/drm/drm_info.c| 351 + drivers/gpu/drm/drm_info.h| 13 ++ drivers/gpu/drm/drm_proc.c| 314 + 5 files c

Re: Add GEM to i915 broke compilation on MIPS

2009-01-14 Thread Eric Anholt
On Sat, 2009-01-10 at 19:16 +0100, Martin Michlmayr wrote: > Eric, > > Your patch "drm: Add GEM ("graphics execution manager") to i915 > driver" [1] broke compilation on MIPS because agp.h doesn't exist. > > CALLscripts/checksyscalls.sh > CC [M] drivers/gpu/drm/drm_agpsupport.o > drivers

[RFC] VGA hotplug support for i915 kms

2009-01-14 Thread Jesse Barnes
Here's a work in progress VGA hotplug patch that I've been testing on my GM45. I've only tested VGA interrupts so far, but other ports may work or should be easy to enable. When a hotplug interrupt is received, the i915 interrupt handler kicks off a work queue which ends up sending a uevent. I've

[Bug 19562] New: Regression: Software Rasterizer with EXA

2009-01-14 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=19562 Summary: Regression: Software Rasterizer with EXA Product: DRI Version: DRI CVS Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priorit

Re: [PATCH] add DRM_DEBUGFS config option to Kconfig

2009-01-14 Thread Eric Anholt
On Sun, 2008-12-21 at 15:21 -0500, Ben Gamari wrote: > --- > drivers/gpu/drm/Kconfig |7 +++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index 6903e54..fd7418a 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/driver

Re: [PATCH] add debugfs init hooks

2009-01-14 Thread Eric Anholt
On Sun, 2008-12-21 at 15:21 -0500, Ben Gamari wrote: > --- > drivers/gpu/drm/drm_stub.c | 12 > 1 files changed, 12 insertions(+), 0 deletions(-) > > diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c > index 5697764..23f1bca 100644 > --- a/drivers/gpu/drm/drm_stu

Re: [PATCH] create IDR mutex for mode_config identifier allocation

2009-01-14 Thread Eric Anholt
On Wed, 2009-01-14 at 10:48 -0800, Jesse Barnes wrote: > >From fc3b2a31f1d2274bcf98929d5f3a5aeaee1baf4d Mon Sep 17 00:00:00 2001 > From: Jesse Barnes > Date: Wed, 14 Jan 2009 10:38:13 -0800 > Subject: [PATCH] drm: create mode_config idr lock > > Create a separate mode_config IDR lock for simplici

[PATCH] i915: make LVDS fixed mode a preferred mode

2009-01-14 Thread Jesse Barnes
The detected fixed panel mode really is preferred, so mark it as such and add it to the LVDS connector mode list. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_lvds.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/

[PATCH] create IDR mutex for mode_config identifier allocation

2009-01-14 Thread Jesse Barnes
>From fc3b2a31f1d2274bcf98929d5f3a5aeaee1baf4d Mon Sep 17 00:00:00 2001 From: Jesse Barnes Date: Wed, 14 Jan 2009 10:38:13 -0800 Subject: [PATCH] drm: create mode_config idr lock Create a separate mode_config IDR lock for simplicity. The core DRM config structures (connector, mode, etc. lists) a

[Bug 12441] Xorg can't use dri on radeon X1950 AGP

2009-01-14 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=12441 --- Comment #3 from dan...@ffwll.ch 2009-01-14 06:48 --- Tested with v2.6.29-rc1-227-gdf0c6c3 (because of the PAT related merge). The problem persisted, but the dmesg changed. radeon related parts: [ 104.396902] pci :05:00.0: PCI

Re: unable to build i915.ko

2009-01-14 Thread Tormod Volden
On Wed, Jan 14, 2009 at 5:30 AM, Abraham Varricatt wrote: > Can you please tell me what are the other make commands I need to run? > Repeating myself, what I run now is, > linux-headers-2.6.28-4-generic> make menuconfig > linux-headers-2.6.28-4-generic> make drivers/gpu/drm > linux-headers-2.6.28-

[Bug 19504] [945GM] glitch in ut2004, regression

2009-01-14 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=19504 --- Comment #8 from Bernd Buschinski 2009-01-14 04:58:10 PST --- Created an attachment (id=21976) --> (http://bugs.freedesktop.org/attachment.cgi?id=21976) Xorg.0.log with i915_dri.so ut2004 with swrast_dri.so looks fine, no glitches (but

[Bug 19496] resume from standby broken when using desktop effects, screen freezed

2009-01-14 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=19496 --- Comment #3 from Cyrill Helg 2009-01-14 03:07:50 PST --- Created an attachment (id=21973) --> (http://bugs.freedesktop.org/attachment.cgi?id=21973) X.org.log -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ---

[Bug 19496] resume from standby broken when using desktop effects, screen freezed

2009-01-14 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=19496 --- Comment #4 from Cyrill Helg 2009-01-14 03:10:34 PST --- Ok here is the X.org.log file. The dmesg output had nothing interesting, neither var/log/messages. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --