Re: [PATCH] vgaarb: fix trylock behaviour accordingly vga_tryget return value

2010-01-13 Thread Henry Zhao
Signed-off-by: Henry Zhao henry.z...@sun.com Tiago Vignatti wrote: From: Henry Zhao henry.z...@sun.com Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- Henry, can you Signed-off-by there? drivers/gpu/vga/vgaarb.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: drivers/gpu/drm/radeon/radeon_cp.c: check for invalid radeon family

2010-01-13 Thread walter harms
Darren Jenkins schrieb: If there is an invalid radeon family the fw_name is NULL and causes an NULL pointer dereference. This just adds a check for something unexpected. Coverity CID: 13252 Signed-off-by: Darren Jenkins darrenrjenk...@gmail.com diff --git

[PATCH] drm/radeon/kms: Fix r600 blit cleanup path

2010-01-13 Thread Jerome Glisse
r600 blit cleanup path need to check if a bo was allocated before trying to free or unpin it. This patch add this check and avoid oops when the initialization on r6xx or r7xx hw fails. Signed-off-by: Jerome Glisse jgli...@redhat.com --- drivers/gpu/drm/radeon/r600.c | 12 +++-

[Bug 25733] Latest drm-radeon-testing fails to suspend

2010-01-13 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=25733 --- Comment #7 from Christophe Saout christo...@saout.de 2010-01-13 01:46:02 PST --- I can confirm this fixes the bug for me too. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this

radeon.benchmark=1 enters xmon on PPC

2010-01-13 Thread Gerhard Pircher
Hi, The radeon benchmark test fails on my non coherent DMA 745x PPC machine (see the kernel log excerpt below). The test was performed with a fresh copy of the airlied/drm-2.6/drm-next branch and the radeon driver was forced to PCIGART mode. The radeon GTT-VRAM copy test however works fine. Let

[PATCH] drm/radeon/kms: Do not unpin buffer in fb destruction

2010-01-13 Thread Jerome Glisse
It's not necessary to unpin buffer in fb destruction. pin/unpin need to be balanced and we don't pin in fb creation. We pin when an fb is associated to a crtc and unpin when the fb is disassociated from the crtc. Note: Maybe we should take reference on fb in set_base callback so fb doesn't

[PATCH] drm/radeon/kms: Disable AGP is aperture size 32M

2010-01-13 Thread Jerome Glisse
radeon KMS need a GART of at least 32M to properly work. This patch check the AGP aperture size and disable if it's less than 32M. Note than unlike non KMS path we don't staticaly allocate AGP memory so we are not wasting memory not used by graphic processing. Signed-off-by: Jerome Glisse

drm/radeon/kms: AGP fixes workaround

2010-01-13 Thread Jerome Glisse
Two patch which fix a couple issue with AGP handling. -- This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market

[PATCH] drm/radeon/kms: Use radeon_agp_disable when disabling AGP

2010-01-13 Thread Jerome Glisse
Use same common function to disable agp so we replace the GART callback by the proper one when we do so. This fix oops if radeon_agp_init report failure. This patch also move radeon_agp_init out of *_mc_init for r600 rv770 so that we can have a similar behavior than for previous hw, ie if

[Bug 25723] Bloom option in OpenArena causes 1FPS (blit sth?)

2010-01-13 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=25723 --- Comment #3 from Rafał Miłecki zaj...@gmail.com 2010-01-13 07:40:04 PST --- With r600: blit - add formats, cleanup, formatting I don't see that format messages anymore :) Before r600: blit - add formats, cleanup, formatting 840 frames

Re: [PATCH] drm/kms: fix fbdev blanking regression

2010-01-13 Thread James Simmons
On 01/07/2010 12:42 AM, Johan Hovold wrote: Yeap. The fix uncovered a bug in your driver. I haven't heard of problems with the other drm drivers. The backlight is handled via the DRI driver I assume. At least i9xx_crtc_dpms is called on powerdown. Can you post

Re: [PATCH] drm/kms: fix fbdev blanking regression

2010-01-13 Thread Alex Deucher
On Wed, Jan 13, 2010 at 2:48 PM, James Simmons jsimm...@infradead.org wrote: On 01/07/2010 12:42 AM, Johan Hovold wrote: Yeap. The fix uncovered a bug in your driver. I haven't heard of problems with the other drm drivers. The backlight is handled via the DRI driver I assume.

[Bug 15030] screen connected to displayport is not detected - kms radeon

2010-01-13 Thread bugzilla-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=15030 --- Comment #2 from Nicolas Reinecke pl4nk...@googlemail.com 2010-01-13 21:00:37 --- I now use kernel 2.6.33-rc4, before it was 2.6.33-rc3. [0.00] Linux version 2.6.33-rc4-desktop32 (r...@desktop) (gcc version 4.4.3 20100108

[PATCH 04/10] vmwgfx: Use bo_driver::move_notify to unbind GMRs.

2010-01-13 Thread Thomas Hellstrom
This was previously done explicitly for overlay- and fb buffers. Now it's done for any buffer leaving the SYSTEM memory region. Signed-off-by: Thomas Hellstrom thellst...@vmware.com --- drivers/gpu/drm/vmwgfx/vmwgfx_buffer.c | 10 +- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h |1 +

[PATCH 09/10] ttm: Kill some leftover debug messages.

2010-01-13 Thread Thomas Hellstrom
Signed-off-by: Thomas Hellstrom thellst...@vmware.com --- drivers/gpu/drm/ttm/ttm_lock.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_lock.c b/drivers/gpu/drm/ttm/ttm_lock.c index 3d172ef..de41e55 100644 --- a/drivers/gpu/drm/ttm/ttm_lock.c

[PATCH 0/10] vmwgfx bug-fixes

2010-01-13 Thread Thomas Hellstrom
This patch series contains a number of bug fixes for the vmwgfx driver. Some fixes has required minimal changes to TTM, most notably a swap_notify callback, since the vmwgfx driver has driver-private GPU bindings. --

[PATCH 01/10] vmwgfx: Don't promote updates from GMR-backed scanouts to fullscreen.

2010-01-13 Thread Thomas Hellstrom
That's unnecessary since partial screen updates from GMRs are fast. Also fix cliprect pointer dereferencing Signed-off-by: Thomas Hellstrom thellst...@vmware.com --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 12 +--- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git

[PATCH 03/10] vmwgfx: Make fence sequences continous across a VT switch.

2010-01-13 Thread Thomas Hellstrom
A vt switch in stealth mode would take down the FIFO, and re- initialize fence sequence numbers. This patch saves the current state of the fence sequence when the FIFO is disabled. Signed-off-by: Thomas Hellstrom thellst...@vmware.com --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c |1 +

[PATCH 06/10] vmwgfx: Implement a swap_notify callback.

2010-01-13 Thread Thomas Hellstrom
Unbind GMR bindings on the buffer about to be swapped out. Signed-off-by: Thomas Hellstrom thellst...@vmware.com --- drivers/gpu/drm/vmwgfx/vmwgfx_buffer.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_buffer.c

[PATCH 05/10] ttm: Add a swap_notify callback.

2010-01-13 Thread Thomas Hellstrom
This is needed for a bugfix in the vmwgfx driver. Drivers may have GPU bindings on buffers that core TTM is not aware of, and TTM may view those buffers as ordinary system memory buffers. Add a notifier to such drivers when TTM is about to move the buffer contents out to swappable memory. The

[PATCH 07/10] ttm: Export symbols needed for vmwgfx suspend / resume operations.

2010-01-13 Thread Thomas Hellstrom
Signed-off-by: Thomas Hellstrom thellst...@vmware.com --- drivers/gpu/drm/ttm/ttm_bo.c |1 + drivers/gpu/drm/ttm/ttm_lock.c |2 ++ 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index e10a04e..7a64f07 100644 ---

[PATCH 02/10] vmwgfx: Fix an error path causing an oops.

2010-01-13 Thread Thomas Hellstrom
An error happening before the snooper.image member had been set up would cause a kfree of an arbitrary pointer. Set up the snooper.image member early. Signed-off-by: Thomas Hellstrom thellst...@vmware.com --- drivers/gpu/drm/vmwgfx/vmwgfx_resource.c | 39 - 1 files

[PATCH 08/10] vmwgfx: Implement basic pm operations.

2010-01-13 Thread Thomas Hellstrom
Currently we really only support S3, since the device doesn't support saving of the 3D state. On S3/S4, move all buffer objects to swappable memory and take down GMR bindings. We need to do that from a PM notifier since we can't do persistant memory allocations from the standard PM callbacks.

[PATCH 10/10] ttm: Make sure system buffer objects has offset == 0.

2010-01-13 Thread Thomas Hellstrom
This is a convention that the vmwgfx driver has come to rely on. Signed-off-by: Thomas Hellstrom thellst...@vmware.com --- drivers/gpu/drm/ttm/ttm_bo.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index

[Bug 15017] kexec regression, radeon/kms irq related (bisected)

2010-01-13 Thread bugzilla-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=15017 Rafael J. Wysocki r...@sisk.pl changed: What|Removed |Added CC||r...@sisk.pl

[Bug 15017] kexec regression, radeon/kms irq related (bisected)

2010-01-13 Thread bugzilla-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=15017 --- Comment #2 from Rafael J. Wysocki r...@sisk.pl 2010-01-13 22:11:26 --- commit d8f60cfc93452d0554f6a701aa8e3236cbee4636 Author: Alex Deucher alexdeuc...@gmail.com Date: Tue Dec 1 13:43:46 2009 -0500 drm/radeon/kms: Add support for

[Bug 25733] Latest drm-radeon-testing fails to suspend

2010-01-13 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=25733 Gavin Kinsey ga...@trollgod.org.uk changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 23993] OpenGL app crashes randomly with 'drmRadeonCmdBuffer: -12'

2010-01-13 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=23993 --- Comment #10 from Dennis Nezic denn...@dennisn.dyndns.org 2010-01-13 16:53:54 PST --- Any other bright ideas? (I tried compiling older versions of xf86-video-ati, but they don't seem to be compatible with the new xorg-server's,

[Bug 15030] screen connected to displayport is not detected - kms radeon

2010-01-13 Thread bugzilla-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=15030 Nicolas Reinecke pl4nk...@googlemail.com changed: What|Removed |Added Kernel Version|2.6.33-rc3 |2.6.33-rc4

[PATCH] drm/radeon/kms: fix displayport-dvi connector DDC.

2010-01-13 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com It appears that attempting AUXCH DDC breaks the subsequent attempt to do DDC over the i2c lines, so use the sink type to determine if we should be doing AUXCH or i2c DDC. This fixes my DVI monitor plugged into DP-DVI convertor. Signed-off-by: Dave Airlie

[Bug 15030] screen connected to displayport is not detected - kms radeon

2010-01-13 Thread bugzilla-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=15030 Dave Airlie airl...@linux.ie changed: What|Removed |Added CC||airl...@linux.ie ---

[Bug 25934] Segfaults while parsing a shader shown to work on other platforms

2010-01-13 Thread bugzilla-daemon
http://bugs.freedesktop.org/show_bug.cgi?id=25934 --- Comment #6 from Lucas Paul reilith...@gmail.com 2010-01-13 20:49:41 PST --- After recompiling (once with Portage's nostrip feature, then again with splitdebug) the latest code, I'm no longer able to reproduce the issue either. I guess