Re: [PATCH] drm/i915: Convert more trace events to DEFINE_EVENT

2010-05-26 Thread Steven Rostedt
On Mon, 2010-05-24 at 16:25 +0800, Li Zefan wrote: Convert i915_gem_object_clflush to DEFINE_EVENT, and save ~0.5K: textdata bss dec hex filename 132042732 12 159483e4c i915_trace_points.o.orig 126682732 12 154123c34 i915_trace_points.o

Re: 2.6.33.2 kmalloc-8 slab leaks ~512 objects per second

2010-05-26 Thread David Rientjes
On Thu, 13 May 2010, Tvrtko Ursulin wrote: You could just enable CONFIG_DEBUG_KMEMLEAK on 2.6.33, mount the debugfs and do a 'cat /sys/kernel/debug/kmemleak' after a half-hour or so. I could do it if radeon/drm guys would be interested in those results? (Given how 2.6.34-rc7 is not

[PATCH 1/2] drm/ttm: Fix cached TTM page allocation.

2010-05-26 Thread Thomas Hellstrom
This patch fixes a regression introduced with the pool page allocator in the event that there are no highmem pages (for example x86_64), in which case cached page allocation would fail. Tested with the vmwgfx driver on a 64-bit vm. Signed-off-by: Thomas Hellstrom thellst...@vmware.com ---

[PATCH 2/2] drm/ttm: Fix ttm_page_alloc.c

2010-05-26 Thread Thomas Hellstrom
Fix a number of typos misspellings and checkpatch.pl warnings. Replace [ttm] with TTM_PFX Signed-off-by: Thomas Hellstrom thellst...@vmware.com --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 62 +++-- 1 files changed, 36 insertions(+), 26 deletions(-) diff --git

Re: [PATCH 1/2] drm/ttm: Fix cached TTM page allocation.

2010-05-26 Thread Jerome Glisse
On Wed, May 26, 2010 at 04:18:49PM +0200, Thomas Hellstrom wrote: This patch fixes a regression introduced with the pool page allocator in the event that there are no highmem pages (for example x86_64), in which case cached page allocation would fail. Tested with the vmwgfx driver on a

Re: [PATCH 2/2] drm/ttm: Fix ttm_page_alloc.c

2010-05-26 Thread Jerome Glisse
On Wed, May 26, 2010 at 04:18:50PM +0200, Thomas Hellstrom wrote: Fix a number of typos misspellings and checkpatch.pl warnings. Replace [ttm] with TTM_PFX Signed-off-by: Thomas Hellstrom thellst...@vmware.com Reviewed-by: Jerome Glisse jgli...@redhat.com ---

Re: [PATCH] drm/i915: Convert more trace events to DEFINE_EVENT

2010-05-26 Thread Eric Anholt
On Tue, 25 May 2010 16:08:46 -0400, Steven Rostedt rost...@goodmis.org wrote: On Mon, 2010-05-24 at 16:25 +0800, Li Zefan wrote: Convert i915_gem_object_clflush to DEFINE_EVENT, and save ~0.5K: textdata bss dec hex filename 132042732 12 159483e4c

Re: [PATCH] drm/i915: Convert more trace events to DEFINE_EVENT

2010-05-26 Thread Eric Anholt
On Mon, 24 May 2010 16:25:44 +0800, Li Zefan l...@cn.fujitsu.com wrote: Convert i915_gem_object_clflush to DEFINE_EVENT, and save ~0.5K: textdata bss dec hex filename 132042732 12 159483e4c i915_trace_points.o.orig 126682732 12 154123c34

Re: [2.6.34, patch] i915: fix lock imbalance on error path...

2010-05-26 Thread Eric Anholt
On Mon, 17 May 2010 14:23:52 +0100, Daniel J Blueman daniel.blue...@gmail.com wrote: While investigating Intel i5 Arrandale GPU lockups with -rc4, I noticed a lock imbalance. Signed-off-by: Daniel J Blueman daniel.blue...@gmail.com Applied. Thanks! pgpNMR7N8gNTc.pgp Description: PGP

Re: [patch -next] i915/intel_sdvo: remove unneeded null check

2010-05-26 Thread Eric Anholt
On Fri, 7 May 2010 10:40:09 +0200, Dan Carpenter erro...@gmail.com wrote: The connector variable is used as the cursor in a list_for_each_entry() and it's always non-null so we don't need to check it. Applied. Thanks! pgp5LjYtrnRQc.pgp Description: PGP signature

Re: [patch -next] i915: remove unneeded null checks

2010-05-26 Thread Eric Anholt
On Fri, 7 May 2010 10:39:00 +0200, Dan Carpenter erro...@gmail.com wrote: The encoder variable can never be null because it is used as loop cursor in a list_for_each_entry() loop. Signed-off-by: Dan Carpenter erro...@gmail.com Applied. Thanks! pgp2b3chFIrqj.pgp Description: PGP signature

Re: [patch] i915: missing unlock on error path

2010-05-26 Thread Eric Anholt
On Fri, 7 May 2010 10:37:01 +0200, Dan Carpenter erro...@gmail.com wrote: There was a missing mutex_unlock(dev-struct_mutex) on this error path. Signed-off-by: Dan Carpenter erro...@gmail.com --- I thought Jiri sent this patch earlier but a google search for stanse struct_mutex i965_reset

Re: 2.6.33.2 kmalloc-8 slab leaks ~512 objects per second

2010-05-26 Thread Tvrtko Ursulin
On Wednesday 26 May 2010 10:21:36 David Rientjes wrote: On Thu, 13 May 2010, Tvrtko Ursulin wrote: You could just enable CONFIG_DEBUG_KMEMLEAK on 2.6.33, mount the debugfs and do a 'cat /sys/kernel/debug/kmemleak' after a half-hour or so. I could do it if radeon/drm guys would be