Re: RFC: libdrm repo

2009-11-17 Thread Jesse Barnes
libdrm, and make sure it works with their current kernel (which may involve some extra work if new DRM interfaces have gone in too). -- Jesse Barnes, Intel Open Source Technology Center -- Let Crystal Reports handle the repor

Re: [RFC] GLX_INTEL_swap_event

2009-11-16 Thread Jesse Barnes
On Mon, 16 Nov 2009 13:25:01 -0800 Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Jesse Barnes wrote: > > On Mon, 16 Nov 2009 11:51:31 -0800 > > Ian Romanick wrote: > > > >> All X events are 32 bytes, but GLX_BUFFER_SWAP_COMPLE

Re: [RFC] GLX_INTEL_swap_event

2009-11-16 Thread Jesse Barnes
On Mon, 16 Nov 2009 11:51:31 -0800 Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Jesse Barnes wrote: > > Kristian, Chris and I met with some of the Clutter/Mutter developers > > last week and came up with a new GLX extension to help GLX inte

[RFC] GLX_INTEL_swap_event

2009-11-16 Thread Jesse Barnes
thing people feel is generally useful? Thanks, -- Jesse Barnes, Intel Open Source Technology Center -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integr

Re: [PATCH] drm: when queuing an event with NEXTONMISS, return queued sequence to userspace

2009-11-11 Thread Jesse Barnes
On Tue, 10 Nov 2009 08:21:25 + Jesse Barnes wrote: > If we queue a vblank event but miss it, we should return the actual > sequence number we queued to userspace, so its event handling function > will know which event to look for. > > Acked-by: Kristian Høgsberg > Si

Re: [PATCH] drm/i915: Fix sync to vblank when VGA output is turned off

2009-11-10 Thread Jesse Barnes
ensure that we will > will return immediately if trying to wait on a disabled pipe. > > Signed-off-by: Li Peng Looks like a good patch, thanks for fixing this up. Reviewed-by: Jesse Barnes Thanks, Jesse -- Let

[PATCH] drm: when queuing an event with NEXTONMISS, return queued sequence to userspace

2009-11-10 Thread Jesse Barnes
If we queue a vblank event but miss it, we should return the actual sequence number we queued to userspace, so its event handling function will know which event to look for. Acked-by: Kristian Høgsberg Signed-off-by: Jesse Barnes diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm

Re: [PATCH] drm: work around EDIDs with bad htotal/vtotal values

2009-11-05 Thread Jesse Barnes
On Thu, 5 Nov 2009 10:12:54 -0800 Jesse Barnes wrote: > We did this on the userspace side, but we need a similar fix for the > kernel. > > Fixes LP #460664. > > Signed-off-by: Jesse Barnes Dave, this should be cc'd to stable as well. Thanks, -- Jesse Barnes, Intel

Re: [RFC] DRI2 synchronization and swap bits

2009-11-02 Thread Jesse Barnes
On Sun, 1 Nov 2009 21:46:45 +0100 Mario Kleiner wrote: > I read this RFC and i'm very excited about the prospect of having > well working support for the OML_sync_control extension in DRI2 on > Linux/X11. I was hoping for this to happen since years, so a big > thank you in advance! This is w

Re: [RFC] DRI2 synchronization and swap bits

2009-10-31 Thread Jesse Barnes
On Fri, 30 Oct 2009 19:15:17 -0700 Keith Packard wrote: > Excerpts from Jesse Barnes's message of Fri Oct 30 10:59:08 -0700 > 2009: > > > These allow us to support GLX extensions like SGI_video_sync, > > OML_swap_control and SGI_swap_interval. > > Let's get the protocol nailed down before we go

Re: [RFC] DRI2 synchronization and swap bits

2009-10-30 Thread Jesse Barnes
On Fri, 30 Oct 2009 11:42:06 -0700 Eric Anholt wrote: > On Fri, 2009-10-30 at 10:59 -0700, Jesse Barnes wrote: > > I've put up some trees (after learning my lesson about working in > > the main tree) with the latest DRI2 sync/swap bits: > > git://git.freedesktop.org/h

[RFC] DRI2 synchronization and swap bits

2009-10-30 Thread Jesse Barnes
the new server code depends on. Thanks, -- Jesse Barnes, Intel Open Source Technology Center -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this y

Re: [resend] i915: high power consumption after suspend/resume

2009-10-30 Thread Jesse Barnes
is bug. > > intel_reg_dumper blames RENCLK_GATE_D2. Patch coming. > > Maybe my BIOS doesn't always reset it. Does resetting that reg get your power savings back? -- Jesse Barnes, Intel Open Source Technology Center

Re: [resend] i915: high power consumption after suspend/resume

2009-10-29 Thread Jesse Barnes
https://bugs.freedesktop.org/show_bug.cgi?id=24386 Andrew, are you still seeing this after the various fixes that have landed in Linus's tree? -- Jesse Barnes, Intel Open Source Technology Center -- Come build with us! The

[PATCH] drm: add developer documentation

2009-10-26 Thread Jesse Barnes
nks, Jesse -- From 2bfae6a8b6145ed59e3f05d8a1ce052007f90394 Mon Sep 17 00:00:00 2001 From: Jesse Barnes Date: Fri, 23 Oct 2009 02:53:40 -0700 Subject: [PATCH] drm: add DRM developer documentation Add a DRM DocBook providing basic information about DRM interfaces, including TTM, GEM, KMS and vblank infrastr

Re: [RFC Patch] use MTRR for write combining if PAT is not available

2009-10-22 Thread Jesse Barnes
On Thu, 22 Oct 2009 18:53:19 -0700 Eric Anholt wrote: > On Thu, 2009-10-22 at 17:11 -0700, Suresh Siddha wrote: > > On Thu, 2009-10-22 at 16:10 -0700, Jesse Barnes wrote: > > > On Thu, 22 Oct 2009 14:47:30 -0700 > > > Suresh Siddha wrote: > > > > > &

Re: [RFC Patch] use MTRR for write combining if PAT is not available

2009-10-22 Thread Jesse Barnes
On Thu, 22 Oct 2009 14:47:30 -0700 Suresh Siddha wrote: > On Thu, 2009-10-22 at 08:34 -0700, Eric Anholt wrote: > > Can we just not create the _wc sysfs entry if we don't have PAT? I > > don't think there's userland relying on its presence as opposed to > > the non-_wc entry. > > Yes indeed. Je

Re: [RFC] drm/i915: support zero flicker boot

2009-10-22 Thread Jesse Barnes
On Thu, 22 Oct 2009 16:45:49 +0900 "H. Peter Anvin" wrote: > On 10/22/2009 03:42 PM, Jesse Barnes wrote: > > If the BIOS programs the native panel mode at boot and the boot > > loader leaves it alone, we should be able to boot with zero > > flicker. This patch fix

Re: [RFC] drm/i915: support zero flicker boot

2009-10-22 Thread Jesse Barnes
On Thu, 22 Oct 2009 16:45:49 +0900 "H. Peter Anvin" wrote: > On 10/22/2009 03:42 PM, Jesse Barnes wrote: > > If the BIOS programs the native panel mode at boot and the boot > > loader leaves it alone, we should be able to boot with zero > > flicker. This patch fix

Re: [RFC] drm/i915: support zero flicker boot

2009-10-22 Thread Jesse Barnes
On Thu, 22 Oct 2009 08:24:42 +0100 Matthew Garrett wrote: > Unfortunately it's basically a requirement for us to come up in VGA > text mode right now - otherwise printk doesn't do anything until > after i915 is up, which is a little excessive. Does the hardware > absolutely require the LVDS be ki

[RFC] drm/i915: support zero flicker boot

2009-10-22 Thread Jesse Barnes
If the BIOS programs the native panel mode at boot and the boot loader leaves it alone, we should be able to boot with zero flicker. This patch fixes up the "mode_switch" test in drm_crtc_helper's set_config function and adds code to the i915 display init function to set the current CRTC mode and

Re: [PATCH] drm: Add async event synchronization for drmWaitVblank

2009-10-14 Thread Jesse Barnes
On Wed, 14 Oct 2009 14:47:22 -0700 Jesse Barnes wrote: > On Fri, 11 Sep 2009 14:33:34 -0400 > "Kristian Høgsberg" wrote: > > > This patch adds a new flag to the drmWaitVblank ioctl, which asks > > the drm to return immediately and notify userspace when the > &

Re: [PATCH] drm: Add async event synchronization for drmWaitVblank

2009-10-14 Thread Jesse Barnes
be sent back to user space in the vblank event. > > Signed-off-by: Kristian Høgsberg > --- This one's been acked, would be good to get into drm-next so we can start pushing stuff that uses it into master of the various repos. Thanks,

Re: drmOpenByName opening incorrect minor?

2009-10-14 Thread Jesse Barnes
quot; drm device. I end up using the wrong fd and get crashes > because my "alpha" device obviously can't handle the "beta" ioctls. > > A few questions: > > 1) Is this expected behavior? > 2) In drmOpenByName( ), why does i

Re: [resend] i915: high power consumption after suspend/resume

2009-10-05 Thread Jesse Barnes
2.6.31. I probably need to save/restore some more of the power saving state across suspend/resume... Can you file a bug for this at bugs.freedesktop.org so it doesn't get lost? Thanks, -- Jesse Barnes, Intel Open Source Technology Center --

Re: [PATCH] drm: Add async event synchronization for drmWaitVblank

2009-09-18 Thread Jesse Barnes
request.sequence, seq, pipe); When we queue the event we should probably return the queued sequence number to the client since in some cases they may be doing a relative wait and will need to know the ultimate sequence numbe

[PATCH] drm: fix drm_fb_helper handling of kernel crtcs

2009-09-17 Thread Jesse Barnes
console blank, both pipes would come back on, even though only one had been enabled before that. Since the other pipe had a bogus config, this led to some screen corruption. Signed-off-by: Jesse Barnes diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 8ee

Re: [PATCH] drm/i915: intel_display.c handle latency variable efficiently

2009-09-17 Thread Jesse Barnes
drivers/gpu/drm/i915/intel_display.c:1918: warning: ‘latency’ may be > used uninitialized in this function > > Signed-off-by: Jaswinder Singh Rajput > --- > drivers/gpu/drm/i915/intel_display.c | 13 ++--- > 1 files changed, 6 insertions(+), 7 deletions(-) Applied to dr

Re: [PATCH] PCI/VGA: fix header commentary

2009-09-17 Thread Jesse Barnes
2007 Paulo R. Zanoni I removed the referenced to the filename altogether and replaced it with a short comment. Thanks. -- Jesse Barnes, Intel Open Source Technology Center -- Come build with us! The BlackBerry® Developer Conf

Re: [PATCH] drm/kms: Force full modeset if depth/bpp changes.

2009-09-15 Thread Jesse Barnes
r bug on the intel side; turned out our pipe base function wasn't masking out the depth bits, just or'ing them in, so the correct setting wouldn't take effect if the depth changed in some cases. Not that

Re: [PATCH] drm: Add async event synchronization for drmWaitVblank

2009-09-12 Thread Jesse Barnes
On Sat, 12 Sep 2009 16:02:10 +0200 Thomas Hellstrom wrote: > Jesse Barnes wrote: > > On Fri, 11 Sep 2009 14:33:34 -0400 > > "Kristian Høgsberg" wrote: > > > > > >> This patch adds a new flag to the drmWaitVblank ioctl, which asks > >>

Re: [PATCH] drm: Add async event synchronization for drmWaitVblank

2009-09-11 Thread Jesse Barnes
struct; the rest was userland and driver specific stuff (though I'll have to go through the discussion to be sure). Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center -- Let Crystal Repor

Re: [PATCH] dri2proto: protocol requests for OML_sync_control and SGI_video_sync

2009-09-08 Thread Jesse Barnes
On Tue, 08 Sep 2009 10:37:38 +0200 Michel Dänzer wrote: > On Sun, 2009-09-06 at 09:46 -0700, Jesse Barnes wrote: > > On Sun, 06 Sep 2009 12:23:12 +0200 > > Michel Dänzer wrote: > > > > > On Fri, 2009-09-04 at 12:17 -0700, Jesse Barnes wrote: > > > >

Re: [PATCH] dri2proto: protocol requests for OML_sync_control and SGI_video_sync

2009-09-06 Thread Jesse Barnes
On Sun, 06 Sep 2009 12:23:12 +0200 Michel Dänzer wrote: > On Fri, 2009-09-04 at 12:17 -0700, Jesse Barnes wrote: > > I've been working on coding up the server and client side of > > SGI_video_sync, OML_sync_control and SGI_swap_control. I came up > > with this set of

Re: [PATCH] dri2proto: protocol requests for OML_sync_control and SGI_video_sync

2009-09-04 Thread Jesse Barnes
On Fri, 4 Sep 2009 12:17:20 -0700 Jesse Barnes wrote: > I've been working on coding up the server and client side of > SGI_video_sync, OML_sync_control and SGI_swap_control. I came up with > this set of new protocol (against the dri2-swapbuffers branch) to > support the new

Re: [PATCH] dri2proto: protocol requests for OML_sync_control and SGI_video_sync

2009-09-04 Thread Jesse Barnes
gt; glXSwapBuffersMscOML. Right? Right, it won't block immediately; and in a good implementation shouldn't block until the latest possible moment, if at all. I'll fix up the text (I should have said "limit the framerate" or something) -- Jesse Barnes, Intel Open Sourc

Re: [PATCH] dri2proto: protocol requests for OML_sync_control and SGI_video_sync

2009-09-04 Thread Jesse Barnes
aitMSC request, a client > > I'm splitting a very fine hair, but these are GLX extensions. Oh heh, true. Sorry if I offended any GL purists :) -- Jesse Barnes, Intel Open Source Technology Center -- Let C

Re: [PATCH] dri2proto: protocol requests for OML_sync_control and SGI_video_sync

2009-09-04 Thread Jesse Barnes
On Fri, 4 Sep 2009 13:25:43 -0700 Ian Romanick wrote: > On Fri, Sep 04, 2009 at 12:17:20PM -0700, Jesse Barnes wrote: > > I've been working on coding up the server and client side of > > SGI_video_sync, OML_sync_control and SGI_swap_control. I came up > > with this se

[PATCH] dri2proto: protocol requests for OML_sync_control and SGI_video_sync

2009-09-04 Thread Jesse Barnes
cond issue mentioned above, so needs to be server side). Comments? If these look ok I'll push them into the dri2-swapbuffers branch and fix up DRI2SwapBuffers with the rest of the OML fields. Thanks, -- Jesse Barnes, Intel Open Source Technology Center diff --git a/dri2proto.h b/dri2proto.

RFC: buffer swaps in a composited environment

2009-08-31 Thread Jesse Barnes
tor developers here. Thanks, -- Jesse Barnes, Intel Open Source Technology Center -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deploy

Re: [PATCH] drm/kms: move driver specific fb common code to helper functions (v2)

2009-08-28 Thread Jesse Barnes
* and turn them off, then turn off the CRTC. > + */ Cut & paste bugs on the comment (we're turning things on here). This one is actually mine I think, but don't feel obligated to preserve my bugs. :) Rest of it looks pret

Re: [PATCH] Add modesetting pageflip ioctl and corresponding drm event

2009-08-28 Thread Jesse Barnes
ap buffer count (the main thing I was concerned about here) w/o the event mechanism. -- Jesse Barnes, Intel Open Source Technology Center -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day

Re: [PATCH] Add modesetting pageflip ioctl and corresponding drm event

2009-08-28 Thread Jesse Barnes
as much as possible. Any kind of GPU drain or wait on event is a killer. -- Jesse Barnes, Intel Open Source Technology Center -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplif

Re: [Kernel 2.6.30] Only GPIOA is used as CRTDDC bus

2009-08-28 Thread Jesse Barnes
On Fri, 28 Aug 2009 11:36:22 +0200 "David Müller (ELSOFT AG)" wrote: > Jesse Barnes wrote: > > Wanna respin it with that change (just remove the IS_85X change and > > add a return below the crtc_ddc_bus = -1 if the structure size > > doesn't match the block

Re: Linux 2.6.31-rc7

2009-08-26 Thread Jesse Barnes
heuristics. We've recently added some to catch non-existent LVDS displays, but currently don't have any for VGA. Using the current configuration as a guide is a reasonable addition... -- Jesse Barnes, Intel Open Source Technology Center

Re: [Kernel 2.6.30] Only GPIOA is used as CRTDDC bus

2009-08-25 Thread Jesse Barnes
can probably assume its correct unless the general definitions block has a size that doesn't match our structure size. Wanna respin it with that change (just remove the IS_85X change and add a return below the crtc_ddc_bus = -1 if the structure size doesn't match the block size). Thanks,

Re: Ping Re: [Kernel 2.6.30] Only GPIOA is used as CRTDDC bus

2009-08-25 Thread Jesse Barnes
On Mon, 03 Aug 2009 08:30:57 +0200 "David Müller (ELSOFT AG)" wrote: > Hello > > Any news regarding this issue? I don't see the patch anymore, but if the VBT pin info is correct we should probably be using it more broadly. -- Jesse Barnes, Intel Open

Re: [Bug 14060] New: oops: sysfs_remove_link and i915

2009-08-25 Thread Jesse Barnes
5&w=4 > > This entry is being used for tracking a regression from 2.6.30. > Please don't close it until the problem is fixed in the mainline. Fixed by this patch? -- Jesse Barnes, Intel Open Source Technology Center diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c ind

Re: [PATCH] vga: implements VGA arbitration on Linux

2009-08-24 Thread Jesse Barnes
On Sun, 16 Aug 2009 18:09:36 +0300 Tiago Vignatti wrote: > On Wed, Aug 12, 2009 at 06:02:14PM +0200, Jesse Barnes wrote: > > On Wed, 12 Aug 2009 10:35:16 +0300 > > "Vignatti Tiago (Nokia-D/Helsinki)" > > wrote: > > > Okay, I can handle this documentation

Re: [PATCH 1/1] GPU: vgaarb, use %p in pointers prints

2009-08-24 Thread Jesse Barnes
up. Thanks, -- Jesse Barnes, Intel Open Source Technology Center -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus o

Re: [PATCH] PCI/vgaarb: cleanup some warnings + cleanup some comments.

2009-08-24 Thread Jesse Barnes
gt; include/linux/vgaarb.h | 49 > + 2 files changed, 32 > insertions(+), 28 deletions(-) Applied to my linux-next branch, thanks. -- Jesse Barnes, Intel Open Source Technology Center -

Re: Problem: Wait for VSync on pipe A and Wake up on pipe B

2009-08-20 Thread Jesse Barnes
nf or elsewhere? With DRI2 we don't currently have a way to do this, but we're working on adding one (along with some other sync -- Jesse Barnes, Intel Open Source Technology Center -- Let Crystal Reports handl

Re: [PATCH] Add modesetting pageflip ioctl and corresponding drm event

2009-08-18 Thread Jesse Barnes
y lock confusion (struct_mutex vs mode_config). Or would you like something substantial changed with these bits before they land? -- Jesse Barnes, Intel Open Source Technology Center -- Let Crystal Reports handle the

Re: [PATCH] Add modesetting pageflip ioctl and corresponding drm event

2009-08-18 Thread Jesse Barnes
On Tue, 18 Aug 2009 09:17:23 -0700 Jesse Barnes wrote: > > >> Exactly what in the generic modesetting code is protected by the > > >> struct mutex here? > > >> > > > > > > I'm a little fuzzy on the details, this part of the patch wa

Re: [PATCH] Add modesetting pageflip ioctl and corresponding drm event

2009-08-18 Thread Jesse Barnes
knows what we > > (don't) > > +        * support > > +        */ > > +       if (flip_data->flags & (~DRM_MODE_PAGE_FLIP_FLAGS_MASK)) { > > +               DRM_DEBUG("bad page flip flags\n"); > > +               return

Re: [PATCH] Add modesetting pageflip ioctl and corresponding drm event

2009-08-18 Thread Jesse Barnes
he drm fd to > >>> their main loop and handle other tasks while waiting for the flip > >>> to happen. The event includes the time of the flip, the frame > >>> counter and a 64 bit opaque token provided by user space in the > >>> ioctl. > >&

Re: [PATCH] Add modesetting pageflip ioctl and corresponding drm event

2009-08-18 Thread Jesse Barnes
On Tue, 18 Aug 2009 09:32:50 +0200 Thomas Hellström wrote: > Jesse Barnes wrote: > > On Mon, 17 Aug 2009 22:22:34 +0200 > > Thomas Hellström wrote: > > > > > >> Kristian Høgsberg wrote: > >> > >>> This patch adds a vblank syn

Re: [PATCH] Add modesetting pageflip ioctl and corresponding drm event

2009-08-17 Thread Jesse Barnes
token provided by user space in the ioctl. > > > > Based on work and suggestions from > > Jesse Barnes , > > Jakob Bornecrantz , > > Chris Wilson > > > > Signed-off-by: Kristian Høgsberg > > Signed-off-by: Jesse Barnes > > --- >

Re: [PATCH] drm: Fix sysfs device confusion.

2009-08-17 Thread Jesse Barnes
ks are aware of those. There is no per device-type suspend / > resume. Only new-style PM. > > Signed-off-by: Thomas Hellstrom Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center -- Le

Re: [PATCH] drm: do not ignore detailed timings of EDID < 1.3

2009-08-14 Thread Jesse Barnes
{ > newmode = drm_mode_detailed(dev, edid, > timing, quirks); Yeah I've sent this before too, but I think it got missed. Dave can you make sure something like this gets applied (if it hasn't been already, I didn't check current sources)? Thanks, -- Je

Re: [PATCH 1/2] drm: Fix sysfs device confusion.

2009-08-14 Thread Jesse Barnes
goes here. > + */ > + > +}; > + Unusual indentation here (I think the usual is struct foo bar { .baz = xyz, }; > + > /* Display the version of drm_core. This doesn't work right in > current design */ static ssize_t version_show(struct class *dev, char >

Re: drm sysfs questions

2009-08-12 Thread Jesse Barnes
On Wed, 12 Aug 2009 16:24:58 -0700 Greg KH wrote: > On Wed, Aug 12, 2009 at 08:59:17AM -0700, Jesse Barnes wrote: > > On Wed, 12 Aug 2009 08:21:24 +0200 > > Thomas Hellström wrote: > > > > > Jesse Barnes wrote: > > > > On Tue, 11 Aug 2009 20:2

Re: [PATCH] vga: implements VGA arbitration on Linux

2009-08-12 Thread Jesse Barnes
On Wed, 12 Aug 2009 00:24:37 -0700 "Vignatti Tiago (Nokia-D/Helsinki)" wrote: > On Wed, Aug 12, 2009 at 08:48:08AM +0200, Benjamin Herrenschmidt > wrote: > > On Tue, 2009-08-11 at 16:17 -0700, Jesse Barnes wrote: > > > > > Ok, applied this to my l

Re: [PATCH] vga: implements VGA arbitration on Linux

2009-08-12 Thread Jesse Barnes
On Wed, 12 Aug 2009 10:35:16 +0300 "Vignatti Tiago (Nokia-D/Helsinki)" wrote: > On Wed, Aug 12, 2009 at 01:21:03AM +0200, Jesse Barnes wrote: > > Oh yeah, and we should get the documentation merged too. I can > > handle that or you can send it to Randy. Tiago? >

Re: drm sysfs questions

2009-08-12 Thread Jesse Barnes
On Wed, 12 Aug 2009 08:21:24 +0200 Thomas Hellström wrote: > Jesse Barnes wrote: > > On Tue, 11 Aug 2009 20:29:39 +0200 > > Thomas Hellström wrote: > > > > > >> Jesse Barnes wrote: > >> > >>> On Tue,

Re: [PATCH] vga: implements VGA arbitration on Linux

2009-08-11 Thread Jesse Barnes
ti > Signed-off-by: Dave Airlie Ok, applied this to my linux-next branch, but I'd like to get Ben's s-o-b before pushing it to Linus. Ben? Thanks, -- Jesse Barnes, Intel Open Source Technology Center -- Le

Re: drm sysfs questions

2009-08-11 Thread Jesse Barnes
On Tue, 11 Aug 2009 20:29:39 +0200 Thomas Hellström wrote: > Jesse Barnes wrote: > > On Tue, 11 Aug 2009 11:23:09 +0200 > > Thomas Hellström wrote: > > > > > >> Hi! > >> > >> I'm wondering why we are using a struct device as a s

Re: [PATCH] vga: implements VGA arbitration on Linux

2009-08-11 Thread Jesse Barnes
On Tue, 11 Aug 2009 16:17:46 -0700 Jesse Barnes wrote: > On Tue, 11 Aug 2009 15:52:06 +1000 > Dave Airlie wrote: > > > From: Tiago Vignatti > > > > Background: > > Graphic devices are accessed through ranges in I/O or memory space. > > While most

Re: drm sysfs questions

2009-08-11 Thread Jesse Barnes
27;d like to do with a full device (e.g. runtime power management or some sort of per-connector suspend/resume). -- Jesse Barnes, Intel Open Source Technology Center -- Let Crystal Reports handle the reporting -

Re: [linux-pm] [PATH] i915: Read outside array bounds

2009-08-02 Thread Jesse Barnes
On Wed, 29 Jul 2009 23:06:14 +0200 "Rafael J. Wysocki" wrote: > On Tuesday 28 July 2009, Andrew Morton wrote: > > (cc jbarnes) > > > > On Sun, 26 Jul 2009 00:50:38 +0200 > > Roel Kluin wrote: > > > > > dev_priv->saveSWF1 is a 16 element array, but this reads up to > > > index 22 > > > > > > S

Re: KMS oops on 945G system

2009-07-21 Thread Jesse Barnes
> sr_entries; 1884} > > > which according to git it seems to be code from this commit: > > commit 7662c8bd6545c12ac7b2b39e4554c3ba34789c50 > Author: Shaohua Li > > drm/i915: add FIFO watermark support Yep, my bug. Should be fixed in Eric's drm-intel-ne

Re: [Bug #12765] i915 VT switch with AIGLX causes X lock up

2009-07-20 Thread Jesse Barnes
bd19219d930bbb9a5a22758c8f5bec > > References : > > http://marc.info/?l=linux-kernel&m=123523074304955&w=4 > > http://lkml.org/lkml/2009/4/27/317 Handled-By : Jesse Barnes > > Patch: > > http://patchwork.kernel.org/patch/20197/ > > St

Re: [Intel-gfx] FW: [PATCH] drm/i915: merge mode attributes of VBT and EDID together

2009-07-14 Thread Jesse Barnes
_pixel_timing *)dvo_timing); > > > > dev_priv->lfp_lvds_vbt_mode = panel_fixed_mode; > > > >@@ -152,7 +125,7 @@ parse_sdvo_panel_data(struct > >drm_i915_private *dev_priv, > >

Re: [Intel-gfx] [PATCH] Make xorg.conf NoAccel/DRI options work under KMS

2009-07-09 Thread Jesse Barnes
On Thu, 9 Jul 2009 11:37:30 -0400 Alex Deucher wrote: > On Thu, Jul 9, 2009 at 11:15 AM, Keith Packard > wrote: > > On Wed, 2009-07-08 at 20:28 +0100, Julien Cristau wrote: > > > >> DRI2 init can fail for various reasons, and it's easier to test if > >> you don't have to hack the driver.  No part

Re: [Intel-gfx] [PATCH] Make xorg.conf NoAccel/DRI options work under KMS

2009-07-08 Thread Jesse Barnes
On Wed, 8 Jul 2009 11:50:38 -0700 Keith Packard wrote: > KMS mode does not call I830AccelMethodInit as that does a ton of > random device initialization, but that means that the NoAccel and DRI > options were ignored. Split out the option parsing from > I830AccelMethodInit and have both KMS and

[PATCH] drm: less noise about bad vblank calls

2009-07-02 Thread Jesse Barnes
Userspace can (and does) flood the kernel log with vblank related error messages. Since we already return a reasonable errno, we can just make this into a DRM_DEBUG instead. Signed-off-by: Jesse Barnes diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c index b4a3dbc..f85aaf2

Re: [PATCH] drm: clarify scaling property names

2009-07-01 Thread Jesse Barnes
On Wed, 1 Jul 2009 12:22:17 -0400 Alex Deucher wrote: > On Wed, Jul 1, 2009 at 12:19 PM, Alex Deucher > wrote: > > On Wed, Jul 1, 2009 at 12:11 PM, Jesse > > Barnes wrote: > >> On Wed, 1 Jul 2009 11:23:50 +0200 > >> Maarten Maathuis wrote: > >> >

Re: [PATCH] drm: remove root requirement from DRM_IOCTL_SET_VERSION

2009-07-01 Thread Jesse Barnes
On Tue, 30 Jun 2009 23:43:19 -0700 Eric Anholt wrote: > On Mon, 2009-06-29 at 16:52 -0700, Jesse Barnes wrote: > > Just a DRM_MASTER flag is sufficient here, though maybe this call is > > totally deprecated anyway (xf86-video-intel still calls it though). > > > >

Re: [PATCH] drm: clarify scaling property names

2009-07-01 Thread Jesse Barnes
On Wed, 1 Jul 2009 12:22:17 -0400 Alex Deucher wrote: > On Wed, Jul 1, 2009 at 12:19 PM, Alex Deucher > wrote: > > On Wed, Jul 1, 2009 at 12:11 PM, Jesse > > Barnes wrote: > >> On Wed, 1 Jul 2009 11:23:50 +0200 > >> Maarten Maathuis wrote: > >> >

Re: [PATCH 1/1] i915: fix up a raw 64bit divide

2009-07-01 Thread Jesse Barnes
aw 64 bit divide in the i915 driver. Fix > up this raw divide. > > Signed-off-by: Andy Whitcroft I think building with newer GCCs will prevent this error, but the fix looks fine. Acked-by: Jesse Barnes -- Jesse Barnes

Re: [PATCH] drm: clarify scaling property names

2009-07-01 Thread Jesse Barnes
be, then yes, it's not ideal. There was some debate on the IRC channel about what it meant... If it's a monitor thing, how is it different from "none" or "center"? Is there some way of telling the monitor to scale or not? --

Re: [PATCH] drm: clarify scaling property names

2009-06-30 Thread Jesse Barnes
m according to our discussion on IRC, though I've left out potential new additions for a new scaling property with an integer (or two) for the scaling factor. None of the drivers implement that today, but if someone wants to do it, I think it could be done with the addition of a single new t

[PATCH] drm: clarify scaling property names

2009-06-30 Thread Jesse Barnes
actor. None of the drivers implement that today, but if someone wants to do it, I think it could be done with the addition of a single new type and a new property to describe the scaling factor in the X and Y directions. Signed-off-by: Jesse Barnes diff --git a/drivers/gpu/drm/drm_crtc.c b/

Re: [Kernel 2.6.30] Only GPIOA is used as CRTDDC bus

2009-06-30 Thread Jesse Barnes
ble attached CRT devices, > but i'm not sure if this really sufficient in all cases. > > Shouldn't the i915 driver use the information provided by the VBT > ("crt_ddc_gmbus_pin" field in the "bdb_general_definitions" block) to > figure out which I2C

[PATCH] drm: remove root requirement from DRM_IOCTL_SET_VERSION

2009-06-29 Thread Jesse Barnes
Just a DRM_MASTER flag is sufficient here, though maybe this call is totally deprecated anyway (xf86-video-intel still calls it though). Signed-off-by: Jesse Barnes diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index b39d7bf..d0a70bd 100644 --- a/drivers/gpu/drm/drm_drv.c

Re: [PATCH] drm/i915: Make driver less chatty

2009-06-29 Thread Jesse Barnes
...) DRM_DEBUG_KMS(prefix, fmt, args...) DRM_DEBUG_MODE(prefix, fmt, args...) but that should probably be done as a separate patch. Reviewed-by: Jesse Barnes -- Jesse

Re: [PATCH 1/2] drm: Fix EDID detailed timing misc flags decoding

2009-06-25 Thread Jesse Barnes
On Thu, 25 Jun 2009 17:57:47 -0700 Keith Packard wrote: > On Thu, 2009-06-25 at 16:50 -0700, Jesse Barnes wrote: > > > Is this mixing up the pixel block definition of sync vs the basic > > block definition (which has all the composite, green etc bits)? > > The VESA spec

Re: [PATCH 1/2] drm: Fix EDID detailed timing misc flags decoding

2009-06-25 Thread Jesse Barnes
T_HSYNC_POSITIVE | > DRM_EDID_PT_VSYNC_POSITIVE; > + pt->misc |= > (DRM_EDID_DETAILED_MISC_DIGITAL_HSYNC_POSITIVE | > + > DRM_EDID_DETAILED_MISC_DIGITAL_VSYNC_POSITIVE); } Looks ok, but according to wikipedia hsync+ is 1<<1 an

Re: [git pull] drm: previous pull req + 1.

2009-06-23 Thread Jesse Barnes
On Tue, 23 Jun 2009 08:39:44 -0700 Jesse Barnes wrote: > On Tue, 23 Jun 2009 09:48:00 +0200 > Michel Dänzer wrote: > > On a side note, I did precisely that about ten years ago on my > > Amiga. :) Granted, that was using two separate framebuffer devices > > (X glint drive

Re: [git pull] drm: previous pull req + 1.

2009-06-23 Thread Jesse Barnes
On Tue, 23 Jun 2009 12:26:15 +1000 Benjamin Herrenschmidt wrote: > On Mon, 2009-06-22 at 19:07 -0700, Jesse Barnes wrote: > > > Yeah I don't think we should try to change the mode, unless we > > really have to for whatever reason. fbcon should generally be able > >

Re: [git pull] drm: previous pull req + 1.

2009-06-23 Thread Jesse Barnes
dly a way around a second machine for > graphics driver development anyway. Oh I know, most operating systems have reasonable debugging facilities, and have had for a long time. Linux is the one lagging here. I agree it probably won't be that helpful for low level gfx debugging, but I

Re: [git pull] drm: previous pull req + 1.

2009-06-22 Thread Jesse Barnes
h buffers (something like this would also be handy for dual head debugging; one head running your desktop and the other a debug console printing all the messages). That's slightly more invasive surgery though... I should have a c

Re: [git pull] drm: previous pull req + 1.

2009-06-22 Thread Jesse Barnes
On Tue, 23 Jun 2009 11:58:44 +1000 Benjamin Herrenschmidt wrote: > On Mon, 2009-06-22 at 18:18 -0700, Jesse Barnes wrote: > > I think it could work, but ideally we'd keep the kernel fbcon object > > pinned, and keep printing into it even while some other gfx app is >

[PATCH] drm: don't filter detailed timing blocks on EDID version

2009-06-16 Thread Jesse Barnes
Not sure where this check came from, but it's wrong according to a bug report I can't find right now. We need to parse the detailed blocks no matter what, or lots of monitors won't be given a good set of default modes. Adam, can you check & ack this? Thanks, Jesse Signed-o

Re: the question about adding the default modes for LVDS output device in KMS mode

2009-06-15 Thread Jesse Barnes
m); no need for big changes there. I don't really care about static or dynamic modes for the standard stuff. We already have the static tables in place; there's not much reason to remove them. CVT/GTF is mainly needed to properly generate mode lists when we parse the EDID I th

Re: [Patch 0/2] [DRM] :add the CVT/GTF algorithm in kernel space

2009-06-10 Thread Jesse Barnes
On Wed, 10 Jun 2009 14:08:44 +0800 yakui_zhao wrote: > On Wed, 2009-06-10 at 06:45 +0800, Eric Anholt wrote: > > On Mon, 2009-05-11 at 10:52 +0800, yakui_zhao wrote: > > > Hi, All > > > > > > This is the patch set to add the CVT/GTF algorithm in > > > kernel space. They are based on the CVT/GT

Re: [RFC] [Patch] [DRM/I915] :Add a debufs I/F to dump the I915 register

2009-06-09 Thread Jesse Barnes
On Wed, 10 Jun 2009 09:06:47 +0800 yakui_zhao wrote: > On Wed, 2009-06-10 at 06:35 +0800, Jesse Barnes wrote: > > On Tue, 09 Jun 2009 15:16:53 -0700 > > Eric Anholt wrote: > > > > > On Mon, 2009-06-08 at 08:52 +0800, yakui_zhao wrote: > > > > On F

Re: [Intel-gfx] [PATCH] drm: remove mode from list and destroy it in order

2009-06-09 Thread Jesse Barnes
Seems ok to me, but I'd have to audit the mode list handling to be sure it's ok; there may be other bugs lurking... Dave? Jesse On Mon, 8 Jun 2009 20:18:09 +0800 "Ma, Ling" wrote: > Any comments ? > > Thanks > Ma Ling > > >-Original Message- > >From: intel-gfx-boun...@lists.freedesk

Re: [RFC] [Patch] [DRM/I915] :Add a debufs I/F to dump the I915 register

2009-06-09 Thread Jesse Barnes
On Tue, 09 Jun 2009 15:16:53 -0700 Eric Anholt wrote: > On Mon, 2009-06-08 at 08:52 +0800, yakui_zhao wrote: > > On Fri, 2009-06-05 at 19:11 +0800, Eric Anholt wrote: > > > On Fri, 2009-06-05 at 15:45 +0800, yakui_zhao wrote: > > > > It is useful to get the register snapshot. > > > > Add a debug

Re: [Intel-gfx] [RFC] [Patch 0/5] [DRM/I915] :Separate several DRM debug levels

2009-06-09 Thread Jesse Barnes
o me. I think Dave will have to make the call. Acked-by: Jesse Barnes -- Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution

<    1   2   3   4   5   6   7   8   >