Re: CVS Update: drm (branch: trunk)

2004-09-12 Thread Simon 'corecode'; Schubert
On 12.09.2004, at 21:24, Jon Smirl wrote: Log message: Fix error path in probe() to release resources if there is an error. It's not particularly about this very change, more about the general concept. I see you moved the pci_request_regions() to the OS specific part. This is very good, thanks

Re: New version of dyn-minor.patch

2004-09-11 Thread Simon 'corecode'; Schubert
On 12.09.2004, at 01:58, Jon Smirl wrote: We know how to remove the DRM() macros and inter_module stuff by switching to a drm_core library model. DaveA has already coded up a prototype. We aren't switching because people are objecting to the change. I'm not sure what the status of the objections is

Re: locate of drm.h

2004-09-11 Thread Simon 'corecode'; Schubert
On 11.09.2004, at 14:50, Alan Cox wrote: On Sad, 2004-09-11 at 00:25, Jon Smirl wrote: I need a major number for the VGA device. Use one of the experimental ones (see Documentation/devices.txt). As and if the driver becomes mainstream kernel material apply for one via LANANA. I don't know what the

Re: radeon-pre-2

2004-09-09 Thread Simon 'corecode'; Schubert
On 09.09.2004, at 19:37, Jon Smirl wrote: This is what I'm talking about with hotplug support and BSD not supporting hotplug. On Linux there are rules for dealing with all of the resources so that you don't get conflicts with new devices when they are plugged in. It's the region code that is causin

radeon-pre-2

2004-09-09 Thread Simon 'corecode'; Schubert
Hey, as I'm slowly ploughing through the last changes to get BSD support working again... the radeon-pre-2 patch added linux-only code to radeon_cp.h, somehow to establish permanent mappings for framebuffer and mmio, as it seems. this is not good. is there an OS independent way to do this? mayb

Re: initmap code

2004-09-09 Thread Simon 'corecode'; Schubert
On 09.09.2004, at 15:02, Alan Cox wrote: So, what happens in x86-64 where sizeof(unsigned long) is 4 bytes for IA-32 apps and 8 bytes for x86-64 apps? I guess since it's a parameter to the ioctl (rather than embedded in a structure) it should be okay, but I just want to be sure... Be cautious her

Re: initmap code

2004-09-08 Thread Simon 'corecode'; Schubert
On 09.09.2004, at 01:00, Jon Smirl wrote: drm.h is included by user space programs (the mesa library). Is caddr_t a both a user space and kernel type or is it kernel only? Any types have to be both user and kernel space. ok, sorry, pilot error. caddr_t is BSDism. so the proper way would be to eith

Re: initmap code

2004-09-08 Thread Simon 'corecode'; Schubert
On 09.09.2004, at 00:24, Jon Smirl wrote: and then, also concerning the declaration of drm_map_t: shouldn't be offset and size be of type caddr_t and size_t? (if this has been handled on list before I joined, please forgive me and tell me to RTFA) drm_map_t is compiled into X binaries so we can't

initmap code

2004-09-08 Thread Simon 'corecode'; Schubert
hey, please forgive my ignorance, as I'm not experienced with this matter. I'm in progress in porting the latest DRM changes to BSD. Jon's addmap-base-2 patch adds the function initmap(): int DRM(initmap)( drm_device_t *dev, unsigned int offset, unsigned int size, int type, int flags ) first of

Re: remove trailing white space from DRM directory

2004-09-07 Thread Simon 'corecode'; Schubert
On 07.09.2004, at 18:54, Jon Smirl wrote: I used sed: sed -e 's/[ ]*$//' < $TMP > $1 to strip the trailing white space from all of the DRM files. Any objections to a check in? Kernel rules for patches are no trailing white space. while you're at doing whitespace commits: there is a bunch of st

Re: New proposed DRM interface design

2004-09-04 Thread Simon &#x27;corecode'; Schubert
On 04.09.2004, at 08:04, Jon Smirl wrote: So what do we do about FreeBSD? For example I need to bring in the I2C and mode setting code from the GPL fbdev radeon driver into the DRM one. I don't want to rewrite a 1,000 lines of working driver code. How many DRM users are there on FreeBSD? I've only

Re: First DRI uber-benchmark

2004-08-22 Thread Simon &#x27;corecode'; Schubert
On 22.08.2004, at 08:16, John Lightsey wrote: glxgears - let it run for 1 minute then marked down the highest score how reproducable and meaningful is a highest score? I don't know, but I got a feeling that using a mean or a median might be of better reproducability and also might better reflect