[PATCH 3/5]: drm: radeon: Fix ring_rptr accesses.

2009-02-12 Thread David Miller
The memory behind ring_rptr can either be in ioremapped memory or a vmalloc() normal kernel memory buffer. However, the code unconditionally uses DRM_{READ,WRITE}32() (and thus readl() and writel()) to access it. Basically, if RADEON_IS_AGP then it's ioremap()'d memory else it's vmalloc'd

Re: [PATCH 3/5]: drm: radeon: Fix ring_rptr accesses.

2009-02-12 Thread Benjamin Herrenschmidt
On Thu, 2009-02-12 at 02:15 -0800, David Miller wrote: The memory behind ring_rptr can either be in ioremapped memory or a vmalloc() normal kernel memory buffer. However, the code unconditionally uses DRM_{READ,WRITE}32() (and thus readl() and writel()) to access it. Basically, if

Re: [PATCH 3/5]: drm: radeon: Fix ring_rptr accesses.

2009-02-12 Thread Benjamin Herrenschmidt
On Thu, 2009-02-12 at 21:37 +1100, Benjamin Herrenschmidt wrote: Similar comment about potential swapper setting when accessing the RPTR via the framebuffer. David (Airlied), what's the current status with that stuff ? I know you work on cleaning that shit up in kms, right now, we'll hit the