Re: [PATCH 4/6] libdrm: Request for _XOPEN_SOURCE to get full posix headers including extensions (XSH: mknod)

2009-07-06 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Ian Romanick wrote: > On Mon, Jul 06, 2009 at 01:14:14PM -0700, Alan Coopersmith wrote: >> Julien Cristau wrote: >>> On Mon, Jul 6, 2009 at 09:46:40 -0700, Ian Romanick wrote: >>> Here's an alterate patch the puts _XOPEN_SOURCE and _GNU_SOURCE in

Re: [PATCH 4/6] libdrm: Request for _XOPEN_SOURCE to get full posix headers including extensions (XSH: mknod)

2009-07-06 Thread Ian Romanick
On Mon, Jul 06, 2009 at 01:14:14PM -0700, Alan Coopersmith wrote: > Julien Cristau wrote: > > On Mon, Jul 6, 2009 at 09:46:40 -0700, Ian Romanick wrote: > > > >> Here's an alterate patch the puts _XOPEN_SOURCE and _GNU_SOURCE in config.h > >> via configure.ac. Comments? > >> > > maybe use AC_USE

Re: [PATCH 4/6] libdrm: Request for _XOPEN_SOURCE to get full posix headers including extensions (XSH: mknod)

2009-07-06 Thread Alan Coopersmith
Julien Cristau wrote: > On Mon, Jul 6, 2009 at 09:46:40 -0700, Ian Romanick wrote: > >> Here's an alterate patch the puts _XOPEN_SOURCE and _GNU_SOURCE in config.h >> via configure.ac. Comments? >> > maybe use AC_USE_SYSTEM_EXTENSIONS instead? Yes please - on some systems (Solaris for instance)

Re: [PATCH 4/6] libdrm: Request for _XOPEN_SOURCE to get full posix headers including extensions (XSH: mknod)

2009-07-06 Thread Pauli Nieminen
Configure setting it sounds good to me. _GNU_SOURCE implies XOPEN_SOURCE set to 600 (That should include everything from the latest standard if I'm not mistaken) I did set 500 because it was enough for XSH api. On Mon, Jul 6, 2009 at 7:59 PM, Julien Cristau wrote: > On Mon, Jul  6, 2009 at 09:46

Re: [PATCH 4/6] libdrm: Request for _XOPEN_SOURCE to get full posix headers including extensions (XSH: mknod)

2009-07-06 Thread Julien Cristau
On Mon, Jul 6, 2009 at 09:46:40 -0700, Ian Romanick wrote: > Here's an alterate patch the puts _XOPEN_SOURCE and _GNU_SOURCE in config.h > via configure.ac. Comments? > maybe use AC_USE_SYSTEM_EXTENSIONS instead? Cheers, Julien -

Re: [PATCH 4/6] libdrm: Request for _XOPEN_SOURCE to get full posix headers including extensions (XSH: mknod)

2009-07-06 Thread Ian Romanick
On Sat, Jul 04, 2009 at 02:18:52AM +0300, Pauli Nieminen wrote: > --- > libdrm/xf86drm.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/libdrm/xf86drm.c b/libdrm/xf86drm.c > index 1e6eb7a..7b05386 100644 > --- a/libdrm/xf86drm.c > +++ b/libdrm/xf86drm.c > @@ -34,6 +

[PATCH 4/6] libdrm: Request for _XOPEN_SOURCE to get full posix headers including extensions (XSH: mknod)

2009-07-03 Thread Pauli Nieminen
--- libdrm/xf86drm.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/libdrm/xf86drm.c b/libdrm/xf86drm.c index 1e6eb7a..7b05386 100644 --- a/libdrm/xf86drm.c +++ b/libdrm/xf86drm.c @@ -34,6 +34,7 @@ #ifdef HAVE_CONFIG_H # include #endif +#define _XOPEN_SOURCE 500 #inc