Re: PATCH: unichrome: Command buffer over PCI ioctl.

2004-09-02 Thread Thomas Hellström
Alan Cox wrote: On Iau, 2004-09-02 at 15:04, Thomas HellstrÃm wrote: Could this be acceptable security-wise? I'd add an upper limit to the kmalloc buffer size of say 32K (realistically thats as big as will be reliable anyway). OK, then we might perhaps skip the kmalloc

Re: PATCH: unichrome: Command buffer over PCI ioctl.

2004-09-02 Thread Alan Cox
On Iau, 2004-09-02 at 15:04, Thomas HellstrÃm wrote: > Could this be acceptable security-wise? I'd add an upper limit to the kmalloc buffer size of say 32K (realistically thats as big as will be reliable anyway). Otherwise looks ok. It does do the offset maths twice once without need and loads val

PATCH: unichrome: Command buffer over PCI ioctl.

2004-09-02 Thread Thomas Hellström
Hi! In order to be able for dri clients to write to certain registers when direct write-access to the MMIO area of the unichrome is shut down, I've added an IOCTL to Erdi's dma interface. It has a very simple "parser" that denies access to register areas that might be dangerous. The 2d blitter ca