On Tue, Feb 18, 2003 at 09:58:41PM -0500, Leif Delgass wrote:
> On Wed, 19 Feb 2003, [iso-8859-15] José Fonseca wrote:
> > It's now official: I'm coding on this. I'm adding the _ioctl suffix to
> > most IOCTLs (e.g., agp_alloc -> agp_alloc_ioctl) to leave to the
> > agp_alloc for internal DRM usage
On Wed, 19 Feb 2003, [iso-8859-15] José Fonseca wrote:
> On Tue, Feb 18, 2003 at 06:30:40PM -0500, Leif Delgass wrote:
> > I also made some other changes to the copy/verify:
> >
> > I added a check to the ioctl handler (mach64_dma_vertex) to check that the
> > vertex buffer has an integral numbe
On Tue, 18 Feb 2003, Linus Torvalds wrote:
>
> On 19 Feb 2003, Alan Cox wrote:
> >
> > copy_from_user sorts out the whole thing itself. In general
> > __copy_from_user and verify_area isnt a win, except if you do lots of
> > small copies to/from the same area, which is often a bad idea anyway.
>
On Tue, Feb 18, 2003 at 06:30:40PM -0500, Leif Delgass wrote:
> I also made some other changes to the copy/verify:
>
> I added a check to the ioctl handler (mach64_dma_vertex) to check that the
> vertex buffer has an integral number of dwords (in addition to the check
> against MACH64_BUFFER_SIZE
On Wed, 2003-02-19 at 01:48, José Fonseca wrote:
> I think our case is one of the exceptions: we are copying from the user
> and verifying the data at the same time (to avoid the user sending
> malicious commands to the card's DMA engine which could potentialy
> compromise the system integrity and
On Wed, Feb 19, 2003 at 01:50:49AM +, Alan Cox wrote:
>
> verify_area performs any checks needed for it to be safe to use the
> _copy forms of copy_*_user. What that does varies. The normal Linux
> approach is
>
> verify_area does access_ok which checks the address is a kernel view
> of a us
On 19 Feb 2003, Alan Cox wrote:
>
> copy_from_user sorts out the whole thing itself. In general __copy_from_user and
>verify_area
> isnt a win, except if you do lots of small copies to/from the same area, which is
>often
> a bad idea anyway.
It _can_ be a good idea, though.
In particular, it'
verify_area performs any checks needed for it to be safe to use the _copy forms of
copy_*_user.
What that does varies. The normal Linux approach is
verify_area does access_ok which checks the address is a kernel view of a user space
address. _copy* functions use the MMU to fault any illegal acce
On Tue, 18 Feb 2003, Leif Delgass wrote:
> > My memory is failing: this might still be usefull for Xv, isn't it?
>
> Maybe, maybe not. DMA for XVideo seems to be of questionable value,
> judging from the Rage 128 driver. Plus the fact that you have to
> wait/sync when switching between GUI mast
On Tue, 18 Feb 2003, [iso-8859-15] José Fonseca wrote:
> On Mon, Feb 17, 2003 at 08:15:02PM -0500, Leif Delgass wrote:
> > As I was doing some minor cleanups in the mach64 drm in the new branch, I
> > made some additional search and replace conversions of the mach64 DRM to
> > the os independence
On Mon, Feb 17, 2003 at 08:15:02PM -0500, Leif Delgass wrote:
> As I was doing some minor cleanups in the mach64 drm in the new branch, I
> made some additional search and replace conversions of the mach64 DRM to
> the os independence macros (I couldn't restrain myself ;) ). However, I
> want to sh
On Mon, 2003-02-17 at 17:15, Leif Delgass wrote:
> As I was doing some minor cleanups in the mach64 drm in the new branch, I
> made some additional search and replace conversions of the mach64 DRM to
> the os independence macros (I couldn't restrain myself ;) ). However, I
> want to share what I've
As I was doing some minor cleanups in the mach64 drm in the new branch, I
made some additional search and replace conversions of the mach64 DRM to
the os independence macros (I couldn't restrain myself ;) ). However, I
want to share what I've done so far and get some feedback, since there are
a cou
13 matches
Mail list logo
