Re: [PATCH] r300_scratch in r300_cmdbuf.c is broken

2007-03-01 Thread Panagiotis Papadakos
Diving more into the code, I also found weird how the scratch cmd packet is build in radeon_mm_use, in radeon_mm.c. I think it should be like in the attached patch. On Wednesday 28 February 2007 22:33, Panagiotis Papadakos wrote: Updated patch. Fix a check. On Tuesday 27 February 2007 23:49,

Re: [PATCH] r300_scratch in r300_cmdbuf.c is broken

2007-03-01 Thread Aapo Tahkola
On Thu, 1 Mar 2007 17:46:12 +0200 Panagiotis Papadakos [EMAIL PROTECTED] wrote: Diving more into the code, I also found weird how the scratch cmd packet is build in radeon_mm_use, in radeon_mm.c. I think it should be like in the attached patch. This patch will break 64 bit systems. It only

Re: [PATCH] r300_scratch in r300_cmdbuf.c is broken

2007-03-01 Thread Panagiotis Papadakos
On Thursday 01 March 2007 20:11, Aapo Tahkola wrote: On Thu, 1 Mar 2007 17:46:12 +0200 Panagiotis Papadakos [EMAIL PROTECTED] wrote: Diving more into the code, I also found weird how the scratch cmd packet is build in radeon_mm_use, in radeon_mm.c. I think it should be like in the

Re: [PATCH] r300_scratch in r300_cmdbuf.c is broken

2007-03-01 Thread Aapo Tahkola
On Thu, 1 Mar 2007 21:33:16 +0200 Panagiotis Papadakos [EMAIL PROTECTED] wrote: On Thursday 01 March 2007 20:11, Aapo Tahkola wrote: On Thu, 1 Mar 2007 17:46:12 +0200 Panagiotis Papadakos [EMAIL PROTECTED] wrote: Diving more into the code, I also found weird how the scratch cmd

Re: [PATCH] r300_scratch in r300_cmdbuf.c is broken

2007-02-28 Thread Panagiotis Papadakos
Updated patch. Fix a check. On Tuesday 27 February 2007 23:49, Panagiotis Papadakos wrote: Hope this patch is OK. With it I no more get infinite messages like: Feb 27 15:48:39 localhost kernel: [drm:r300_do_cp_cmdbuf] R300_CMD_SCRATCH Feb 27 15:48:39 localhost last message repeated 2 times