Re: [rfc] cache flush avoidance..

2007-10-11 Thread Thomas Hellström
Dave Airlie wrote: > >> >> Since Poulsbo is CMA, to avoid the SMP ipi issue, it should be possible >> to enclose the whole reloc fixup within a spinlock and use >> kmap_atomic which should be faster than kmap. >> Since within a spinlock, also preemption is disabled we can guarantee >> that a batch

Re: [rfc] cache flush avoidance..

2007-10-10 Thread Dave Airlie
> > Since Poulsbo is CMA, to avoid the SMP ipi issue, it should be possible > to enclose the whole reloc fixup within a spinlock and use > kmap_atomic which should be faster than kmap. > Since within a spinlock, also preemption is disabled we can guarantee > that a batchbuffer write followed by a

Re: [rfc] cache flush avoidance..

2007-10-09 Thread Thomas Hellström
Dave Airlie wrote: > >>> >> Dave, >> I like the idea of moving over to clflush, but I still think we >> shouldn't use TT drmBOs for batch buffers and buffers with similar use. >> (i915tex uses a sub-allocator for batch buffers, which avoids the cache >> flushes completely during normal rendering).

Re: [rfc] cache flush avoidance..

2007-10-09 Thread Dave Airlie
>> > Dave, > I like the idea of moving over to clflush, but I still think we > shouldn't use TT drmBOs for batch buffers and buffers with similar use. > (i915tex uses a sub-allocator for batch buffers, which avoids the cache > flushes completely during normal rendering). > I think something simila

Re: [rfc] cache flush avoidance..

2007-10-09 Thread Thomas Hellström
Dave Airlie wrote: > So in an attempt to avoid flushes on remap etc, I've attempt to avoid > doing anymore than 1 cache flush per batchbuffer.. > > http://people.freedesktop.org/~airlied/i915-hack-cacheflush.txt > > I allocate the batchbuffers CACHED and then flush the cache for those > pages po