Re: drm_stub.c

2005-05-27 Thread Lukas Hejtmanek
On Fri, May 27, 2005 at 02:06:16PM -0700, Ian Romanick wrote: > Please try the attached patch. Since I don't have any i9X5 hardware, I > haven't run-tested it, but it does compile. This implements a fix > similar to the one described by Alan in one of his posts. Note that the > i810 and i830

Re: drm_stub.c

2005-05-27 Thread Ian Romanick
Lukas Hejtmanek wrote: drm_stub.c version 1.52 contains check whether device is AGP. I have i915 card that is PCIE and it fails to initialize i915 module. If I comment out check for AGP then everything is OK. Please try the attached patch. Since I don't have any i9X5 hardware, I haven't run-

Re: drm_stub.c

2005-05-27 Thread Alan Hourihane
On Fri, May 27, 2005 at 02:53:12PM -0400, Michel Dänzer wrote: > On Fri, 2005-05-27 at 19:02 +0100, Alan Hourihane wrote: > > > > > > Why does the mga_drv.c set DRIVER_REQUIRE_AGP when it doesn't 'require' it > > > if there's a PCI Matrox card ? > > > > > > Couldn't we do > > > > > >if (

Re: drm_stub.c

2005-05-27 Thread Michel Dänzer
On Fri, 2005-05-27 at 19:02 +0100, Alan Hourihane wrote: > > > > Why does the mga_drv.c set DRIVER_REQUIRE_AGP when it doesn't 'require' it > > if there's a PCI Matrox card ? > > > > Couldn't we do > > > >if (drm_device_is_agp(dev) || DRIVER_REQUIRE_AGP) > >dev->agp = drm_agp_ini

Re: drm_stub.c

2005-05-27 Thread Alan Hourihane
On Fri, May 27, 2005 at 11:10:29AM -0700, Ian Romanick wrote: > Alan Hourihane wrote: > > >Why does the mga_drv.c set DRIVER_REQUIRE_AGP when it doesn't 'require' it > >if there's a PCI Matrox card ? > > It does still require it. The PCI cards are not (yet) supported. The > whole reason I adde

Re: drm_stub.c

2005-05-27 Thread Ian Romanick
Alan Hourihane wrote: Why does the mga_drv.c set DRIVER_REQUIRE_AGP when it doesn't 'require' it if there's a PCI Matrox card ? It does still require it. The PCI cards are not (yet) supported. The whole reason I added the call to drm_device_is_agp in that place and added the drm_driver::de

Re: drm_stub.c

2005-05-27 Thread Alan Hourihane
On Fri, May 27, 2005 at 06:58:08PM +0100, Alan Hourihane wrote: > On Fri, May 27, 2005 at 10:48:50AM -0700, Ian Romanick wrote: > > Lukas Hejtmanek wrote: > > > > >drm_stub.c version 1.52 contains check whether device is AGP. I have i915 > > >card > > >that is PCIE and it fails to initialize i915

Re: drm_stub.c

2005-05-27 Thread Alan Hourihane
On Fri, May 27, 2005 at 10:48:50AM -0700, Ian Romanick wrote: > Lukas Hejtmanek wrote: > > >drm_stub.c version 1.52 contains check whether device is AGP. I have i915 > >card > >that is PCIE and it fails to initialize i915 module. If I comment out > >check for > >AGP then everything is OK. > > T

Re: drm_stub.c

2005-05-27 Thread Ian Romanick
Lukas Hejtmanek wrote: drm_stub.c version 1.52 contains check whether device is AGP. I have i915 card that is PCIE and it fails to initialize i915 module. If I comment out check for AGP then everything is OK. That's interesting. I guess the problem is that the i915 driver has DRIVER_REQUIRE_