Re: [PATCH] drm: Allow platform devices to register as DRM devices

2010-03-16 Thread Paul Mundt
On Mon, Mar 15, 2010 at 10:56:02AM +1000, Dave Airlie wrote: On Tue, Mar 2, 2010 at 2:00 AM, Jordan Crouse jcro...@codeaurora.org wrote: Allow platform devices without PCI resources to be DRM devices. Signed-off-by: Jordan Crouse jcro...@codeaurora.org This patch has a bunch of

Re: [PATCH] drm: Allow platform devices to register as DRM devices

2010-03-15 Thread Jordan Crouse
Dave Airlie wrote: On Tue, Mar 2, 2010 at 2:00 AM, Jordan Crouse jcro...@codeaurora.org wrote: Allow platform devices without PCI resources to be DRM devices. Signed-off-by: Jordan Crouse jcro...@codeaurora.org This patch has a bunch of whitespace damage at least in my inbox and also in

Re: [PATCH] drm: Allow platform devices to register as DRM devices

2010-03-15 Thread Ville Syrjälä
On Mon, Mar 01, 2010 at 09:00:09AM -0700, Jordan Crouse wrote: Allow platform devices without PCI resources to be DRM devices. I really dislike the fact that drm has bus specific junk all over the generic code. Some ideas how to clean that up: Add 'struct device *dev' into drm_device so you

Re: [PATCH] drm: Allow platform devices to register as DRM devices

2010-03-15 Thread Dave Airlie
I guess technically we could also drop the AGP requirement, but since it worked on my box with AGP=n it seemed to me like a NOP. Its not a NOP, otherwise we'd remove it, AGP || AGP=n means if AGP is enabled DRM must be enabled similiarly, it stops AGP=m + DRM=y basically.  

Re: [PATCH] drm: Allow platform devices to register as DRM devices

2010-03-14 Thread Dave Airlie
On Tue, Mar 2, 2010 at 2:00 AM, Jordan Crouse jcro...@codeaurora.org wrote: Allow platform devices without PCI resources to be DRM devices. Signed-off-by: Jordan Crouse jcro...@codeaurora.org This patch has a bunch of whitespace damage at least in my inbox and also in patchwork Please also

[PATCH] drm: Allow platform devices to register as DRM devices

2010-03-01 Thread Jordan Crouse
Allow platform devices without PCI resources to be DRM devices. Signed-off-by: Jordan Crouse jcro...@codeaurora.org --- drivers/gpu/drm/Kconfig |4 - drivers/gpu/drm/Makefile|2 drivers/gpu/drm/drm_bufs.c | 27 ++- drivers/gpu/drm/drm_drv.c

drm: Allow platform devices to register as DRM devices

2010-03-01 Thread Jordan Crouse
Following is a patch to allow platform devices on platforms without PCI to register and operate as fully fledged DRM devices. I have been using this code for some time now and I'm convinced that the model works, but I'm posting this to get some constructive criticism on ways to improve the