Re: drm_edid: potential range checking issue?

2010-05-10 Thread Adam Jackson
On Fri, 2010-05-07 at 10:35 +0200, Dan Carpenter wrote: In include/drm/drm_edid.h this array has 5 elements not 6. struct detailed_non_pixel { u8 pad1; u8 type; /* ff=serial, fe=string, fd=monitor range, fc=monitor name fb=color point data,

Re: drm_edid: potential range checking issue?

2010-05-07 Thread Dan Carpenter
Ping. This off-by-one overflow is still there in -next. I'm not sure how to fix it because both the declaraion and the use in add_detailed_modes() look deliberate. regards, dan carpenter On Sun, Mar 28, 2010 at 02:25:58PM +0300, Dan Carpenter wrote: Hi list, :) Just going through some

drm_edid: potential range checking issue?

2010-03-28 Thread Dan Carpenter
Hi list, :) Just going through some Smatch warnings. drivers/gpu/drm/drm_edid.c +1032 add_detailed_modes() 'data-data.timings' 5 = 5 1027 /* Six modes per detailed section */ 1028 for (i = 0; i 6; i++) { 1029 struct std_timing