Re: [PATCH] drm/i915: Storage class should be before const qualifier

On Wed, 23 Dec 2009 14:14:34 +0100, Tobias Klauser tklau...@distanz.ch wrote: The C99 specification states in section 6.11.5: The placement of a storage-class specifier other than at the beginning of the declaration specifiers in a declaration is an obsolescent feature. Signed-off-by:

[Bug 13683] Internal Laptopdisplay blurrys to white screen after enabling modesetting on Radeon X700 Mobility

http://bugzilla.kernel.org/show_bug.cgi?id=13683 --- Comment #37 from Jan Kreuzer kontrolla...@gmx.de 2009-12-24 11:05:37 --- I am on daves radeon-testing tree. I finally had time to do an bisect, git bisect shows: 7923c615b811945a9d9f456c92a7a32c34167458 is the first bad commit commit

drivers/gpu/drm/radeon/radeon_connectors.c: add a NULL test before dereference

The encoder variable can be NULL in this function so I believe it should be checked before dereference. Coverity CID: 13253 Signed-off-by: Darren Jenkins darrenrjenk...@gmail.com diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c index

drivers/gpu/drm/radeon/radeon_fence.c: move a dereference below the NULL test

If a NULL value is possible, the dereference should only occur after the NULL test. Coverity CID: 13334 Signed-off-by: Darren Jenkins darrenrjenk...@gmail.com diff --git a/drivers/gpu/drm/radeon/radeon_fence.c b/drivers/gpu/drm/radeon/radeon_fence.c index cb4cd97..f4f5942 100644 ---

drivers/gpu/drm/radeon/radeon_cp.c: check for invalid radeon family

If there is an invalid radeon family the fw_name is NULL and causes an NULL pointer dereference. This just adds a check for something unexpected. Coverity CID: 13252 Signed-off-by: Darren Jenkins darrenrjenk...@gmail.com diff --git a/drivers/gpu/drm/radeon/radeon_cp.c

drivers/gpu/drm/radeon: fix a couple of array index errors

There are a couple of array overruns, and some associated confusion in the code. This is just a wild guess at what the code should actually look like. Coverity CID: 13305 13306 Signed-off-by: Darren Jenkins darrenrjenk...@gmail.com diff --git a/drivers/gpu/drm/radeon/radeon_legacy_tv.c

drivers/gpu/drm/radeon/radeon_device.c: move a dereference below a NULL test

If a NULL value is possible, the dereference should only occur after the NULL test. Coverity CID: 13335 Signed-off-by: Darren Jenkins darrenrjenk...@gmail.com diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c index 02bcdb1..c0104b0 100644 ---

drivers/gpu/drm/radeon: move a dereference below a NULL test

If a NULL value is possible, the dereference should only occur after the NULL test. Signed-off-by: Darren Jenkins darrenrjenk...@gmail.com diff --git a/drivers/gpu/drm/radeon/radeon_irq.c b/drivers/gpu/drm/radeon/radeon_irq.c index b79ecc4..2f349a3 100644 --- a/drivers/gpu/drm/radeon/radeon_irq.c

drivers/gpu/drm/radeon/r100.c: check for invalid family

If there is an invalid family the fw_name is NULL and causes an NULL pointer dereference. This just adds a check for something unexpected. Coverity CID: 13251 Signed-off-by: Darren Jenkins darrenrjenk...@gmail.com diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/radeon/r100.c index

drivers/gpu/drm/radeon/radeon_cp.c: fix resource leak on error

If drm_addmap() fails master_priv is leaked. Coverity CID: 13195 Signed-off-by: Darren Jenkins darrenrjenk...@gmail.com diff --git a/drivers/gpu/drm/radeon/radeon_cp.c b/drivers/gpu/drm/radeon/radeon_cp.c index 0b2f9c2..06123ba 100644 --- a/drivers/gpu/drm/radeon/radeon_cp.c +++

[Bug 25776] [regression] crash on loading radeon module on 2.6.33-rc1 vanilla

http://bugs.freedesktop.org/show_bug.cgi?id=25776 --- Comment #2 from Bartłomiej Zimoń uz...@o2.pl 2009-12-24 07:38:43 PST --- (In reply to comment #0) radeon loaded with modeset=1 crash with some data notated (could be usefull): BUG: unable to handle kernel NULL pointer dereference ar

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (V9)

Il Tue, Dec 22, 2009 at 11:06:16PM +0100, Rafał Miłecki ha scritto: V2: reorganize functions, fix modesetting calls V3: rebase patch, use radeon's workqueue V4: enable on tested chipsets only, request VBLANK IRQs V5: enable PM on older hardware (IRQs, mode_fixup, dpms) V6: use separate dynpm

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (V9)

W dniu 24 grudnia 2009 17:32 użytkownik Luca Tettamanti kronos...@gmail.com napisał: Il Tue, Dec 22, 2009 at 11:06:16PM +0100, Rafał Miłecki ha scritto: V2: reorganize functions, fix modesetting calls V3: rebase patch, use radeon's workqueue V4: enable on tested chipsets only, request VBLANK

Re: radeon KMS causes GART Table Walk Errors (was: K8 ECC error with linux-2.6.32)

Am Freitag 18 Dezember 2009 15:44:35 schrieb Jerome Glisse: On Fri, Dec 18, 2009 at 02:47:00PM +0100, Johannes Hirte wrote: Am Mittwoch 16 Dezember 2009 20:31:48 schrieb Johannes Hirte: Am Mittwoch 16 Dezember 2009 19:41:48 schrieb Jerome Glisse: On Wed, Dec 16, 2009 at 03:58:30PM +0100,

Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (V9)

2009/12/24 Rafał Miłecki zaj...@gmail.com: W dniu 24 grudnia 2009 17:32 użytkownik Luca Tettamanti kronos...@gmail.com napisał: I think it would be safer to execute that code in the IH (or in a tasklet, which is guaranteed to run after the handler); the only problem I see is that

[Bug 25506] radeon kms causes 33 second boot delay on kernel v2.6.32

http://bugs.freedesktop.org/show_bug.cgi?id=25506 --- Comment #12 from Steven Noonan ste...@uplinklabs.net 2009-12-24 15:29:42 PST --- Any progress on a patch for this bug? ( Also, I forgot to mention previously that reverting the two commits Alex mentions in comment 5 does eliminate the