[Bug 20954] mesa/drm(git): kernel panic with radeon driver (Radeon 9500 Pro)
http://bugs.freedesktop.org/show_bug.cgi?id=20954 Kevin Locke k...@cornell.edu changed: What|Removed |Added CC||k...@cornell.edu Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #9 from Kevin Locke k...@cornell.edu 2009-09-05 09:32:01 PST --- Appologies for reopening this bug if it truly is fixed in the KMS branch. I have been unable to get KMS setup on my machine, but have tried my best to analyze the changes in linux-next to check if this is truly fixed but I can not see how it would be. Also note, I am not an advanced kernel or DRI hacker, so this analysis may be completely bogus. My analysis of the problem is as follows: During X shutdown, RADEONDRICloseScreen (radeon_dri.c:1915) in the X driver calls the radeon_cp_init (radeon_cp.c:1313) ioctl with RADEON_CLEANUP_CP. radeon_cp_init then calls radeon_do_cleanup_cp (radeon_cp.c:1221) which sets mmio to NULL when it memset's most of dev_priv to 0. Later at module unload time (or pci unplug time in the KMS branch) drm_unload (drm_drv.c:358) (drm_put_dev (drm_stub.c:490) in KMS) calls drm_vblank_cleanup (drm_irq.c:97) which calls vblank_disable_fn (drm_irq.c:74) which calls radeon_get_vblank_counter (radeon_irq.c:284) and causes an Oops trying to read from mmio, which is NULL. I'm not sure if the solution is to not zero mmio during cleanup or protect against it being NULL in get_vblank_count or not call get_vblank_count during vblank cleanup (presumably by saving the last vblank during driver cleanup). I don't know enough about the code to make that determination. As best I can tell, this sequence happens in both the current git master as well as the linux-next KMS branch, but perhaps I am overlooking something... my apologies if this really is properly fixed. Thanks for reconsidering it. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 20954] mesa/drm(git): kernel panic with radeon driver (Radeon 9500 Pro)
http://bugs.freedesktop.org/show_bug.cgi?id=20954 Rafael Antonio Porras Samaniego sp...@distrobit.net changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #8 from Rafael Antonio Porras Samaniego sp...@distrobit.net 2009-08-09 03:05:35 PST --- I've been using the KMS branch [1] for a while and the panic is gone. [1] http://airlied.livejournal.com/66958.html -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 20954] mesa/drm(git): kernel panic with radeon driver (Radeon 9500 Pro)
http://bugs.freedesktop.org/show_bug.cgi?id=20954 --- Comment #7 from Rafael Antonio Porras Samaniego sp...@distrobit.net 2009-05-13 05:49:17 PST --- (In reply to comment #6) Many more reports: https://bugs.gentoo.org/show_bug.cgi?id=264280 This still exists in latest kernel src and drm git. Rafael, are you going to submit for inclusion? How? I thought that filing a bug report was the way to fix this issue. Dug around in the source to try and confirm the fix, but I can't find the code that would ever make this mmio pointer be NULL. I wonder if we are operating on this structure after it has been freed? Or am I missing something? I reviewed the code and also I was unable to find the sentence that turns NULL the pointer. To be honest, I don't see my patch as a fix because it attacks the symptom and not the illness. I'll try again to find the point where dev_priv-mmio is nullified but I'm afraid that I won't get anything useful. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. -- The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your production scanning environment may not be a perfect world - but thanks to Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700 Series Scanner you'll get full speed at 300 dpi even with all image processing features enabled. http://p.sf.net/sfu/kodak-com -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 20954] mesa/drm(git): kernel panic with radeon driver (Radeon 9500 Pro)
http://bugs.freedesktop.org/show_bug.cgi?id=20954 Daniel Drake d...@gentoo.org changed: What|Removed |Added CC||d...@gentoo.org --- Comment #6 from Daniel Drake d...@gentoo.org 2009-05-11 15:52:12 PST --- Many more reports: https://bugs.gentoo.org/show_bug.cgi?id=264280 This still exists in latest kernel src and drm git. Rafael, are you going to submit for inclusion? Dug around in the source to try and confirm the fix, but I can't find the code that would ever make this mmio pointer be NULL. I wonder if we are operating on this structure after it has been freed? Or am I missing something? -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. -- The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your production scanning environment may not be a perfect world - but thanks to Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700 Series Scanner you'll get full speed at 300 dpi even with all image processing features enabled. http://p.sf.net/sfu/kodak-com -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 20954] mesa/drm(git): kernel panic with radeon driver (Radeon 9500 Pro)
http://bugs.freedesktop.org/show_bug.cgi?id=20954 --- Comment #5 from Rafael Antonio Porras Samaniego sp...@distrobit.net 2009-04-21 11:59:48 PST --- Created an attachment (id=25010) -- (http://bugs.freedesktop.org/attachment.cgi?id=25010) Proposed patch to avoid null pointer use. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. -- Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 20954] mesa/drm(git): kernel panic with radeon driver (Radeon 9500 Pro)
http://bugs.freedesktop.org/show_bug.cgi?id=20954 --- Comment #4 from Michel Dänzer mic...@daenzer.net 2009-04-15 09:44:59 PST --- (In reply to comment #3) if (dev_priv-mmio == NULL) return -EINVAL; Looks like a good solution. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. -- This SF.net email is sponsored by: High Quality Requirements in a Collaborative Environment. Download a free trial of Rational Requirements Composer Now! http://p.sf.net/sfu/www-ibm-com -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 20954] mesa/drm(git): kernel panic with radeon driver (Radeon 9500 Pro )
http://bugs.freedesktop.org/show_bug.cgi?id=20954 Rafael Antonio Porras Samaniego sp...@distrobit.net changed: What|Removed |Added Attachment #24374|0 |1 is obsolete|| --- Comment #3 from Rafael Antonio Porras Samaniego sp...@distrobit.net 2009-04-10 08:17:18 PST --- Created an attachment (id=24695) -- (http://bugs.freedesktop.org/attachment.cgi?id=24695) Kernel panic complete message Here is the complete panic message. I've used objdump with the radeon.ko module to locate the specific line that causes the error. It seems to be this: radeon_get_vblank_counter(radeon_irq.c:307) return RADEON_READ(RADEON_CRTC2_CRNT_FRAME); de10: 8b 80 e0 00 00 00 mov0xe0(%eax),%eax de16: 8b 40 10mov0x10(%eax),%eax de19: 05 14 02 00 00 add$0x214,%eax de1e: 8b 00 mov(%eax),%eax de20: 83 c4 0cadd$0xc,%esp de23: c3 ret The problem is 0xde16(radeon_get_vblank_counter+0x76) operating with eax = NULL as you can see in the photo. I guess that dev_priv-mmio is NULL and that triggers the oops. I've tested this hypothesis adding a check: if (dev_priv-mmio == NULL) return -EINVAL; This avoids the panic. Well, this is the information I've been able to gather but I'm not an expert so I'm sorry if I've erroneously brought more darkness than light :) -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. -- This SF.net email is sponsored by: High Quality Requirements in a Collaborative Environment. Download a free trial of Rational Requirements Composer Now! http://p.sf.net/sfu/www-ibm-com -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 20954] mesa/drm(git): kernel panic with radeon driver (Radeon 9500 Pro )
http://bugs.freedesktop.org/show_bug.cgi?id=20954 --- Comment #2 from Rafael Antonio Porras Samaniego sp...@distrobit.net 2009-04-01 11:36:22 PST --- (In reply to comment #1) I just moved the vblank_cleanup after lastclose, give that a try and see if it is resolved. No, the same kernel panic still appears. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. -- -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 20954] mesa/drm(git): kernel panic with radeon driver (Radeon 9500 Pro )
http://bugs.freedesktop.org/show_bug.cgi?id=20954 Michel Dänzer mic...@daenzer.net changed: What|Removed |Added Component|Drivers/DRI/Radeon |DRM/Radeon Product|Mesa|DRI Version|CVS |DRI CVS -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. -- -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 20954] mesa/drm(git): kernel panic with radeon driver (Radeon 9500 Pro )
http://bugs.freedesktop.org/show_bug.cgi?id=20954 --- Comment #1 from Robert Noland rnol...@2hip.net 2009-03-31 11:56:16 PST --- I just moved the vblank_cleanup after lastclose, give that a try and see if it is resolved. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. -- -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
