[Dri-devel] Re: Update direct-rendering to current DRI CVS tree.

2003-03-30 Thread Dave Jones
On Sun, Mar 30, 2003 at 06:34:37AM +, Linux Kernel wrote: This bit seems to be backing out a memleak fix.. (takedown doesn't kfree 'device' 'minor' that I can see.) diff -Nru a/drivers/char/drm/drm_drv.h b/drivers/char/drm/drm_drv.h --- a/drivers/char/drm/drm_drv.h Sat Mar 29

[Dri-devel] Re: Update direct-rendering to current DRI CVS tree.

2003-03-30 Thread Linus Torvalds
On Sun, 30 Mar 2003, Dave Jones wrote: This bit seems to be backing out a memleak fix.. Well, yes and no. I looked at the code, and decided that the memleak fix was hottibly bogus. Look at how the allocations are done inside the loop: they are INSIDE A LOOP. Look at what happens with the

[Dri-devel] Re: Update direct-rendering to current DRI CVS tree.

2003-03-30 Thread Nicholas Wourms
Dave Jones wrote: #if LINUX_VERSION_CODE = KERNEL_VERSION(2,4,2) #define down_write down #define up_write up #if can go, like it did in other parts of the patch. What will replace it? If you intend to keep the two projects in sync and easy to update, I'm afraid that it will call for

[Dri-devel] Re: Update direct-rendering to current DRI CVS tree.

2003-03-30 Thread Christoph Hellwig
On Sun, Mar 30, 2003 at 09:14:58AM -0500, Nicholas Wourms wrote: Dave Jones wrote: #if LINUX_VERSION_CODE = KERNEL_VERSION(2,4,2) #define down_write down #define up_write up #if can go, like it did in other parts of the patch. What will replace it? Nothing.