Re: [PATCH] DRM depends on ???

2005-05-30 Thread Geert Uytterhoeven
On Sun, 29 May 2005, Kyle Moffett wrote: On May 29, 2005, at 15:58:10, Geert Uytterhoeven wrote: What Kyle said is the correct answer... we either keep this lovely construct (I'll add a comment for 2.6.13) or we go back to the old intermodule or module_get stuff... DRM built-in with

Re: [PATCH] DRM depends on ???

2005-05-30 Thread Dave Airlie
OK. So we still need the dependency on PCI. at the moment yes but I'm think we will have to remove this as soon as we get the Sparc ffb stuff up and running again, the ffb driver doesn't do any PCI stuff, we have some code around but we haven't had any testing done on it and I'm sure its

Re: [PATCH] DRM depends on ???

2005-05-30 Thread Geert Uytterhoeven
On Mon, 30 May 2005, Dave Airlie wrote: OK. So we still need the dependency on PCI. at the moment yes but I'm think we will have to remove this as soon as we get the Sparc ffb stuff up and running again, the ffb driver doesn't do any PCI stuff, we have some code around but we haven't had

Re: [PATCH] DRM depends on ???

2005-05-30 Thread Dave Airlie
Why is that case invalid? I may have DRM=y so I get DRM on my PCI graphichs card. Then I might load an agp module in order to use agp on *some other* agp card. I have no problem with DRM=y,AGP=m being invalid for the common single-card setup, but there are multi-card setups too. Not that

Re: [PATCH] DRM depends on ???

2005-05-30 Thread Helge Hafting
Kyle Moffett wrote: On May 29, 2005, at 15:58:10, Geert Uytterhoeven wrote: What Kyle said is the correct answer... we either keep this lovely construct (I'll add a comment for 2.6.13) or we go back to the old intermodule or module_get stuff... DRM built-in with modular AGP is always

Re: [PATCH] DRM depends on ???

2005-05-29 Thread Dave Airlie
The whole dependancy seems like nonsense to me. I think depends on PCI is a lot more sensible. I think the original reasoning was something like this: If DRM is built-in, then AGP _must_ be built-in or not included at all, modular won't work. If DRM is modular or not

Re: [PATCH] DRM depends on ???

2005-05-29 Thread Christoph Hellwig
On Sun, May 29, 2005 at 12:25:10AM -0400, Kyle Moffett wrote: If DRM is built-in, then AGP _must_ be built-in or not included at all, modular won't work. If DRM is modular or not built, then AGP may be built- in, modular, or not built at all. The depends on AGP || AGP=n means that if

Re: [PATCH] DRM depends on ???

2005-05-29 Thread Kyle Moffett
On May 29, 2005, at 15:58:10, Geert Uytterhoeven wrote: What Kyle said is the correct answer... we either keep this lovely construct (I'll add a comment for 2.6.13) or we go back to the old intermodule or module_get stuff... DRM built-in with modular AGP is always wrong... or at least I'll

Re: [PATCH] DRM depends on ???

2005-05-28 Thread Dave Jones
On Sat, May 28, 2005 at 11:39:00PM +0200, Geert Uytterhoeven wrote: DRM depending on `AGP=n' is driving me crazy! How to make CONFIG_DRM not eligible for selection on platforms that do not have AGP? Since many of the core DRM files depend on PCI, add a dependency on PCI, to minimize

[PATCH] DRM depends on ???

2005-05-28 Thread Geert Uytterhoeven
DRM depending on `AGP=n' is driving me crazy! How to make CONFIG_DRM not eligible for selection on platforms that do not have AGP? Since many of the core DRM files depend on PCI, add a dependency on PCI, to minimize the damage. Signed-off-by: Geert Uytterhoeven [EMAIL PROTECTED] ---

Re: [PATCH] DRM depends on ???

2005-05-28 Thread Kyle Moffett
On May 28, 2005, at 17:50:05, Dave Jones wrote: On Sat, May 28, 2005 at 11:39:00PM +0200, Geert Uytterhoeven wrote: config DRM tristate Direct Rendering Manager (XFree86 4.1.0 and higher DRI support) -depends on AGP || AGP=n +depends on (AGP || AGP=n) PCI The whole