[PATCH] drm/i915: Clean up vblank data after lastclose and unload

2010-01-05 Thread Kristian Høgsberg
Otherwise we end up waking up a freed waitqueue.

Signed-off-by: Kristian Høgsberg k...@bitplanet.net
---

Resend.  This didn't get picked up earlier, so this time I'll try
sending to the right mailing list.

 drivers/gpu/drm/drm_stub.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c
index ad73e14..3735478 100644
--- a/drivers/gpu/drm/drm_stub.c
+++ b/drivers/gpu/drm/drm_stub.c
@@ -515,8 +515,6 @@ void drm_put_dev(struct drm_device *dev)
}
driver = dev-driver;
 
-   drm_vblank_cleanup(dev);
-
drm_lastclose(dev);
 
if (drm_core_has_MTRR(dev)  drm_core_has_AGP(dev) 
@@ -531,6 +529,8 @@ void drm_put_dev(struct drm_device *dev)
if (dev-driver-unload)
dev-driver-unload(dev);
 
+   drm_vblank_cleanup(dev);
+
if (drm_core_has_AGP(dev)  dev-agp) {
kfree(dev-agp);
dev-agp = NULL;
-- 
1.6.5.rc2


--
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: [PATCH] drm/i915: Clean up vblank data after lastclose and unload

2010-01-05 Thread Jesse Barnes
On Tue,  5 Jan 2010 12:33:46 -0500
Kristian Høgsberg k...@bitplanet.net wrote:

 Otherwise we end up waking up a freed waitqueue.
 
 Signed-off-by: Kristian Høgsberg k...@bitplanet.net
 ---
 
 Resend.  This didn't get picked up earlier, so this time I'll try
 sending to the right mailing list.
 
  drivers/gpu/drm/drm_stub.c |4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c
 index ad73e14..3735478 100644
 --- a/drivers/gpu/drm/drm_stub.c
 +++ b/drivers/gpu/drm/drm_stub.c
 @@ -515,8 +515,6 @@ void drm_put_dev(struct drm_device *dev)
   }
   driver = dev-driver;
  
 - drm_vblank_cleanup(dev);
 -
   drm_lastclose(dev);
  
   if (drm_core_has_MTRR(dev)  drm_core_has_AGP(dev) 
 @@ -531,6 +529,8 @@ void drm_put_dev(struct drm_device *dev)
   if (dev-driver-unload)
   dev-driver-unload(dev);
  
 + drm_vblank_cleanup(dev);
 +
   if (drm_core_has_AGP(dev)  dev-agp) {
   kfree(dev-agp);
   dev-agp = NULL;

What prevents a driver's vblank_disable hook from getting called at
cleanup time?  Do we zero dev-num_crtcs or set vblank_disable_allowed?
If so, this should be safe and you can add my

Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org

-- 
Jesse Barnes, Intel Open Source Technology Center

--
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel