Re: [PATCH] drm: Round size of mappings in drmAddMap ioctl

2009-05-17 Thread Benjamin Herrenschmidt
> So, in order to fix a problem with the SAREA you align the map size > for all added maps? Sounds bogus to me, especially since the range of > possible page sizes is potentially unbounded. Only the requested size from userspace, most drivers create the map from the kernel anyway. > IMO the prop

Re: [PATCH] drm: Round size of mappings in drmAddMap ioctl

2009-05-17 Thread Stephane Marchesin
On Mon, May 18, 2009 at 03:11, Benjamin Herrenschmidt wrote: > Currently, userspace fails to obtain the SAREA mapping on some platforms > because they pass SAREA_MAX to drmAddMap without aligning it to the page > size. This breaks for example on PowerPC with 64K pages. > > The way SAREA_MAX is def

[PATCH] drm: Round size of mappings in drmAddMap ioctl

2009-05-17 Thread Benjamin Herrenschmidt
Currently, userspace fails to obtain the SAREA mapping on some platforms because they pass SAREA_MAX to drmAddMap without aligning it to the page size. This breaks for example on PowerPC with 64K pages. The way SAREA_MAX is defined with a bunch of ifdef's and duplicated between libdrm and the X se