Re: [Patch] mach64 port to vblank rework

2007-11-01 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jesse Barnes wrote: > The other option is to calculate how many vblank interrupts have > occurred between off and on periods. You could do this by recording > the time when interrupts were disabled, figuring out how much time has > passed between

Re: [Patch] mach64 port to vblank rework

2007-11-01 Thread Jesse Barnes
On Thursday, November 01, 2007 12:06 Mathieu Bérard wrote: > Jesse Barnes a écrit : > >> Forgive my lack of global understanding of the whole issue but my > >> conclusion is that we just can't disable vbl interrupt on hardware > >> which lack vbl count in hardware, right ? > > > > That's one option

Re: [Patch] mach64 port to vblank rework

2007-11-01 Thread Mathieu Bérard
Jesse Barnes a écrit : >> Forgive my lack of global understanding of the whole issue but my >> conclusion is that we just can't disable vbl interrupt on hardware >> which lack vbl count in hardware, right ? >> > > That's one option, yes. > > The other option is to calculate how many vblank int

Re: [Patch] mach64 port to vblank rework

2007-11-01 Thread Jesse Barnes
On Thursday, November 01, 2007 11:24 Mathieu Bérard wrote: > Jesse Barnes a écrit : > > I think this bit might cause problems. Since it doesn't look like > > you're using a hardware provided vblank count register, you'll want > > to keep vblank interrupts on after the first enable call so that > >

Re: [Patch] mach64 port to vblank rework

2007-11-01 Thread Mathieu Bérard
Jesse Barnes a écrit : > I think this bit might cause problems. Since it doesn't look like > you're using a hardware provided vblank count register, you'll want to > keep vblank interrupts on after the first enable call so that it'll > keep getting incremented in mach64_driver_irq_handler(), ot

Re: [Patch] mach64 port to vblank rework

2007-10-31 Thread Jesse Barnes
On Wednesday, October 31, 2007 3:12 Mathieu Bérard wrote: > +void mach64_disable_vblank(struct drm_device * dev, int crtc) > +{ > +   drm_mach64_private_t *dev_priv = dev->dev_private; > u32 status = MACH64_READ(MACH64_CRTC_INT_CNTL); >   > -   DRM_DEBUG("before install CRTC_INT_CTN

[Patch] mach64 port to vblank rework

2007-10-31 Thread Mathieu Bérard
Hi, here is a patch that port the mach64 drm driver to vblank rework. It does not seems to cause any regression on my Rage Mobility P/M -- Mathieu Bérard diff --git a/linux-core/mach64_drv.c b/linux-core/mach64_drv.c index 9709934..16bc9ff 100644 --- a/linux-core/mach64_drv.c +++ b/linux-core/ma