Re: [linux-pm] [PATH] i915: Read outside array bounds

2009-08-02 Thread Jesse Barnes
On Wed, 29 Jul 2009 23:06:14 +0200 Rafael J. Wysocki r...@sisk.pl wrote: On Tuesday 28 July 2009, Andrew Morton wrote: (cc jbarnes) On Sun, 26 Jul 2009 00:50:38 +0200 Roel Kluin roel.kl...@gmail.com wrote: dev_priv-saveSWF1 is a 16 element array, but this reads up to index 22

Re: [linux-pm] [PATH] i915: Read outside array bounds

2009-07-29 Thread Rafael J. Wysocki
On Tuesday 28 July 2009, Andrew Morton wrote: (cc jbarnes) On Sun, 26 Jul 2009 00:50:38 +0200 Roel Kluin roel.kl...@gmail.com wrote: dev_priv-saveSWF1 is a 16 element array, but this reads up to index 22 Signed-off-by: Roel Kluin roel.kl...@gmail.com --- save_state does not do

Re: [linux-pm] [PATH] i915: Read outside array bounds

2009-07-28 Thread Andrew Morton
(cc jbarnes) On Sun, 26 Jul 2009 00:50:38 +0200 Roel Kluin roel.kl...@gmail.com wrote: dev_priv-saveSWF1 is a 16 element array, but this reads up to index 22 Signed-off-by: Roel Kluin roel.kl...@gmail.com --- save_state does not do this addition, can it be removed? please review. diff

Re: [linux-pm] [PATH] i915: Read outside array bounds

2009-07-28 Thread Ben Gamari
On Tue, Jul 28, 2009 at 02:50:03PM -0700, Andrew Morton wrote: (cc jbarnes) This looks rather correct and the original code looked rather wrong. Someone please tell me that this might fix one of our splendid number of i915 bugs :( Unfortunately, according to the docs we were just