Re: Proposal for a few minor internal API changes.

2007-12-15 Thread Keith Whitwell
Keith Packard wrote: I'm writing up some documentation for internal DRM interfaces and came across a couple of interface inconsistencies that seem like they should get fixed before they start getting used a lot more. If these look like good changes, I'll continue to search out other similar

Re: Proposal for a few minor internal API changes.

2007-12-15 Thread Brian Paul
Keith Whitwell wrote: Keith Packard wrote: I'm writing up some documentation for internal DRM interfaces and came across a couple of interface inconsistencies that seem like they should get fixed before they start getting used a lot more. If these look like good changes, I'll continue to

Re: Proposal for a few minor internal API changes.

2007-12-15 Thread Keith Packard
On Sat, 2007-12-15 at 16:31 +, Keith Whitwell wrote: These all look sensible. Thanks. It's a pity that the change above looks like it will allow users of the old argument order to continue to compile without error despite the change. It's a bit hard to know how to achieve that

Re: Proposal for a few minor internal API changes.

2007-12-15 Thread Keith Packard
On Sat, 2007-12-15 at 10:59 -0700, Brian Paul wrote: Could a temporary/dummy parameter be added for a while? Callers that weren't updated would get an error/warning about too few arguments. Then remove the dummy at some point in the future. We could change the use_old_fence_class into a

Re: Proposal for a few minor internal API changes.

2007-12-15 Thread Keith Whitwell
Keith Packard wrote: On Sat, 2007-12-15 at 10:59 -0700, Brian Paul wrote: Could a temporary/dummy parameter be added for a while? Callers that weren't updated would get an error/warning about too few arguments. Then remove the dummy at some point in the future. We could change the

Re: Proposal for a few minor internal API changes.

2007-12-15 Thread Keith Packard
On Sat, 2007-12-15 at 19:53 +, Keith Whitwell wrote: Ultimately it's not that big of a deal - if this change makes sense on it's own, then sure go ahead. Ok, I'll push to master then. Otherwise it's only Poulsbo that I can think of being out-of-tree, and we should be able to figure

Proposal for a few minor internal API changes.

2007-12-14 Thread Keith Packard
I'm writing up some documentation for internal DRM interfaces and came across a couple of interface inconsistencies that seem like they should get fixed before they start getting used a lot more. If these look like good changes, I'll continue to search out other similar issues. I'll just include