Re: [Intel-gfx] [PATCH v12 01/14] video/hdmi: Add Unpack only function for DRM infoframe

2020-05-14 Thread Mun, Gwan-gyeong
Hi Bartlomiej and Laurent Pinchart, can I have your ack for merging this via drm-intel along with the rest of the series, please? BR, G.G. On Thu, 2020-05-14 at 09:07 +0300, Gwan-gyeong Mun wrote: > It adds an unpack only function for DRM infoframe for dynamic range > and > mastering infoframe

Re: [PATCH 5/9] drm/udl: Don't call get/put_pages on imported dma-buf

2020-05-14 Thread Thomas Zimmermann
Hi, given the upcoming removal of this file, I don't know if you really want to merge this patch. If so, please see my comment on patch 6 and Acked-by: Thomas Zimmermann Am 11.05.20 um 11:35 schrieb Daniel Vetter: > There's no direct harm, because for the shmem helpers these are noops > on

Re: [PATCH 5/4] dt-bindings: display: bridge: thc63lvd1024: Document dual-output mode

2020-05-14 Thread Jacopo Mondi
Hi Laurent, On Thu, May 14, 2020 at 02:21:27AM +0300, Laurent Pinchart wrote: > The DT binding support both dual-input and dual-output mode, but only > dual-input is documented. Document dual-output mode. > > Suggested-by: Jacopo Mondi > Signed-off-by: Laurent Pinchart Thanks Acked-by: Jacopo

[PATCH v12 07/14] drm/i915: Program DP SDPs with computed configs

2020-05-14 Thread Gwan-gyeong Mun
In order to use computed config for DP SDPs (DP VSC SDP and DP HDR Metadata Infoframe SDP), it replaces intel_dp_vsc_enable() function and intel_dp_hdr_metadata_enable() function to intel_dp_set_infoframes() function. And it removes unused functions. Before: intel_dp_vsc_enable() and

[PATCH v12 05/14] drm/i915: Include DP HDR Metadata Infoframe SDP in the crtc state dump

2020-05-14 Thread Gwan-gyeong Mun
Dump out the DP HDR Metadata Infoframe SDP in the normal crtc state dump. HDMI Dynamic Range and Mastering (DRM) infoframe and DP HDR Metadata Infoframe SDP use the same member variable in infoframes of crtc state. Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar ---

[PATCH v12 09/14] drm/i915: Add state readout for DP VSC SDP

2020-05-14 Thread Gwan-gyeong Mun
Added state readout for DP VSC SDP and enabled state validation for DP VSC SDP. v2: Minor style fix v3: Replace a structure name to drm_dp_vsc_sdp from intel_dp_vsc_sdp v4: Use struct drm_device logging macros v10: Skip checking of VSC SDP when a crtc config has psr. Signed-off-by: Gwan-gyeong

Re: [PATCH 6/4] dt-bindings: display: renesas: lvds: RZ/G2E needs renesas,companion too

2020-05-14 Thread Geert Uytterhoeven
On Thu, May 14, 2020 at 1:39 AM Laurent Pinchart wrote: > From: Fabrizio Castro > > Document RZ/G2E support for property renesas,companion. > > Signed-off-by: Fabrizio Castro > Reviewed-by: Laurent Pinchart > Signed-off-by: Laurent Pinchart > ---

Re: [PATCH v2 00/10] drivers, provide a way to add sysfs groups easily

2020-05-14 Thread Greg Kroah-Hartman
On Wed, May 13, 2020 at 11:18:15PM +0100, Emil Velikov wrote: > Hi Greg, > > On Fri, 2 Aug 2019 at 11:46, Greg Kroah-Hartman > wrote: > > > > > I have now done this with patch 1/10. Here's the pull info if any > > subsystem maintainer wants to suck this into their tree to provide the > >

Re: [PATCH 6/9] drm/shmem-helpers: Don't call get/put_pages on imported dma-buf in vmap

2020-05-14 Thread Thomas Zimmermann
Hi Am 11.05.20 um 11:35 schrieb Daniel Vetter: > There's no direct harm, because for the shmem helpers these are noops > on imported buffers. The trouble is in the locks these take - I want > to change dma_buf_vmap locking, and so need to make sure that we only > ever take certain locks on one

Re: [PATCH v1.1 4/4] dt-bindings: display: bridge: renesas,lvds: Convert binding to YAML

2020-05-14 Thread Geert Uytterhoeven
Hi Laurent, On Thu, May 14, 2020 at 1:29 AM Laurent Pinchart wrote: > Convert the Renesas R-Car LVDS encoder text binding to YAML. > > Signed-off-by: Laurent Pinchart > Acked-by: Maxime Ripard > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.yaml >

Re: [PATCH 2/9] drm/gem: WARN if drm_gem_get_pages is called on a private obj

2020-05-14 Thread Thomas Zimmermann
Am 11.05.20 um 11:35 schrieb Daniel Vetter: > No real functional change, since this just converts an annoying Oops > into a more harmless WARNING backtrace. It's still a driver bug. > > Signed-off-by: Daniel Vetter Acked-by: Thomas Zimmermann > --- > drivers/gpu/drm/drm_gem.c | 8

Re: [PATCH 4/9] drm/virtio: Call the right shmem helpers

2020-05-14 Thread Thomas Zimmermann
Am 11.05.20 um 11:35 schrieb Daniel Vetter: > drm_gem_shmem_get_sg_table is meant to implement > obj->funcs->get_sg_table, for prime exporting. The one we want is > drm_gem_shmem_get_pages_sgt, which also handles imported dma-buf, not > just native objects. > > v2: Rebase, this stuff moved

Re: [PATCH] drm: avoid spurious EBUSY due to nonblocking atomic modesets

2020-05-14 Thread Daniel Stone
On Wed, 8 Apr 2020 at 17:24, Daniel Vetter wrote: > Resending because last attempt failed CI and meanwhile the results are > lost :-/ Did anything happen with this? Cheers, Daniel ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: [PATCH] drm: avoid spurious EBUSY due to nonblocking atomic modesets

2020-05-14 Thread Daniel Vetter
On Thu, May 14, 2020 at 8:42 AM Daniel Stone wrote: > > On Wed, 8 Apr 2020 at 17:24, Daniel Vetter wrote: > > Resending because last attempt failed CI and meanwhile the results are > > lost :-/ > > Did anything happen with this? Nope. There's an igt now that fails with this, and I'm not sure

Re: [PATCH] drm: avoid spurious EBUSY due to nonblocking atomic modesets

2020-05-14 Thread Daniel Stone
On Thu, 14 May 2020 at 08:25, Daniel Vetter wrote: > On Thu, May 14, 2020 at 9:18 AM Daniel Stone wrote: > > On Thu, 14 May 2020 at 08:08, Daniel Vetter wrote: > > I'd be very much in favour of putting the blocking down in the kernel > > at least until the kernel can give us a clear indication

Re: [PATCH v3 5/5] drm/panel: Add ilitek ili9341 driver

2020-05-14 Thread Linus Walleij
Hi Dillon, thanks for your patch! Overall this looks like a good start. On Tue, May 12, 2020 at 9:04 AM wrote: > #define ILI9341_SLEEP_OUT0x11 /* Sleep out register */ This is not a register, also just use MIPI_DCS_EXIT_SLEEP_MODE in the code. > +#define ILI9341_DFC

Re: [PATCH v2] drm: plane: Verify that no or all planes have a zpos property

2020-05-14 Thread Simon Ser
On Thursday, May 14, 2020 12:58 AM, Laurent Pinchart wrote: > The zpos property is used by userspace to sort the order of planes. > While the property is not mandatory for drivers to implement, mixing > planes with and without zpos confuses userspace, and shall not be > allowed. Clarify this in

Re: [PATCH 3/3] drm/bridge: Introduce LT9611 DSI to HDMI bridge

2020-05-14 Thread Vinod Koul
Hello Emil, Thanks for the comments. On 13-05-20, 20:20, Emil Velikov wrote: > Hi Vinod, > > Few high-level comments: > - handful of functions always return 0 and the return value is never > checked - switch to return void Sure makes sense, will do > - annotate all (nearly) arrays as static

[PULL] drm-misc-next

2020-05-14 Thread Thomas Zimmermann
Hi Dave and Daniel, this is the forth pull request for drm-misc-next for what will become v5.8. It's fairly small number of patches without major changes. There's one fix to the UAPI headers, but it only affects comments. Best regards Thomsa drm-misc-next-2020-05-14: drm-misc-next for 5.8:

Re: [PATCH] drm: avoid spurious EBUSY due to nonblocking atomic modesets

2020-05-14 Thread Daniel Stone
Hi, On Thu, 14 May 2020 at 08:08, Daniel Vetter wrote: > > Did anything happen with this? > > Nope. There's an igt now that fails with this, and I'm not sure > whether changing the igt is the right idea or not. > > I'm kinda now thinking about changing this to instead document under > which

[PATCH v12 10/14] drm/i915: Fix enabled infoframe states of lspcon

2020-05-14 Thread Gwan-gyeong Mun
Compared to implementation of DP and HDMI's encoder->infoframes_enabled, the lspcon's implementation returns its active state. (we expect enabled infoframe states of HW.) It leads to pipe state mismatch error when ddi_get_config is called. Because the current implementation of lspcon is not ready

[PATCH v12 13/14] drm/i915/dp: Add compute routine for DP PSR VSC SDP

2020-05-14 Thread Gwan-gyeong Mun
In order to use a common VSC SDP Colorimetry calculating code on PSR, it adds a compute routine for PSR VSC SDP. As PSR routine can not use infoframes.vsc of crtc state, it also adds new writing of DP SDPs (Secondary Data Packet) for PSR. PSR routine has its own scenario and timings of writing a

[PATCH v12 03/14] drm: Add logging function for DP VSC SDP

2020-05-14 Thread Gwan-gyeong Mun
When receiving video it is very useful to be able to log DP VSC SDP. This greatly simplifies debugging. v2: Minor style fix v3: Move logging functions to drm core [Jani N] v5: Rebased v10: Rebased Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/drm_dp_helper.c |

[PATCH v12 06/14] drm/i915: Include DP VSC SDP in the crtc state dump

2020-05-14 Thread Gwan-gyeong Mun
Dump out the DP VSC SDP in the normal crtc state dump v3: Replace a structure name to drm_dp_vsc_sdp from intel_dp_vsc_sdp Use drm core's DP VSC SDP logging function Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_display.c | 13 +

[PATCH v12 02/14] drm/i915/dp: Read out DP SDPs

2020-05-14 Thread Gwan-gyeong Mun
It adds code to read the DP SDPs from the video DIP and unpack them into the crtc state. It adds routines that read out DP VSC SDP and DP HDR Metadata Infoframe SDP In order to unpack DP VSC SDP, it adds intel_dp_vsc_sdp_unpack() function. It follows DP 1.4a spec. [Table 2-116: VSC SDP Header

[PATCH v12 01/14] video/hdmi: Add Unpack only function for DRM infoframe

2020-05-14 Thread Gwan-gyeong Mun
It adds an unpack only function for DRM infoframe for dynamic range and mastering infoframe readout. It unpacks the information data block contained in the binary buffer into a structured frame of the HDMI Dynamic Range and Mastering (DRM) information frame. In contrast to

[PATCH v12 14/14] drm/i915/psr: Use new DP VSC SDP compute routine on PSR

2020-05-14 Thread Gwan-gyeong Mun
In order to use a common VSC SDP Colorimetry calculating code on PSR, it uses a new psr vsc sdp compute routine. Because PSR routine has its own scenario and timings of writing a VSC SDP, the current PSR routine needs to have its own drm_dp_vsc_sdp structure member variable on struct i915_psr. In

[PATCH v12 12/14] drm/i915: Stop sending DP SDPs on ddi disable

2020-05-14 Thread Gwan-gyeong Mun
Call intel_dp_set_infoframes(false) function on intel_ddi_post_disable_dp() to make sure not to send VSC SDP and HDR Metadata Infoframe SDP. v5: Polish commit message [Uma] Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 ++ 1 file

[PATCH v12 00/14] In order to readout DP SDPs, refactors the handling of DP SDPs

2020-05-14 Thread Gwan-gyeong Mun
In order to readout DP SDPs (Secondary Data Packet: DP HDR Metadata Infoframe SDP, DP VSC SDP), it refactors handling DP SDPs codes. It adds new compute routines for DP HDR Metadata Infoframe SDP and DP VSC SDP. And new writing routines of DP SDPs (Secondary Data Packet) that uses computed

[PATCH v12 11/14] drm/i915: Program DP SDPs on pipe updates

2020-05-14 Thread Gwan-gyeong Mun
Call intel_dp_set_infoframes() function on pipe updates to make sure that we send VSC SDP and HDR Metadata Infoframe SDP (when applicable) on fastsets. Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_ddi.c | 1 + 1 file changed, 1 insertion(+)

[PATCH v12 04/14] drm/i915: Include HDMI DRM infoframe in the crtc state dump

2020-05-14 Thread Gwan-gyeong Mun
Dump out the HDMI Dynamic Range and Mastering (DRM) infoframe in the normal crtc state dump. Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH v12 08/14] drm/i915: Add state readout for DP HDR Metadata Infoframe SDP

2020-05-14 Thread Gwan-gyeong Mun
Added state readout for DP HDR Metadata Infoframe SDP. v9: Rebased v10: Rebased Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_ddi.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c

Re: [PATCH 8/9] drm/shmem-helpers: Ensure get_pages is not called on imported dma-buf

2020-05-14 Thread Thomas Zimmermann
Hi Am 11.05.20 um 11:35 schrieb Daniel Vetter: > Just a bit of light paranoia. Also sprinkle this check over > drm_gem_shmem_get_sg_table, which should only be called when > exporting, same for the pin/unpin functions, on which it relies to > work correctly. > > Cc: Gerd Hoffmann > Cc: Rob

Re: [PATCH 9/9] drm/shmem-helpers: Simplify dma-buf importing

2020-05-14 Thread Thomas Zimmermann
Hi Am 11.05.20 um 11:35 schrieb Daniel Vetter: > - Ditch the ->pages array > - Make it a private gem bo, which means no shmem object, which means > fireworks if anyone calls drm_gem_object_get_pages. But we've just > made sure that's all covered. > > Cc: Gerd Hoffmann > Cc: Rob Herring >

Re: [RFC v2 0/1] drm/connector: Add support for privacy-screen properties

2020-05-14 Thread Pekka Paalanen
On Wed, 13 May 2020 11:28:38 -0700 Rajat Jain wrote: > On Wed, May 13, 2020 at 12:49 AM Pekka Paalanen wrote: ... > > On Tue, 12 May 2020 10:38:11 -0700 > > Rajat Jain wrote: > > > > > The chrome browser currently uses the API exposed by my (previous) > > > patchset to control privacy

Re: [PATCH 7/9] drm/shmem-helpers: Redirect mmap for imported dma-buf

2020-05-14 Thread Thomas Zimmermann
Hi Am 11.05.20 um 11:35 schrieb Daniel Vetter: > Currently this seems to work by converting the sgt into a pages array, > and then treating it like a native object. Do the right thing and > redirect mmap to the exporter. > > With this nothing is calling get_pages anymore on imported dma-buf, >

Re: [PATCH] drm: avoid spurious EBUSY due to nonblocking atomic modesets

2020-05-14 Thread Daniel Vetter
On Thu, May 14, 2020 at 9:18 AM Daniel Stone wrote: > > Hi, > > On Thu, 14 May 2020 at 08:08, Daniel Vetter wrote: > > > Did anything happen with this? > > > > Nope. There's an igt now that fails with this, and I'm not sure > > whether changing the igt is the right idea or not. > > > > I'm kinda

Re: [PATCH v3 1/4] dma-buf: add support for virtio exported objects

2020-05-14 Thread Gerd Hoffmann
Hi, > - for the runtime upcasting the usual approach is to check the ->ops > pointer. Which means that would need to be the same for all virtio > dma_bufs, which might get a bit awkward. But I'd really prefer we not > add allocator specific stuff like this to dma-buf. This is exactly the

Re: [PATCH v1 08/18] backlight: add backlight_is_blank()

2020-05-14 Thread Sam Ravnborg
Hi Daniel. On Thu, May 14, 2020 at 09:41:16PM +0200, Daniel Vetter wrote: > On Thu, May 14, 2020 at 09:09:51PM +0200, Sam Ravnborg wrote: > > The backlight support has two properties that express the state: > > - power > > - state > > > > It is un-documented and easy to get wrong. > > Add

Re: [GIT PULL] mediatek drm next for 5.8

2020-05-14 Thread Daniel Vetter
On Thu, May 14, 2020 at 05:19:08PM +0300, Laurent Pinchart wrote: > Hi Daniel, > > On Thu, May 14, 2020 at 07:25:10AM +0200, Daniel Vetter wrote: > > On Thu, May 14, 2020 at 1:33 AM Chun-Kuang Hu > > wrote: > > > Daniel Vetter 於 2020年5月14日 週四 上午3:45寫道: > > > > On Thu, May 14, 2020 at

Re: [PATCH v3 4/5] clk: stm32: Fix stm32f429 ltdc driver loading hang in clk set rate. keep ltdc clk running after kernel startup

2020-05-14 Thread Stephen Boyd
Quoting dillon.min...@gmail.com (2020-05-12 00:03:36) > From: dillon min > > as store stm32f4_rcc_register_pll return to the wrong offset of clks, Use () on functions, i.e. stm32f4_rcc_register_pll(). > so ltdc gate clk is null. need change clks[PLL_VCO_SAI] to clks[PLL_SAI] And quote

[PATCH AUTOSEL 5.6 45/62] drm/amd/display: fix counter in wait_for_no_pipes_pending

2020-05-14 Thread Sasha Levin
From: Roman Li [ Upstream commit 80797dd6f1a525d1160c463d6a9f9d29af182cbb ] [Why] Wait counter is not being reset for each pipe. [How] Move counter reset into pipe loop scope. Signed-off-by: Roman Li Reviewed-by: Zhan Liu Acked-by: Aurabindo Pillai Signed-off-by: Alex Deucher

[PATCH AUTOSEL 5.6 46/62] drm/amd/display: Prevent dpcd reads with passive dongles

2020-05-14 Thread Sasha Levin
From: Aurabindo Pillai [ Upstream commit e6142dd511425cb827b5db869f489eb81f5f994d ] [why] During hotplug, a DP port may be connected to the sink through passive adapter which does not support DPCD reads. Issuing reads without checking for this condition will result in errors [how] Ensure the

[PATCH AUTOSEL 5.6 44/62] drm/amd/display: Update DCN2.1 DV Code Revision

2020-05-14 Thread Sasha Levin
From: Sung Lee [ Upstream commit b95e51eb9f2ee7b6d6c3203a2f75122349aa77be ] [WHY & HOW] There is a problem in hscale_pixel_rate, the bug causes DCN to be more optimistic (more likely to underflow) in upscale cases during prefetch. This commit ports the fix from DV code to address these issues.

[PATCH AUTOSEL 5.6 34/62] sun6i: dsi: fix gcc-4.8

2020-05-14 Thread Sasha Levin
From: Arnd Bergmann [ Upstream commit 3a3a71f97c30983f1627c2c550d43566e9b634d2 ] Older compilers warn about initializers with incorrect curly braces: drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c: In function 'sun6i_dsi_encoder_enable': drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c:720:8: error: missing

Re: [PATCH v1.1 4/4] dt-bindings: display: bridge: renesas,lvds: Convert binding to YAML

2020-05-14 Thread Geert Uytterhoeven
Hi Laurent, On Thu, May 14, 2020 at 5:17 PM Laurent Pinchart wrote: > On Thu, May 14, 2020 at 09:31:53AM +0200, Geert Uytterhoeven wrote: > > On Thu, May 14, 2020 at 1:29 AM Laurent Pinchart wrote: > > > Convert the Renesas R-Car LVDS encoder text binding to YAML. > > > > > > Signed-off-by:

[PATCH] drm/msm: Don't call dma_buf_vunmap without _vmap

2020-05-14 Thread Daniel Vetter
I honestly don't exactly understand what's going on here, but the current code is wrong for sure: It calls dma_buf_vunmap without ever calling dma_buf_vmap. What I'm not sure about is whether the WARN_ON is correct: - msm imports dma-buf using drm_prime_sg_to_page_addr_arrays. Which is a pretty

Re: [PATCH v1.1 4/4] dt-bindings: display: bridge: renesas,lvds: Convert binding to YAML

2020-05-14 Thread Laurent Pinchart
Hi Geert, On Thu, May 14, 2020 at 09:02:54PM +0200, Geert Uytterhoeven wrote: > On Thu, May 14, 2020 at 5:17 PM Laurent Pinchart wrote: > > On Thu, May 14, 2020 at 09:31:53AM +0200, Geert Uytterhoeven wrote: > > > On Thu, May 14, 2020 at 1:29 AM Laurent Pinchart wrote: > > > > Convert the Renesas

Re: [PATCH 5/6] drm: msm: a6xx: use dev_pm_opp_set_bw to set DDR bandwidth

2020-05-14 Thread Matthias Kaehlcke
On Thu, May 14, 2020 at 04:24:18PM +0530, Sharat Masetty wrote: > This patches replaces the previously used static DDR vote and uses > dev_pm_opp_set_bw() to scale GPU->DDR bandwidth along with scaling > GPU frequency. > > Signed-off-by: Sharat Masetty > --- >

[PATCH 1/8] dt-bindings: media: renesas,fcp: Convert binding to YAML

2020-05-14 Thread Laurent Pinchart
Convert the Renesas R-Car FCP text binding to YAML. Signed-off-by: Laurent Pinchart --- .../devicetree/bindings/media/renesas,fcp.txt | 34 --- .../bindings/media/renesas,fcp.yaml | 56 +++ 2 files changed, 56 insertions(+), 34 deletions(-) delete mode 100644

[PATCH 2/8] dt-bindings: media: renesas, fcp: Make power-domains mandatory

2020-05-14 Thread Laurent Pinchart
All DT source files in the kernel tree specifyc the power-domains property. Make it mandatory. Signed-off-by: Laurent Pinchart --- Documentation/devicetree/bindings/media/renesas,fcp.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 7/8] dt-bindings: media: renesas, vsp1: Convert binding to YAML

2020-05-14 Thread Laurent Pinchart
Convert the Renesas R-Car VSP1 text binding to YAML. Signed-off-by: Laurent Pinchart --- .../bindings/media/renesas,vsp1.txt | 30 --- .../bindings/media/renesas,vsp1.yaml | 83 +++ 2 files changed, 83 insertions(+), 30 deletions(-) delete mode 100644

[PATCH 4/8] dt-bindings: media: renesas, fdp1: Convert binding to YAML

2020-05-14 Thread Laurent Pinchart
Convert the Renesas R-Car FDP1 text binding to YAML. Signed-off-by: Laurent Pinchart --- .../bindings/media/renesas,fdp1.txt | 37 --- .../bindings/media/renesas,fdp1.yaml | 63 +++ 2 files changed, 63 insertions(+), 37 deletions(-) delete mode 100644

[PATCH 6/8] dt-bindings: media: renesas,fdp1: Add resets property

2020-05-14 Thread Laurent Pinchart
The resets property ise used in DT sources in the kernel tree. Document it and make it mandatory. Signed-off-by: Laurent Pinchart --- Documentation/devicetree/bindings/media/renesas,fdp1.yaml | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH 5/8] dt-bindings: media: renesas, fdp1: Make power-domains mandatory

2020-05-14 Thread Laurent Pinchart
All DT source files in the kernel tree specifyc the power-domains property. Make it mandatory. Signed-off-by: Laurent Pinchart --- Documentation/devicetree/bindings/media/renesas,fdp1.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 3/8] dt-bindings: media: renesas, fcp: Add resets and iommus properties

2020-05-14 Thread Laurent Pinchart
The resets and iommus properties are used in DT sources in the kernel tree. Document them, and make resets mandatory. The iommus property is optional as not all platforms wire the FCP to a functional IOMMU. Signed-off-by: Laurent Pinchart ---

[PATCH 0/8] d-bindings: media: Conversion of Renesas bindings to YAML

2020-05-14 Thread Laurent Pinchart
Hello, This patch series converts the DT bindings for the Renesas R-Car FCP, FDP1 and VSP1 to YAML. It also updates the bindings based on the properties that have been added to the DT sources over time but never documented. Laurent Pinchart (8): dt-bindings: media: renesas,fcp: Convert binding

[PATCH 8/8] dt-bindings: media: renesas, vsp1: Add power-domains and resets

2020-05-14 Thread Laurent Pinchart
The power-domains and resets properties are used in all DT sources in the kernel but are absent from the bindings. Document them and make them mandatory. Signed-off-by: Laurent Pinchart --- .../devicetree/bindings/media/renesas,vsp1.yaml| 14 ++ 1 file changed, 14 insertions(+)

Re: [PATCH 4/6] drm: msm: a6xx: send opp instead of a frequency

2020-05-14 Thread Matthias Kaehlcke
On Thu, May 14, 2020 at 05:39:57PM -0700, Matthias Kaehlcke wrote: > On Thu, May 14, 2020 at 04:24:17PM +0530, Sharat Masetty wrote: > > This patch changes the plumbing to send the devfreq recommended opp rather > > than the frequency. Also consolidate and rearrange the code in a6xx to set > > the

Re: [PATCH v3 19/20] dt-bindings: mali-midgard: Allow dma-coherent

2020-05-14 Thread Rob Herring
On Wed, 13 May 2020 11:30:15 +0100, Andre Przywara wrote: > Add the boolean dma-coherent property to the list of allowed properties, > since some boards (Arm Juno) integrate the GPU this way. > > Signed-off-by: Andre Przywara > --- > Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml |

Re: linux-next: manual merge of the amdgpu tree with the pm tree

2020-05-14 Thread Stephen Rothwell
Hi all, On Fri, 8 May 2020 14:34:57 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the amdgpu tree got a conflict in: > > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c > > between commit: > > e07515563d01 ("PM: sleep: core: Rename DPM_FLAG_NEVER_SKIP") > > from the pm tree and

[PATCH AUTOSEL 5.4 37/49] drm/amd/display: Prevent dpcd reads with passive dongles

2020-05-14 Thread Sasha Levin
From: Aurabindo Pillai [ Upstream commit e6142dd511425cb827b5db869f489eb81f5f994d ] [why] During hotplug, a DP port may be connected to the sink through passive adapter which does not support DPCD reads. Issuing reads without checking for this condition will result in errors [how] Ensure the

[PATCH AUTOSEL 5.4 31/49] sun6i: dsi: fix gcc-4.8

2020-05-14 Thread Sasha Levin
From: Arnd Bergmann [ Upstream commit 3a3a71f97c30983f1627c2c550d43566e9b634d2 ] Older compilers warn about initializers with incorrect curly braces: drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c: In function 'sun6i_dsi_encoder_enable': drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c:720:8: error: missing

Re: [PATCH v1 08/18] backlight: add backlight_is_blank()

2020-05-14 Thread Daniel Vetter
On Thu, May 14, 2020 at 09:09:51PM +0200, Sam Ravnborg wrote: > The backlight support has two properties that express the state: > - power > - state > > It is un-documented and easy to get wrong. > Add backlight_is_blank() helper to make it simpler for drivers > to get the check of the state

Re: [PATCH v1 08/18] backlight: add backlight_is_blank()

2020-05-14 Thread Daniel Vetter
On Thu, May 14, 2020 at 09:46:46PM +0200, Sam Ravnborg wrote: > Hi Daniel. > > On Thu, May 14, 2020 at 09:41:16PM +0200, Daniel Vetter wrote: > > On Thu, May 14, 2020 at 09:09:51PM +0200, Sam Ravnborg wrote: > > > The backlight support has two properties that express the state: > > > - power > >

[PATCH v2] drm/dp: Include the AUX CH name in the debug messages

2020-05-14 Thread Ville Syrjala
From: Ville Syrjälä To make it easier to figure out what caused a particular debug message let's print out aux->name. v2: Convert drm_dp_send_real_edid_checksum() too Cc: Sam Ravnborg Signed-off-by: Ville Syrjälä --- IIRC Sam suggested that I switch to per-device logging functions at the

[PATCH] drm/shmem-helpers: Don't call get/put_pages on imported dma-buf in vmap

2020-05-14 Thread Daniel Vetter
There's no direct harm, because for the shmem helpers these are noops on imported buffers. The trouble is in the locks these take - I want to change dma_buf_vmap locking, and so need to make sure that we only ever take certain locks on one side of the dma-buf interface: Either for exporters, or

[PATCH v1.2 4/4] dt-bindings: display: bridge: renesas, lvds: Convert binding to YAML

2020-05-14 Thread Laurent Pinchart
Convert the Renesas R-Car LVDS encoder text binding to YAML. Signed-off-by: Laurent Pinchart Acked-by: Maxime Ripard --- Changes since v1: - Mention RZ/G1 and R2/G2 explicitly - Drop the part numbers in comments, only keep the SoC names - Use one address and size cell in the examples ---

[PATCH v1 0/18] backlight updates

2020-05-14 Thread Sam Ravnborg
The following series touches a lot of backlight things. It starts by migrating users of of_find_backlight_by_node() over to devm_of_find_backlight() to simplify code and to use the preferred way to register backlight. All the functions in the backlight core that is no longer used by any drivers

[PATCH v1 02/18] drm/tilcdc: use devm_of_find_backlight

2020-05-14 Thread Sam Ravnborg
Look up backlight device using devm_of_find_backlight(). This simplifies the code and prevents us from hardcoding the node name in the driver. Signed-off-by: Sam Ravnborg Cc: Jyri Sarha Cc: Tomi Valkeinen --- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 17 ++--- 1 file changed, 6

[PATCH v1 01/18] drm/omap: display: use devm_of_find_backlight

2020-05-14 Thread Sam Ravnborg
Look up backlight device using devm_of_find_backlight(). This simplifies the code and prevents us from hardcoding the node name in the driver. Signed-off-by: Sam Ravnborg Cc: Tomi Valkeinen Cc: Zheng Bin Cc: Kate Stewart Cc: Enrico Weigelt Cc: Allison Randal Cc: Laurent Pinchart Cc: Thomas

[PATCH v1 07/18] backlight: refactor fb_notifier_callback()

2020-05-14 Thread Sam Ravnborg
Increase readability of fb_notifier_callback() by removing a few indent levels. No functional change. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- drivers/video/backlight/backlight.c | 43 +++-- 1 file changed, 22 insertions(+), 21

[PATCH v1 12/18] backlight: document inline functions in backlight.h

2020-05-14 Thread Sam Ravnborg
Add documentation for the inline functions in backlight.h Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- include/linux/backlight.h | 16 1 file changed, 16 insertions(+) diff --git a/include/linux/backlight.h b/include/linux/backlight.h

[PATCH v1 08/18] backlight: add backlight_is_blank()

2020-05-14 Thread Sam Ravnborg
The backlight support has two properties that express the state: - power - state It is un-documented and easy to get wrong. Add backlight_is_blank() helper to make it simpler for drivers to get the check of the state correct. A lot of drivers also includes checks for fb_blank. This check is

[PATCH v1 13/18] backlight: document enums in backlight.h

2020-05-14 Thread Sam Ravnborg
Add kernel-doc documentation for the backlight enums Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- include/linux/backlight.h | 84 +++ 1 file changed, 84 insertions(+) diff --git a/include/linux/backlight.h

[PATCH v1 03/18] video: amba-clcd: use devm_of_find_backlight

2020-05-14 Thread Sam Ravnborg
Look up backlight device using devm_of_find_backlight(). This simplifies the code and prevents us from hardcoding the node name in the driver. Signed-off-by: Sam Ravnborg Cc: Russell King Cc: Sam Ravnborg Cc: Bartlomiej Zolnierkiewicz Cc: Daniel Vetter Cc: Linus Walleij Cc: Jani Nikula Cc:

[PATCH v1 04/18] backlight: make of_find_backlight static

2020-05-14 Thread Sam Ravnborg
There are no external users of of_find_backlight, as they have all changed to use the managed version. Make of_find_backlight static to prevent new external users. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- drivers/video/backlight/backlight.c | 31

[PATCH v1 09/18] backlight: improve backlight_ops documentation

2020-05-14 Thread Sam Ravnborg
Improve the documentation for backlight_ops and adapt it to kernel-doc style. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- include/linux/backlight.h | 60 +++ 1 file changed, 54 insertions(+), 6 deletions(-) diff --git

[PATCH v1 06/18] backlight: make of_find_backlight_by_node() static

2020-05-14 Thread Sam Ravnborg
There are no external users of of_find_backlight_by_node(). Make it static so we keep it that way. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- drivers/video/backlight/backlight.c | 22 +- include/linux/backlight.h | 10

[PATCH v1 16/18] backlight: add overview and update existing doc

2020-05-14 Thread Sam Ravnborg
Add overview chapter to backlight.c. Update existing kernel-doc to follow a more consistent style and drop kernel-doc for deprecated functions. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- drivers/video/backlight/backlight.c | 134

[PATCH v1 05/18] backlight: drop backlight_put()

2020-05-14 Thread Sam Ravnborg
There are no external users of backlight_put(). Drop it and open code the two users in backlight.c. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- drivers/video/backlight/backlight.c | 7 +-- include/linux/backlight.h | 10 -- 2 files

[PATCH v1 14/18] backlight: remove the unused backlight_bl driver

2020-05-14 Thread Sam Ravnborg
The driver required initialization using struct generic_bl_info. As there are no more references to this struct there is no users left. So it is safe to delete the driver. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- drivers/video/backlight/Kconfig |

[PATCH v1 10/18] backlight: improve backlight_properties documentation

2020-05-14 Thread Sam Ravnborg
Improve the documentation for backlight_properties and adapt it to kernel-doc style. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- include/linux/backlight.h | 101 +- 1 file changed, 90 insertions(+), 11 deletions(-)

[PATCH v1 18/18] backlight: use backlight_is_blank() in all backlight drivers

2020-05-14 Thread Sam Ravnborg
Replaces the open-coded checks if the state etc., with the backlight_is_blank() helper. This increases readability of the code and aling the functionality. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han Cc: Michael Hennerich Cc: Support Opensource Cc: Thierry

[PATCH v1 11/18] backlight: improve backlight_device documentation

2020-05-14 Thread Sam Ravnborg
Improve the documentation for backlight_device and adapt it to kernel-doc style. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- include/linux/backlight.h | 81 --- 1 file changed, 58 insertions(+), 23 deletions(-) diff

[PATCH v1 15/18] backlight: drop extern from prototypes

2020-05-14 Thread Sam Ravnborg
No need to put "extern" in front of prototypes. While touching the prototypes adjust indent to follow the kernel style. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- include/linux/backlight.h | 35 +++ 1 file changed, 19

[PATCH v1 17/18] backlight: wire up kernel-doc documentation

2020-05-14 Thread Sam Ravnborg
Include backlight so the documentation is now generated with make htmldocs and friends. Signed-off-by: Sam Ravnborg Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: Jonathan Corbet --- Documentation/gpu/backlight.rst | 12

Re: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-14 Thread Laurent Pinchart
Hi Enric, On Thu, May 14, 2020 at 07:35:33PM +0200, Enric Balletbo i Serra wrote: > On 14/5/20 19:12, Enric Balletbo i Serra wrote: > > On 14/5/20 18:44, Chun-Kuang Hu wrote: > >> Enric Balletbo i Serra 於 2020年5月14日 週四 > >> 下午11:42寫道: > >>> On 14/5/20 16:28, Chun-Kuang Hu wrote: > Enric

Re: [PATCH v2] drm/dp: Include the AUX CH name in the debug messages

2020-05-14 Thread Sam Ravnborg
Hi Ville. On Thu, May 14, 2020 at 09:40:40PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > To make it easier to figure out what caused a particular debug > message let's print out aux->name. > > v2: Convert drm_dp_send_real_edid_checksum() too > > Cc: Sam Ravnborg > Signed-off-by:

Re: [PATCH 1/2] drm/shmem: Use cached mappings by default

2020-05-14 Thread Rob Herring
On Thu, May 14, 2020 at 7:40 AM Daniel Vetter wrote: > > On Wed, May 13, 2020 at 05:03:11PM +0200, Thomas Zimmermann wrote: > > SHMEM-buffer backing storage is allocated from system memory; which is > > typically cachable. Currently, only virtio uses cachable mappings; udl > > uses its own

Re: [PATCH 3/9] drm/doc: Some polish for shmem helpers

2020-05-14 Thread Daniel Vetter
On Mon, May 11, 2020 at 01:12:49PM +0200, Thomas Zimmermann wrote: > > > Am 11.05.20 um 11:35 schrieb Daniel Vetter: > > - Move the shmem helper section to the drm-mm.rst file, next to the > > vram helpers. Makes a lot more sense there with the now wider scope. > > Also, that's where the all

Re: [PATCH 2/3] drm/etnaviv: Don't ignore errors on getting clocks

2020-05-14 Thread Lucas Stach
Am Donnerstag, den 14.05.2020, 09:27 +0100 schrieb Russell King - ARM Linux admin: > On Thu, May 14, 2020 at 10:18:02AM +0200, Lucas Stach wrote: > > Am Mittwoch, den 13.05.2020, 23:41 -0300 schrieb Fabio Estevam: > > > On Wed, May 13, 2020 at 2:09 PM Fabio Estevam wrote: > > > > > > > The

Re: [pull] amdgpu, amdkfd drm-next-5.8

2020-05-14 Thread Daniel Stone
Hi Alex, On Thu, 30 Apr 2020 at 22:30, Alex Deucher wrote: > UAPI: > - Add amdgpu UAPI for encrypted GPU memory > Used by: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4401 Did this ever go through uAPI review? It's been pushed to the kernel before Mesa review was complete. Even

[PATCH 6/6] dt-bindings: drm/msm/gpu: Document gpu opp table

2020-05-14 Thread Sharat Masetty
Update documentation to list the gpu opp table bindings including the newly added "opp-peak-kBps" needed for GPU-DDR bandwidth scaling. Signed-off-by: Sharat Masetty --- .../devicetree/bindings/display/msm/gpu.txt| 28 ++ 1 file changed, 28 insertions(+) diff --git

[PATCH 2/6] arm64: dts: qcom: sc7180: Add opp-peak-kBps to GPU opp

2020-05-14 Thread Sharat Masetty
Add opp-peak-kBps bindings to the GPU opp table, listing the peak GPU -> DDR bandwidth requirement for each opp level. This will be used to scale the DDR bandwidth along with the GPU frequency dynamically. Signed-off-by: Sharat Masetty --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 7 +++ 1

[PATCH 0/6] Add support for GPU DDR BW scaling

2020-05-14 Thread Sharat Masetty
This is a rework of my previous series [1], but this time based on the bindings from Georgi [2] + a few fixes which look to be fixed in v8 of Georgi's series [3]. The work is based on the chromeOS tip. [1]: https://patchwork.freedesktop.org/series/75291/ [2]:

[PATCH 1/6] arm64: dts: qcom: sc7180: Add interconnect bindings for GPU

2020-05-14 Thread Sharat Masetty
This patch adds the interconnect bindings to the GPU node. This enables the GPU->DDR path bandwidth voting. Signed-off-by: Sharat Masetty --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi

[PATCH 4/6] drm: msm: a6xx: send opp instead of a frequency

2020-05-14 Thread Sharat Masetty
This patch changes the plumbing to send the devfreq recommended opp rather than the frequency. Also consolidate and rearrange the code in a6xx to set the GPU frequency and the icc vote in preparation for the upcoming changes for GPU->DDR scaling votes. Signed-off-by: Sharat Masetty ---

[PATCH 5/6] drm: msm: a6xx: use dev_pm_opp_set_bw to set DDR bandwidth

2020-05-14 Thread Sharat Masetty
This patches replaces the previously used static DDR vote and uses dev_pm_opp_set_bw() to scale GPU->DDR bandwidth along with scaling GPU frequency. Signed-off-by: Sharat Masetty --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

[PATCH 3/6] OPP: Add and export helper to set bandwidth

2020-05-14 Thread Sharat Masetty
From: Sibi Sankar Add and export 'dev_pm_opp_set_bw' to set the bandwidth levels associated with an OPP for a given frequency. Signed-off-by: Sibi Sankar Signed-off-by: Sharat Masetty --- drivers/opp/core.c | 43 +++ include/linux/pm_opp.h | 6

  1   2   >