Re: [git pull] drm fixes for v5.7-rc7

2020-05-22 Thread pr-tracker-bot
The pull request you sent on Sat, 23 May 2020 06:38:11 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2020-05-23 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a24deb9d68b423f3e5e190b9836d192ee3e0ff9d Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH] drm/radeon/dpm: Replace one-element array and use struct_size() helper

2020-05-22 Thread Christian König
Am 22.05.20 um 03:25 schrieb Gustavo A. R. Silva: The current codebase makes use of one-element arrays in the following form: struct something { int length; u8 data[1]; }; struct something *instance; instance = kmalloc(sizeof(*instance) + size, GFP_KERNEL); instance->length = size;

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-05-22 Thread Michal Simek
On 21. 05. 20 15:53, Michael Ellerman wrote: > Christophe Leroy writes: >> Le 21/05/2020 à 09:02, Michael Ellerman a écrit : >>> Arnd Bergmann writes: +On Wed, Apr 8, 2020 at 2:04 PM Michael Ellerman wrote: > Benjamin Herrenschmidt writes: >> On Fri, 2020-04-03 at 15:59

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-05-22 Thread Michael Ellerman
Christophe Leroy writes: > Le 21/05/2020 à 09:02, Michael Ellerman a écrit : >> Arnd Bergmann writes: >>> +On Wed, Apr 8, 2020 at 2:04 PM Michael Ellerman >>> wrote: Benjamin Herrenschmidt writes: > On Fri, 2020-04-03 at 15:59 +1100, Michael Ellerman wrote: >> Benjamin

Re: [PATCH v1 13/25] dma-buf: Use sequence counter with associated wound/wait mutex

2020-05-22 Thread Ahmed S. Darwish
On Wed, May 20, 2020, Christian König wrote: > Am 19.05.20 um 23:45 schrieb Ahmed S. Darwish: > > A sequence counter write side critical section must be protected by some > > form of locking to serialize writers. If the serialization primitive is > > not disabling preemption implicitly, preemption

[PATCH] drm/nouveau/dispnv50: fix runtime pm imbalance on error

2020-05-22 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 4 +++- 1 file changed, 3

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-22 Thread Guenter Roeck
On Fri, May 22, 2020 at 02:35:23AM +0100, Al Viro wrote: > On Fri, May 22, 2020 at 02:29:50AM +0100, Al Viro wrote: > > On Thu, May 21, 2020 at 06:11:08PM -0700, Guenter Roeck wrote: > > > > > Mainline, with: > > > > > > qemu-system-sparc -M SS-4 -kernel arch/sparc/boot/zImage -no-reboot \ > > >

[PATCH v2] drm/fourcc: Add bayer formats and modifiers

2020-05-22 Thread Niklas Söderlund
Bayer formats are used with cameras and contain green, red and blue components, with alternating lines of red and green, and blue and green pixels in different orders. For each block of 2x2 pixels there is one pixel with a red filter, two with a green filter, and one with a blue filter. The

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-22 Thread Al Viro
On Thu, May 21, 2020 at 03:20:46PM -0700, Guenter Roeck wrote: > On 5/21/20 10:27 AM, Al Viro wrote: > > On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: > >> On Mon, May 18, 2020 at 11:48:43AM -0700, ira.we...@intel.com wrote: > >>> From: Ira Weiny > >>> > >>> The kunmap_atomic

Re: [PATCH 1/5] drivers/powerpc: Replace _ALIGN_UP() by ALIGN()

2020-05-22 Thread Michael Ellerman
On Mon, 20 Apr 2020 18:36:34 + (UTC), Christophe Leroy wrote: > _ALIGN_UP() is specific to powerpc > ALIGN() is generic and does the same > > Replace _ALIGN_UP() by ALIGN() Applied to powerpc/next. [1/5] drivers/powerpc: Replace _ALIGN_UP() by ALIGN()

[Bug Report] drivers/video/fbdev/kyro/fbdev.c: unsigned integer wrap-around might cause unexpected behavior

2020-05-22 Thread Changming Liu
Hi Bartlomiej, Greetings, I'm a first-year PhD student who is interested in the usage of UBSan for linux. And after some experiments, I found that in drivers/video/fbdev/kyro/fbdev.c function kyro_dev_overlay_viewport_set, there is an unsigned integer overflow that might cause unexpected

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-05-22 Thread Michael Ellerman
Arnd Bergmann writes: > +On Wed, Apr 8, 2020 at 2:04 PM Michael Ellerman wrote: >> Benjamin Herrenschmidt writes: >> > On Fri, 2020-04-03 at 15:59 +1100, Michael Ellerman wrote: >> >> Benjamin Herrenschmidt writes: >> > IBM still put 40x cores inside POWER chips no ? >> >> Oh yeah that's true.

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-05-22 Thread Christophe Leroy
Le 21/05/2020 à 09:02, Michael Ellerman a écrit : Arnd Bergmann writes: +On Wed, Apr 8, 2020 at 2:04 PM Michael Ellerman wrote: Benjamin Herrenschmidt writes: On Fri, 2020-04-03 at 15:59 +1100, Michael Ellerman wrote: Benjamin Herrenschmidt writes: IBM still put 40x cores inside POWER

[PATCH] drm/etnaviv: fix runtime pm imbalance on error

2020-05-22 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 3 +++ 1 file changed, 3

Re: Re: [PATCH] drm/panfrost: fix runtime pm imbalance on error

2020-05-22 Thread dinghao . liu
Hi Steve, There are two bailing out points in panfrost_job_hw_submit(): one is the error path beginning from pm_runtime_get_sync(), the other one is the error path beginning from WARN_ON() in the if statement. The pm imbalance fixed in this patch is between these two paths. I think the caller

[PATCH] drm/nouveau: fix runtime pm imbalance on error

2020-05-22 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/gpu/drm/nouveau/nouveau_gem.c | 2 +- 1 file changed, 1

[PATCH v2 1/1] drm: check for NULL pointer in drm_gem_object_put

2020-05-22 Thread Nirmoy Das
drm_gem_fb_destroy() calls drm_gem_object_put() with NULL obj causing: [ 11.584209] BUG: kernel NULL pointer dereference, address: [ 11.584213] #PF: supervisor write access in kernel mode [ 11.584215] #PF: error_code(0x0002) - not-present page [ 11.584216] PGD 0 P4D 0 [

[PATCH] drm/v3d: fix runtime pm imbalance on error

2020-05-22 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/gpu/drm/v3d/v3d_gem.c | 4 +++- 1 file changed, 3 insertions(+),

RE: [PATCH v2] drm/exynos: Remove dev_err() on platform_get_irq() failure

2020-05-22 Thread M Tamseel Shams
> -Original Message- > From: Inki Dae > Sent: Wednesday, May 20, 2020 11:08 AM > To: Tamseel Shams ; jy0922.s...@samsung.com; > sw0312@samsung.com; kyungmin.p...@samsung.com; airl...@linux.ie; > dan...@ffwll.ch > Cc: dri-devel@lists.freedesktop.org;

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-22 Thread Guenter Roeck
On 5/21/20 10:27 AM, Al Viro wrote: > On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: >> On Mon, May 18, 2020 at 11:48:43AM -0700, ira.we...@intel.com wrote: >>> From: Ira Weiny >>> >>> The kunmap_atomic clean up failed to remove one set of pagefault/preempt >>> enables when vaddr

[PATCH 1/2] dt-bindings: serial: add generic DT binding for announcing RTS/CTS lines

2020-05-22 Thread Erwan Le Ray
Add support of generic DT binding for annoucing RTS/CTS lines. The initial binding 'st,hw-flow-control' is not needed anymore since generic binding is available, but is kept for backward compatibility. Signed-off-by: Erwan Le Ray diff --git

[PATCH v3] drm/exynos: Remove dev_err() on platform_get_irq() failure

2020-05-22 Thread Tamseel Shams
platform_get_irq() will call dev_err() itself on failure, so there is no need for the driver to also do this. This is detected by coccinelle. Signed-off-by: Tamseel Shams --- - Changes since v2: * Addressed Inki Dae comments drivers/gpu/drm/exynos/exynos_drm_g2d.c | 1 - 1 file changed, 1

[PATCH 1/1] drm: check for NULL pointer in drm_gem_object_put

2020-05-22 Thread Nirmoy Das
drm_gem_fb_destroy() calls drm_gem_object_put() with NULL obj causing: [ 11.584209] BUG: kernel NULL pointer dereference, address: [ 11.584213] #PF: supervisor write access in kernel mode [ 11.584215] #PF: error_code(0x0002) - not-present page [ 11.584216] PGD 0 P4D 0 [

[PATCH 2/2] serial: stm32: Use generic DT binding for announcing RTS/CTS lines

2020-05-22 Thread Erwan Le Ray
Add support of generic DT binding for annoucing RTS/CTS lines. The initial binding 'st,hw-flow-control' is not needed anymore since generic binding is available, but is kept for backward compatibility. Signed-off-by: Erwan Le Ray diff --git a/drivers/tty/serial/stm32-usart.c

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2020-05-22 Thread Shengjiu Wang
Hi On Wed, May 20, 2020 at 5:42 PM Lucas Stach wrote: > > Am Mittwoch, den 20.05.2020, 16:20 +0800 schrieb Shengjiu Wang: > > Hi > > > > On Tue, May 19, 2020 at 6:04 PM Lucas Stach wrote: > > > Am Dienstag, den 19.05.2020, 17:41 +0800 schrieb Shengjiu Wang: > > > > There are two requirements

[PATCH 0/2] add generic DT binding for RTS/CTS

2020-05-22 Thread Erwan Le Ray
Add support of generic DT binding for annoucing RTS/CTS lines. The initial binding 'st,hw-flow-control' is not needed anymore since generic binding is available, but is kept for backward compatibility. Erwan Le Ray (2): dt-bindings: serial: add generic DT binding for announcing RTS/CTS

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2020-05-22 Thread Shengjiu Wang
Hi On Tue, May 19, 2020 at 6:04 PM Lucas Stach wrote: > > Am Dienstag, den 19.05.2020, 17:41 +0800 schrieb Shengjiu Wang: > > There are two requirements that we need to move the request > > of dma channel from probe to open. > > How do you handle -EPROBE_DEFER return code from the channel

[PATCH] drm/nouveau/debugfs: fix runtime pm imbalance on error

2020-05-22 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/gpu/drm/nouveau/nouveau_debugfs.c | 5 - 1 file changed, 4

Re: [PATCH v2 20/91] clk: bcm: rpi: Discover the firmware clocks

2020-05-22 Thread Nicolas Saenz Julienne
Hi Maxime, On Fri, 2020-05-15 at 10:19 +0200, Maxime Ripard wrote: > Hi Nicolas, > > On Mon, May 04, 2020 at 02:05:47PM +0200, Nicolas Saenz Julienne wrote: > > Hi Maxime, as always, thanks for the series! > > Some extra context, and comments below. > > > > On Fri, 2020-04-24 at 17:34 +0200,

[PATCH v2 1/1] drm: check for NULL pointer in drm_gem_object_put

2020-05-22 Thread Nirmoy Das
drm_gem_fb_destroy() calls drm_gem_object_put() with NULL obj causing: [ 11.584209] BUG: kernel NULL pointer dereference, address: [ 11.584213] #PF: supervisor write access in kernel mode [ 11.584215] #PF: error_code(0x0002) - not-present page [ 11.584216] PGD 0 P4D 0 [

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-22 Thread Al Viro
On Thu, May 21, 2020 at 06:11:08PM -0700, Guenter Roeck wrote: > Mainline, with: > > qemu-system-sparc -M SS-4 -kernel arch/sparc/boot/zImage -no-reboot \ > -snapshot -drive file=rootfs.ext2,format=raw,if=scsi \ > -append "panic=-1 slub_debug=FZPUA root=/dev/sda console=ttyS0" >

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-22 Thread Guenter Roeck
On 5/19/20 10:13 PM, Ira Weiny wrote: > On Tue, May 19, 2020 at 12:42:15PM -0700, Guenter Roeck wrote: >> On Tue, May 19, 2020 at 11:40:32AM -0700, Ira Weiny wrote: >>> On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: On Mon, May 18, 2020 at 11:48:43AM -0700, ira.we...@intel.com

Re: [RFC PATCH 0/4] DirectX on Linux

2020-05-22 Thread Jan Engelhardt
On Tuesday 2020-05-19 22:36, Sasha Levin wrote: > >> - Why DX12 on linux? Looking at this feels like classic divide and > > There is a single usecase for this: WSL2 developer who wants to run > machine learning on his GPU. The developer is working on his laptop, > which is running Windows and

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2020-05-22 Thread Shengjiu Wang
On Wed, May 20, 2020 at 8:38 PM Mark Brown wrote: > > On Wed, May 20, 2020 at 07:22:19PM +0800, Shengjiu Wang wrote: > > > I see some driver also request dma channel in open() or hw_params(). > > how can they avoid the defer probe issue? > > for example: > > sound/arm/pxa2xx-pcm-lib.c > >

Re: [RFC PATCH 0/8] Qualcomm Cloud AI 100 driver

2020-05-22 Thread Jeffrey Hugo
On 5/20/2020 9:59 AM, Greg Kroah-Hartman wrote: On Wed, May 20, 2020 at 08:48:13AM -0600, Jeffrey Hugo wrote: On 5/20/2020 2:34 AM, Daniel Vetter wrote: On Wed, May 20, 2020 at 7:15 AM Greg Kroah-Hartman wrote: On Tue, May 19, 2020 at 10:41:15PM +0200, Daniel Vetter wrote: On Tue, May 19,

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-22 Thread Guenter Roeck
On 5/21/20 10:42 AM, Ira Weiny wrote: > On Thu, May 21, 2020 at 09:05:41AM -0700, Guenter Roeck wrote: >> On 5/19/20 10:13 PM, Ira Weiny wrote: >>> On Tue, May 19, 2020 at 12:42:15PM -0700, Guenter Roeck wrote: On Tue, May 19, 2020 at 11:40:32AM -0700, Ira Weiny wrote: > On Tue, May 19,

Re: [RFC PATCH 0/8] Qualcomm Cloud AI 100 driver

2020-05-22 Thread Jeffrey Hugo
On 5/20/2020 2:34 AM, Daniel Vetter wrote: On Wed, May 20, 2020 at 7:15 AM Greg Kroah-Hartman wrote: On Tue, May 19, 2020 at 10:41:15PM +0200, Daniel Vetter wrote: On Tue, May 19, 2020 at 07:41:20PM +0200, Greg Kroah-Hartman wrote: On Tue, May 19, 2020 at 08:57:38AM -0600, Jeffrey Hugo

Re: [PATCH 2/3] drm/etnaviv: Don't ignore errors on getting clocks

2020-05-22 Thread Lubomir Rintel
On Thu, May 14, 2020 at 09:53:08AM +0100, Russell King - ARM Linux admin wrote: > On Thu, May 14, 2020 at 10:40:58AM +0200, Lucas Stach wrote: > > Am Donnerstag, den 14.05.2020, 09:27 +0100 schrieb Russell King - ARM Linux > > admin: > > > On Thu, May 14, 2020 at 10:18:02AM +0200, Lucas Stach

[Bug Report] drivers/video/fbdev/da8xx-fb.c: undefined behavior when left shifting

2020-05-22 Thread Changming Liu
Hi Bartlomiej, Greetings, it's me again, I sent you a bug report yesterday, I hope that find you well. This time I found that in /drivers/video/fbdev/da8xx-fb.c function lcd_cfg_vertical_sync, there might be an undefined result by left shifting. More specifically, in function

[PATCH] drm/panfrost: fix runtime pm imbalance on error

2020-05-22 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/gpu/drm/panfrost/panfrost_job.c | 4 +++- 1 file changed, 3

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-22 Thread Al Viro
On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: > On Mon, May 18, 2020 at 11:48:43AM -0700, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > The kunmap_atomic clean up failed to remove one set of pagefault/preempt > > enables when vaddr is not in the fixmap. > > > > Fixes:

[PATCH] drm/nouveau: fix runtime pm imbalance on error

2020-05-22 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/gpu/drm/nouveau/nouveau_gem.c | 4 +++- 1 file changed, 3

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-22 Thread Guenter Roeck
On 5/21/20 5:46 PM, Al Viro wrote: > On Thu, May 21, 2020 at 11:46:12PM +0100, Al Viro wrote: >> On Thu, May 21, 2020 at 03:20:46PM -0700, Guenter Roeck wrote: >>> On 5/21/20 10:27 AM, Al Viro wrote: On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: > On Mon, May 18, 2020 at

Re: [RFC] Deprecate AGP GART support for Radeon/Nouveau/TTM

2020-05-22 Thread Rui Salvaterra
Hi, Christian, On Wed, 20 May 2020 at 16:00, Christian König wrote: > > So I've used an ancient system (32bit) to setup a test box for this. > > > The first GPU I could test is an RV280 (Radeon 9200 PRO) which is easily > 15 years old. Oh, I have one of those in box somewhere, but no AGP

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-22 Thread Al Viro
On Thu, May 21, 2020 at 11:46:12PM +0100, Al Viro wrote: > On Thu, May 21, 2020 at 03:20:46PM -0700, Guenter Roeck wrote: > > On 5/21/20 10:27 AM, Al Viro wrote: > > > On Tue, May 19, 2020 at 09:54:22AM -0700, Guenter Roeck wrote: > > >> On Mon, May 18, 2020 at 11:48:43AM -0700,

Re: [PATCH] arch/{mips,sparc,microblaze,powerpc}: Don't enable pagefault/preempt twice

2020-05-22 Thread Al Viro
On Fri, May 22, 2020 at 02:29:50AM +0100, Al Viro wrote: > On Thu, May 21, 2020 at 06:11:08PM -0700, Guenter Roeck wrote: > > > Mainline, with: > > > > qemu-system-sparc -M SS-4 -kernel arch/sparc/boot/zImage -no-reboot \ > > -snapshot -drive file=rootfs.ext2,format=raw,if=scsi \ > >

[PATCH] drm/exynos: Properly propagate return value in drm_iommu_attach_device()

2020-05-22 Thread Marek Szyprowski
Propagate the proper error codes from the called functions instead of unconditionally returning 0. Reported-by: kbuild test robot Signed-off-by: Marek Szyprowski --- drivers/gpu/drm/exynos/exynos_drm_dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] drm/vblank: Fix -Wformat compile warnings on some arches

2020-05-22 Thread Thomas Zimmermann
Am 21.05.20 um 22:46 schrieb Lyude Paul: > On some architectures like ppc64le and aarch64, compiling with > -Wformat=1 will throw the following warnings: > > In file included from drivers/gpu/drm/drm_vblank.c:33: > drivers/gpu/drm/drm_vblank.c: In function 'drm_update_vblank_count': >

Re: [PATCH] drm: rcar-du: Fix build error

2020-05-22 Thread Kieran Bingham
Hi Daniel, On 18/05/2020 21:16, Daniel Gomez wrote: > Select DRM_KMS_HELPER dependency. > > Build error when DRM_KMS_HELPER is not selected: > > drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xd48): undefined reference to > `drm_atomic_helper_bridge_duplicate_state' >

Re: [RFC] Deprecate AGP GART support for Radeon/Nouveau/TTM

2020-05-22 Thread Christian König
Am 20.05.20 um 18:25 schrieb Michel Dänzer: On 2020-05-20 4:43 p.m., Christian König wrote: Am 13.05.20 um 13:03 schrieb Christian König: Unfortunately AGP is still to widely used as we could just drop support for using its GART. Not using the AGP GART also doesn't mean a loss in

Re: [PATCH] drm/tegra: hub: Do not enable orphaned window group

2020-05-22 Thread Thierry Reding
On Tue, May 19, 2020 at 02:03:01AM -0700, Nicolin Chen wrote: > Though the unconditional enable/disable code is not a final solution, > we don't want to run into a NULL pointer situation when window group > doesn't link to its DC parent if the DC is disabled in Device Tree. > > So this patch

Re: [RFC] Deprecate AGP GART support for Radeon/Nouveau/TTM

2020-05-22 Thread Christian König
Am 20.05.20 um 18:18 schrieb Alex Deucher: On Wed, May 20, 2020 at 10:43 AM Christian König wrote: Am 13.05.20 um 13:03 schrieb Christian König: Unfortunately AGP is still to widely used as we could just drop support for using its GART. Not using the AGP GART also doesn't mean a loss in

Re: [PATCH] drm/doc: device hot-unplug for userspace

2020-05-22 Thread Pekka Paalanen
On Wed, 20 May 2020 16:19:00 +0200 Daniel Vetter wrote: > On Wed, May 20, 2020 at 3:20 PM Simon Ser wrote: > > > > On Wednesday, May 20, 2020 2:55 PM, Daniel Vetter wrote: > > > > > Maybe we should add an explicit note that there's no guarantee about the > > > new chardev minor this new

Re: [RFC] Deprecate AGP GART support for Radeon/Nouveau/TTM

2020-05-22 Thread Michel Dänzer
On 2020-05-22 12:40 p.m., Christian König wrote: > Am 20.05.20 um 18:25 schrieb Michel Dänzer: >> On 2020-05-20 4:43 p.m., Christian König wrote: >>> Am 13.05.20 um 13:03 schrieb Christian König: Unfortunately AGP is still to widely used as we could just drop support for using its GART.

[Bug 206475] amdgpu under load drop signal to monitor until hard reset

2020-05-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206475 andrewammerl...@riseup.net (andrewammerl...@riseup.net) changed: What|Removed |Added CC|

[PATCH v5 39/38] drm: xen: fix common struct sg_table related issues

2020-05-22 Thread Marek Szyprowski
The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function returns the number of the created entries in the DMA address space. However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and dma_unmap_sg must be called with the original number of the entries passed to the

Re: [PATCH] drm/panfrost: fix runtime pm imbalance on error

2020-05-22 Thread Steven Price
On 21/05/2020 08:00, dinghao@zju.edu.cn wrote: Hi Steve, There are two bailing out points in panfrost_job_hw_submit(): one is the error path beginning from pm_runtime_get_sync(), the other one is the error path beginning from WARN_ON() in the if statement. The pm imbalance fixed in this

RE: [EXTERNAL] Re: [RFC PATCH 0/4] DirectX on Linux

2020-05-22 Thread Steve Pronovost
Thanks Daniel, more below. From: Daniel Vetter Sent: Wednesday, May 20, 2020 12:41 AM To: Steve Pronovost Cc: Dave Airlie ; Sasha Levin ; linux-hyp...@vger.kernel.org; Stephen Hemminger ; Ursulin, Tvrtko ; Greg Kroah-Hartman ; Haiyang Zhang ; LKML ; dri-devel ; Chris Wilson ; Linux Fbdev

[PATCH] drm/mediatek: dsi: fix scrolling of panel with small hfp or hbp

2020-05-22 Thread Jitao Shi
If panel has too small hfp or hbp, horizontal_frontporch_byte or horizontal_backporch_byte may become very small value or negative value. This patch adjusts their values so that they are greater than minimum value and keep total of them unchanged. Signed-off-by: Jitao Shi ---

RE: [EXTERNAL] Re: [RFC PATCH 0/4] DirectX on Linux

2020-05-22 Thread Steve Pronovost
>Echoing what others said, you're not making a DRM driver. The driver should >live outside of the DRM code. Agreed, please see my earlier reply. We'll be moving the driver to drivers/hyperv node or something similar. Apology for the confusion here. > I have one question about the driver API:

RE: [EXTERNAL] Re: [RFC PATCH 0/4] DirectX on Linux

2020-05-22 Thread Steve Pronovost
[resending as plain text, sorry about that] Thanks Daniel, more below. From: Daniel Vetter Sent: Wednesday, May 20, 2020 12:41 AM To: Steve Pronovost Cc: Dave Airlie ; Sasha Levin ;

Re: [PATCH v4 3/8] spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4

2020-05-22 Thread Mark Brown
On Mon, May 18, 2020 at 07:09:20PM +0800, dillon.min...@gmail.com wrote: > 2, use stm32 spi's "In full-duplex (BIDIMODE=0 and RXONLY=0)", as tx_buf is > null, we must add dummy data sent out before read data. > so, add stm32f4_spi_tx_dummy() to handle this situation. There are flags

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2020-05-22 Thread Mark Brown
On Thu, May 21, 2020 at 07:30:04PM +0800, Shengjiu Wang wrote: > On Wed, May 20, 2020 at 8:38 PM Mark Brown wrote: > > Other drivers having problems means those drivers should be fixed, not > > that we should copy the problems. In the case of the PXA driver that's > > very old code which

[PATCH 14/21] drm/mxsfb: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The mxsfb driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 11

[PATCH 02/21] drm/arc: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The arc driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/arc/arcpgu_drv.c | 12

[PATCH 16/21] drm/shmobile: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The shmobile driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/shmobile/shmob_drm_drv.c

[PATCH 12/21] drm/mcde: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The mcde driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mcde/mcde_drv.c | 12

[PATCH 20/21] drm/tv200: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The tve200 driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tve200/tve200_drv.c | 12

[PATCH 07/21] drm/hisilicon/kirin: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The kirin driver uses the default implementation for CMA functions; except for the .dumb_create callback. The __DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults and .dumb_create in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas

[PATCH 01/21] drm/cma-helper: Rework DRM_GEM_CMA_VMAP_DRIVER_OPS macro

2020-05-22 Thread Thomas Zimmermann
Rename the macro to DRM_GEM_CMA_DRIVER_OPS to align with SHMEM helpers. An internal version is provided for drivers that override the default .dumb_create callback. Adapt drivers to the changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_cma_helper.c | 2 +-

[PATCH 21/21] drm/zte: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The zte driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/zte/zx_drm_drv.c | 11

[PATCH 09/21] drm/ingenic: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The ingenic driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ingenic/ingenic-drm.c | 13

[PATCH 13/21] drm/meson: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The meson driver uses the default implementation for CMA functions; except for the .dumb_create callback. The __DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults and .dumb_create in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas

[PATCH 04/21] drm/aspeed: Set driver CMA functions with DRM_GEM_CMA_DRIVER_OPS

2020-05-22 Thread Thomas Zimmermann
DRM_GEM_CMA_DRIVER_OPS sets the functions in struct drm_driver to their defaults. No functional changes are made. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git

[PATCH 05/21] drm/atmel-hlcdc: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The atmel-hlcdc driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann ---

[PATCH 00/21] drm: Convert most CMA-based drivers to GEM object functions

2020-05-22 Thread Thomas Zimmermann
Most of the CMA-based drivers use the default implementation for the callbacks in struct drm_driver. With this patch, these interfaces are initialized with a common helper macro and GEM object functions replace several deprecated interfaces. The first patch updates the existing macro to similar

[PATCH 10/21] drm/komeda: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The komeda driver uses the default implementation for CMA functions; except for the .dumb_create callback. The __DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults and .dumb_create in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas

[PATCH 03/21] drm/arm: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The arm driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/arm/hdlcd_drv.c | 12

[PATCH 17/21] drm/stm: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The stm driver uses the default implementation for CMA functions; except for the .dumb_create callback. The __DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults and .dumb_create in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas

[PATCH 06/21] drm/fsl-dcu: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The fsl-dcu driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c

Re: [RFC] Deprecate AGP GART support for Radeon/Nouveau/TTM

2020-05-22 Thread Alex Deucher
On Fri, May 22, 2020 at 6:41 AM Christian König wrote: > > Am 20.05.20 um 18:18 schrieb Alex Deucher: > > On Wed, May 20, 2020 at 10:43 AM Christian König > > wrote: > >> Am 13.05.20 um 13:03 schrieb Christian König: > >>> Unfortunately AGP is still to widely used as we could just drop support

[PATCH AUTOSEL 5.6 35/41] drm/meson: pm resume add return errno branch

2020-05-22 Thread Sasha Levin
From: Bernard Zhao [ Upstream commit c54a8f1f329197d83d941ad84c4aa38bf282cbbd ] pm_resump api did not handle drm_mode_config_helper_resume error. This change add handle to return drm_mode_config_helper_resume`s error number. This code logic is aligned with api pm_suspend. After this change, the

[PATCH AUTOSEL 5.6 26/41] drm/amd/amdgpu: Update update_config() logic

2020-05-22 Thread Sasha Levin
From: "Leo (Hanghong) Ma" [ Upstream commit 650e723cecf2738dee828564396f3239829aba83 ] [Why] For MST case: when update_config is called to disable a stream, this clears the settings for all the streams on that link. We should only clear the settings for the stream that was disabled. [How]

[PATCH AUTOSEL 5.6 19/41] drm/amdgpu: Use GEM obj reference for KFD BOs

2020-05-22 Thread Sasha Levin
From: Felix Kuehling [ Upstream commit 39b3128d7ffd44e400e581e6f49e88cb42bef9a1 ] Releasing the AMDGPU BO ref directly leads to problems when BOs were exported as DMA bufs. Releasing the GEM reference makes sure that the AMDGPU/TTM BO is not freed too early. Also take a GEM reference when

[PATCH AUTOSEL 5.4 14/32] drm/amd/powerplay: perform PG ungate prior to CG ungate

2020-05-22 Thread Sasha Levin
From: Evan Quan [ Upstream commit f4fcfa4282c1a1bf51475ebb0ffda623eebf1191 ] Since gfxoff should be disabled first before trying to access those GC registers. Signed-off-by: Evan Quan Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 5.4 15/32] drm/amdgpu: Use GEM obj reference for KFD BOs

2020-05-22 Thread Sasha Levin
From: Felix Kuehling [ Upstream commit 39b3128d7ffd44e400e581e6f49e88cb42bef9a1 ] Releasing the AMDGPU BO ref directly leads to problems when BOs were exported as DMA bufs. Releasing the GEM reference makes sure that the AMDGPU/TTM BO is not freed too early. Also take a GEM reference when

[PATCH AUTOSEL 5.4 13/32] drm/amdgpu: drop unnecessary cancel_delayed_work_sync on PG ungate

2020-05-22 Thread Sasha Levin
From: Evan Quan [ Upstream commit 1fe48ec08d9f2e26d893a6c05bd6c99a3490f9ef ] As this is already properly handled in amdgpu_gfx_off_ctrl(). In fact, this unnecessary cancel_delayed_work_sync may leave a small time window for race condition and is dangerous. Signed-off-by: Evan Quan

Re: [GIT PULL v2] mediatek drm next for 5.8

2020-05-22 Thread Matthias Brugger
On 20/05/2020 07:46, Dave Airlie wrote: > On Wed, 20 May 2020 at 15:44, Dave Airlie wrote: >> >> On Mon, 18 May 2020 at 10:06, Chun-Kuang Hu wrote: >>> >>> Hi, Dave & Daniel: >>> >>> This include dpi pin mode swap, config mipi_tx current and impedance, >>> and some fixup. I drop drm_bridge

[PATCH 15/21] drm/rcar-du: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The rcar-du driver uses the default implementation for CMA functions; except for the .dumb_create callback. The __DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults and .dumb_create in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas

[PATCH 11/21] drm/malidp: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The malidp driver uses the default implementation for CMA functions; except for the .dumb_create callback. The __DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults and .dumb_create in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas

[PATCH 19/21] drm/tilcdc: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The tilcdc driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 13

[PATCH 08/21] drm/imx: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The imx driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/imx/imx-drm-core.c | 12

[PATCH 18/21] drm/sti: Use GEM CMA object functions

2020-05-22 Thread Thomas Zimmermann
The sti driver uses the default implementation for CMA functions. The DRM_GEM_CMA_DRIVER_OPS macro now sets these defaults in struct drm_driver. All remaining operations are provided by CMA GEM object functions. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/sti/sti_drv.c | 12

[PATCH AUTOSEL 5.6 18/41] drm/amd/powerplay: perform PG ungate prior to CG ungate

2020-05-22 Thread Sasha Levin
From: Evan Quan [ Upstream commit f4fcfa4282c1a1bf51475ebb0ffda623eebf1191 ] Since gfxoff should be disabled first before trying to access those GC registers. Signed-off-by: Evan Quan Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 5.6 17/41] drm/amdgpu: drop unnecessary cancel_delayed_work_sync on PG ungate

2020-05-22 Thread Sasha Levin
From: Evan Quan [ Upstream commit 1fe48ec08d9f2e26d893a6c05bd6c99a3490f9ef ] As this is already properly handled in amdgpu_gfx_off_ctrl(). In fact, this unnecessary cancel_delayed_work_sync may leave a small time window for race condition and is dangerous. Signed-off-by: Evan Quan

[PATCH] drm/panfrost: Fix inbalance of devfreq record_busy/idle()

2020-05-22 Thread Steven Price
The calls to panfrost_devfreq_record_busy() and panfrost_devfreq_record_idle() must be balanced to ensure that the devfreq utilisation is correctly reported. But there are two cases where this doesn't work correctly. In panfrost_job_hw_submit() if pm_runtime_get_sync() fails or the WARN_ON()

[Bug 206987] [drm] [amdgpu] Whole system crashes when the driver is in mode_support_and_system_configuration

2020-05-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206987 --- Comment #13 from Cyrax (ev...@hotmail.com) --- Created attachment 289237 --> https://bugzilla.kernel.org/attachment.cgi?id=289237=edit kernel log dumped from crash dump by using crash utility -- You are receiving this mail because: You

[Bug 206987] [drm] [amdgpu] Whole system crashes when the driver is in mode_support_and_system_configuration

2020-05-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206987 --- Comment #14 from Cyrax (ev...@hotmail.com) --- Created attachment 289239 --> https://bugzilla.kernel.org/attachment.cgi?id=289239=edit backtrace created by executing bt -f command in crash utility -- You are receiving this mail because:

[Bug 206987] [drm] [amdgpu] Whole system crashes when the driver is in mode_support_and_system_configuration

2020-05-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206987 --- Comment #15 from Cyrax (ev...@hotmail.com) --- Created attachment 289241 --> https://bugzilla.kernel.org/attachment.cgi?id=289241=edit dump of struct dcn_bw_internal_vars -- You are receiving this mail because: You are watching the

Re: [PATCH v2] drm/radeon/dpm: Replace one-element array and use struct_size() helper

2020-05-22 Thread Alex Deucher
On Fri, May 22, 2020 at 1:29 PM Gustavo A. R. Silva wrote: > > The current codebase makes use of one-element arrays in the following > form: > > struct something { > int length; > u8 data[1]; > }; > > struct something *instance; > > instance = kmalloc(sizeof(*instance) + size,

  1   2   >