Re: [PATCH] drm: headers: Add neccessary include files and guards

2019-03-27 Thread Ahmed S. Darwish
Hi, On Wed, Mar 27, 2019 at 09:30:59AM +0100, Daniel Vetter wrote: > On Wed, Mar 27, 2019 at 12:23:43AM +0100, Ahmed S. Darwish wrote: > > Otherwise gcc will complain about unknown types, and declarations > > inside parameter lists, if "drm_internal.h" is used in C fi

[PATCH] drm: headers: Add neccessary include files and guards

2019-03-26 Thread Ahmed S. Darwish
Otherwise gcc will complain about unknown types, and declarations inside parameter lists, if "drm_internal.h" is used in C files with less headers than what's now typically done under drivers/gpu/drm/. Signed-off-by: Ahmed S. Darwish --- Notes: This was triggered by the in-devel

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-13 Thread Ahmed S. Darwish
Hi, On Wed, Mar 13, 2019 at 09:35:05AM +0100, Daniel Vetter wrote: > On Tue, Mar 12, 2019 at 11:13:03PM +0100, Ahmed S. Darwish wrote: > > On Mon, Mar 11, 2019 at 11:33:15PM +0100, Noralf Trønnes wrote: > > > Den 11.03.2019 20.23, skrev Daniel Vetter: [……] > > > >

Re: [PATCH v2 0/3] drm: Add panic handling

2019-03-17 Thread Ahmed S. Darwish
and _not_ an official patch submission. It's now Show-me-the-code time ;-) Subject: [PATCH] Documentation: gpu: Add initial DRM panic design Co-developed-by: Daniel Vetter Signed-off-by: Ahmed S. Darwish --- Documentation/gpu/drm-panic-design.rst | 124 + 1 file cha

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-12 Thread Ahmed S. Darwish
Hi, On Tue, Mar 12, 2019 at 11:58:10AM +0100, Daniel Vetter wrote: > On Mon, Mar 11, 2019 at 11:33:15PM +0100, Noralf Trønnes wrote: > > > > > > Den 11.03.2019 20.23, skrev Daniel Vetter: > > > On Mon, Mar 11, 2019 at 06:42:16PM +0100, Noralf Trønnes wrote: [...] > > >> +} > > >> + > > >> +static

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-12 Thread Ahmed S. Darwish
Hi, [[ CCing John for the trylock parts ]] On Mon, Mar 11, 2019 at 11:33:15PM +0100, Noralf Trønnes wrote: > > Den 11.03.2019 20.23, skrev Daniel Vetter: > > On Mon, Mar 11, 2019 at 06:42:16PM +0100, Noralf Trønnes wrote: > >> This adds support for outputting kernel messages on panic(). > >> A

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-13 Thread Ahmed S. Darwish
Hi, [[ CCing John for the trylock parts ]] On Mon, Mar 11, 2019 at 11:33:15PM +0100, Noralf Trønnes wrote: > > > Den 11.03.2019 20.23, skrev Daniel Vetter: > > On Mon, Mar 11, 2019 at 06:42:16PM +0100, Noralf Trønnes wrote: > >> This adds support for outputting kernel messages on panic(). > >> A

DRM-based Oops viewer

2019-03-11 Thread Ahmed S. Darwish
Hello DRM/UEFI maintainers, Several years ago, I wrote a set of patches to dump the kernel log to disk upon panic -- through BIOS INT 0x13 services. [1] The overwhelming response was that it's unsafe to do this in a generic manner. Linus proposed a video-based viewer instead: [2] If you

Re: DRM-based Oops viewer

2019-03-12 Thread Ahmed S. Darwish
On Mon, Mar 11, 2019 at 02:49:41PM +0100, Daniel Vetter wrote: > On Mon, Mar 11, 2019 at 11:04:19AM +0200, Jani Nikula wrote: > > On Sun, 10 Mar 2019, "Ahmed S. Darwish" wrote: > > > Hello DRM/UEFI maintainers, > > > > > > Several years ago, I wrote

Re: DRM-based Oops viewer

2019-03-12 Thread Ahmed S. Darwish
Hello Jani, On Mon, Mar 11, 2019 at 11:04:19AM +0200, Jani Nikula wrote: > On Sun, 10 Mar 2019, "Ahmed S. Darwish" wrote: > > Hello DRM/UEFI maintainers, > > > > Several years ago, I wrote a set of patches to dump the kernel > > log to disk upon panic

Re: [PATCH v2 1/3] drm: Add support for panic message output

2019-03-13 Thread Ahmed S. Darwish
[[ Adding Sebastian, who is quite experienced in intricate locking situations due to daily PREEMPT_RT work.. ]] On Wed, Mar 13, 2019 at 09:37:10AM +0100, Daniel Vetter wrote: > On Wed, Mar 13, 2019 at 08:49:17AM +0100, John Ogness wrote: > > On 2019-03-12, Ahmed S. Darwi

Re: [PATCH v1 13/25] dma-buf: Use sequence counter with associated wound/wait mutex

2020-05-22 Thread Ahmed S. Darwish
On Wed, May 20, 2020, Christian König wrote: > Am 19.05.20 um 23:45 schrieb Ahmed S. Darwish: > > A sequence counter write side critical section must be protected by some > > form of locking to serialize writers. If the serialization primitive is > > not disabling preemption i

[PATCH v1 06/25] dma-buf: Remove custom seqcount lockdep class key

2020-05-20 Thread Ahmed S. Darwish
t. Use seqcount_init() inside the dma reservation object initializer. Signed-off-by: Ahmed S. Darwish Reviewed-by: Sebastian Andrzej Siewior --- drivers/dma-buf/dma-resv.c | 9 + include/linux/dma-resv.h | 2 -- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/dma-buf/

[PATCH v1 00/25] seqlock: Extend seqcount API with associated locks

2020-05-20 Thread Ahmed S. Darwish
to read_seqbegin_or_lock(). By using the lockdep debugging mechanisms added in this patch series, a number of erroneous seqcount call-sites were discovered across the kernel. The fixes are included at the beginning of the series. Thanks, 8<-- Ahmed S. Darwish (25): net: c

[PATCH v1 13/25] dma-buf: Use sequence counter with associated wound/wait mutex

2020-05-20 Thread Ahmed S. Darwish
side critical section because the write_begin/end() functions for this new data type automatically do this. If lockdep is disabled this ww_mutex lock association is compiled out and has neither storage size nor runtime overhead. Signed-off-by: Ahmed S. Darwish --- drivers/dma-buf/dma-resv.c

[PATCH v2 00/18] seqlock: Extend seqcount API with associated locks

2020-06-08 Thread Ahmed S. Darwish
8<-- Ahmed S. Darwish (18): Documentation: locking: Describe seqlock design and usage seqlock: Properly format kernel-doc code samples seqlock: Add missing kernel-doc annotations seqlock: Extend seqcount API with associated locks dma-buf: Remove custom seqcount lockdep cla

[PATCH v2 05/18] dma-buf: Remove custom seqcount lockdep class key

2020-06-08 Thread Ahmed S. Darwish
t. Use seqcount_init() inside the dma reservation object initializer. Signed-off-by: Ahmed S. Darwish Reviewed-by: Sebastian Andrzej Siewior Acked-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 9 + include/linux/dma-resv.h | 2 -- 2 files changed, 1 insertion(+), 10 deletions(-) diff

[PATCH v2 06/18] dma-buf: Use sequence counter with associated wound/wait mutex

2020-06-08 Thread Ahmed S. Darwish
side critical section because the write_begin/end() functions for this new data type automatically do this. If lockdep is disabled this ww_mutex lock association is compiled out and has neither storage size nor runtime overhead. Signed-off-by: Ahmed S. Darwish --- drivers/dma-buf/dma-resv.c

Re: [PATCH v2 0/6] seqlock: seqcount_t call sites bugfixes

2020-06-05 Thread Ahmed S. Darwish
On Thu, Jun 04, 2020 at 09:28:41AM +0200, Daniel Vetter wrote: > On Wed, Jun 03, 2020 at 04:49:43PM +0200, Ahmed S. Darwish wrote: > > Hi, > > > > Since patch #7 and #8 from the series: > > > >[PATCH v1 00/25] seqlock: Extend seqcount API with a

[PATCH v2 0/6] seqlock: seqcount_t call sites bugfixes

2020-06-04 Thread Ahmed S. Darwish
. Thanks to Dan/kbuild-bot report. - patch #4: new patch, invalid preemptible context found by the new lockdep checks added in the seqlock series + kbuild-bot. Thanks, 8<-- Ahmed S. Darwish (6): net: core: device_rename: Use rwsem instead of a seqcount net:

[PATCH v2 6/6] dma-buf: Remove custom seqcount lockdep class key

2020-06-04 Thread Ahmed S. Darwish
t. Use seqcount_init() inside the dma reservation object initializer. Signed-off-by: Ahmed S. Darwish Reviewed-by: Sebastian Andrzej Siewior --- drivers/dma-buf/dma-resv.c | 9 + include/linux/dma-resv.h | 2 -- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/dma-buf/

[PATCH v3 07/20] dma-buf: Remove custom seqcount lockdep class key

2020-06-30 Thread Ahmed S. Darwish
t. Use seqcount_init() inside the dma reservation object initializer. Signed-off-by: Ahmed S. Darwish Reviewed-by: Sebastian Andrzej Siewior Acked-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 9 + include/linux/dma-resv.h | 2 -- 2 files changed, 1 insertion(+), 10 deletions(-) diff

[PATCH v3 00/20] seqlock: Extend seqcount API with associated locks

2020-06-30 Thread Ahmed S. Darwish
d-by tags Thanks, 8<------ Ahmed S. Darwish (20): Documentation: locking: Describe seqlock design and usage seqlock: Properly format kernel-doc code samples seqlock: Add missing kernel-doc annotations lockdep: Add preemption enabled/disabled assertion APIs seqlock: lockde

[PATCH v3 08/20] dma-buf: Use sequence counter with associated wound/wait mutex

2020-06-30 Thread Ahmed S. Darwish
side critical section because the write_begin/end() functions for this new data type automatically do this. If lockdep is disabled this ww_mutex lock association is compiled out and has neither storage size nor runtime overhead. Signed-off-by: Ahmed S. Darwish Acked-by: Daniel Vetter