Re: [PATCH] drm/amdgpu/acp: Make PM domain really work

2021-07-21 Thread Alex Deucher
Applied. Thanks! I've removed the unused variables when I applied. Alex On Tue, Jul 20, 2021 at 1:31 PM Kai-Heng Feng wrote: > > Devices created by mfd_add_hotplug_devices() don't really increase the > index of its name, so get_mfd_cell_dev() cannot find any device, hence a > NULL dev is passe

[pull] amdgpu drm-fixes-5.14

2021-07-21 Thread Alex Deucher
Hi Dave, Daniel, Updates for 5.14. Mostly fixes for new asics added in 5.14. The following changes since commit 876d98e5511d8cfd12fc617a6717e7a8ea07be17: Merge tag 'drm-intel-fixes-2021-07-15' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes (2021-07-16 10:53:02 +1000) are ava

Re: [Intel-gfx] [RFC 0/8] Per client GPU stats

2021-07-23 Thread Alex Deucher
On Fri, Jul 23, 2021 at 9:51 AM Tvrtko Ursulin wrote: > > > On 23/07/2021 12:23, Christian König wrote: > > Am 23.07.21 um 13:21 schrieb Tvrtko Ursulin: > >> > >> On 15/07/2021 10:18, Tvrtko Ursulin wrote: > >>> From: Tvrtko Ursulin > >>> > >>> Same old work but now rebased and series ending with

Re: [RFC 8/8] drm/amdgpu: Convert to common fdinfo format

2021-07-23 Thread Alex Deucher
+ David, Roy On Thu, Jul 15, 2021 at 5:18 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Convert fdinfo format to one documented in drm-usage-stats.rst. > > Opens: > * Does it work for AMD? > * What are the semantics of AMD engine utilisation reported in percents? >Can it align with

Re: [PATCH 1/3] drm/amdgpu: create amdgpu_vkms (v2)

2021-07-23 Thread Alex Deucher
On Wed, Jul 21, 2021 at 1:07 PM Ryan Taylor wrote: > > Modify the VKMS driver into an api that dce_virtual can use to create > virtual displays that obey drm's atomic modesetting api. > > v2: Made local functions static. > > Reported-by: kernel test robot > Signed-off-by: Ryan Taylor > --- > dr

Re: [PATCH 3/3] drm/amdgpu: replace dce_virtual with amdgpu_vkms (v3)

2021-07-23 Thread Alex Deucher
orted-by: kernel test robot > Suggested-by: Alex Deucher > Signed-off-by: Ryan Taylor > --- > drivers/gpu/drm/amd/amdgpu/Makefile | 3 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 234 ++- > drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.h | 5 +- >

Re: [PATCH 1/3] drm/amdgpu: create amdgpu_vkms (v2)

2021-07-26 Thread Alex Deucher
- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Friday, July 23, 2021 10:32 PM > To: Taylor, Ryan > Cc: kernel test robot ; Daniel Vetter > ; Siqueira, Rodrigo ; > amd-gfx list ; Melissa Wen > ; Maling list - DRI developers > > Subject: Re: [PATCH 1/3] d

Re: [PATCH 1/3] drm/amdgpu: create amdgpu_vkms (v2)

2021-07-26 Thread Alex Deucher
match vkms. Alex > > Best, > Ryan > ________ > From: Alex Deucher > Sent: Monday, July 26, 2021 9:21 AM > To: Chen, Guchun > Cc: Taylor, Ryan ; kernel test robot ; > Daniel Vetter ; Siqueira, Rodrigo > ; amd-gfx list ; > Melissa Wen ; Malin

Re: [PATCH 01/14] drm/amdgpu: Convert to Linux IRQ interfaces

2021-07-28 Thread Alex Deucher
nitlaizaton in thi case. The DRM IRQ > > midlayer does not handle this correctly. > > > > Signed-off-by: Thomas Zimmermann > > Alex needs to take a look at this as well, but of hand the patch is > Acked-by: Christian König . Looks good to me as well: Reviewed-by: Ale

[pull] amdgpu drm-fixes-5.14

2021-07-28 Thread Alex Deucher
contents exposure in error path - pmops check fix for S0ix vs S3 - DCN 2.1 display fixes - DCN 2.0 display fix - Backlight control fix for laptops with HDR panels - Maintainers updates Alex Deucher (1): drm/amdgpu/display: only

Re: [PATCH 23/64] drm/amd/pm: Use struct_group() for memcpy() region

2021-07-29 Thread Alex Deucher
sent interfaces with firmware running on microcontrollers, so if the sizes or offsets change that could cause a problem. That doesn't seem to be the case, but something to keep in mind. Patch is: Acked-by: Alex Deucher Feel free to take this through whatever tree makes sense. Alex &g

Re: [PATCH] drm/amd/display: Fix typo in comments

2021-07-29 Thread Alex Deucher
On Thu, Jul 29, 2021 at 4:18 AM Cai Huoqing wrote: > > Remove the repeated word 'the' from comments > > Signed-off-by: Cai Huoqing Applied. Thanks! > --- > drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 2 +- > .../gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c | 2

Re: [PATCH] gpu/drm/radeon: Fix typo in comments

2021-07-29 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jul 29, 2021 at 4:21 AM Cai Huoqing wrote: > > Remove the repeated word 'the' from comments > > Signed-off-by: Cai Huoqing > --- > drivers/gpu/drm/radeon/atombios.h | 4 ++-- > drivers/gpu/drm/radeon/r300_reg.h | 2 +- > drivers/gpu/drm/radeon/radeon_de

[pull] amdgpu, amdkfd, radeon drm-next-5.15

2021-07-29 Thread Alex Deucher
ellow carp drm/amdgpu: update yellow carp external rev_id handling drm/amdgpu: add yellow carp pci id (v2) Aaron Rice (1): drm/amdgpu: rework smu11 i2c for generic operation Alex Deucher (16): drm/amdgpu/display: drop unused variable drm/amdgpu: add new dimgrey cavefish DID

[ANNOUNCE] xf86-video-amdgpu 21.0.0

2021-07-30 Thread Alex Deucher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Adam Jackson (2): kms: Handle changes to SourceValidate call chain in xserver 19 Fix link failure with gcc 10 Alex Deucher (1): Bump version for the 21.0.0 release Emil Velikov (10): Use ODEV_ATTRIB_PATH where possible for

Re: [PATCH -next] drm/amdgpu: fix checking pmops when PM_SLEEP is not enabled

2021-07-30 Thread Alex Deucher
pmops for desired suspend state") > Signed-off-by: Randy Dunlap > Cc: Alex Deucher > Cc: Christian König > Cc: "Pan, Xinhui" > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-n...@vger.kernel.org > --- > drivers/gpu/

Re: [PATCH] drm/radeon: Update pitch for page flip

2021-08-02 Thread Alex Deucher
bly a bit much on this old > hw. If just the pitch changed, that probably wouldn't be much of a problem, but if the pitch is changing, that probably implies other stuff has changed as well and we'll just be chasing changes. I agree it would be best to just reject anything other th

Re: [PATCH 09/14] drm/radeon: Convert to Linux IRQ interfaces

2021-08-02 Thread Alex Deucher
g called directly or inlined. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/radeon/radeon_drv.c | 4 --- > drivers/gpu/drm/radeon/radeon_irq_kms.c | 44 + > drivers/gpu/drm/radeon/radeon_kms.h | 4 --- >

Re: [PATCH] gpu/drm/amd: Remove duplicated include of drm_drv.h

2021-08-02 Thread Alex Deucher
On Mon, Aug 2, 2021 at 3:32 AM zhouchuangao wrote: > > Duplicate include header file > line 28: #include > line 44: #include > > Signed-off-by: zhouchuangao Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/dri

Re: [PATCH 0/3] drm/amdgpu: modernize virtual display feature

2021-08-02 Thread Alex Deucher
llbacks needed for buffer management. > Ultimately, it proved easier to import the vkms code as it mostly used core > drm helpers anyway. Series is: Reviewed-by: Alex Deucher > > Ryan Taylor (3): > drm/amdgpu: create amdgpu_vkms (v4) > drm/amdgpu: cleanup dce_virtual &g

Re: [PATCH] drm/radeon: Update pitch for page flip

2021-08-03 Thread Alex Deucher
On Tue, Aug 3, 2021 at 4:34 AM Michel Dänzer wrote: > > On 2021-08-02 4:51 p.m., Alex Deucher wrote: > > On Mon, Aug 2, 2021 at 4:31 AM Daniel Vetter wrote: > >> > >> On Mon, Aug 02, 2021 at 10:12:47AM +0200, Christian König wrote: > >>> Am 02.08.21

Re: [pull] amdgpu, radeon, ttm, sched drm-next-5.13

2021-04-06 Thread Alex Deucher
On Tue, Apr 6, 2021 at 11:42 AM Felix Kuehling wrote: > > Am 2021-04-01 um 6:29 p.m. schrieb Alex Deucher: > > Hi Dave, Daniel, > > > > New stuff for 5.13. There are two small patches for ttm and scheduler > > that were dependencies for amdgpu changes. > > &g

Re: [pull] amdgpu, radeon, ttm, sched drm-next-5.13

2021-04-06 Thread Alex Deucher
is PR. Thanks, Alex > > Thanks, > Christian. > > Am 02.04.21 um 00:29 schrieb Alex Deucher: > > Hi Dave, Daniel, > > > > New stuff for 5.13. There are two small patches for ttm and scheduler > > that were dependencies fo

Re: [PATCH] drm/radeon/ttm: Fix memory leak userptr pages

2021-04-06 Thread Alex Deucher
GS:950ebfc0() > >> knlGS: > >> [17359.930047] CS: 0010 DS: ES: CR0: 80050033 > >> [17359.936674] CR2: CR3: 0006d700e005 CR4: > >> 001706e0 > > From what I understand, the init

Re: [PATCH 2/2] drm/scheduler: Change scheduled fence track

2021-04-07 Thread Alex Deucher
+ dri-devel since GPU scheduler is a shared component. On Wed, Apr 7, 2021 at 9:31 AM Roy Sun wrote: > > Update the timestamp of scheduled fence on HW > completion of the previous fences > > This allow more accurate tracking of the fence > execution in HW > > Signed-off-by: David M Nieto > Signe

Re: [pull] amdgpu, radeon, ttm, sched drm-next-5.13

2021-04-07 Thread Alex Deucher
On Wed, Apr 7, 2021 at 3:23 AM Dave Airlie wrote: > > On Wed, 7 Apr 2021 at 06:54, Alex Deucher wrote: > > > > On Fri, Apr 2, 2021 at 12:22 PM Christian König > > wrote: > > > > > > Hey Alex, > > > > > > the TTM and scheduler changes

Re: [PATCH] drm/amd/pm: convert sysfs snprintf to sysfs_emit

2021-04-07 Thread Alex Deucher
On Tue, Apr 6, 2021 at 10:13 AM Carlis wrote: > > From: Xuezhi Zhang > > Fix the following coccicheck warning: > drivers/gpu/drm/amd/pm//amdgpu_pm.c:1940:8-16: > WARNING: use scnprintf or sprintf > drivers/gpu/drm/amd/pm//amdgpu_pm.c:1978:8-16: > WARNING: use scnprintf or sprintf > drivers/gpu/dr

[pull] amdgpu, radeon drm-fixes-5.12

2021-04-07 Thread Alex Deucher
fixes-5.12-2021-04-08: amdgpu: - DCN3 fix - Fix CAC setting regression for TOPAZ - Fix ttm regression radeon: - Fix ttm regression ---- Alex Deucher (1): drm/amdgpu/smu7: fix CAC setting on TOPAZ Qingqing Zhuo (1): drm/amd/di

Re: [pull] amdgpu, radeon, ttm, sched drm-next-5.13

2021-04-08 Thread Alex Deucher
On Thu, Apr 8, 2021 at 6:28 AM Christian König wrote: > > Am 08.04.21 um 09:13 schrieb Christian König: > > Am 07.04.21 um 21:04 schrieb Alex Deucher: > >> On Wed, Apr 7, 2021 at 3:23 AM Dave Airlie wrote: > >>> On Wed, 7 Apr 2021 at 06:54, Alex Deucher > &

Re: [pull] amdgpu, amdkfd, radeon drm-next-5.12

2021-04-08 Thread Alex Deucher
I can finally get it sorted out. Alex > -Daniel > > > > > Dave. > > > > On Sat, 27 Mar 2021 at 05:16, Zhuo, Qingqing wrote: > > > > > > [AMD Public Use] > > > > > > On Thu, Feb 18, 2021 at 11:15 PM Alex Deucher > > &

Re: [PATCH] drm/radeon/r600: Fix variables that are not used after assignment

2021-04-08 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Apr 8, 2021 at 8:13 AM Tian Tao wrote: > > err was not used after being assigned -EINVAL and was given a new value, > so here add goto to handle the error case. > > Signed-off-by: Tian Tao > --- > drivers/gpu/drm/radeon/r600.c | 2 ++ > 1 file changed, 2 insertio

Re: [PATCH -next] drm/amd/display: Fix the Wunused-function warning

2021-04-08 Thread Alex Deucher
nction] > >941 | static void dm_dmub_trace_high_irq(void *interrupt_params) > >| ^~ > > > > Fixes: 83b39e1fc3ea ("drm/amd/display: Log DMCUB trace buffer events") > > Cc: Leo (Hanghong) Ma > > Cc: Daniel Wheeler &g

Re: [PATCH v1] drm/radeon: Fix a missing check bug in radeon_dp_mst_detect()

2021-04-08 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Apr 7, 2021 at 2:23 AM wrote: > > From: Yingjie Wang > > In radeon_dp_mst_detect(), We should check whether or not @connector > has been unregistered from userspace. If the connector is unregistered, > we should return disconnected status. > > Fixes: 9843ead08f18

[pull] amdgpu, radeon drm-next-5.13

2021-04-12 Thread Alex Deucher
o YCbCr420 when YCbCr444 fails - SR-IOV fixes - RAS updates - Misc cleanups and fixes radeon: - Typo fixes - Fix error handling for firmware on r6xx - Fix a missing check in DP MST handling ---- Alex Deucher (22): drm/amdgpu/displ

Re: [PATCH] efifb: Check efifb_pci_dev before using it

2021-04-13 Thread Alex Deucher
r efifb stays at PCI > D0") > BugLink: https://bugs.launchpad.net/bugs/1922403 > Signed-off-by: Kai-Heng Feng Reviewed-by: Alex Deucher > --- > drivers/video/fbdev/efifb.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/efi

Re: [PATCH] efifb: Check efifb_pci_dev before using it

2021-04-13 Thread Alex Deucher
On Tue, Apr 13, 2021 at 2:37 PM Daniel Vetter wrote: > > On Tue, Apr 13, 2021 at 8:02 PM Alex Deucher wrote: > > > > On Tue, Apr 13, 2021 at 1:05 PM Kai-Heng Feng > > wrote: > > > > > > On some platforms like Hyper-V and RPi4 with UEFI firmware, efifb

Re: [PATCH] drm/radeon/cik: remove set but not used variables

2021-04-15 Thread Alex Deucher
On Mon, Apr 12, 2021 at 11:26 PM Tian Tao wrote: > > The value of pipe_id and queue_id are not used under certain > circumstances, so just delete. > > Signed-off-by: Tian Tao Applied. Thanks! Alex > --- > drivers/gpu/drm/radeon/cik.c | 4 > 1 file changed, 4 deletions(-) > > diff --git

Re: [PATCH v2] drm/amdgpu: fix an error code in init_pmu_entry_by_type_and_add()

2021-04-15 Thread Alex Deucher
On Wed, Apr 14, 2021 at 1:59 AM Dan Carpenter wrote: > > If the kmemdup() fails then this should return a negative error code > but it currently returns success > > Fixes: b4a7db71ea06 ("drm/amdgpu: add per device user friendly xgmi events > for vega20") > Signed-off-by: Dan Carpenter Applied.

Re: [PATCH] drm/radeon/si: Fix inconsistent indenting

2021-04-15 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Apr 15, 2021 at 5:30 AM Yang Li wrote: > > Kernel test robot throws below warning -> > > smatch warnings: > drivers/gpu/drm/radeon/si.c:4514 si_vm_packet3_cp_dma_check() warn: > inconsistent indenting > > Fixed the inconsistent indenting. > > Reported-by: Abaci Rob

Re: [Regression] amdgpu driver broken on AMD HD7770 GHz edition.

2021-04-15 Thread Alex Deucher
On Fri, Apr 16, 2021 at 12:48 AM David Niklas wrote: > > Hey, > > I forgot to give you a bug tracker in case you want one. > Here: https://bugzilla.kernel.org/show_bug.cgi?id=212691 I've followed up on the bug report. Please take a look there. Alex > > Thanks, > David > ___

Re: 16 bpc fixed point (RGBA16) framebuffer support for core and AMD.

2021-04-20 Thread Alex Deucher
On Fri, Apr 16, 2021 at 12:29 PM Mario Kleiner wrote: > > Friendly ping to the AMD people. Nicholas, Harry, Alex, any feedback? > Would be great to get this in sooner than later. > No objections from me. Alex > Thanks and have a nice weekend, > -mario > > On Fri, Mar 19, 2021 at 10:03 PM Mario

Re: [PATCH 23/40] drm/ttm/ttm_bo: Fix incorrectly documented function 'ttm_bo_cleanup_refs'

2021-04-20 Thread Alex Deucher
On Fri, Apr 16, 2021 at 11:32 AM Christian König wrote: > > Am 16.04.21 um 16:37 schrieb Lee Jones: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/ttm/ttm_bo.c:293: warning: expecting prototype for > > function ttm_bo_cleanup_refs(). Prototype was for ttm_bo_cleanu

Re: [PATCH 26/40] drm/amd/amdgpu/amdgpu_device: Remove unused variable 'r'

2021-04-20 Thread Alex Deucher
: variable ‘r’ set > but not used [-Wunused-but-set-variable] > > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-

Re: [PATCH 25/40] drm/radeon/radeon_device: Provide function name in kernel-doc header

2021-04-20 Thread Alex Deucher
with '/**', but isn't a kernel-doc comment. Refer > > Documentation/doc-guide/kernel-doc.rst > > > > Cc: Alex Deucher > > Cc: "Christian König" > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: amd-...@lists.freedesktop.org

Re: [PATCH 29/40] drm/amd/amdgpu/amdgpu_fence: Provide description for 'sched_score'

2021-04-20 Thread Alex Deucher
er or member 'sched_score' not described in > > 'amdgpu_fence_driver_init_ring' > > > > Cc: Alex Deucher > > Cc: "Christian König" > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: Sumit Semwal > > Cc: J

Re: [PATCH 31/40] drm/amd/amdgpu/amdgpu_gart: Correct a couple of function names in the docs

2021-04-20 Thread Alex Deucher
gt; for amdgpu_dummy_page_init(). Prototype was for > > amdgpu_gart_dummy_page_init() instead > > drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c:96: warning: expecting prototype > > for amdgpu_dummy_page_fini(). Prototype was for > > amdgpu_gart_dummy_page_fini() instead >

Re: [PATCH 32/40] drm/amd/amdgpu/amdgpu_ttm: Fix incorrectly documented function 'amdgpu_ttm_copy_mem_to_mem()'

2021-04-20 Thread Alex Deucher
for amdgpu_copy_ttm_mem_to_mem(). Prototype was for > > amdgpu_ttm_copy_mem_to_mem() instead > > > > Cc: Alex Deucher > > Cc: "Christian König" > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: Sumit Semwal > > Cc: Jerome Glisse >

Re: [PATCH 33/40] drm/amd/amdgpu/amdgpu_ring: Provide description for 'sched_score'

2021-04-20 Thread Alex Deucher
t; or member 'sched_score' not described in 'amdgpu_ring_init' > > > > Cc: Alex Deucher > > Cc: "Christian König" > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: Sumit Semwal > > Cc: amd-...@lists.freedes

Re: [PATCH 35/40] drm/amd/amdgpu/amdgpu_cs: Repair some function naming disparity

2021-04-20 Thread Alex Deucher
/amdgpu/amdgpu_cs.c:1656: warning: expecting prototype > > for amdgpu_cs_find_bo_va(). Prototype was for amdgpu_cs_find_mapping() > > instead > > > > Cc: Alex Deucher > > Cc: "Christian König" > > Cc: David Airlie > > Cc: Daniel Ve

[pull] amdgpu drm-fixes-5.12

2021-04-21 Thread Alex Deucher
Hi Dave, Daniel, A few late fixes for 5.12. The following changes since commit 796b556cbfdbe0d65b9793e63653ad24f9fa033c: Merge tag 'vmwgfx-fixes-2021-04-14' of gitlab.freedesktop.org:zack/vmwgfx into drm-fixes (2021-04-18 09:27:00 +1000) are available in the Git repository at: https://git

Re: umn experiment patches fallout in drm

2021-04-21 Thread Alex Deucher
On Wed, Apr 21, 2021 at 2:58 PM Dave Airlie wrote: > > Looking at the umn.edu patches for drm in the last while, all the > refcount ones look bogus, > > 2020-06-13 20:48 -0500 Aditya Pakki o drm/nouveau: fix reference count > leak in nouveau_debugfs_strap_peek > 2020-06-13 20:22 -0500 Aditya Pakki

Re: [PULL] drm-misc-next-fixes

2021-04-22 Thread Alex Deucher
On Thu, Apr 22, 2021 at 12:33 PM Maxime Ripard wrote: > > Hi Dave, Daniel, > > Here's this week drm-misc-next-fixes PR, for the next merge window > Can we also cherry-pick this patch: https://cgit.freedesktop.org/drm/drm-misc/commit/?id=d510c88cfbb294d2b1e2d0b71576e9b79d0e2e83 It should have real

Re: [PATCH v1] drm/amd/dc: Fix a missing check bug in dm_dp_mst_detect()

2021-04-23 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Apr 8, 2021 at 9:01 PM wrote: > > From: Yingjie Wang > > In dm_dp_mst_detect(), We should check whether or not @connector > has been unregistered from userspace. If the connector is unregistered, > we should return disconnected status. > > Fixes: 4562236b3bc0 ("dr

Re: [PATCH] drm/amdgpu: Register VGA clients after init can no longer fail

2021-04-23 Thread Alex Deucher
On Wed, Apr 21, 2021 at 1:43 PM Kai-Heng Feng wrote: > > When an amdgpu device fails to init, it makes another VGA device cause > kernel splat: > kernel: amdgpu :08:00.0: amdgpu: amdgpu_device_ip_init failed > kernel: amdgpu :08:00.0: amdgpu: Fatal error during GPU init > kernel: amdgpu: p

Re: linux-next: build warning after merge of the amdgpu tree

2021-04-23 Thread Alex Deucher
On Wed, Apr 21, 2021 at 2:40 AM Stephen Rothwell wrote: > > Hi all, > > On Fri, 16 Apr 2021 12:40:44 +1000 Stephen Rothwell > wrote: > > > > After merging the amdgpu tree, today's linux-next build (powerpc > > ppc64_defconfig) produced this warning: > > > > drivers/pci/quirks.c: In function 'qui

[pull] amdgpu, radeon drm-next-5.13

2021-04-23 Thread Alex Deucher
e cleanups ---- Alex Deucher (1): drm/amdgpu/gmc9: remove dummy read workaround for newer chips Anthony Koo (3): drm/amd/display: [FW Promotion] Release 0.0.60 drm/amd/display: [FW Promotion] Release 0.0.61 drm/amd/display: [FW Promotion] Release 0.0.62 Antho

Re: [Mesa-dev] [RFC] Linux Graphics Next: Explicit fences everywhere and no BO fences - initial proposal

2021-04-27 Thread Alex Deucher
On Tue, Apr 27, 2021 at 1:35 PM Simon Ser wrote: > > On Tuesday, April 27th, 2021 at 7:31 PM, Lucas Stach > wrote: > > > > Ok. So that would only make the following use cases broken for now: > > > > > > - amd render -> external gpu > > > - amd video encode -> network device > > > > FWIW, "only"

Re: [Mesa-dev] [RFC] Linux Graphics Next: Explicit fences everywhere and no BO fences - initial proposal

2021-04-28 Thread Alex Deucher
On Wed, Apr 28, 2021 at 6:31 AM Christian König wrote: > > Am 28.04.21 um 12:05 schrieb Daniel Vetter: > > On Tue, Apr 27, 2021 at 02:01:20PM -0400, Alex Deucher wrote: > >> On Tue, Apr 27, 2021 at 1:35 PM Simon Ser wrote: > >>> On Tuesday, April 27th, 2021 at 7

Re: [Mesa-dev] [RFC] Linux Graphics Next: Explicit fences everywhere and no BO fences - initial proposal

2021-04-28 Thread Alex Deucher
21 um 14:26 schrieb Daniel Vetter: > > > > > On Wed, Apr 28, 2021 at 02:21:54PM +0200, Daniel Vetter wrote: > > > > > > On Wed, Apr 28, 2021 at 12:31:09PM +0200, Christian König wrote: > > > > > > > Am 28.04.21 um 12:05 schrieb Dani

Re: [PATCH v6 1/1] drm/drm_mst: Use Extended Base Receiver Capability DPCD space

2021-04-28 Thread Alex Deucher
+ dri-devel as well. On Wed, Apr 28, 2021 at 4:44 PM Nikola Cornij wrote: > > [why] > DP 1.4a spec madates that if DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is > set, Extended Base Receiver Capability DPCD space must be used. Without > doing that, the three DPCD values that differ will be wrong, lea

Re: [PATCH v2] drm/amdgpu: Register VGA clients after init can no longer fail

2021-04-28 Thread Alex Deucher
On Mon, Apr 26, 2021 at 6:50 AM Kai-Heng Feng wrote: > > When an amdgpu device fails to init, it makes another VGA device cause > kernel splat: > kernel: amdgpu :08:00.0: amdgpu: amdgpu_device_ip_init failed > kernel: amdgpu :08:00.0: amdgpu: Fatal error during GPU init > kernel: amdgpu: p

Re: [PULL] drm-misc-next-fixes

2021-04-28 Thread Alex Deucher
On Mon, Apr 26, 2021 at 3:35 AM Maxime Ripard wrote: > > Hi Alex, > > On Thu, Apr 22, 2021 at 12:40:10PM -0400, Alex Deucher wrote: > > On Thu, Apr 22, 2021 at 12:33 PM Maxime Ripard wrote: > > > > > > Hi Dave, Daniel, > > > > > > Here&

Re: [PATCH v2] drm/amd/pm/powerplay/hwmgr: Fix kernel-doc syntax in documentation

2021-04-28 Thread Alex Deucher
On Sat, Apr 24, 2021 at 6:19 PM Fabio M. De Francesco wrote: > > Fixed kernel-doc syntax errors in documentation of functions. > > Signed-off-by: Fabio M. De Francesco Applied. Thanks! Alex > --- > > Changes from v1: Reword both the subject and the log message > > drivers/gpu/drm/amd/pm/powe

Re: [PATCH] drm/amd/display: Remove condition which is always set to True

2021-04-28 Thread Alex Deucher
On Fri, Apr 23, 2021 at 4:57 PM Souptick Joarder wrote: > > Kernel test robot throws below warning -> > > >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:3015:53: > >> warning: address of 'aconnector->mst_port->mst_mgr' will always > >> evaluate to 'true' [-Wpointer-bool-con

Re: [PATCH] drm/amd/amdgpu: Fix errors in documentation of function parameters

2021-04-28 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Apr 23, 2021 at 7:38 AM Fabio M. De Francesco wrote: > > In the function documentation, I removed the excess parameters, > described the undocumented ones, and fixed the syntax errors. > > Signed-off-by: Fabio M. De Francesco > --- > drivers/gpu/drm/amd/amdgpu/am

Re: [PATCH] drm/amd/display: Fix build warnings

2021-04-28 Thread Alex Deucher
On Wed, Apr 21, 2021 at 12:18 PM Guenter Roeck wrote: > > Fix the following build warnings. > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: > In function ‘dm_update_mst_vcpi_slots_for_dsc’: > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:6242:46: > wa

Re: 16 bpc fixed point (RGBA16) framebuffer support for core and AMD.

2021-04-28 Thread Alex Deucher
On Tue, Apr 20, 2021 at 5:25 PM Alex Deucher wrote: > > On Fri, Apr 16, 2021 at 12:29 PM Mario Kleiner > wrote: > > > > Friendly ping to the AMD people. Nicholas, Harry, Alex, any feedback? > > Would be great to get this in sooner than later. > > > > No

Re: [git pull] drm for 5.13-rc1

2021-04-28 Thread Alex Deucher
On Wed, Apr 28, 2021 at 8:14 PM Mikita Lipski wrote: > > Hi Linus, > > The patch to fix the warning is here > (https://www.spinics.net/lists/amd-gfx/msg61614.html) > > I guess it just didn't propagate all the way to the release. > Can it still be pulled into 5.13-rc1 release? I'll include it in m

Re: [PATCH v2] drm/amd/amdgpu: Fix errors in documentation of function parameters

2021-04-29 Thread Alex Deucher
On Thu, Apr 29, 2021 at 2:44 AM Felix Kuehling wrote: > > On 2021-04-27 7:27, Fabio M. De Francesco wrote: > > In the documentation of functions, removed excess parameters, described > > undocumented ones, and fixed syntax errors. > > > > Signed-off-by: Fabio M. De Francesco > > --- > > > > Chang

Re: [PATCH] drm/radeon/dpm: Disable sclk switching when two 4K 60Hz monitors are connected

2021-04-29 Thread Alex Deucher
On Thu, Apr 29, 2021 at 9:40 AM Kai-Heng Feng wrote: > > Screen flickers rapidly when two 4K 60Hz monitors are connected to an > Oland card. This issue doesn't happen when one monitor is 4K 60Hz > (pixelclock 594MHz) and another one is 4K 30Hz (pixelclock 297MHz). > > The issue is gone after setti

Re: [PATCH v5 03/27] drm/amdgpu: Split amdgpu_device_fini into early and late

2021-04-29 Thread Alex Deucher
> > > Signed-off-by: Andrey Grodzovsky > > Acked-by: Christian König > > But Alex should acknowledge this as well since it is general driver design. Looks good to me as well. Reviewed-by: Alex Deucher > > Christian. > > > --- > >

Re: [PATCH v5 06/27] drm/amdgpu: Handle IOMMU enabled case.

2021-04-29 Thread Alex Deucher
On Wed, Apr 28, 2021 at 11:13 AM Andrey Grodzovsky wrote: > > Handle all DMA IOMMU gropup related dependencies before the > group is removed. > > v5: Drop IOMMU notifier and switch to lockless call to ttm_tt_unpopulate > > Signed-off-by: Andrey Grodzovsky > --- > drivers/gpu/drm/amd/amdgpu/amdgp

[pull] amdgpu drm-fixes-5.14

2021-08-04 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.14. The following changes since commit d28e2568ac26fff351c846bf74ba6ca5dded733e: Merge tag 'amd-drm-fixes-5.14-2021-07-28' of https://gitlab.freedesktop.org/agd5f/linux into drm-fixes (2021-07-29 17:20:29 +1000) are available in the Git repository at: https:/

Re: [PATCH v2] drm/radeon: Update pitch for page flip

2021-08-04 Thread Alex Deucher
; This refers to amdgpu's pageflip. > > v1->v2: > Update all of the pitch in all of the page_flip functions > in radeon rather than just the evergreen one. > > Cc: Alex Deucher > Cc: "Christian König" > Cc: "Pan, Xinhui" > C

Re: [PATCH] drm/amdgpu: drop redundant null-pointer checks in amdgpu_ttm_tt_populate() and amdgpu_ttm_tt_unpopulate()

2021-08-04 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Aug 4, 2021 at 2:49 AM Christian König wrote: > > Am 04.08.21 um 03:51 schrieb Tuo Li: > > The varialbe gtt in the function amdgpu_ttm_tt_populate() and > > amdgpu_ttm_tt_unpopulate() is guaranteed to be not NULL in the context. > > Thus the null-pointer checks are

Re: [git pull] drm fixes for 5.14-rc4

2021-08-05 Thread Alex Deucher
On Thu, Aug 5, 2021 at 2:14 PM Linus Torvalds wrote: > > This might possibly have been fixed already by the previous drm pull, > but I wanted to report it anyway, just in case. > > It happened after an uptime of over a week, so it might not be trivial > to reproduce. > > It's a NULL pointer derefe

Re: [PATCH v3] drm/radeon: Update pitch for page flip

2021-08-05 Thread Alex Deucher
; This refers to amdgpu's pageflip. > > v1->v2: > Update all of the pitch in all of the page_flip functions > in radeon rather than just the evergreen one. > > v2->v3: > Update pitch set method for r100 according to > radeon_legacy_crtc.c > > Cc: Alex Deuc

Re: [PATCH] drm/amd/pm: Fix a memory leak in an error handling path in 'vangogh_tables_init()'

2021-08-05 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Aug 5, 2021 at 2:44 PM Christophe JAILLET wrote: > > 'watermarks_table' must be freed instead 'clocks_table', because > 'clocks_table' is known to be NULL at this point and 'watermarks_table' is > never freed if the last kzalloc fails. > > Fixes: c98ee89736b8 ("drm

[pull] amdgpu drm-fixes-5.14

2021-08-05 Thread Alex Deucher
Hi Dave, Daniel, Same pull, more S-o-b. The following changes since commit d28e2568ac26fff351c846bf74ba6ca5dded733e: Merge tag 'amd-drm-fixes-5.14-2021-07-28' of https://gitlab.freedesktop.org/agd5f/linux into drm-fixes (2021-07-29 17:20:29 +1000) are available in the Git repository at:

Re: [PATCH] drm/amdgpu: check for allocation failure in amdgpu_vkms_sw_init()

2021-08-06 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Aug 6, 2021 at 11:09 AM Christian König wrote: > > Am 06.08.21 um 17:05 schrieb Dan Carpenter: > > Check whether the kcalloc() fails and return -ENOMEM if it does. > > > > Fixes: eeba0b9046fc ("drm/amdgpu: create amdgpu_vkms (v4)") > > Signed-off-by: Dan Carpenter

Re: [PATCH] drm/amd/display: Remove redundant initialization of variable eng_id

2021-08-06 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Aug 6, 2021 at 7:16 AM Colin King wrote: > > From: Colin Ian King > > The variable eng_id is being initialized with a value that is never > read, it is being re-assigned on the next statment. The assignment > is redundant and can be removed. > > Addresses-Coverity

[pull] amdgpu, amdkfd, radeon drm-next-5.15

2021-08-06 Thread Alex Deucher
el_queries ---- Alex Deucher (1): drm/amdgpu: don't enable baco on boco platforms in runpm Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.77 Aric Cyr (1): drm/amd/display: 3.2.147 Bing Guo (2): drm/amd/display: Fix Dynamic bpp issue with 8K

Re: [PATCH] drm/amd/display: use do-while-0 for DC_TRACE_LEVEL_MESSAGE()

2021-08-09 Thread Alex Deucher
suggest braces around empty body in an 'else' statement [-Wempty-body] > 113 | *state, retry_count); > > Fixes: b30eda8d416c ("drm/amd/display: Add ETW log to dmub_psr_get_state") > Signed-off-by: Randy Dunlap > Cc: Wyatt Wood

Re: [PATCH] drm/amdgpu: fix kernel-doc warnings on non-kernel-doc comments

2021-08-09 Thread Alex Deucher
-doc comment. Refer > Documentation/doc-guide/kernel-doc.rst > * This shader is used to clear the uninitiated sgprs after the above > > Fixes: 0e0036c7d13b ("drm/amdgpu: fix no full coverage issue for gprs > initialization") > Signed-off-by: Randy Du

Re: [PATCH] drm/amdgpu: Removed unnecessary if statement

2021-08-09 Thread Alex Deucher
On Mon, Aug 9, 2021 at 9:59 AM Sergio Miguéns Iglesias wrote: > > There was an "if" statement that did nothing so it was removed. > > Signed-off-by: Sergio Miguéns Iglesias Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 3 --- > 1 file changed, 3 deletions(-) > > diff

Re: [PATCH] drm/amd/display: remove variable backlight

2021-08-10 Thread Alex Deucher
On Mon, Aug 9, 2021 at 9:24 PM zhaoxiao wrote: > > The variable backlight is being initialized with a value that > is never read, it is being re-assigned immediately afterwards. I don't think this comment really matches the code. I think you can drop it. Alex > Clean up the code by removing th

Re: [Intel-gfx] [PATCH v2] fbdev/efifb: Release PCI device's runtime PM ref during FB destroy

2021-08-10 Thread Alex Deucher
On Tue, Aug 10, 2021 at 4:36 AM Imre Deak wrote: > > Hi Kai-Heng, Alex, > > could you add your ack if the fix looks ok and you're ok if I push it to > the i915 tree? > Acked-by: Alex Deucher > Thanks, > Imre > > On Mon, Aug 09, 2021 at 04:31:46PM +0300,

Re: [PATCH] Whitelist AMD host bridge device(s) to enable P2P DMA

2021-08-11 Thread Alex Deucher
On Wed, Aug 11, 2021 at 3:11 PM Ramesh Errabolu wrote: > > Current implementation will disallow P2P DMA if the participating > devices belong to different root complexes. Implementation allows > this default behavior to be overridden for whitelisted devices. The > patch adds an AMD host bridge to

Re: [PATCH] gpu: drm: amd: amdgpu: amdgpu_i2c: fix possible uninitialized-variable access in amdgpu_i2c_router_select_ddc_port()

2021-08-11 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Aug 11, 2021 at 7:35 AM Tuo Li wrote: > > The variable val is declared without initialization, and its address is > passed to amdgpu_i2c_get_byte(). In this function, the value of val is > accessed in: > DRM_DEBUG("i2c 0x%02x 0x%02x read failed\n", >addr,

Re: [PATCH 2/2] drm/amdgpu: Use mod_delayed_work in JPEG/UVD/VCE/VCN ring_end_use hooks

2021-08-11 Thread Alex Deucher
On Wed, Aug 11, 2021 at 12:52 PM Michel Dänzer wrote: > > From: Michel Dänzer > > In contrast to schedule_delayed_work, this pushes back the work if it > was already scheduled before. Specific behaviour change: > > Before: > > The scheduled work ran ~1 second after the first time ring_end_use was

Re: [PATCH] Whitelist AMD host bridge device(s) to enable P2P DMA

2021-08-11 Thread Alex Deucher
On Wed, Aug 11, 2021 at 4:50 PM Felix Kuehling wrote: > > > Am 2021-08-11 um 3:29 p.m. schrieb Alex Deucher: > > On Wed, Aug 11, 2021 at 3:11 PM Ramesh Errabolu > > wrote: > >> Current implementation will disallow P2P DMA if the participating > >> dev

[pull] amdgpu drm-fixes-5.14

2021-08-11 Thread Alex Deucher
3:06 -0400) amd-drm-fixes-5.14-2021-08-11: amdgpu: - Yellow carp update - RAS EEPROM fixes - BACO/BOCO fixes - Fix a memory leak in an error path - Freesync fix - VCN harvesting fix - Display fixes ---- Alex Deucher (2):

[pull] amdgpu, amdkfd drm-next-5.15

2021-08-13 Thread Alex Deucher
Alex Deucher (1): drm/amdgpu: handle VCN instances when harvesting (v2) Anson Jacob (1): drm/amd/display: use GFP_ATOMIC in amdgpu_dm_irq_schedule_work Anthony Koo (2): drm/amd/display: [FW Promotion] Release 0.0.78 drm/amd/display: 3.2.148 Ashley Thomas (1

Re: [PATCH] drm/radeon: Add break to switch statement in radeonfb_create_pinned_object()

2021-08-16 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Aug 16, 2021 at 3:23 AM Christian König wrote: > > Am 15.08.21 um 21:29 schrieb Nathan Chancellor: > > Clang + -Wimplicit-fallthrough warns: > > > > drivers/gpu/drm/radeon/radeon_fb.c:170:2: warning: unannotated > > fall-through between switch labels [-Wimplicit-fa

Re: [PATCH v3] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-16 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Aug 16, 2021 at 11:07 AM Michel Dänzer wrote: > > On 2021-08-16 2:06 p.m., Christian König wrote: > > Am 16.08.21 um 13:33 schrieb Lazar, Lijo: > >> On 8/16/2021 4:05 PM, Michel Dänzer wrote: > >>> From: Michel Dänzer > >>> > >>> schedule_delayed_work does not pus

Re: [PATCH][next] drm/amd/pm: Fix spelling mistake "firwmare" -> "firmware"

2021-08-17 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Aug 17, 2021 at 10:35 AM Colin King wrote: > > From: Colin Ian King > > There is a spelling mistake in a dev_err error message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 2 +- > 1 file changed, 1 insertion

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-18 Thread Alex Deucher
+ dri-devel Since scheduler is a shared component, please add dri-devel on all scheduler patches. On Wed, Aug 18, 2021 at 7:21 AM Jingwen Chen wrote: > > [Why] > for bailing job, this commit will delete it from pending list thus the > bailing job will never have a chance to be resubmitted even i

Re: [PATCH 2/5] drm: amdgpu: remove obsolete reference to config CHASH

2021-08-18 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Aug 18, 2021 at 8:41 AM Lukas Bulwahn wrote: > > Commit 04ed8459f334 ("drm/amdgpu: remove chash") removes the chash > architecture and its corresponding config CHASH. > > There is still a reference to CHASH in the config DRM_AMDGPU in > ./drivers/gpu/drm/Kconfig. >

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-18 Thread Alex Deucher
Applied. Let's see how long this one lasts :) Alex On Tue, Aug 17, 2021 at 4:23 AM Michel Dänzer wrote: > > From: Michel Dänzer > > schedule_delayed_work does not push back the work if it was already > scheduled before, so amdgpu_device_delay_enable_gfx_off ran ~100 ms > after the first time G

[pull] amdgpu, amdkfd drm-fixes-5.14

2021-08-18 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.14. The following changes since commit 7c60610d476766e128cc4284bb6349732cbd6606: Linux 5.14-rc6 (2021-08-15 13:40:53 -1000) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5.14-2021-08-18 for you to fe

  1   2   3   4   5   6   7   8   9   10   >