M Andrzej Hajda wrote:
>>
>> W dniu 31.03.2021 o 16:48, Doug Anderson pisze:
>>> Hi,
>>>
>>> On Wed, Mar 31, 2021 at 4:08 AM Andrzej Hajda wrote:
>>>> W dniu 30.03.2021 o 04:53, Douglas Anderson pisze:
>>>>> eDP panels won't p
Hi Jagan,
W dniu 09.08.2021 o 10:00, Jagan Teki pisze:
> Hi Andrzej,
>
> On Wed, Aug 4, 2021 at 7:48 PM a.hajda wrote:
>> Hi Maxime,
>>
>> I have been busy with other tasks, and I did not follow the list last
>> time, so sorry for my late response.
>>
>> On 28.07.2021 15:32, Maxime Ripard wrote:
Hi Maxime,
On 23.08.2021 10:47, Maxime Ripard wrote:
> Interactions between bridges, panels, MIPI-DSI host and the component
> framework are not trivial and can lead to probing issues when
> implementing a display driver. Let's document the various cases we need
> too consider, and the solution t
t;
> Reviewed-by: Sam Ravnborg
> Signed-off-by: Maxime Ripard
Reviewed-by: Andrzej Hajda
Regards
Andrzej
oval or when an error occurs, that device needs to be removed
> through a call to mipi_dsi_device_unregister().
>
> Let's create a device-managed variant of the registration function that
> will automatically unregister the device at unbind.
>
> Signed-off-by: Maxime Ripard
W dniu 23.08.2021 o 10:47, Maxime Ripard pisze:
> Signed-off-by: Maxime Ripard
Missing description.
With this fixed:
Reviewed-by: Andrzej Hajda
Regards
Andrzej
W dniu 23.08.2021 o 10:47, Maxime Ripard pisze:
> In order to avoid any probe ordering issue, the best practice is to move
> the secondary MIPI-DSI device registration and attachment to the
> MIPI-DSI host at probe time. Let's do this.
>
> Signed-off-by: Maxime Ripard
> ---
> drivers/gpu/drm/b
ncoder->bridge_chain, chain_node) {
> if (iter->funcs->pre_enable)
> iter->funcs->pre_enable(iter);
> +
> + if (iter == bridge)
> + break;
Looking at the bridge chaining code always makes me sick :) but beside
this the
e/disable/prepare/unprepare. Let's make use of this to simplify
> things a tiny bit.
>
> Signed-off-by: Douglas Anderson
> Reviewed-by: Robert Foss
> Reviewed-by: Bjorn Andersson
> Reviewed-by: Stephen Boyd
> Reviewed-by: Laurent Pinchart
Reviewed-by: Andrzej Hajda
Reg
W dniu 30.03.2021 o 04:53, Douglas Anderson pisze:
> A random comment inside a function had "/**" in front of it. That
> doesn't make sense. Remove.
>
> Signed-off-by: Douglas Anderson
Reviewed-by: Andrzej Hajda
Regards
Andrzej
> ---
>
> (no changes since
}
>
> + kfree(pdata->edid);
> +
> + ti_sn_debugfs_remove(pdata);
> +
> drm_bridge_remove(&pdata->bridge);
>
> + pm_runtime_disable(pdata->dev);
> +
> + of_node_put(pdata->host_node);
> +
Looks good.
Reviewed-by: An
W dniu 30.03.2021 o 04:53, Douglas Anderson pisze:
> The register() / attach() for MIPI happen in the bridge's
> attach(). That means that the inverse belongs in the bridge's
> detach().
As I commented in previous patch, it would be better to fix mipi/bridge
registration order in host and this
f again)
> when reading the EDID.
>
> Signed-off-by: Douglas Anderson
Reviewed-by: Andrzej Hajda
Regards
Andrzej
> ---
>
> (no changes since v1)
>
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/dr
W dniu 30.03.2021 o 04:53, Douglas Anderson pisze:
> If we just leave the detect() function as NULL then the upper layers
> assume we're always connected. There's no reason for a stub.
>
> Signed-off-by: Douglas Anderson
Reviewed-by: Andrzej Hajda
Regards
Andrzej
> ---
; Signed-off-by: Douglas Anderson
Reviewed-by: Andrzej Hajda
Regards
Andrzej
> ---
>
> (no changes since v1)
>
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 11 ---
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65d
W dniu 30.03.2021 o 04:53, Douglas Anderson pisze:
> Now that we have the patch ("drm/edid: Use the cached EDID in
> drm_get_edid() if eDP") we no longer need to maintain our own
> cache. Drop this code.
>
> Signed-off-by: Douglas Anderson
Reviewed-by: Andrze
W dniu 30.03.2021 o 04:53, Douglas Anderson pisze:
> eDP panels won't provide their EDID unless they're powered on. Let's
> chain a power-on before we read the EDID. This roughly matches what
> was done in 'parade-ps8640.c'.
>
> NOTE: The old code attempted to call pm_runtime_get_sync() before
> r
after
err_free_host_node label - of_node_put(NULL) does nothing.
> }
>
> of_node_put(port_node);
> + return 0;
>
> end:
> return ret;
This label and code can be removed, am I right?
After reading the body I know what the patch does
W dniu 31.03.2021 o 16:48, Doug Anderson pisze:
> Hi,
>
> On Wed, Mar 31, 2021 at 4:08 AM Andrzej Hajda wrote:
>>
>> W dniu 30.03.2021 o 04:53, Douglas Anderson pisze:
>>> eDP panels won't provide their EDID unless they're powered on. Let's
>&
Hi Dmitry,
W dniu 17.01.2021 o 01:23, Dmitry Baryshkov pisze:
> drm hotplug handling code (drm_client_dev_hotplug()) can wait on mutex,
> thus delaying further lt9611uxc IRQ events processing. It was observed
> occasionally during bootups, when drm_client_modeset_probe() was waiting
> for EDID re
d-off-by: Dmitry Baryshkov
> Fixes: 0cbbd5b1a012 ("drm: bridge: add support for lontium LT9611UXC bridge")
> Reviewed-by: Bjorn Andersson
Reviewed-by: Andrzej Hajda
Regards
Andrzej
___
dri-devel mailing list
dri-devel@lists.freedesktop
yshkov
> Fixes: 0cbbd5b1a012 ("drm: bridge: add support for lontium LT9611UXC bridge")
> Reviewed-by: Bjorn Andersson
Reviewed-by: Andrzej Hajda
Regards
Andrzej
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freed
rm: bridge: add support for lontium LT9611UXC bridge")
Reviewed-by: Andrzej Hajda
Let's wait till Monday for other comments, then I can queue the patchset.
Regards
Andrzej
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Allen,
Sorry for long delay.
W dniu 08.12.2020 o 11:58, allen pisze:
> This adds support for the iTE IT6505.
> This device can convert DPI signal to DP output.
>
> From: Allen Chen
> Signed-off-by: Jitao Shi
> Signed-off-by: Pi-Hsun Shih
> Signed-off-by: Yilun Lin
> Signed-off-by: Hermes W
W dniu 22.01.2021 o 10:34, Andrzej Hajda pisze:
> W dniu 22.01.2021 o 00:33, Dmitry Baryshkov pisze:
>> drm hotplug handling code (drm_client_dev_hotplug()) can wait on mutex,
>> thus delaying further lt9611uxc IRQ events processing. It was observed
>> occasionally
W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze:
> On Thu, Feb 4, 2021 at 8:07 PM Robert Foss wrote:
>> Hi Xin,
>>
>> Thanks for the patch.
>>
>> On Thu, 28 Jan 2021 at 12:17, Xin Ji wrote:
>>> Enable DSI EOTP feature for fixing some panel screen constance
>>> shift issue.
>>> Removing MIPI fla
eb 2021 17:33:14 +0100, Michael Tretter wrote:
>>>>> On Tue, 15 Sep 2020 21:40:40 +0200, Andrzej Hajda wrote:
>>>>>> W dniu 14.09.2020 o 23:19, Andrzej Hajda pisze:
>>>>>>> On 14.09.2020 22:01, Michael Tretter wrote:
>>>>>>>&
W dniu 19.01.2021 o 05:41, Jun Nie pisze:
> With commit 55c5cc63ab, the hdmi_codec_set_jack() will report unsupport
> failure if set_jack handler is missing. Add set_jack handler to resolve
> this failure.
>
> Signed-off-by: Jun Nie
> ---
> .../gpu/drm/bridge/adv7511/adv7511_audio.c| 27 +++
2021 at 06:19:22PM +0100, Daniel Vetter wrote:
>>>>> On Thu, Feb 4, 2021 at 5:28 PM Andrzej Hajda wrote:
>>>>>> W dniu 04.02.2021 o 17:05, Daniel Vetter pisze:
>>>>>>> On Thu, Feb 04, 2021 at 11:56:32AM +0100, Michael Tretter wrote:
>>>&
by: Nicolas Boichat
>> This looks good to me, it increases readability.
>>
>> Reviewed-by: Laurent Pinchart
>>
>> Please however see the end of the mail for a comment.
Reviewed-by: Andrzej Hajda
And comment at the end.
>>
>>> ---
>>> I consi
On 13.03.2022 20:45, Andi Shyti wrote:
Hi Andrzej,
I'm sorry, but I'm not fully understanding,
+struct intel_gt *intel_gt_sysfs_get_drvdata(struct device *dev,
+ const char *name)
+{
+ struct kobject *kobj = &dev->kobj;
+
+ /*
+*
wed-by: Matt Roper
---
Reviewed-by: Andrzej Hajda
Regards
Andrzej
- throttle_reason_thermal
- throttle_reason_prochot
- throttle_reason_ratl
- throttle_reason_vr_thermalert
- throttle_reason_vr_tdc
Signed-off-by: Sujaritha Sundaresan
Cc: Dale B Stimson
Signed-off-by: Andi Shyti
---
Reviewed-by: Andrzej Hajda
Regards
Andrzej
915.
Signed-off-by: Andi Shyti
Signed-off-by: Lucas De Marchi
Cc: Chris Wilson
Cc: Joonas Lahtinen
Cc: Matt Roper
Cc: Sujaritha Sundaresan
Cc: Tvrtko Ursulin
---
Reviewed-by: Andrzej Hajda
Regards
Andrzej
drivers/gpu/drm/i915/i915_sysfs.h| 3 +
scripts/extract-cert | Bin 0 -> 17952 bytes
With above removed.
Reviewed-by: Andrzej Hajda
Regards
Andrzej
lä
---
Reviewed-by: Andrzej Hajda
Regards
Andrzej
emcpy(&mode, E, S)
+ drm_mode_copy(&mode, E)
)
@@
struct drm_display_mode *mode;
@@
- &*mode
+ mode
Signed-off-by: Ville Syrjälä
---
Reviewed-by: Andrzej Hajda
Regards
Andrzej
On 17.02.2022 16:38, Eric Dumazet wrote:
On Thu, Feb 17, 2022 at 6:05 AM Andrzej Hajda wrote:
To improve readibility of ref_tracker printing following changes
have been performed:
- added display name for ref_tracker_dir,
- stack trace is printed indented, in the same printk call,
- total
On 17.02.2022 16:13, Eric Dumazet wrote:
On Thu, Feb 17, 2022 at 6:05 AM Andrzej Hajda wrote:
Library can be called in non-sleeping context, so it should not use
__GFP_NOFAIL. Instead it should calmly handle allocation fails, for
this __GFP_NOWARN has been added as well.
Your commit
On 17.02.2022 15:48, Ville Syrjälä wrote:
On Thu, Feb 17, 2022 at 03:04:38PM +0100, Andrzej Hajda wrote:
-static noinline depot_stack_handle_t
+static intel_wakeref_t
track_intel_runtime_pm_wakeref(struct intel_runtime_pm *rpm)
{
- depot_stack_handle_t stack, *stacks
On 17.02.2022 16:23, Eric Dumazet wrote:
On Thu, Feb 17, 2022 at 6:05 AM Andrzej Hajda wrote:
In cases references are taken alternately on multiple exec paths leak
report can grow substantially, sorting and grouping leaks by stack_handle
allows to compact it.
Signed-off-by: Andrzej Hajda
On 18.02.2022 11:03, Ville Syrjala wrote:
From: Ville Syrjälä
Add a variant of drm_mode_copy() that explicitly clears out
the list head of the destination mode. Helpful to guarantee
we don't have stack garbage left in there for on-stack modes.
Signed-off-by: Ville Syrjälä
---
drivers/gpu
emcpy(&mode, E, S)
+ drm_mode_copy(&mode, E)
)
@@
struct drm_display_mode *mode;
@@
- &*mode
+ mode
Cc: Andrzej Hajda
Cc: Neil Armstrong
Cc: Robert Foss
Cc: Laurent Pinchart
Cc: Jonas Karlman
Cc: Jernej Skrabec
Signed-off-by: Ville Syrjälä
Reviewed-by: Andrzej Hajda
Regards
A
On 18.02.2022 12:56, Ville Syrjälä wrote:
On Fri, Feb 18, 2022 at 12:22:44PM +0100, Andrzej Hajda wrote:
On 18.02.2022 11:03, Ville Syrjala wrote:
From: Ville Syrjälä
Add a variant of drm_mode_copy() that explicitly clears out
the list head of the destination mode. Helpful to guarantee
Hi,
On 16.02.2022 17:59, Dave Stevenson wrote:
Hi All
Hopefully I've cc'ed all those that have bashed this problem around previously,
or are otherwise linked to DRM bridges.
There have been numerous discussions around how DSI support is currently broken
as it doesn't support initialising the P
ds
Andrzej
Andrzej Hajda (6):
lib/ref_tracker: add unlocked leak print helper
lib/ref_tracker: __ref_tracker_dir_print improve printing
lib/ref_tracker: add printing to memory buffer
lib/ref_tracker: remove warnings in case of allocation failure
drm/i915: Correct type of wakeref variable
Dumazet
Signed-off-by: David S. Miller
Signed-off-by: Andrzej Hajda
---
include/linux/ref_tracker.h | 2 ++
lib/ref_tracker.c | 5 +
2 files changed, 7 insertions(+)
diff --git a/include/linux/ref_tracker.h b/include/linux/ref_tracker.h
index 60f3453be23e6..a443abda937d8 100644
--- a
-off-by: Andrzej Hajda
Reviewed-by: Chris Wilson
---
include/linux/ref_tracker.h | 8 +
lib/ref_tracker.c | 66 +
2 files changed, 46 insertions(+), 28 deletions(-)
diff --git a/include/linux/ref_tracker.h b/include/linux/ref_tracker.h
index
Dumazet
Signed-off-by: David S. Miller
Signed-off-by: Andrzej Hajda
---
include/linux/ref_tracker.h | 2 ++
lib/ref_tracker.c | 5 +
2 files changed, 7 insertions(+)
diff --git a/include/linux/ref_tracker.h b/include/linux/ref_tracker.h
index 60f3453be23e6..a443abda937d8 100644
--- a
a dedicated
refcount_t just for them.
Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller
Signed-off-by: Andrzej Hajda
---
include/linux/ref_tracker.h | 2 ++
lib/ref_tracker.c | 12 +++-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/include/linux
In cases references are taken alternately on multiple exec paths leak
report can grow substantially, sorting and grouping leaks by stack_handle
allows to compact it.
Signed-off-by: Andrzej Hajda
Reviewed-by: Chris Wilson
---
lib/ref_tracker.c | 35 +++
1 file
a dedicated
refcount_t just for them.
Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller
Signed-off-by: Andrzej Hajda
---
include/linux/ref_tracker.h | 2 ++
lib/ref_tracker.c | 12 +++-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/include/linux
Signed-off-by: David S. Miller
Signed-off-by: Andrzej Hajda
---
lib/ref_tracker.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/ref_tracker.c b/lib/ref_tracker.c
index 9c0c2e09df666..dc7b14aa3431e 100644
--- a/lib/ref_tracker.c
+++ b/lib/ref_tracker.c
@@ -89,7 +89,6 @@ int ref_tra
: Andrzej Hajda
Reviewed-by: Chris Wilson
---
include/linux/ref_tracker.h | 15 ---
lib/ref_tracker.c | 28 ++--
2 files changed, 34 insertions(+), 9 deletions(-)
diff --git a/include/linux/ref_tracker.h b/include/linux/ref_tracker.h
index b9c968a716483
In case one wants to show stats via debugfs.
Signed-off-by: Andrzej Hajda
Reviewed-by: Chris Wilson
---
include/linux/ref_tracker.h | 8 ++
lib/ref_tracker.c | 52 -
2 files changed, 54 insertions(+), 6 deletions(-)
diff --git a/include/linux
Signed-off-by: David S. Miller
Signed-off-by: Andrzej Hajda
---
lib/ref_tracker.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/ref_tracker.c b/lib/ref_tracker.c
index 9c0c2e09df666..dc7b14aa3431e 100644
--- a/lib/ref_tracker.c
+++ b/lib/ref_tracker.c
@@ -89,7 +89,6 @@ int ref_tra
time,
- print info about dropped references.
Signed-off-by: Andrzej Hajda
---
include/linux/ref_tracker.h | 15 +--
lib/ref_tracker.c | 90 -
2 files changed, 91 insertions(+), 14 deletions(-)
diff --git a/include/linux/ref_tracker.h b/include
-off-by: Andrzej Hajda
Reviewed-by: Chris Wilson
---
include/linux/ref_tracker.h | 8 +
lib/ref_tracker.c | 66 +
2 files changed, 46 insertions(+), 28 deletions(-)
diff --git a/include/linux/ref_tracker.h b/include/linux/ref_tracker.h
index
Library can be called in non-sleeping context, so it should not use
__GFP_NOFAIL. Instead it should calmly handle allocation fails, for
this __GFP_NOWARN has been added as well.
Signed-off-by: Andrzej Hajda
---
lib/ref_tracker.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions
From: Chris Wilson
Extract the callstack tracking of intel_runtime_pm.c into its own
utility so that that we can reuse it for other online debugging of
scoped wakerefs.
Signed-off-by: Chris Wilson
Reviewed-by: Andrzej Hajda
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/Kconfig.debug
In case one wants to show stats via debugfs.
Signed-off-by: Andrzej Hajda
Reviewed-by: Chris Wilson
---
include/linux/ref_tracker.h | 8 ++
lib/ref_tracker.c | 56 +++--
2 files changed, 56 insertions(+), 8 deletions(-)
diff --git a/include/linux
.
v2: Rebase from backporting wakeref leak (Umesh)
Signed-off-by: Chris Wilson
Reviewed-by: Andrzej Hajda
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/Kconfig.debug| 15 +++
.../gpu/drm/i915/gem/i915_gem_execbuffer.c| 7 ++--
.../i915/gem/selftests
Wakeref has dedicated type. Assumption it will be int
compatible forever is incorrect.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
b
Library can handle allocation failures. To avoid allocation warnings
__GFP_NOWARN has been added everywhere. Moreover GFP_ATOMIC has been
replaced with GFP_NOWAIT in case of stack allocation on tracker free
call.
Signed-off-by: Andrzej Hajda
---
lib/ref_tracker.c | 5 +++--
1 file changed, 3
From: Chris Wilson
Extract the callstack tracking of intel_runtime_pm.c into its own
utility so that that we can reuse it for other online debugging of
scoped wakerefs.
Signed-off-by: Chris Wilson
Reviewed-by: Andrzej Hajda
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/Kconfig.debug
Beside reusing existing code, the main advantage of ref_tracker is
tracking per instance of wakeref. It allows also to catch double
put.
On the other side we lose information about the first acquire and
the last release, but the advantages outweigh it.
Signed-off-by: Andrzej Hajda
Reviewed-by
.
v2: Rebase from backporting wakeref leak (Umesh)
Signed-off-by: Chris Wilson
Reviewed-by: Andrzej Hajda
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/Kconfig.debug| 15 +++
.../gpu/drm/i915/gem/i915_gem_execbuffer.c| 7 ++--
.../i915/gem/selftests
Wakeref has dedicated type. Assumption it will be int
compatible forever is incorrect.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
b
Beside reusing existing code, the main advantage of ref_tracker is
tracking per instance of wakeref. It allows also to catch double
put.
On the other side we lose information about the first acquire and
the last release, but the advantages outweigh it.
Signed-off-by: Andrzej Hajda
Reviewed-by
On 22.02.2022 00:16, Andrzej Hajda wrote:
Hi,
Appearance of ref_tracker library allows to drop custom solution for wakeref
tracking used in i915 and reuse the library.
For this few adjustements has been made to ref_tracker, details in patches.
I hope changes are OK for original author.
The
fixed mess with duplicated mails
Regards
Andrzej
Andrzej Hajda (6):
lib/ref_tracker: add unlocked leak print helper
lib/ref_tracker: __ref_tracker_dir_print improve printing
lib/ref_tracker: add printing to memory buffer
lib/ref_tracker: remove warnings in case of allocation failure
Dumazet
Signed-off-by: David S. Miller
Signed-off-by: Andrzej Hajda
---
include/linux/ref_tracker.h | 2 ++
lib/ref_tracker.c | 5 +
2 files changed, 7 insertions(+)
diff --git a/include/linux/ref_tracker.h b/include/linux/ref_tracker.h
index 60f3453be23e6..a443abda937d8 100644
--- a
a dedicated
refcount_t just for them.
Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller
Signed-off-by: Andrzej Hajda
---
include/linux/ref_tracker.h | 2 ++
lib/ref_tracker.c | 12 +++-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/include/linux
Signed-off-by: David S. Miller
Signed-off-by: Andrzej Hajda
---
lib/ref_tracker.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/ref_tracker.c b/lib/ref_tracker.c
index 9c0c2e09df666..dc7b14aa3431e 100644
--- a/lib/ref_tracker.c
+++ b/lib/ref_tracker.c
@@ -89,7 +89,6 @@ int ref_tra
-off-by: Andrzej Hajda
Reviewed-by: Chris Wilson
---
include/linux/ref_tracker.h | 8 +
lib/ref_tracker.c | 66 +
2 files changed, 46 insertions(+), 28 deletions(-)
diff --git a/include/linux/ref_tracker.h b/include/linux/ref_tracker.h
index
time,
- print info about dropped references.
Signed-off-by: Andrzej Hajda
---
include/linux/ref_tracker.h | 15 +--
lib/ref_tracker.c | 90 -
2 files changed, 91 insertions(+), 14 deletions(-)
diff --git a/include/linux/ref_tracker.h b/include
In case one wants to show stats via debugfs.
Signed-off-by: Andrzej Hajda
Reviewed-by: Chris Wilson
---
include/linux/ref_tracker.h | 8 ++
lib/ref_tracker.c | 56 +++--
2 files changed, 56 insertions(+), 8 deletions(-)
diff --git a/include/linux
.
v2: Rebase from backporting wakeref leak (Umesh)
Signed-off-by: Chris Wilson
Reviewed-by: Andrzej Hajda
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/Kconfig.debug| 15 +++
.../gpu/drm/i915/gem/i915_gem_execbuffer.c| 7 ++--
.../i915/gem/selftests
From: Chris Wilson
Extract the callstack tracking of intel_runtime_pm.c into its own
utility so that that we can reuse it for other online debugging of
scoped wakerefs.
Signed-off-by: Chris Wilson
Reviewed-by: Andrzej Hajda
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/Kconfig.debug
Library can handle allocation failures. To avoid allocation warnings
__GFP_NOWARN has been added everywhere. Moreover GFP_ATOMIC has been
replaced with GFP_NOWAIT in case of stack allocation on tracker free
call.
Signed-off-by: Andrzej Hajda
---
lib/ref_tracker.c | 5 +++--
1 file changed, 3
Wakeref has dedicated type. Assumption it will be int
compatible forever is incorrect.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
b
Beside reusing existing code, the main advantage of ref_tracker is
tracking per instance of wakeref. It allows also to catch double
put.
On the other side we lose information about the first acquire and
the last release, but the advantages outweigh it.
Signed-off-by: Andrzej Hajda
Reviewed-by
On 22.02.2022 08:12, Ville Syrjälä wrote:
On Tue, Feb 22, 2022 at 12:25:39AM +0100, Andrzej Hajda wrote:
-static noinline depot_stack_handle_t
+static intel_wakeref_t
track_intel_runtime_pm_wakeref(struct intel_runtime_pm *rpm)
{
- depot_stack_handle_t stack, *stacks
On 22.02.2022 01:08, Eric Dumazet wrote:
On Mon, Feb 21, 2022 at 3:26 PM Andrzej Hajda wrote:
To improve readibility of ref_tracker printing following changes
readability
have been performed:
- reports are printed per stack_handle - log is more compact,
- added display name for
On 22.02.2022 00:54, Eric Dumazet wrote:
On Mon, Feb 21, 2022 at 3:26 PM Andrzej Hajda wrote:
Library can handle allocation failures. To avoid allocation warnings
__GFP_NOWARN has been added everywhere. Moreover GFP_ATOMIC has been
replaced with GFP_NOWAIT in case of stack allocation on
On 22.02.2022 09:43, Dave Stevenson wrote:
Hi Laurent.
Thanks for the review.
On Tue, 22 Feb 2022 at 06:34, Laurent Pinchart
wrote:
Hi Dave,
Thank you for the patch.
On Wed, Feb 16, 2022 at 04:59:43PM +, Dave Stevenson wrote:
DSI sink devices typically want the DSI host powered up a
On 17.02.2022 15:41, Andi Shyti wrote:
From: Tvrtko Ursulin
On a multi-tile platform, each tile has its own registers + GGTT
space, and BAR 0 is extended to cover all of them.
Up to four GTs are supported in i915->gt[], with slot zero
shadowing the existing i915->gt0 to enable source compat
On 17.02.2022 15:41, Andi Shyti wrote:
With the upcoming multitile support each tile will have its own
local memory. Mark the current LMEM with the suffix '0' to
emphasise that it belongs to the root tile.
Suggested-by: Michal Wajdeczko
Signed-off-by: Andi Shyti
Reviewed-by: And
e
id var.
or just use it this way in this patch, with that:
Reviewed-by: Michal Wajdeczko
Accordingly:
Reviewed-by: Andrzej Hajda
Regards
Andrzej
static inline struct intel_gt *uc_to_gt(struct intel_uc *uc)
{
return container_of(uc, struct intel_gt, uc);
On 17.02.2022 15:41, Andi Shyti wrote:
Now that we have tiles we want each of them to have its own
interface. A directory "gt/" is created under "cardN/" that will
contain as many diroctories as the tiles.
In the coming patches tile related interfaces will be added. For
now the sysfs gt struc
+}
Merging handling "gt/gt#/*" and "power/*" attributes into the same
helpers seems unnatural to me, in many functions we have two branches
based on value of is_object_gt, with the most hacky
intel_gt_sysfs_get_drvdata.
Splitting handling these attributes would allow to drop fr
On 17.02.2022 15:41, Andi Shyti wrote:
Now tiles have their own sysfs interfaces under the gt/
directory. Because RPS is a property that can be configured on a
tile basis, then each tile should have its own interface
The new sysfs structure will have a similar layout for the 4 tile
case:
/sy
On 17.02.2022 15:41, Andi Shyti wrote:
From: Sujaritha Sundaresan
This patch adds the following new sysfs frequency attributes;
- punit_req_freq_mhz
- throttle_reason_status
- throttle_reason_pl1
- throttle_reason_pl2
- throttle_reason_pl4
- th
On 07.03.2022 00:04, Andi Shyti wrote:
Hi Andrzej,
[...]
+bool is_object_gt(struct kobject *kobj)
+{
+ return !strncmp(kobj->name, "gt", 2);
+}
It looks quite fragile, at the moment I do not have better idea:) maybe
after reviewing the rest of the patches.
yeah... it's not pretty, I
W dniu 31.08.2021 o 15:50, Cai Huoqing pisze:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing
Reviewed-by: Andrzej Hajda
Regards
Andrzej
Removed most CC: SMTP server protested.
On 01.09.2021 22:19, Douglas Anderson wrote:
> The goal of this patch series is to move away from hardcoding exact
> eDP panels in device tree files. As discussed in the various patches
> in this series (I'm not repeating everything here), most eDP panels
On 02.09.2021 01:10, Doug Anderson wrote:
> Hi,
>
> On Wed, Sep 1, 2021 at 2:12 PM Olof Johansson wrote:
>>
>> On Wed, Sep 1, 2021 at 1:20 PM Douglas Anderson
>> wrote:
>>>
>>> In the patch ("drm/panel-simple-edp: Split eDP panels out of
>>> panel-simple") we split the PANEL_SIMPLE driver in 2.
t know
what is going on, so let's add some diagnostic messages to gather info
and figure it out later'.
Whole driver lacks IRQ handler which IMO could perform better diagnosis,
and I guess it could also help in recovery, but this is just my guess.
So if this patch is enough for now you can add:
Reviewed-by: Andrzej Hajda
Regards
Andrzej
> }
>
> static void sn65dsi83_atomic_disable(struct drm_bridge *bridge,
>
W dniu 07.09.2021 o 16:25, Marek Vasut pisze:
> On 9/7/21 9:31 AM, Andrzej Hajda wrote:
>> On 07.09.2021 04:39, Marek Vasut wrote:
>>> In rare cases, the bridge may not start up correctly, which usually
>>> leads to no display output. In case this happens, warn abo
W dniu 08.09.2021 o 13:11, Dave Stevenson pisze:
> Hi Marek and Andrzej
>
> On Tue, 7 Sept 2021 at 22:24, Marek Vasut wrote:
>> On 9/7/21 7:29 PM, Andrzej Hajda wrote:
>>> W dniu 07.09.2021 o 16:25, Marek Vasut pisze:
>>>> On 9/7/21 9:31 AM, Andrzej Hajda wro
1 - 100 of 2435 matches
Mail list logo
