Re: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

2020-05-13 Thread Ashwin H
This patch fixes CVE-2018-20669 in 4.19 tree. On 13/05/20, 11:36 AM, "Greg KH" wrote: On Wed, May 13, 2020 at 07:19:21AM +0530, ashwin-h wrote: > From: Linus Torvalds > > commit 594cc251fdd0d231d342d88b2fdff4bc42fb0690 upstream. > >

RE: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

2020-05-13 Thread Ashwin H
> Ok, but what does that mean for us? > > You need to say why you are sending a patch, otherwise we will guess wrong. In drivers/gpu/drm/i915/i915_gem_execbuffer.c, ioctl functions does user_access_begin() without doing access_ok(Checks if a user space pointer is valid) first. A local

[PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

2020-05-12 Thread ashwin-h
. We have way too long a history of people trying to avoid them. Signed-off-by: Linus Torvalds Signed-off-by: Ashwin H --- arch/x86/include/asm/uaccess.h | 11 ++- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 15 +-- include/linux/uaccess.h

RE: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

2020-05-28 Thread Ashwin H
> -Original Message- > From: Greg KH > Sent: Wednesday, May 27, 2020 9:02 PM > To: Ashwin H > Cc: x...@kernel.org; dri-devel@lists.freedesktop.org; intel- > g...@lists.freedesktop.org; linux-ker...@vger.kernel.org; sta...@kernel.org; > Srivatsa Bhat ; sriva...@

RE: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

2020-05-28 Thread Ashwin H
> -Original Message- > From: Ashwin H > Sent: Thursday, May 28, 2020 1:01 PM > To: Greg KH > Cc: x...@kernel.org; dri-devel@lists.freedesktop.org; intel- > g...@lists.freedesktop.org; linux-ker...@vger.kernel.org; sta...@kernel.org; > Srivatsa Bhat ; sriva...@