Re: [PATCH 2/4] clk: samsung: Remove Exynos4415 driver (SoC not supported anymore)

2017-01-20 Thread Chanwoo Choi
he platform cannot be instantiated so remove also the drivers. >> >> Signed-off-by: Krzysztof Kozlowski <k...@kernel.org> > > Applied, thanks. > ___ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https

[PATCH 4/5] PM / devfreq: rockchip: add devfreq driver for rk3399 dmc

2016-09-02 Thread Chanwoo Choi
gned-off-by: Lin Huang >> Signed-off-by: MyngJoo Ham >> Reviewed-by: Chanwoo Choi >> --- > > [...] > >> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c >> new file mode 100644 >> index 000..54d65f2 >> --- /dev/null &

[PATCH 4/5] PM / devfreq: rockchip: add devfreq driver for rk3399 dmc

2016-09-05 Thread Chanwoo Choi
://www.spinics.net/lists/arm-kernel/msg528298.html Best Regards, Chanwoo Choi On 2016년 09월 02일 10:23, kbuild test robot wrote: > Hi Lin, > > [auto build test ERROR on next-20160825] > [also build test ERROR on v4.8-rc4] > [cannot apply to rockchip/for-next devfreq/for-rafael linus/master v

[PATCH 1/5] Documentation: bindings: add dt documentation for dfi controller

2016-09-02 Thread Chanwoo Choi
k used by the DFI, must be "pclk_ddr_mon"; > + > +Example: > + dfi: dfi at 0xff63 { > + reg = <0x00 0xff63 0x00 0x4000>; > + compatible = "rockchip,rk3399-dfi"; As I already commented, you need to reorder between compati

[PATCH 3/5] Documentation: bindings: add dt documentation for rk3399 dmc

2016-09-02 Thread Chanwoo Choi
compatible = "operating-points-v2"; > + > + opp00 { > + opp-hz = /bits/ 64 <3>; > + opp-microvolt = <90>; > + }; > + opp01 { > + opp-hz = /bits/ 64 <66600>; > + opp-microvolt = <90>; > + }; > + }; > + > + dmc: dmc { > + compatible = "rockchip,rk3399-dmc"; > + devfreq-events = <>; > + interrupts = ; > + clocks = < SCLK_DDRCLK>; > + clock-names = "dmc_clk"; > + operating-points-v2 = <_opp_table>; > + center-supply = <_centerlogic>; > + upthreshold = <15>; > + downdifferential = <10>; > + status = "disabled"; > + }; > + > -- Best Regards, Chanwoo Choi

[PATCH v9 3/5] Documentation: bindings: add dt documentation for rk3399 dmc

2016-09-05 Thread Chanwoo Choi
Hi Lin, Looks good to me. I add one comment on below. If you modify it according to my comment, feel free to add my tag. Reviewed-by: Chanwoo Choi On 2016년 09월 03일 06:08, Lin Huang wrote: > This patch adds the documentation for rockchip rk3399 dmc driver. > > Signed-off-by:

[PATCH v9 1/5] Documentation: bindings: add dt documentation for dfi controller

2016-09-05 Thread Chanwoo Choi
Hi Lin, Looks good to me. Acked-by: Chanwoo Choi Best Regards, Chanwoo Choi On 2016년 09월 03일 06:08, Lin Huang wrote: > This patch adds the documentation for rockchip dfi devfreq-event driver. > > Signed-off-by: Lin Huang > --- > Changes in v9: > - reorder

[PATCH v4 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-01-04 Thread Chanwoo Choi
Hi Hoegeun, I tested this patch on Exynos5433-TM2 board. It is well working Tested-by: Chanwoo Choi Regards, Chanwoo Choi On 2017년 01월 04일 15:58, Hoegeun Kwon wrote: > This patch add support for MIPI-DSI based S6E3HA2 AMOLED panel > driver. This panel has 1440x2560 resolution

[PATCH v5 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

2017-01-04 Thread Chanwoo Choi
Hi Hoegeun, I already tested this patch. But this patch does not include my tested-by tag. Tested-by: Chanwoo Choi Regards, Chanwoo Choi On 2017년 01월 04일 17:15, Hoegeun Kwon wrote: > This patch add support for MIPI-DSI based S6E3HA2 AMOLED panel > driver. This panel has 144

[PATCH v5 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board

2017-01-04 Thread Chanwoo Choi
Hi Hoegeun, I tested this patch. But this patch does not include my tested-by tag. Tested-by: Chanwoo Choi Regards, Chanwoo Choi On 2017년 01월 04일 17:15, Hoegeun Kwon wrote: > From: Hyungwon Hwang > > This patch add the panel device tree node for S6E3HA2 display > controlle

[PATCH v4 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board

2017-01-04 Thread Chanwoo Choi
Hi Hoegeun, On 2017년 01월 04일 15:58, Hoegeun Kwon wrote: > From: Hyungwon Hwang > > This patch add the panel device tree node for S6E3HA2 display > controller to TM2 dts. > > Signed-off-by: Hyungwon Hwang > Signed-off-by: Andrzej Hajda > Signed-off-by: Ch

Re: [PATCH 3/4] pinctrl: samsung: Remove support for Exynos4415 (SoC not supported anymore)

2017-01-16 Thread Chanwoo Choi
3 files changed, 78 deletions(-) Reviewed-by: Chanwoo Choi <cw00.c...@samsung.com> [snip] -- Best Regards, Chanwoo Choi S/W Center, Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/4] ARM: EXYNOS: Remove Exynos4415 driver (SoC not supported anymore)

2017-01-16 Thread Chanwoo Choi
he mach code. > > Signed-off-by: Krzysztof Kozlowski <k...@kernel.org> > --- > arch/arm/mach-exynos/Kconfig | 5 - > arch/arm/mach-exynos/exynos.c | 1 - > arch/arm/mach-exynos/suspend.c | 1 - > 3 files changed, 7 deletions(-) Reviewed-by: Chanwoo Choi <cw

Re: [PATCH 2/4] clk: samsung: Remove Exynos4415 driver (SoC not supported anymore)

2017-01-16 Thread Chanwoo Choi
; delete mode 100644 include/dt-bindings/clock/exynos4415.h Reviewed-by: Chanwoo Choi <cw00.c...@samsung.com> [snip] -- Best Regards, Chanwoo Choi S/W Center, Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v4 0/7] rk3399 support ddr frequency scaling

2016-08-01 Thread Chanwoo Choi
hes. Also, I want to test the build test. but, When I apply these patches, merge conflict happen. Could you give the information about base git repository? Regards, Chanwoo Choi > drivers/clk/rockchip/Makefile | 1 + > drivers/clk/rockchip/clk-ddr.c | 146 +

[PATCH v4 5/7] PM / devfreq: event: support rockchip dfi controller

2016-08-01 Thread Chanwoo Choi
Hi Lin, Because you remove the 'RFC' prefix on patch title, I think that you better to make the documentation as following: - Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt Regards, Chanwoo Choi On 2016년 07월 29일 16:56, Lin Huang wrote: > on rk3399 platform, there is

[PATCH v4 5/7] PM / devfreq: event: support rockchip dfi controller

2016-08-01 Thread Chanwoo Choi
Hi Lin, I add the one minor comment for full name of 'DRI'. On 2016년 08월 01일 16:41, Chanwoo Choi wrote: > Hi Lin, > > Because you remove the 'RFC' prefix on patch title, > I think that you better to make the documentation as following: > - Documentation/devicetree/binding

[PATCH v4 6/7] PM / devfreq: rockchip: add devfreq driver for rk3399 dmc

2016-08-01 Thread Chanwoo Choi
l letter for the first char. > + return ret; > + } > + > + /* > + * We add a devfreq driver to our parent since it has a device tree node > + * with operating points. > + */ You should wrap the rcu lock before calling the dev_pm_opp_of_add_table(). > + if (dev_pm_opp_of_add_table(dev)) { > + dev_err(dev, "Invalid operating-points in device tree.\n"); > + return -EINVAL; > + } > + of_property_read_u32(np, "upthreshold", > + >ondemand_data.upthreshold); > + of_property_read_u32(np, "downdifferential", > + >ondemand_data.downdifferential); Need one blank line. Maybe this code to get the properfy for ondemand governor, the devfreq will support in the future. > + data->rate = clk_get_rate(data->dmc_clk); > + rk3399_devfreq_dmc_profile.initial_freq = data->rate; Need one blank line. > + data->devfreq = devfreq_add_device(dev, > +_devfreq_dmc_profile, > +"simple_ondemand", > +>ondemand_data); > + if (IS_ERR(data->devfreq)) > + return PTR_ERR(data->devfreq); > + devfreq_register_opp_notifier(dev, data->devfreq); Use the devm_devfreq_register_opp_notifier(). > + > + data->dev = dev; > + platform_set_drvdata(pdev, data); > + > + return 0; > +} > + > +static int rk3399_dmcfreq_remove(struct platform_device *pdev) > +{ > + struct rk3399_dmcfreq *dmcfreq = platform_get_drvdata(pdev); > + > + devfreq_remove_device(dmcfreq->devfreq); > + regulator_put(dmcfreq->vdd_center); > + > + return 0; > +} > + > +static const struct of_device_id rk3399dmc_devfreq_of_match[] = { > + { .compatible = "rockchip,rk3399-dmc" }, > + { }, > +}; > + > +static struct platform_driver rk3399_dmcfreq_driver = { > + .probe = rk3399_dmcfreq_probe, > + .remove = rk3399_dmcfreq_remove, > + .driver = { > + .name = "rk3399-dmc-freq", > + .pm = _dmcfreq_pm, > + .of_match_table = rk3399dmc_devfreq_of_match, > + }, > +}; > +module_platform_driver(rk3399_dmcfreq_driver); > + > +MODULE_LICENSE("GPL v2"); > +MODULE_DESCRIPTION("RK3399 dmcfreq driver with devfreq framework"); You need to add the MODULE_AUTHOR information. Regards, Chanwoo Choi

[PATCH v4 5/7] PM / devfreq: event: support rockchip dfi controller

2016-08-01 Thread Chanwoo Choi
Hi Lin, On 2016년 08월 01일 17:27, hl wrote: > Hi Chanwoo Choi, > > On 2016年08月01日 16:08, Chanwoo Choi wrote: >> Hi Lin, >> >> I add the one minor comment for full name of 'DRI'. >> >> On 2016년 08월 01일 16:41, Chanwoo Choi wrote: >>

[PATCH v4 0/7] rk3399 support ddr frequency scaling

2016-08-01 Thread Chanwoo Choi
Hi Lin, On 2016년 08월 01일 16:46, hl wrote: > Hi Chanwoo Choi, > > Ah, i am base on > https://chromium.googlesource.com/chromiumos/third_party/kernel/v4.4, > and forget to rebase on > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git, i will > f

[PATCH v4 6/7] PM / devfreq: rockchip: add devfreq driver for rk3399 dmc

2016-08-02 Thread Chanwoo Choi
Hi Lin, On the next version, I'd like you to add the 'linux-pm at vger.kernel.org' because devfreq is a subsystem of power management. On 2016년 08월 02일 10:03, hl wrote: > Hi Chanwoo Choi, > > Thanks for reviewing so carefully. And i have some question: > > On 2016年0

[PATCH v4 6/7] PM / devfreq: rockchip: add devfreq driver for rk3399 dmc

2016-08-04 Thread Chanwoo Choi
Hi Lin, On 2016년 08월 03일 16:38, hl wrote: > > Hi Chanwoo Choi, > On 2016年08月02日 12:21, Chanwoo Choi wrote: >> Hi Lin, >> >> On the next version, I'd like you to add the 'linux-pm at vger.kernel.org' >> because devfreq is a subsystem of power ma

[v10 PATCH 0/5] Rockchip Type-C and DisplayPort driver

2016-08-10 Thread Chanwoo Choi
Is to support the notification > - extcon: Add EXTCON_DISP_DP and the property for USB Type-C The extcon patches are merged on extcon-next branch. So, you can check them on both extcon git and linux-next git repo. [snip] Regards, Chanwoo Choi

[PATCH v5 4/8] Documentation: bindings: add dt documentation for dfi controller

2016-08-10 Thread Chanwoo Choi
eg = <0x00 0xff63 0x00 0x4000>; > + compatible = "rockchip,rk3399-dfi"; Usually, the compatible is first entry within Device-tree node. > + rockchip,pmu = <>; > + clocks = < PCLK_DDR_MON>; > + clock-names = "pclk_ddr_mon"; > + status = "disabled"; > + }; > + > Looks good to me. Just I want to change the sequence between 'compatible' and 'reg' property. Acked-by: Chanwoo Choi Regards, Chawnoo Choi

[PATCH v5 6/8] Documentation: bindings: add dt documentation for rk3399 dmc

2016-08-10 Thread Chanwoo Choi
ot;dmc_clk"; > + ddr_timing = <_timing>; I think that you should add the detailed document for 'ddr_timing' because we don't understand the 'ddr_timing' easily , it depends on the trust firmware. > + operating-points-v2 = <_opp_table>; I think that you better to add the example of 'dmc_opp_table' in the documentation. > + center-supply = <_centerlogic>; > + upthreshold = <15>; > + downdifferential = <10>; > + status = "disabled"; > + }; > + > Regards, Chanwoo Choi

[PATCH v5 7/8] PM / devfreq: rockchip: add devfreq driver for rk3399 dmc

2016-08-10 Thread Chanwoo Choi
Hi Lin, I add the some comment on below. If you modify them, feel free to add the my reviewed tag on next version: Reviewed-by: Chanwoo Choi On 2016년 08월 10일 12:26, Lin Huang wrote: > base on dfi result, we do ddr frequency scaling, register > dmc driver to devfreq framework, a

[PATCH v5 8/8] drm/rockchip: Add dmc notifier in vop driver

2016-08-10 Thread Chanwoo Choi
Hi Lin, Looks good to me about the devfreq/devfreq-event usage. [Usage of the devfreq/devfreq-event APIs] Reviewed-by: Chanwoo Choi Regards, Chanwoo Choi On 2016년 08월 10일 12:26, Lin Huang wrote: > when in ddr frequency scaling process, vop can not do > enable or disable operation,

[PATCH v6 4/8] Documentation: bindings: add dt documentation for dfi controller

2016-08-17 Thread Chanwoo Choi
Hi Lin, I add the additional comment. On 2016년 08월 17일 09:31, Chanwoo Choi wrote: > Hi Lin, > > I add one minor comment. > > After fixing it, looks good to me. > Acked-by: Chanwoo Choi > > On 2016년 08월 17일 07:36, Lin Huang wrote: >> This patch adds

[PATCH v6 4/8] Documentation: bindings: add dt documentation for dfi controller

2016-08-17 Thread Chanwoo Choi
Hi Lin, I add one minor comment. After fixing it, looks good to me. Acked-by: Chanwoo Choi On 2016년 08월 17일 07:36, Lin Huang wrote: > This patch adds the documentation for rockchip dfi devfreq-event driver. > > Signed-off-by: Lin Huang > --- > Changes in v6: > -None

[PATCH v6 7/8] PM / devfreq: rockchip: add devfreq driver for rk3399 dmc

2016-08-17 Thread Chanwoo Choi
Hi Lin, I add just one comment to remove the blank line. On 2016년 08월 17일 07:36, Lin Huang wrote: > base on dfi result, we do ddr frequency scaling, register > dmc driver to devfreq framework, and use simple-ondemand > policy. > > Signed-off-by: Lin Huang > Reviewe

[PATCH v6 6/8] Documentation: bindings: add dt documentation for rk3399 dmc

2016-08-17 Thread Chanwoo Choi
by_idle = <0>; rockchip,dram_dll_dis_freq = <300>; rockchip,phy_dll_dis_freq = <125>; rockchip,ddr3_odt_dis_freq = <333>; rockchip,ddr3_drv = ; rockchip,ddr3_odt = ; rockchip,phy_ddr3_ca_drv = ; rockchip,phy_ddr3_dq_drv = ; rockchip,phy_ddr3_odt = ; rockchip,lpddr3_odt_dis_freq = <333>; rockchip,lpddr3_drv = ; rockchip,lpddr3_odt = ; rockchip,phy_lpddr3_ca_drv = ; rockchip,phy_lpddr3_dq_drv = ; rockchip,phy_lpddr3_odt = ; rockchip,lpddr4_odt_dis_freq = <333>; rockchip,lpddr4_drv = ; rockchip,lpddr4_dq_odt = ; rockchip,lpddr4_ca_odt = ; rockchip,phy_lpddr4_ca_drv = ; rockchip,phy_lpddr4_ck_cs_drv = ; rockchip,phy_lpddr4_dq_drv = ; rockchip,phy_lpddr4_odt = ; Regards, Chanwoo Choi

[RFC PATCH 3/4] PM / devfreq: rockchip: add devfreq driver for rk3399 dmc

2016-06-01 Thread Chanwoo Choi
know. I'll help you. Thanks, Chanwoo Choi On Wed, Jun 1, 2016 at 6:35 PM, Lin Huang wrote: > there is dfi controller on rk3399 platform, it can monitor > ddr load, register this controller to devfreq framework, and > default to use simple_ondeamnd policy, and do ddr frequency > scaling bas

[RFC PATCH v1 4/6] PM / devfreq: event: support rockchip dfi controller

2016-06-03 Thread Chanwoo Choi
Hi Lin, I add the some comment on below. If you modify it, You can add my acked-by tag. Looks good to me. Acked-by: Chanwoo Choi Also, I'd like you to add me to mail thread on next version because I'm supporter of devfreq-event. On 2016년 06월 03일 18:55, Lin Huang wrote: > on rk3

[RFC PATCH v2 6/6] drm/rockchip: Add dmc notifier in vop driver

2016-06-22 Thread Chanwoo Choi
_TRANSITION_NOTIFIER notifier" - https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=0fe3a66410a3ba96679be903f1e287d7a0a264a9 Thanks, Chanwoo Choi > > Signed-off-by: Lin Huang > --- > > Changes in v2: > - None > > Changes in v1: > - use wait

[RFC PATCH v2 6/6] drm/rockchip: Add dmc notifier in vop driver

2016-06-23 Thread Chanwoo Choi
Hi Lin, On 2016년 06월 22일 21:25, hl wrote: > Hi Chanwoo Choi, > > On 2016年06月22日 15:11, Chanwoo Choi wrote: >> Hi, >> >> On 2016년 06월 06일 19:13, Lin Huang wrote: >>> when in ddr frequency scaling process, vop can not do >>> enable o

[PATCH v3 6/7] PM / devfreq: rockchip: add devfreq driver for rk3399 dmc

2016-07-25 Thread Chanwoo Choi
, nb); > + > + return ret; > +} > + > +/** > + * dmc_unregister_notifier - unregister a driver from dmc chain > + * @nb: remove notifier function > + */ > +int dmc_unregister_notifier(struct notifier_block *nb) > +{ > + int ret; > + > + if (!nb) > + return -EINVAL; > + > + ret = blocking_notifier_chain_unregister(_notifier_list, nb); > + > + return ret; > +} > + > +/** > + * rockchip_dmc_get - Register the notifier block for the dmc chain. > + * @nb The dmc notifier block to register > + */ > +int rockchip_dmc_get(struct notifier_block *nb) > +{ > + if (!nb) > + return -EINVAL; > + > + mutex_lock(_en_lock); > + > + /* > + * if have two notifier(enable two vop etc), > + * need to disable dmc > + */ > + if (num_wait == 1 && num_disable <= 0) > + dmc_event(DMC_DISABLE); > + num_wait++; > + dmc_register_notifier(nb); > + mutex_unlock(_en_lock); > + > + return 0; > +} > + > +/** > + * rockchip_dmc_put - Remove the notifier block from the dmc chain. > + * @nb The dmc notifier block to unregister > + */ > +int rockchip_dmc_put(struct notifier_block *nb) > +{ > + if (!nb) > + return -EINVAL; > + > + mutex_lock(_en_lock); > + num_wait--; > + > + /* if notifier from 2 back to 1, enable dmc again */ > + if (num_wait == 1 && num_disable <= 0) > + dmc_event(DMC_ENABLE); > + dmc_unregister_notifier(nb); > + mutex_unlock(_en_lock); > + > + return 0; > +} > diff --git a/include/soc/rockchip/rockchip_dmc.h > b/include/soc/rockchip/rockchip_dmc.h > new file mode 100644 > index 000..3f69cbf > --- /dev/null > +++ b/include/soc/rockchip/rockchip_dmc.h > @@ -0,0 +1,45 @@ > +/* > + * Copyright (c) 2016, Fuzhou Rockchip Electronics Co., Ltd > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms and conditions of the GNU General Public License, > + * version 2, as published by the Free Software Foundation. > + * > + * This program is distributed in the hope it will be useful, but WITHOUT > + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for > + * more details. > + */ > + > +#ifndef __SOC_ROCKCHIP_DMC_H > +#define __SOC_ROCKCHIP_DMC_H > + > +#include > + > +#define DMC_ENABLE 0 > +#define DMC_DISABLE 1 > +#define DMCFREQ_ADJUST 2 > +#define DMCFREQ_FINISH 3 > + > +#if IS_ENABLED(CONFIG_ARM_ROCKCHIP_DMC_DEVFREQ) > +int rockchip_dmc_get(struct notifier_block *nb); > +int rockchip_dmc_put(struct notifier_block *nb); > +#else > +static inline int rockchip_dmc_get(struct notifier_block *nb) > +{ > + return 0; > +} > + > +static inline int rockchip_dmc_put(struct notifier_block *nb) > +{ > + return 0; > +} > +#endif > + > +void dmc_event(int event); > +int dmc_register_notifier(struct notifier_block *nb); > +int dmc_unregister_notifier(struct notifier_block *nb); > +void rockchip_dmc_enable(void); > +void rockchip_dmc_disable(void); > +bool rockchip_dmc_enabled(void); > +#endif > Regards, Chanwoo Choi

[PATCH v3 6/7] PM / devfreq: rockchip: add devfreq driver for rk3399 dmc

2016-07-25 Thread Chanwoo Choi
Hi Lin, On 2016년 07월 25일 17:47, hl wrote: > Hi Chanwoo Choi, > > On 2016年07月25日 14:01, Chanwoo Choi wrote: >> Hi Lin, >> >> I'm glad to support the for dmc ddr clock scaling with devfreq/devfreq-event. >> >> But, I think that you have to use

[PATCH v6 6/8] Documentation: bindings: add dt documentation for rk3399 dmc

2016-08-23 Thread Chanwoo Choi
Hi Lin, On 2016년 08월 22일 07:16, hl wrote: > Hi Chanwoo Choi, > > On 2016年08月17日 12:50, Chanwoo Choi wrote: >> Hi Lin, >> >> On 2016년 08월 17일 07:36, Lin Huang wrote: >>> This patch adds the documentation for rockchip rk3399 dmc driv

[PATCH v7 6/8] Documentation: bindings: add dt documentation for rk3399 dmc

2016-08-23 Thread Chanwoo Choi
Hi Lin, I reply the on v6 patch[1]. If you have another opinion, please let me know. If my suggestion is not reasonable, we need to discuss it. [1] https://lkml.org/lkml/2016/8/23/28 Best Regards, Chanwoo Choi On 2016년 08월 22일 12:36, Lin Huang wrote: > This patch adds the documentat

[PATCH v7 4/8] Documentation: bindings: add dt documentation for dfi controller

2016-08-23 Thread Chanwoo Choi
names = "pclk_ddr_mon"; > + status = "disabled"; > + }; > + > I reviewed this patch on previous version[1] already. [1] https://lkml.org/lkml/2016/8/16/913 There are minor requirement. If you modify it, I'll finish the review of this patch. -- Best Regards, Chanwoo Choi

Re: [PATCH v8 1/3] dt-bindings: Add support for samsung s6e3ha2 panel binding

2017-01-11 Thread Chanwoo Choi
t;human.hw...@samsung.com> > Signed-off-by: Hoegeun Kwon <hoegeun.k...@samsung.com> > Tested-by: Chanwoo Choi <cw00.c...@samsung.com> I think my tested-by tag is improper against binding documentation. Maybe you added the my tested-by tag when you split the panel driver because

Re: [PATCH] drm: exynos: Add runtime PM support to MIC driver

2017-01-11 Thread Chanwoo Choi
orm_device *pdev) > static int exynos_mic_remove(struct platform_device *pdev) > { > component_del(>dev, _mic_component_ops); > + pm_runtime_disable(>dev); > return 0; > } > > If this patch just notifies the status(enabled or disabled) of mic device with p

Re: [RFC PATCH 3/4] extcon: add possibility to get extcon device by of node

2017-10-18 Thread Chanwoo Choi
t; --- > drivers/extcon/extcon.c | 44 ++-- > include/linux/extcon.h | 6 ++ > 2 files changed, 40 insertions(+), 10 deletions(-) Looks good to me. Just I added the minor comment. Acked-by: Chanwoo Choi <cw00.c...@samsung.com> > > d

Re: [RFC PATCH 03/10] devfreq: rk3399_dmc: Pass ODT and auto power down parameters to TF-A.

2018-05-15 Thread Chanwoo Choi
ommented, it depend on only rk3399_dmc. You better to add detailed comment. And I prefer to define the XXX_SHIFT/XXX_MASK definition instead of using 8/16/0xff/0x for the readability. > /* >* We add a devfreq driver to our parent since it has a device tree node >*

Re: [RFC PATCH 02/10] dt-bindings: devfreq: rk3399_dmc: Add rockchip,pmu phandle.

2018-05-15 Thread Chanwoo Choi
DMC supply node. > - status: Marks the node enabled/disabled. > +- rockchip,pmu: Phandle to the syscon managing the "PMU > general register > + files". > > Optional properties: > - interrupts:

Re: [RFC PATCH 01/10] devfreq: rockchip-dfi: Move GRF definitions to a common place.

2018-05-15 Thread Chanwoo Choi
ic.balle...@collabora.com> > + */ > + > +#ifndef __SOC_RK3399_GRF_H > +#define __SOC_RK3399_GRF_H > + > +/* PMU GRF Registers */ > +#define RK3399_PMUGRF_OS_REG20x308 > +#define RK3399_PMUGRF_DDRTYPE_SHIFT 13 > +#define RK3399_PMUGRF_DDRTYPE_MAS

Re: [RFC PATCH 04/10] devfreq: rk3399_dmc / rockchip: pm_domains: Register notify to DMC driver.

2018-05-18 Thread Chanwoo Choi
u; > + > return 0; > > err_out: > diff --git a/include/soc/rockchip/rk3399_dmc.h > b/include/soc/rockchip/rk3399_dmc.h > new file mode 100644 > index ..031a62607f61 > --- /dev/null > +++ b/include/soc/rockchip/rk3399_dmc.h > @@ -0,0 +1,14 @@ > +/* SP

Re: [RFC PATCH 03/10] devfreq: rk3399_dmc: Pass ODT and auto power down parameters to TF-A.

2018-06-17 Thread Chanwoo Choi
Hi Enric 2018-06-16 19:15 GMT+09:00 Enric Balletbo Serra : > Hi Chanwoo, > > I'll send a new version soon, just wanted to ask some questions here. See > below. > > Missatge de Chanwoo Choi del dia dt., 15 de > maig 2018 a les 0:21: >> >> Hi, >> >> O

Re: [PATCH 4/8] devfreq: rk3399_dmc / clk: rockchip: Sync with vblank in the kernel for DDRfreq.

2018-08-02 Thread Chanwoo Choi
cannot develop the all device drivers with direct call function without standard subsystem interface. [A subsystem] - [B subsystem] | | [A device driver] - [B device driver] Regards, Chanwoo Choi On 2018년 07월 30일 17:11

Re: [PATCH 3/8] devfreq: rk3399_dmc: Pass ODT and auto power down parameters to TF-A.

2018-08-02 Thread Chanwoo Choi
ncy is lower than the on-die termination (ODT) disable frequency > this driver should disable the DDR ODT. > > Signed-off-by: Enric Balletbo i Serra Looks good to me. Reviewed-by: Chanwoo Choi > --- > > Changes in v1: > - [RFC 3/10] Add an explanation for platform

Re: [PATCH 1/8] devfreq: rockchip-dfi: Move GRF definitions to a common place.

2018-08-02 Thread Chanwoo Choi
alletbo i Serra > --- > > Changes in v1: > - [RFC 1/10] Add Acked-by: Chanwoo Choi Even if you add the changes log, you are missing my Acked-by tag. > - [RFC 1/10] s/Generic/General/ (Robin Murphy) > - [RFC 4/10] Removed from the series. I did not found a use case where not >

Re: [PATCH v5 0/6] dt-bindings: add bindings for USB physical connector

2018-03-07 Thread Chanwoo Choi
ztof will merge dts via > samsung-soc tree. > > Is it OK, for all? Better ideas? Krzysztof picked the dts patches. I'll make the immutable branch based on v4.16-rc1 and apply them except for dts patchs. And I'll send the immutable branch to Rob and Andrzej. -- Best Regards, Chanwoo Choi Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v5 0/6] dt-bindings: add bindings for USB physical connector

2018-03-07 Thread Chanwoo Choi
On 2018년 03월 07일 11:12, Chanwoo Choi wrote: > Hi Rob and Andrzej, > > On 2018년 03월 06일 21:53, Andrzej Hajda wrote: >> Hi Rob, Chanwoo, Krzysztof, >> >> >> On 27.02.2018 08:11, Andrzej Hajda wrote: >>> Hi, >>> >>> Thanks for reviews

Re: [PATCH v5 0/6] dt-bindings: add bindings for USB physical connector

2018-03-07 Thread Chanwoo Choi
Hi Andrzej, Archit, On 2018년 03월 07일 20:13, Andrzej Hajda wrote: > Hi Chanwoo, Archit, > > On 07.03.2018 05:48, Chanwoo Choi wrote: >> On 2018년 03월 07일 11:12, Chanwoo Choi wrote: >>> Hi Rob and Andrzej, >>> >>> On 2018년 03월 06일 21:53, Andrzej Ha

Re: [PATCH v5 0/6] dt-bindings: add bindings for USB physical connector

2018-03-13 Thread Chanwoo Choi
Hi Andrzej and Rob, On 2018년 03월 09일 18:20, Andrzej Hajda wrote: > Hi Chanwoo, > > On 08.03.2018 02:52, Chanwoo Choi wrote: >> Hi Andrzej, Archit, >> >> On 2018년 03월 07일 20:13, Andrzej Hajda wrote: >>> Hi Chanwoo, Archit, >>> >>> On 07.03.20

Re: [PATCH] drm/bridge/sii8620: add Kconfig dependency on extcon

2018-04-10 Thread Chanwoo Choi
C_CORE > select DRM_KMS_HELPER > + imply EXTCON > help > Silicon Image SII8620 HDMI/MHL bridge chip driver. > > Looks good to me. Reviewed-by: Chanwoo Choi <cw00.c...@samsung.com> -- Best Regards, Chanwoo Choi Samsung Electronics __

Re: [PATCH v5 6/6] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

2018-02-28 Thread Chanwoo Choi
Hi, On 2018년 02월 27일 21:05, Andrzej Hajda wrote: > On 27.02.2018 12:08, Chanwoo Choi wrote: >> Hi, >> >> On 2018년 02월 27일 16:11, Andrzej Hajda wrote: >>> From: Maciej Purski <m.pur...@samsung.com> >>> >>> Currently MHL chip must be turned

Re: [PATCH v5 6/6] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

2018-02-28 Thread Chanwoo Choi
get_clientdata(client); > > - disable_irq(to_i2c_client(ctx->dev)->irq); > - sii8620_hw_off(ctx); > + if (ctx->extcon) { > + extcon_unregister_notifier(ctx->extcon, EXTCON_DISP_MHL, > +

Re: [PATCH v5 5/6] extcon: add possibility to get extcon device by OF node

2018-02-28 Thread Chanwoo Choi
Hi, On 2018년 02월 27일 16:11, Andrzej Hajda wrote: > Since extcon property is not allowed in DT, extcon subsystem requires > another way to get extcon device. Lets try the simplest approach - get > edev by of_node. > > Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> >

Re: [PATCH v5 6/6] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

2018-03-02 Thread Chanwoo Choi
On 2018년 02월 28일 22:44, Andrzej Hajda wrote: > On 27.02.2018 23:26, Chanwoo Choi wrote: >> Hi, >> >> On 2018년 02월 27일 21:05, Andrzej Hajda wrote: >>> On 27.02.2018 12:08, Chanwoo Choi wrote: >>>> Hi, >>>> >>>> On 2018년 02

Re: [RFC PATCH 00/11] Simple QoS for exynos-bus driver using interconnect

2019-08-15 Thread Chanwoo Choi
tsi| 1 + > arch/arm/boot/dts/exynos4412.dtsi | 10 + > drivers/devfreq/exynos-bus.c | 296 ++ > drivers/gpu/drm/exynos/exynos_mixer.c | 68 +++- > drivers/interconnect/core.c | 12 +- > include/linux/interco

Re: [RFC PATCH 00/11] Simple QoS for exynos-bus driver using interconnect

2019-08-13 Thread Chanwoo Choi
Hi Artur, On 19. 8. 13. 오후 3:17, Chanwoo Choi wrote: > Hi Artur. > > The patch1-4 in this series depend on other patches[1] on mainline. > On next v2 version, please make some patches based on patches[1] > in order to prevent the merge conflict. > > [1] [RESEND PATC

Re: [RFC PATCH 09/11] devfreq: exynos-bus: Add interconnect functionality to exynos-bus

2019-08-19 Thread Chanwoo Choi
Hi Artur and Leonard, On 19. 8. 9. 오전 12:00, Leonard Crestez wrote: > On 29.07.2019 04:49, Chanwoo Choi wrote: >> On 19. 7. 23. 오후 9:20, Artur Świgoń wrote: >>> This patch adds interconnect functionality to the exynos-bus devfreq >>> driver. >>> >&g

Re: [PATCH RESEND] drm: Switch to use DEVFREQ_GOV_SIMPLE_ONDEMAND constant

2019-07-25 Thread Chanwoo Choi
NULL); > if (IS_ERR(pfdev->devfreq.devfreq)) { > DRM_DEV_ERROR(>pdev->dev, "Couldn't initialize GPU > devfreq\n"); > ret = PTR_ERR(pfdev->devfreq.devfreq); > The include/linux/devfreq.h defines the governor name. It looks good to me. Rev

Re: [RFC PATCH 01/11] devfreq: exynos-bus: Extract exynos_bus_profile_init()

2019-07-25 Thread Chanwoo Choi
t;failed to register opp notifier\n"); > - goto err; > - } > - > - /* > -* Enable devfreq-event to get raw data which is used to determine > -* current bus load. > -*/ > - ret = exynos_bus_enable_edev(bus); > - if (ret < 0) { > - dev_err(dev, "failed to enable devfreq-event devices\n"); > - goto err; > - } > - > - ret = exynos_bus_set_event(bus); > - if (ret < 0) { > - dev_err(dev, "failed to set event to devfreq-event > devices\n"); > - goto err; > - } > > goto out; > passive: > -- > 2.17.1 > NACK. It has not any benefit and I don't understand reason why it is necessary. I don't agree. Please drop it. -- Best Regards, Chanwoo Choi

Re: [RFC PATCH 02/11] devfreq: exynos-bus: Extract exynos_bus_profile_init_passive()

2019-07-25 Thread Chanwoo Choi
m_devfreq_add_device(dev, profile, > DEVFREQ_GOV_PASSIVE, > - passive_data); > - if (IS_ERR(bus->devfreq)) { > - dev_err(dev, > - "failed to add devfreq dev with passive governor\n"); > - ret = PTR_ERR(bus->devfreq); > - goto err; > - } > > out: > max_state = bus->devfreq->profile->max_state; > -- > 2.17.1 > Actually, it is not necessary. It has no any benefit. Please drop it as I commented on patch1. -- Best Regards, Chanwoo Choi

Re: [RFC PATCH 04/11] devfreq: exynos-bus: Clean up code

2019-07-25 Thread Chanwoo Choi
if (ret < 0) { > + if (ret < 0) > dev_err(dev, "failed to enable the devfreq-event devices\n"); > - return ret; > - } > > - return 0; > + return ret; > } > > static int exynos_bus_suspend(struct device *dev) > @@ -561,12 +558,10 @@ static int exynos_bus_suspend(struct device *dev) > int ret; > NACK. > ret = exynos_bus_disable_edev(bus); > - if (ret < 0) { > + if (ret < 0) > dev_err(dev, "failed to disable the devfreq-event devices\n"); > - return ret; > - } > > - return 0; > + return ret; > } > #endif > > -- > 2.17.1 > NACK. As I already commented, It has never any benefit. I think that it is not usful. Please drop it. -- Best Regards, Chanwoo Choi

Re: [RFC PATCH 03/11] devfreq: exynos-bus: Change goto-based logic to if-else logic

2019-07-25 Thread Chanwoo Choi
_passive(bus, profile); > - if (ret < 0) > - goto err; > - > -out: > max_state = bus->devfreq->profile->max_state; > min_freq = (bus->devfreq->profile->freq_table[0] / 1000); > max_freq = (bus->devfreq->profile->freq_table[max_state - 1] / 1000); > -- > 2.17.1 > It seems more simple than before. Instead, please merge patch1/2/3 to one patch. and drop the patch4. -- Best Regards, Chanwoo Choi

Re: [RFC PATCH 08/11] arm: dts: exynos: Add parents and #interconnect-cells to Exynos4412

2019-07-25 Thread Chanwoo Choi
}; > > @@ -491,6 +498,7 @@ > clocks = < CLK_ACLK100>; > clock-names = "bus"; > operating-points-v2 = <_peri_opp_table>; > + #interconnect-cells = <0>; > status = "disabled"; > }; > > @@ -499,6 +507,7 @@ > clocks = < CLK_SCLK_MFC>; > clock-names = "bus"; > operating-points-v2 = <_leftbus_opp_table>; > + #interconnect-cells = <0>; > status = "disabled"; > }; > > -- > 2.17.1 > -- Best Regards, Chanwoo Choi

Re: [RFC PATCH 03/11] devfreq: exynos-bus: Change goto-based logic to if-else logic

2019-07-25 Thread Chanwoo Choi
2019년 7월 25일 (목) 오후 9:56, Chanwoo Choi 님이 작성: > > 2019년 7월 24일 (수) 오전 8:08, Artur Świgoń 님이 작성: > > > > This patch improves code readability by changing the following construct: > > > > >if (cond) > > >goto passive; > > >f

Re: [RFC PATCH 04/11] devfreq: exynos-bus: Clean up code

2019-07-26 Thread Chanwoo Choi
On 19. 7. 26. 오후 7:45, Krzysztof Kozlowski wrote: > On Thu, 25 Jul 2019 at 14:51, Chanwoo Choi wrote: >> >> 2019년 7월 24일 (수) 오전 8:07, Artur Świgoń 님이 작성: >>> >>> This patch adds minor improvements to the exynos-bus driver. >>> >>> Signed-off-by

Re: [RFC PATCH 01/11] devfreq: exynos-bus: Extract exynos_bus_profile_init()

2019-07-26 Thread Chanwoo Choi
On 19. 7. 26. 오후 7:42, Krzysztof Kozlowski wrote: > On Thu, 25 Jul 2019 at 14:44, Chanwoo Choi wrote: >> >> 2019년 7월 24일 (수) 오전 8:09, Artur Świgoń 님이 작성: >>> >>> This patch adds a new static function, exynos_bus_profile_init(), extracted >>> from exynos

Re: [RFC PATCH 08/11] arm: dts: exynos: Add parents and #interconnect-cells to Exynos4412

2019-07-28 Thread Chanwoo Choi
Hi, On 19. 7. 26. 오후 9:02, Marek Szyprowski wrote: > Hi > > On 2019-07-25 15:13, Chanwoo Choi wrote: >> 2019년 7월 24일 (수) 오전 8:07, Artur Świgoń 님이 작성: >>> This patch adds two fields tp the Exynos4412 DTS: >>>- parent: to declare connections between nodes

Re: [RFC PATCH 09/11] devfreq: exynos-bus: Add interconnect functionality to exynos-bus

2019-07-28 Thread Chanwoo Choi
d(node, provider); > + > + ret = exynos_bus_icc_connect(bus); > + if (ret < 0) > + goto err_connect; > + > +out: > + return ret; > + > +err_connect: > + icc_node_del(node); > + icc_node_destroy(id); > +err_node: > + icc_provider_del(provider); > + > + return ret; > +} > + > static int exynos_bus_probe(struct platform_device *pdev) > { > struct device *dev = >dev; > @@ -517,6 +654,14 @@ static int exynos_bus_probe(struct platform_device *pdev) > goto err; > } > > + /* > + * Initialize interconnect provider. A return value of -ENOTSUPP means > + * that CONFIG_INTERCONNECT is disabled. > + */ > + ret = exynos_bus_icc_init(bus); > + if (ret < 0 && ret != -ENOTSUPP) > + goto err; > + > max_state = bus->devfreq->profile->max_state; > min_freq = (bus->devfreq->profile->freq_table[0] / 1000); > max_freq = (bus->devfreq->profile->freq_table[max_state - 1] / 1000); > -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [RFC PATCH 09/11] devfreq: exynos-bus: Add interconnect functionality to exynos-bus

2019-08-08 Thread Chanwoo Choi
wrote: > Hi, > > Thank you for your remarks. I will take them into account while preparing > RFCv2. > > On Mon, 2019-07-29 at 10:52 +0900, Chanwoo Choi wrote: >> Hi, >> >> On 19. 7. 23. 오후 9:20, Artur Świgoń wrote: >>> This patch adds interconnect funct