Re: DRM Error on Acer Aspire One

2010-05-11 Thread Chris Wilson
On Tue, 11 May 2010 10:48:18 -0400, Andrew Morton a...@linux-foundation.org wrote: On Tue, 11 May 2010 17:10:53 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, 11 May 2010 20:30:07 +0530, Jaswinder Singh Rajput jaswinderli...@gmail.com wrote: Hello, With latest

[PATCH] drm/i915: Record error batch buffers using iomem

2010-05-11 Thread Chris Wilson
Directly read the GTT mapping for the contents of the batch buffers rather than relying on possibly stale CPU caches. Also for completeness scan the flushing/inactive lists for the current buffers - we are collecting error state after all. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk

Re: DRM Error on Acer Aspire One

2010-05-11 Thread Chris Wilson
On Tue, 11 May 2010 12:10:01 -0700, Andrew Morton a...@linux-foundation.org wrote: On Tue, 11 May 2010 19:52:31 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, 11 May 2010 11:35:55 -0400, Andrew Morton a...@linux-foundation.org wrote: No, io_mapping_map_atomic_wc() cannot

[PATCH 1/4] drm/i915: Propagate error from drm_fb_helper_init().

2010-06-06 Thread Chris Wilson
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/intel_fb.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_fb.c b/drivers/gpu/drm/i915/intel_fb.c index dfbb0c6..c3c5052 100644 --- a/drivers/gpu/drm/i915

[PATCH 3/4] drm/nouveau: Propagate error from drm_fb_helper_init()

2010-06-06 Thread Chris Wilson
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/nouveau/nouveau_fbcon.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c index fd4a2df..c9a4a0d 100644

[PATCH 4/4] drm/radeon: Propagate error from drm_fb_helper_init()

2010-06-06 Thread Chris Wilson
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/radeon/radeon_fb.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c index e192acf..dc1634b 100644 --- a/drivers/gpu

Fair eviction for i915, based on Daniel's drm_mm scanner

2010-07-02 Thread Chris Wilson
This is a resend of Daniel Vetter's drm mm work to provide a basis for performing fair eviction in i915. I've taken the liberty of attaching the acks and review comments from the previous round, so please look over and check that they still hold true. drivers/gpu/drm/drm_mm.c|

[PATCH 01/11] drm: use list_for_each_entry in drm_mm.c

2010-07-02 Thread Chris Wilson
From: Daniel Vetter daniel.vet...@ffwll.ch Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Acked-by: Thomas Hellstrom thellst...@vmwgfx.com --- drivers/gpu/drm/drm_mm.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions

[PATCH 02/11] drm: kill drm_mm_node-private

2010-07-02 Thread Chris Wilson
From: Daniel Vetter daniel.vet...@ffwll.ch Only ever assigned, never used. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch [glisse: I will re-add if needed for range-restricted allocations] Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_gem.c |4

[PATCH 04/11] drm: sane naming for drm_mm.c

2010-07-02 Thread Chris Wilson
From: Daniel Vetter daniel.vet...@ffwll.ch Yeah, I've kinda noticed that fl_entry is the free stack. Still give it (and the memory node list ml_entry) decent names. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch Acked-by: Thomas Hellstrom thellst...@vmwgfx.com Signed-off-by: Chris Wilson ch

[PATCH 05/11] drm_mm: extract check_free_mm_node

2010-07-02 Thread Chris Wilson
-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/drm_mm.c | 71 ++ 1 files changed, 34 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c index d2267ff..fd86a6c 100644 --- a/drivers/gpu/drm/drm_mm.c

[PATCH 07/11] drm/i915: prepare for fair lru eviction

2010-07-02 Thread Chris Wilson
From: Daniel Vetter daniel.vet...@ffwll.ch This does two little changes: - Add an alignment parameter for evict_something. It's not really great to whack a carefully sized hole into the gtt with the wrong alignment. Especially since the fallback path is a full evict. - With the inactive

[PATCH 08/11] drm/i915: Use a common seqno for all rings.

2010-07-02 Thread Chris Wilson
This will be used by the eviction logic to maintain fairness between the rings. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_drv.h |3 +- drivers/gpu/drm/i915/i915_gem.c |2 + drivers/gpu/drm/i915/intel_ringbuffer.c | 46

[PATCH 09/11] drm/i915: Move the eviction logic to its own file.

2010-07-02 Thread Chris Wilson
The eviction code is the gnarly underbelly of memory management, and is clearer if kept separated from the normal domain management in GEM. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/Makefile |1 + drivers/gpu/drm/i915/i915_drv.h |6

[PATCH 10/11] drm/i915: Implement fair lru eviction across both rings.

2010-07-02 Thread Chris Wilson
- Hang when scrolling firefox page with window in front https://bugs.freedesktop.org/show_bug.cgi?id=24369 Bug 28478 - Intermittent graphics lockups due to overflow/loop https://bugs.freedesktop.org/show_bug.cgi?id=28478 Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu

[PATCH 11/11] drm/i915: Maintain LRU order of inactive objects upon access by CPU

2010-07-02 Thread Chris Wilson
the CPU objects from casual eviction, preferring to keep the GPU active for as long as possible. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_gem.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b

Re: [Intel-gfx] [PATCH 07/11] drm/i915: prepare for fair lru eviction

2010-07-02 Thread Chris Wilson
On Fri, 2 Jul 2010 15:02:17 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: From: Daniel Vetter daniel.vet...@ffwll.ch This does two little changes: - Add an alignment parameter for evict_something. It's not really great to whack a carefully sized hole into the gtt with the wrong

Re: [PATCH] drm/gem: Add new flink_to ioctl

2010-07-08 Thread Chris Wilson
-- Chris Wilson, Intel Open Source Technology Centre ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 3/3] agp/intel: Destroy the scatterlist on allocation failure

2010-07-24 Thread Chris Wilson
A side-effect of being able to use custom page allocations with the sg_table is that it cannot reap the partially constructed scatterlist if fails to allocate a page. So we need to call sg_free_table() ourselves if sg_alloc_table() fails. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc

[PATCH 1/3] drm: Cleanup after failing to create master-unique and dev-name

2010-07-24 Thread Chris Wilson
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/drm_ioctl.c | 73 -- 1 files changed, 55 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c index 9b9ff46..197267b 100644

[PATCH 2/3] drm: Free devname along with master-unique

2010-07-24 Thread Chris Wilson
[f8316665] drm_setversion+0x11d/0x1b1 [drm] [f83148d4] drm_ioctl+0x29a/0x356 [drm] [c04f27c4] vfs_ioctl+0x33/0x91 [c04f31cf] do_vfs_ioctl+0x46b/0x496 [c04f3240] sys_ioctl+0x46/0x66 [c040325f] sysenter_do_call+0x12/0x38 [] 0x Signed-off-by: Chris Wilson ch

Re: [PATCH 1/3] drm: Cleanup after failing to create master-unique and dev-name

2010-07-24 Thread Chris Wilson
On Sat, 24 Jul 2010 18:29:35 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk @@ -323,7 +358,9 @@ int drm_setversion(struct drm_device *dev, void *data, struct drm_file *file_pri

[PATCH] drm: Cleanup after failing to create master-unique and dev-name

2010-07-24 Thread Chris Wilson
to do so. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/drm_ioctl.c | 79 -- 1 files changed, 60 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c index 9b9ff46..f107fff 100644

Re: [patch] i915: take struct_mutex in i915_dma_cleanup()

2010-07-25 Thread Chris Wilson
is not empty, file a bug. [Of course this means having to compile kmemleak into the kernel. The DEBUG_KMEMLEAK option is found under Kernel Hacking.] And since each generation has slightly different initialization stanzas, we need to repeat the test on all platforms. -- Chris Wilson, Intel Open Source

Re: [Bugme-new] [Bug 16488] New: [i915] Framebuffer ID error after suspend/hibernate leading to X crash

2010-08-03 Thread Chris Wilson
/show_bug.cgi?id=16488 Innocuous-looking one-liner is said to have made Milan's X server even worse than normal. We go from a random OOPS to a consistent error (and a failing userspace). It sounds more likely that we have uncovered a real bug, probably in the ddx. -- Chris Wilson, Intel Open

[PATCH] drm: Cleanup after failing to create master-unique and dev-name

2010-08-04 Thread Chris Wilson
to do so. v3: Rebase to drm-core-next. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/drm_ioctl.c | 85 +-- 1 files changed, 66 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm

[PATCH] drm: Use ENOENT consistently for the error return for an unmatched handle.

2010-08-04 Thread Chris Wilson
-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/drm_gem.c |2 +- drivers/gpu/drm/i915/i915_gem.c| 26 +- drivers/gpu/drm/i915/i915_gem_tiling.c |4 ++-- drivers/gpu/drm/nouveau/nouveau_gem.c |8 drivers/gpu/drm

[PATCH 2/2] drm/i915: Record error batch buffers using iomem

2010-08-04 Thread Chris Wilson
Directly read the GTT mapping for the contents of the batch buffers rather than relying on possibly stale CPU caches. Also for completeness scan the flushing/inactive lists for the current buffers - we are collecting error state after all. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk

[PATCH 1/2] drm,io-mapping: Specify slot to use for atomic mappings

2010-08-04 Thread Chris Wilson
This is required should we ever attempt to use an io-mapping where KM_USER0 is verboten, such as inside an IRQ context. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Eric Anholt e...@anholt.net --- drivers/gpu/drm/i915/i915_gem.c|9 + drivers/gpu/drm/i915

Re: [PATCH] drm: Use ENOENT consistently for the error return for an unmatched handle.

2010-08-05 Thread Chris Wilson
!) -- Chris Wilson, Intel Open Source Technology Centre ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm: Only set DPMS once on the CRTC not after every encoder.

2010-08-06 Thread Chris Wilson
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/drm_crtc_helper.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c index 11fe9c8..7b1eb2f 100644 --- a/drivers/gpu/drm

[PATCH] drm: Propagate error code from fb_create()

2010-08-08 Thread Chris Wilson
Change the interface to expect a PTR_ERR specifing the real error code as opposed to assuming a NULL return = -EINVAL. Just once the user may not be at fault! Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/drm_crtc.c|4 ++-- drivers/gpu/drm/i915

[PATCH] drm/i915: Perform initial configuration asynchronously

2010-08-09 Thread Chris Wilson
It takes over 0.5s to probe the outputs and configure the i915 console. This can be performed in the background whilst the rest of the system is booting. Based on a patch by Arjan van de Van ar...@linux.intel.com Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Dave Airlie airl

Re: [PATCH] drm: Use global_mutex to serialise open/lastclose

2010-08-09 Thread Chris Wilson
On Sun, 8 Aug 2010 09:37:24 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: Dave Airlie: I might be missing something, but what stops the race with something reopening while we are in lastclose now? The global_mutex which appears to fill this role is only taken inside

[PATCH] drm: Remove count_lock for calling lastclose() after 58474713 (v2)

2010-08-11 Thread Chris Wilson
] system_call_fastpath+0x16/0x1b v2: The spinlock is actually superfluous as access to open_count is entirely serialised by drm_global_mutex and so can be dropped. The count_lock spinlock instead appears to be used to protect access to dev-buf_alloc and dev-buf_use. Signed-off-by: Chris Wilson ch...@chris

[PATCH] drm/kms: Add a module parameter to disable polling

2010-08-12 Thread Chris Wilson
. (The presumption being that all connections are probed in a single xrandr pass, which is currently valid.) References: Bug 29536 - 2.6.35 causes ~600ms latency every 10s https://bugs.freedesktop.org/show_bug.cgi?id=29536 Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Reported-and-tested-by: Bruno

Re: [REGRESSION] [2.6.36-rc1] [DRM INTEL] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for plane, expect flickering: entries required = 36, available = 28.

2010-08-18 Thread Chris Wilson
experiencing FIFO underruns, e.g. the screen flickering, then it is likely that the error is benign (and just wasting power). -- Chris Wilson, Intel Open Source Technology Centre ___ dri-devel mailing list dri-devel@lists.freedesktop.org http

[PATCH] vgaarb: Wrap vga_(get|put) in CONFIG_VGA_ARB

2010-08-19 Thread Chris Wilson
Fix link failure without the vga arbitrator. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Dave Airlie airl...@redhat.com Cc: Jesse Barnes jbar...@virtuousgeek.org --- include/linux/vgaarb.h | 15 +-- 1 files changed, 13 insertions(+), 2 deletions(-) diff --git

[PATCH] drm/kms: Add a module parameter to disable polling

2010-08-20 Thread Chris Wilson
://bugzilla.kernel.org/show_bug.cgi?id=16265 Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Reported-and-tested-by: Bruno Prémont bonb...@linux-vserver.org --- drivers/gpu/drm/drm_crtc_helper.c | 17 +++-- 1 files changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

Re: [PATCH] fix i915 compile in 2.6.36-rc2

2010-08-23 Thread Chris Wilson
-by: Meelis Roos mr...@linux.ee Acked-by: Chris Wilson ch...@chris-wilson.co.uk I have a pending patch to compile out this code when DEBUG_FS is not used which is the root cause of the compilation failure. That is a little more invasive than this simple patch... -- Chris Wilson, Intel Open Source

Re: [patch] i915: return -EFAULT if copy_to_user fails

2010-08-23 Thread Chris Wilson
On Wed, 23 Jun 2010 19:03:01 +0200, Dan Carpenter erro...@gmail.com wrote: copy_to_user() returns the number of bytes remaining to be copied and I'm pretty sure we want to return a negative error code here. Signed-off-by: Dan Carpenter erro...@gmail.com Reviewed-by: Chris Wilson ch...@chris

Re: [patch] i915: return -EFAULT if copy_to_user fails

2010-08-23 Thread Chris Wilson
Wilson ch...@chris-wilson.co.uk -- Chris Wilson, Intel Open Source Technology Centre ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [now bisected] i915: 2.6.36-rc2 hoses my Intel display

2010-08-23 Thread Chris Wilson
failed, ret=%d\n, ret); + return false; } #define SDVO_CMD_NAME_ENTRY(cmd) {cmd, #cmd} -- Chris Wilson, Intel Open Source Technology Centre ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [now bisected] i915: 2.6.36-rc2 hoses my Intel display

2010-08-23 Thread Chris Wilson
On Mon, 23 Aug 2010 17:32:25 -0600, Jonathan Corbet cor...@lwn.net wrote: On Mon, 23 Aug 2010 23:36:55 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: Taking the patch at face value, the cause should be a mistake in error handling. So the first step would be to identify which

Re: [REGRESSION, i915]: Periodic stalls with 2.6.36-rc2

2010-08-24 Thread Chris Wilson
is that the change to intel_wait_for_vblank() is actually causing issues here. -- Chris Wilson, Intel Open Source Technology Centre ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [REGRESSION, i915]: Periodic stalls with 2.6.36-rc2

2010-08-24 Thread Chris Wilson
On Tue, 24 Aug 2010 09:49:02 +0100, Sitsofe Wheeler sits...@yahoo.com wrote: On Tue, Aug 24, 2010 at 09:16:50AM +0100, Chris Wilson wrote: Ok, I'm a little happier that the hangcheck could be just another symptom of the problem... I think it is safe to assume that the bug is in i915

[PATCH] drm/i915/tv: Flush register writes before sleeping.

2010-08-24 Thread Chris Wilson
to the register prior to sleeping. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/intel_tv.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c index d2029ef..19b9739 100644

Re: [now bisected] i915: 2.6.36-rc2 hoses my Intel display

2010-08-24 Thread Chris Wilson
On Tue, 24 Aug 2010 07:16:26 -0600, Jonathan Corbet cor...@lwn.net wrote: On Tue, 24 Aug 2010 00:55:54 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: In threes. Hmm, one for primary, cursor and self-refresh. drm.debug=0xe would be interesting to see what the pixel clock is. Can

Re: [REGRESSION, i915]: Periodic stalls with 2.6.36-rc2

2010-08-26 Thread Chris Wilson
but is on the right lines. The first bug appears to be that in the driver we have multiple bits of code to set the panel backlight with different bugs. -- Chris Wilson, Intel Open Source Technology Centre ___ dri-devel mailing list dri-devel

[PATCH] drm: gem objects do not have a handle upon creation

2010-09-05 Thread Chris Wilson
that it was unecessary. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/drm_gem.c |1 - drivers/gpu/drm/nouveau/nouveau_gem.c |4 +--- drivers/gpu/drm/radeon/radeon_gem.c |3 +-- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm

[PATCH] drm: Fix regression in disable polling e58f637

2010-09-06 Thread Chris Wilson
performs the desired re-initialisation of the polling should the user have toggled the parameter, without the recursive side-effect. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Dave Airlie airl...@redhat.com --- drivers/gpu/drm/drm_crtc_helper.c |2 +- 1 files changed, 1

[PATCH] drm: Force a full mode set if the frame buffer depth changes.

2010-09-07 Thread Chris Wilson
As the crtc will need to be reconfigured if the framebuffer depth changes, we need to check for such a change during set_config(). Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/drm_crtc_helper.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git

[PATCH] drm: Use a nondestructive mode for output detect when polling

2010-09-09 Thread Chris Wilson
/show_bug.cgi?id=29536 Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=16265 Reported-by: Bruno Prémont bonb...@linux-vserver.org Tested-by: Sitsofe Wheeler sits...@yahoo.com Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: sta...@kernel.org --- drivers/gpu/drm/drm_crtc_helper.c

[PATCH] drm: Use a nondestructive mode for output detect when polling (v2)

2010-09-10 Thread Chris Wilson
instead. Much easier to type as well. ;-) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=29536 Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=16265 Reported-by: Bruno Prémont bonb...@linux-vserver.org Tested-by: Sitsofe Wheeler sits...@yahoo.com Signed-off-by: Chris Wilson ch...@chris

[PATCH] drm: Use a nondestructive mode for output detect when polling (v2)

2010-09-14 Thread Chris Wilson
v2: Julien Cristau pointed out that @nondestructive results in double-negatives and confusion when trying to interpret the parameter, so use @force instead. Much easier to type as well. ;-) And fix the miscompilation of vmgfx reported by Sedat Dilek. Signed-off-by: Chris Wilson ch...@chris

Re: [PATCH 2/4] drm/i915: Enable DisplayPort audio

2010-09-19 Thread Chris Wilson
; -- Chris Wilson, Intel Open Source Technology Centre ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 4/4] drm/i915: add new param to force audio on or off for HDMI/DP port

2010-09-19 Thread Chris Wilson
along the lines of a connector property for force_audio. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 4/4] drm/i915: add new param to force audio on or off for HDMI/DP port

2010-09-19 Thread Chris Wilson
On Sun, 19 Sep 2010 16:22:06 +0800, Zhenyu Wang zhen...@linux.intel.com wrote: On 2010.09.19 09:14:53 +0100, Chris Wilson wrote: On Sun, 19 Sep 2010 14:52:09 +0800, Zhenyu Wang zhen...@linux.intel.com wrote: Two reasons to add this param, one is for some AV device requiring HDMI input

Re: i915: glxgears causes GPU hang [was: mmotm 2010-09-22-16-11 uploaded]

2010-09-27 Thread Chris Wilson
correctly and failed to start. G33, this is likely to be https://bugzilla.kernel.org/show_bug.cgi?id=16891 -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org

[PATCH] drm: Prune GEM vma entries

2010-09-27 Thread Chris Wilson
Hook the GEM vm open/close ops into the generic drm vm open/close so that the vma entries are created and destroy appropriately. Reported-by: Matt Mackall m...@selenic.com Cc: Dave Airlie airl...@redhat.com Cc: Jesse Barnes jbar...@virtuousgeek.org Signed-off-by: Chris Wilson ch...@chris

[PATCH] drm: Prune GEM vma entries

2010-09-27 Thread Chris Wilson
Barnes jbar...@virtuousgeek.org Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Acked-by: Jesse Barnes jbar...@virtuousgeek.org Cc: sta...@kernel.org --- drivers/gpu/drm/drm_gem.c |9 - drivers/gpu/drm/drm_vm.c | 28 ++-- include/drm/drmP.h|1

Re: i915 blocked for more than 120 seconds.

2010-09-29 Thread Chris Wilson
the root cause. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm: Hold the mutex when dropping the last GEM reference

2010-09-29 Thread Chris Wilson
variant to take the dev-struct_mutex around the kref_put. Note that no driver is currently using the free_unlocked vfunc and it is scheduled for removal. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=30454 Reported-by: Magnus Kessler magnus.kess...@gmx.net Signed-off-by: Chris Wilson ch

Re: [PATCH] drm/gem: handlecount isnt really a kref so dont make it one.

2010-09-29 Thread Chris Wilson
it increase the normal object kref. Now i915/radeon/nouveau drivers can drop the normal reference on userspace object creation. Signed-off-by: Dave Airlie airl...@redhat.com Speaking as one who was recently confused by the not-a-kref nature of handlecount:- Reviewed-by: Chris Wilson ch...@chris

Re: i915 blocked for more than 120 seconds.

2010-09-29 Thread Chris Wilson
-detection on i8xx/i915). -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm: Hold the mutex when dropping the last GEM reference (v2)

2010-09-30 Thread Chris Wilson
and it is scheduled for removal, hasten that process. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=30454 Reported-by: Magnus Kessler magnus.kess...@gmx.net Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Dave Airlie airl...@redhat.com Cc: sta...@kernel.org --- drivers/gpu/drm/drm_gem.c | 22

[PATCH] drm: Move the GTT accounting to i915

2010-09-30 Thread Chris Wilson
Only drm/i915 does the bookkeeping that makes the information useful, and the information maintained is driver specific, so move it out of the core and into its single user. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Dave Airlie airl...@redhat.com --- drivers/gpu/drm/drm_debugfs.c

Re: [PATCH] drm: Hold the mutex when dropping the last GEM reference (v2)

2010-09-30 Thread Chris Wilson
On Thu, 30 Sep 2010 09:10:26 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: In order to be fully threadsafe we need to check that the drm_gem_object refcount is still 0 after acquiring the mutex in order to call the free function. Otherwise, we may encounter scenarios like: [snip

Re: [PATCH 3/4] drivers/gpu/drm/i915/i915_gem.c: Add missing error handling code

2010-10-02 Thread Chris Wilson
On Sat, 2 Oct 2010 15:59:17 +0200, Julia Lawall ju...@diku.dk wrote: Extend the error handling code with operations found in other nearby error handling code Thanks, your fix was correct. Applied. -Chris -- Chris Wilson, Intel Open Source Technology Centre

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use pipe state to tell when pipe is off

2010-10-03 Thread Chris Wilson
On Sun, 3 Oct 2010 00:33:06 -0700, Keith Packard kei...@keithp.com wrote: Instead of waiting for the display line value to settle, we can simply wait for the pipe configuration register 'state' bit to turn off. Thanks Keith, series applied to -fixes. -Chris -- Chris Wilson, Intel Open Source

Re: [Intel-gfx] [PATCH] drm/i915: mark display port DPMS state as ON when enabling output

2010-10-03 Thread Chris Wilson
sets the DPMS state to ON when the output is enabled. It appears that all users (crtc and encoders) are tracking dpms_mode, in one form or another. Should we move this to core? Is there any hardware that requires notification even when there is no change? -Chris -- Chris Wilson, Intel Open Source

Re: [Intel-gfx] [PATCH] drm/i915: avoid struct mutex output_poll mutex lock loop on unload

2010-10-04 Thread Chris Wilson
-- Chris Wilson, Intel Open Source Technology Centre ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH] intel: Listen for hotplug uevents (V2)

2010-10-04 Thread Chris Wilson
or disconnected. The obvious question: why are we doing this in the driver? It looks very generic and can be shared between any of the drm drivers, so should this be a facility provided by the server? It would be a good start to a KMS module... -Chris -- Chris Wilson, Intel Open Source Technology

Re: [Intel-gfx] [PATCH] drm/i915: mark display port DPMS state as ON when enabling output

2010-10-04 Thread Chris Wilson
On Sun, 03 Oct 2010 16:06:07 -0700, Keith Packard kei...@keithp.com wrote: On Sun, 03 Oct 2010 22:05:13 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: It appears that all users (crtc and encoders) are tracking dpms_mode, in one form or another. Should we move this to core? Sounds

Re: [PATCH] drm/i915: Free hardware status page on unload when physically mapped

2010-10-07 Thread Chris Wilson
which neatly pulls the call before the mmio teardown. Applied with the amendment to -next. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [PATCH 0/4] updated patches for KMS audio

2010-10-14 Thread Chris Wilson
current change. This fixed incorrect probe for DP monitor's audio. Fengguang helped to test this set. We got correct DP sound on Eizo EV2333W, and HDMI audio also worked with no regression found. Applied. Thanks for the reminder, Zhenyu. -Chris -- Chris Wilson, Intel Open Source Technology

Re: [PATCH 04/13] drivers: gpu: drm: i915: Fix a typo.

2010-10-15 Thread Chris Wilson
On Fri, 15 Oct 2010 17:14:33 +0200, Andrea Gelmini andrea.gelm...@gelma.net wrote: userpace - userspace Applied, I had noticed but it didn't annoy me to actually write a patch. Thanks, -Chris -- Chris Wilson, Intel Open Source Technology Centre

Re: BUG: pin_count exceeded in i915_gem_object_pin

2010-10-17 Thread Chris Wilson
pinned fb. I haven't gotten to the bottom of this entirely yet, in theory this should be fixed with the unpin fb added when disabling the connector in -next. I am not totally convinced that explains everything in this case though: https://bugs.freedesktop.org/show_bug.cgi?id=29857 -Chris -- Chris

Re: [patch] i915: fix impossible BUG_ON() test

2010-10-27 Thread Chris Wilson
On Wed, 27 Oct 2010 23:25:34 +0200, Dan Carpenter erro...@gmail.com wrote: obj_priv-pin_count is unsigned so the BUG_ON(obj_priv-pin_count 0) will never trigger. I have the same change pending, but not queued for -fixes since it is impossible. Thanks, -Chris -- Chris Wilson, Intel Open

Re: [patch] i915: signedness bug in check_overlay_src()

2010-10-27 Thread Chris Wilson
. Applied to fixes, thanks. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] i915: reprogram power monitoring registers on resume

2010-11-03 Thread Chris Wilson
to -fixes, thanks. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm: idr_find (drm_gem_object_lookup) needs only rcu read locks

2010-11-04 Thread Chris Wilson
... other mutation of the handle idr is still serialised using spin locks. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/drm_gem.c | 20 1 files changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm

Re: [PATCH] drm: idr_find (drm_gem_object_lookup) needs only rcu read locks

2010-11-08 Thread Chris Wilson
On Thu, 4 Nov 2010 10:09:53 +, Chris Wilson ch...@chris-wilson.co.uk wrote: /* Release reference and decrement refcount. */ idr_remove(filp-object_idr, handle); spin_unlock(filp-table_lock); + synchronize_rcu(); + This is an absolute performance killer. Looks

Re: i915 i2c driver problems (was: Re: [lm-sensors] hwmon/adt7470 crash on module load (2.6.37-rc1))

2010-11-09 Thread Chris Wilson
for input. Thanks, and Jean many thanks for the fixes! -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [git pull] drm fixes

2010-11-12 Thread Chris Wilson
in your tree? Just cherry-pick and be dammed? -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 0/9] make struct drm_mm_node embeddable

2010-11-12 Thread Chris Wilson
in that it couples the bo much more tightly with their allocations; to manage the bo is to manage those allocations. This aligns well with my review of the memory management for i915. Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk -Chris -- Chris Wilson, Intel Open Source Technology Centre

Re: [PATCH 0/9] make struct drm_mm_node embeddable

2010-11-14 Thread Chris Wilson
for this series here). [ /QUOTE ] Against which GIT tree or linux-next version are these patchset for? git://anongit.freedesktop.org/~danvet/drm direct-gtt -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ dri-devel mailing list dri

Re: bug report: potential integer overflow in validate_exec_list()

2010-11-21 Thread Chris Wilson
length, hence realistically capped at around 4k entries. However... Thanks, -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: bug report: potential integer overflow in validate_exec_list()

2010-11-22 Thread Chris Wilson
On Mon, 22 Nov 2010 12:56:42 +0300, Dan Carpenter erro...@gmail.com wrote: On Sun, Nov 21, 2010 at 09:23:46AM +, Chris Wilson wrote: Yes, it could. Not through normal use since relocation count can not be more than buffer length, hence realistically capped at around 4k entries. However

Re: [PATCH] MAINTAINERS: INTEL DRM DRIVERS list (intel-gfx) is subscribers-only

2010-11-24 Thread Chris Wilson
On Tue, 23 Nov 2010 22:36:42 -0800, Joe Perches j...@perches.com wrote: Mark it so. It was my mistake so I've applied this patch and will send upwards. Thanks, -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ dri-devel mailing list

[PATCH] drm: Replace kref with a simple atomic reference count

2010-11-25 Thread Chris Wilson
For a deferred-free cache of unreferenced bound objects, a simple reference count is required without the baggage of kref. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/drm_gem.c | 12 +++- drivers/gpu/drm/drm_info.c |2 +- include/drm/drmP.h

Re: [PATCH] drm: Replace kref with a simple atomic reference count

2010-11-25 Thread Chris Wilson
On Fri, 26 Nov 2010 08:38:29 +1000, Dave Airlie airl...@redhat.com wrote: On Thu, 2010-11-25 at 21:40 +, Chris Wilson wrote: For a deferred-free cache of unreferenced bound objects, a simple reference count is required without the baggage of kref. eh? The issue with kref

Re: [PATCH] drm: Set connector DPMS status to ON in drm_crtc_helper_set_config

2010-11-26 Thread Chris Wilson
and a future mode set that disables the specified connector will not turn the connector off. Signed-off-by: Keith Packard kei...@keithp.com Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/drm_crtc_helper.c |7 +++ 1 files changed, 7 insertions(+), 0

Re: [PATCH] drm: Set connector DPMS status to ON in drm_crtc_helper_set_config

2010-11-26 Thread Chris Wilson
Ah, having seen the bounce when replying, I now know why Dave didn't see these... I've pushed the two patches to git://people.freedesktop.org/~ickle/linux-2.6 for-airlied -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ dri-devel

[PATCH] drm: Add missing drm_vblank_put() along queue vblank error path

2010-12-01 Thread Chris Wilson
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Kristian Høgsberg k...@bitplanet.net Cc: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/drm_irq.c | 19 ++- 1 files changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu

[PATCH] drm: Don't try and disable an encoder that was never enabled

2010-12-06 Thread Chris Wilson
Prevents code that assumes that the encoder is active when asked to be disabled from dying a horrible death. Reported-by: Daniel Vetter daniel.vet...@ffwll.ch Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Dave Airlie airl...@redhat.com --- drivers/gpu/drm/drm_crtc_helper.c |2

Re: [Intel-gfx] [PATCH 2/2] drm: record monitor status in output_poll_execute

2010-12-08 Thread Chris Wilson
On Wed, 8 Dec 2010 17:34:24 +0100, Florian Mickler flor...@mickler.org wrote: Does that mean that the kernel regression will not be fixed/worked-around for old userspace? I think there is some confusion in that I believe there is more than one backlight bug at play here. -Chris -- Chris

Re: [PATCH] drm/i915/dp: Fix I2C/EDID handling with active DisplayPort to DVI converter

2010-12-08 Thread Chris Wilson
for AUX ACK. And it didn't break my bog standard DP setup. :) Applied to -fixes and tagged for stable. Thanks, -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ dri-devel mailing list dri-devel@lists.freedesktop.org http

[PATCH] glx: Refcnt the GLXDrawable to avoid use after free with multiple FreeResource

2010-12-10 Thread Chris Wilson
Although there may be more than one resource handles pointing to the Drawable, we only want to destroy it once and only reference the resource which may have just been deleted on the first instance. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Kristian Høgsberg k...@bitplanet.net Cc

[PATCH] glx: Refcnt the GLXDrawable to avoid use after free with multiple FreeResource

2010-12-10 Thread Chris Wilson
://bugs.freedesktop.org/show_bug.cgi?id=28181 Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Kristian Høgsberg k...@bitplanet.net Cc: Michel Dänzer daen...@vmware.com --- glx/glxcmds.c | 23 +++ glx/glxdrawable.h |3 +++ glx/glxext.c | 15 ++- 3 files changed

  1   2   3   4   5   6   7   8   9   10   >