RE: [PATCH v6] drm/kmb: Add support for KeemBay Display

2020-08-31 Thread Chrisanthus, Anitha
Hi Sam, Thanks a lot for the review. I will address your comments in v7. For those that are not addressed, please see my reply inline. Regards, Anitha > -Original Message- > From: Sam Ravnborg > Sent: Thursday, August 20, 2020 1:10 PM > To: Chrisanthus, Anitha >

RE: [PATCH v7 0/4] Add support for KeemBay DRM driver

2020-09-10 Thread Chrisanthus, Anitha
0 1:42 AM > To: Chrisanthus, Anitha > Cc: dri-devel@lists.freedesktop.org; Paauwe, Bob J > ; Dea, Edmund J ; > Vetter, Daniel > Subject: Re: [PATCH v7 0/4] Add support for KeemBay DRM driver > > On Mon, Aug 31, 2020 at 01:02:48PM -0700, Anitha Chrisanthus wrote: > >

RE: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-09-11 Thread Chrisanthus, Anitha
> -Original Message- > From: Neil Armstrong > Sent: Thursday, September 10, 2020 2:33 AM > To: Chrisanthus, Anitha ; dri- > de...@lists.freedesktop.org; Paauwe, Bob J ; > Dea, Edmund J > Cc: Vetter, Daniel > Subject: Re: [PATCH v7 2/4] drm/kmb: Add support for KeemB

RE: [PATCH v1] dt-bindings: display: Add support for Intel KeemBay Display

2020-10-06 Thread Chrisanthus, Anitha
Hi Rob, Thanks for the your prompt review. Please see my comments/questions inline. For everything else, I can incorporate the changes in v2. Anitha > -Original Message- > From: Rob Herring > Sent: Tuesday, October 6, 2020 2:08 PM > To: Chrisanthus, Anitha &

RE: [PATCH v8 1/4] drm/kmb: Keem Bay driver register definition

2020-10-07 Thread Chrisanthus, Anitha
> -Original Message- > From: Rob Herring > Sent: Wednesday, October 7, 2020 6:45 AM > To: Chrisanthus, Anitha > Cc: dri-devel ; Paauwe, Bob J > ; Dea, Edmund J ; > Vetter, Daniel ; Sam Ravnborg > > Subject: Re: [PATCH v8 1/4] drm/kmb: Keem Bay driver regi

RE: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-10-05 Thread Chrisanthus, Anitha
> -Original Message- > From: Daniel Vetter > Sent: Monday, October 5, 2020 6:49 AM > To: Chrisanthus, Anitha > Cc: Daniel Vetter ; dri-devel@lists.freedesktop.org; > Paauwe, Bob J ; Dea, Edmund J > ; Vetter, Daniel > Subject: Re: [PATCH v7 2/4] drm/kmb: Add sup

RE: [PATCH v9 1/5] dt-bindings: display: Add support for Intel KeemBay Display

2020-10-12 Thread Chrisanthus, Anitha
Hi Neil, Thanks for your review, please see my reply inline. > -Original Message- > From: Neil Armstrong > Sent: Friday, October 9, 2020 2:10 AM > To: Chrisanthus, Anitha ; dri- > de...@lists.freedesktop.org; devicet...@vger.kernel.org; Vetter, Daniel > >

RE: [PATCH v9 1/5] dt-bindings: display: Add support for Intel KeemBay Display

2020-10-09 Thread Chrisanthus, Anitha
> -Original Message- > From: Neil Armstrong > Sent: Friday, October 9, 2020 2:10 AM > To: Chrisanthus, Anitha ; dri- > de...@lists.freedesktop.org; devicet...@vger.kernel.org; Vetter, Daniel > > Cc: Dea, Edmund J ; s...@ravnborg.org > Subject: Re: [PATCH v9 1

RE: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-09-22 Thread Chrisanthus, Anitha
> Sent: Thursday, September 10, 2020 1:31 AM > To: Chrisanthus, Anitha > Cc: dri-devel@lists.freedesktop.org; Paauwe, Bob J > ; Dea, Edmund J ; > Vetter, Daniel > Subject: Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display > > On Mon, Aug 31, 2020 at 01:02:50PM -

RE: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-10-01 Thread Chrisanthus, Anitha
() is taking too long sometimes. I can work on this after we merge. Will send out V8 with the minor changes and device tree YAML binding file ASAP. Will work on the rest of the review comments after. Thanks, Anitha > From: Daniel Vetter > Sent: Thursday, September 10, 2020 1:31 AM > To: Ch

RE: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-10-02 Thread Chrisanthus, Anitha
> -Original Message- > From: Daniel Vetter > Sent: Friday, October 2, 2020 2:19 AM > To: Chrisanthus, Anitha > Cc: dri-devel@lists.freedesktop.org; Paauwe, Bob J > ; Dea, Edmund J ; > Vetter, Daniel > Subject: Re: [PATCH v7 2/4] drm/kmb: Add support for Kee

RE: [Intel-gfx] [PATCH v2 00/59] Add support for KeemBay DRM driver

2020-07-15 Thread Chrisanthus, Anitha
Hi Sam and Daniel, Thank you very much for reviewing the code. I will squish all the commits and send version 3, so it will be easier for you to review. Anitha > -Original Message- > From: Sam Ravnborg > Sent: Wednesday, July 15, 2020 10:07 AM > To: Daniel Vetter >

RE: [PATCH 00/59] Add support for Keem Bay DRM driver

2020-07-01 Thread Chrisanthus, Anitha
Thanks much Sam for reviewing the code so quickly. I'll address your reviews in v2. Anitha > -Original Message- > From: Sam Ravnborg > Sent: Wednesday, July 1, 2020 12:01 AM > To: Chrisanthus, Anitha > Cc: dri-devel@lists.freedesktop.org; Paauwe, Bob J ; > Dea,

RE: [PATCH v2] drm/kmb: Fix possible oops in probe error handling

2020-12-02 Thread Chrisanthus, Anitha
Thanks Dan. > -Original Message- > From: Dan Carpenter > Sent: Sunday, November 29, 2020 11:48 PM > To: Chrisanthus, Anitha > Cc: Dea, Edmund J ; David Airlie ; > Daniel Vetter ; Sam Ravnborg ; dri- > de...@lists.freedesktop.org; kernel-janit...@vger.kernel.org >

RE: [PATCH] drm/kmb: fix array bounds warning

2020-11-30 Thread Chrisanthus, Anitha
Hi Arnd, Thanks for your patch. > -Original Message- > From: Arnd Bergmann > Sent: Sunday, November 29, 2020 12:09 PM > To: Chrisanthus, Anitha ; Dea, Edmund J > ; David Airlie ; Daniel Vetter > ; Sam Ravnborg > Cc: Arnd Bergmann ; lkp ; dri- > de...@lists.fr

RE: [PATCH][next] drm/kmb: fix array out-of-bounds writes to kmb->plane_status[]

2020-11-16 Thread Chrisanthus, Anitha
Hi Sam and Colin, > -Original Message- > From: Sam Ravnborg > Sent: Friday, November 13, 2020 10:02 AM > To: Colin Ian King > Cc: Chrisanthus, Anitha ; Dea, Edmund J > ; David Airlie ; Daniel Vetter > ; dri-devel@lists.freedesktop.org; kernel- > janit...@vg

RE: [PATCH] drm/kmb: Remove an unnecessary NULL check

2020-11-19 Thread Chrisanthus, Anitha
Looks good to me. Anitha > -Original Message- > From: Dan Carpenter > Sent: Monday, November 16, 2020 11:22 PM > To: Chrisanthus, Anitha > Cc: Dea, Edmund J ; David Airlie ; > Daniel Vetter ; dri-devel@lists.freedesktop.org; kernel- > janit...@vger.kernel.org >

RE: [PATCH] drm/kmb: Fix possible oops in probe error handling

2020-11-19 Thread Chrisanthus, Anitha
Hi Dan, > -Original Message- > From: Dan Carpenter > Sent: Monday, November 16, 2020 11:21 PM > To: Chrisanthus, Anitha > Cc: Dea, Edmund J ; David Airlie ; > Daniel Vetter ; Sam Ravnborg ; dri- > de...@lists.freedesktop.org; kernel-janit...@vger.kernel.org >

RE: [PATCH] drm/kmb: Remove an unnecessary NULL check

2020-11-20 Thread Chrisanthus, Anitha
> -Original Message- > From: Thomas Zimmermann > Sent: Friday, November 20, 2020 12:34 AM > To: Sam Ravnborg ; Chrisanthus, Anitha > > Cc: David Airlie ; Dea, Edmund J ; > kernel-janit...@vger.kernel.org; dri-devel@lists.freedesktop.org; Dan > Carpenter > S

RE: [PATCH v2] drm/kmb: Fix possible oops in probe error handling

2020-11-20 Thread Chrisanthus, Anitha
Hi Dan, I see the problem now, thanks for the patch. > -Original Message- > From: Dan Carpenter > Sent: Friday, November 20, 2020 12:11 AM > To: Chrisanthus, Anitha > Cc: Dea, Edmund J ; David Airlie ; > Daniel Vetter ; Sam Ravnborg ; dri- > de...@lists.freedesk

RE: [PATCH 1/1] drm/kmb: Fix error return code in kmb_hw_init()

2021-06-22 Thread Chrisanthus, Anitha
Thanks for the patch. Patch pushed to drm-misc-fixes. Anitha > -Original Message- > From: Chrisanthus, Anitha > Sent: Thursday, May 13, 2021 10:12 AM > To: Zhen Lei ; Dea, Edmund J > ; David Airlie ; Daniel Vetter > ; Sam Ravnborg ; dri-devel de...@lists.freedesktop.

RE: [PATCH 1/1] drm/kmb: Fix error return code in kmb_hw_init()

2021-05-13 Thread Chrisanthus, Anitha
Thanks for the patch. Reviewed-by: Anitha Chrisanthus > -Original Message- > From: Zhen Lei > Sent: Thursday, May 13, 2021 6:47 AM > To: Chrisanthus, Anitha ; Dea, Edmund J > ; David Airlie ; Daniel Vetter > ; Sam Ravnborg ; dri-devel de...@lists.freedesktop.o

RE: [PATCH v2 2/2] drm/kmb: Do not report 0 (success) in case of error

2021-05-27 Thread Chrisanthus, Anitha
This is already fixed in the patch from Zhen Lei. > -Original Message- > From: Christophe JAILLET > Sent: Wednesday, May 26, 2021 11:10 PM > To: Chrisanthus, Anitha ; Dea, Edmund J > ; airl...@linux.ie; dan...@ffwll.ch; > s...@ravnborg.org > Cc: dri-devel@lists.freed

RE: [PATCH] drm/kmb: Fix an error handling path

2021-05-26 Thread Chrisanthus, Anitha
Hi Christophe, Thanks for the patch, good catch! Patch looks good, few minor comments. Anitha > -Original Message- > From: Christophe JAILLET > Sent: Wednesday, May 19, 2021 1:47 PM > To: Chrisanthus, Anitha ; Dea, Edmund J > ; airl...@linux.ie; dan...@ffwll.ch; > s...

RE: [PATCH linux-next] : add put_device() after of_find_device_by_node()

2021-08-26 Thread Chrisanthus, Anitha
Hi Jing, > -Original Message- > From: Chrisanthus, Anitha > Sent: Monday, August 23, 2021 4:25 PM > To: jing yangyang > Cc: Dea, Edmund J ; David Airlie ; > Daniel Vetter ; dri-devel@lists.freedesktop.org; linux- > ker...@vger.kernel.org; jing yangyang ; Zeal &

RE: [PATCH linux-next] : add put_device() after of_find_device_by_node()

2021-08-23 Thread Chrisanthus, Anitha
Acked-by: Anitha Chrisanthus > -Original Message- > From: jing yangyang > Sent: Thursday, August 19, 2021 7:10 PM > To: Chrisanthus, Anitha > Cc: Dea, Edmund J ; David Airlie ; > Daniel Vetter ; dri-devel@lists.freedesktop.org; linux- > ker...@vger.kernel.org;

RE: [PATCH] drm/kmb: Avoid warnings on impossible plane_id

2021-08-25 Thread Chrisanthus, Anitha
in this series, and we are waiting for reviews on those before this can be checked in. Thanks, Anitha > -Original Message- > From: Kees Cook > Sent: Wednesday, August 25, 2021 11:18 AM > To: Chrisanthus, Anitha > Cc: Kees Cook ; Dea, Edmund J > ; David Airlie ; Daniel Ve

RE: [PATCH] drm/kmb: Avoid warnings on impossible plane_id

2021-09-07 Thread Chrisanthus, Anitha
; From: Chrisanthus, Anitha > Sent: Wednesday, August 25, 2021 1:44 PM > To: Kees Cook > Cc: Dea, Edmund J ; David Airlie ; > Daniel Vetter ; dri-devel@lists.freedesktop.org; Sam > Ravnborg ; linux-ker...@vger.kernel.org; linux- > harden...@vger.kernel.org > Subject: RE: [PAT

RE: [PATCH 13/14] drm/kmb: Enable alpha blended second plane

2021-08-02 Thread Chrisanthus, Anitha
Hi Sam, Thanks. Where should this go, drm-misc-fixes or drm-misc-next? Anitha > -Original Message- > From: Sam Ravnborg > Sent: Wednesday, July 28, 2021 12:29 AM > To: Chrisanthus, Anitha > Cc: dri-devel@lists.freedesktop.org; Dea, Edmund J > > Subject: Re:

RE: [PATCH 02/14] drm/kmb: Define driver date and major/minor version

2021-08-05 Thread Chrisanthus, Anitha
Thanks Thomas, I'll keep this in mind for the next patch. > -Original Message- > From: dri-devel On Behalf Of > Thomas Zimmermann > Sent: Wednesday, August 4, 2021 11:13 AM > To: Chrisanthus, Anitha ; dri- > de...@lists.freedesktop.org; Dea, Edmund J > Subject: Re:

RE: [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy

2021-08-05 Thread Chrisanthus, Anitha
Hi Thomas, > -Original Message- > From: Thomas Zimmermann > Sent: Wednesday, August 4, 2021 12:11 AM > To: Chrisanthus, Anitha ; Sam Ravnborg > > Cc: dan...@ffwll.ch; airl...@linux.ie; alexander.deuc...@amd.com; > christian.koe...@amd.com; liviu.du...@arm.com;

RE: [PATCH 01/14] drm/kmb: Enable LCD DMA for low TVDDCV

2021-07-29 Thread Chrisanthus, Anitha
12:05 AM > To: Chrisanthus, Anitha > Cc: dri-devel@lists.freedesktop.org; Dea, Edmund J > > Subject: Re: [PATCH 01/14] drm/kmb: Enable LCD DMA for low TVDDCV > > Hi Anitha, > On Tue, Jul 27, 2021 at 05:31:13PM -0700, Anitha Chrisanthus wrote: > > From: Edmund Dea > &

RE: [PATCH 09/14] drm/kmb : W/A for planar formats

2021-07-28 Thread Chrisanthus, Anitha
Please ignore this patch. Will combine this with 256B w/a patch. > -Original Message- > From: Chrisanthus, Anitha > Sent: Tuesday, July 27, 2021 5:31 PM > To: dri-devel@lists.freedesktop.org; Chrisanthus, Anitha > ; Dea, Edmund J > Subject: [PATCH 09/14] drm/kmb : W/A

RE: [PATCH 12/14] drm/kmb: Fix possible oops in error handling

2021-07-28 Thread Chrisanthus, Anitha
Hi Sam, > -Original Message- > From: Sam Ravnborg > Sent: Wednesday, July 28, 2021 12:27 AM > To: Chrisanthus, Anitha > Cc: dri-devel@lists.freedesktop.org; Dea, Edmund J > ; Dan Carpenter > Subject: Re: [PATCH 12/14] drm/kmb: Fix possible oops in error ha

RE: [PATCH 04/14] drm/kmb : W/A for 256B cache alignment for video

2021-07-28 Thread Chrisanthus, Anitha
Hi Sam, Thanks for you review. > -Original Message- > From: Sam Ravnborg > Sent: Wednesday, July 28, 2021 12:16 AM > To: Chrisanthus, Anitha > Cc: dri-devel@lists.freedesktop.org; Dea, Edmund J > > Subject: Re: [PATCH 04/14] drm/kmb : W/A for 256B cache alignm

RE: [PATCH 14/14] drm/kmb: Enable support for fbcon (framebuffer console)

2021-07-28 Thread Chrisanthus, Anitha
Hi Sam, Thanks for the review. > -Original Message- > From: Sam Ravnborg > Sent: Wednesday, July 28, 2021 12:31 AM > To: Chrisanthus, Anitha > Cc: dri-devel@lists.freedesktop.org; Dea, Edmund J > > Subject: Re: [PATCH 14/14] drm/kmb: Enable support for fbcon (

RE: [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy

2021-08-03 Thread Chrisanthus, Anitha
mrip...@kernel.org; ste...@agner.ch; > alison.w...@nxp.com; patrik.r.jakobs...@gmail.com; Chrisanthus, Anitha > ; robdcl...@gmail.com; Dea, Edmund J > ; s...@poorly.run; shawn...@kernel.org; > s.ha...@pengutronix.de; ker...@pengutronix.de; jyri.sa...@iki.fi; > to...@kernel.org; d

RE: [PATCH v3 7/7] drm/kmb: Enable support for framebuffer console

2021-10-15 Thread Chrisanthus, Anitha
Hi Thomas, Thanks for your review. > -Original Message- > From: Thomas Zimmermann > Sent: Thursday, October 14, 2021 5:50 AM > To: Chrisanthus, Anitha ; dri- > de...@lists.freedesktop.org > Cc: s...@ravnborg.org; Dea, Edmund J > Subject: Re: [PATCH v3 7/7] dr

RE: [PATCH v3 7/7] drm/kmb: Enable support for framebuffer console

2021-10-15 Thread Chrisanthus, Anitha
Hi Thomas, Thanks for your review. > -Original Message- > From: Thomas Zimmermann > Sent: Thursday, October 14, 2021 6:08 AM > To: Chrisanthus, Anitha ; dri- > de...@lists.freedesktop.org > Cc: s...@ravnborg.org; Dea, Edmund J > Subject: Re: [PATCH v3 7/7] dr

RE: [PATCH] drm/kmb: Remove set_test_mode_src_osc_freq_target_{hi,low}_bits()

2021-09-28 Thread Chrisanthus, Anitha
Thanks for the patch. Looks good. Acked-by: Anitha Chrisanthus > -Original Message- > From: Nathan Chancellor > Sent: Tuesday, September 28, 2021 12:24 PM > To: Chrisanthus, Anitha ; Dea, Edmund J > > Cc: Geert Uytterhoeven ; Nick Desaulniers > ; dri-devel@lists.f

RE: [PATCH] drm/kmb: Fix for build errors with Warray-bounds

2022-01-27 Thread Chrisanthus, Anitha
Thanks. Fixed line wrapping and change is pushed to drm-misc-fixes. > -Original Message- > From: dri-devel On Behalf Of Kees > Cook > Sent: Thursday, January 27, 2022 1:14 PM > To: Chrisanthus, Anitha > Cc: Dea, Edmund J ; s...@ravnborg.org; dri- > de...@lis

RE: [PATCH v3 2/5] drm/kmb: add trailing newlines to drm_dbg msgs

2023-09-06 Thread Chrisanthus, Anitha
org; intel- > g...@lists.freedesktop.org > Cc: daniel.vet...@ffwll.ch; dan...@ffwll.ch; Nikula, Jani > ; ville.syrj...@linux.intel.com; > seanp...@chromium.org; robdcl...@gmail.com; Jim Cromie > ; Chrisanthus, Anitha > ; Edmund Dea ; > David Airlie > Subject: [PATCH v3 2/5] drm/kmb

RE: [PATCH] drm/kmb: fix dereference before NULL check in kmb_plane_atomic_update()

2022-07-29 Thread Chrisanthus, Anitha
Agree with Thomas, drm_atomic_commit() will not call kmb_atomic_update() with a NULL plane. This is not an actual bug. Thanks, Anitha > -Original Message- > From: Thomas Zimmermann > Sent: Friday, July 29, 2022 7:26 AM > To: Zeng Jingxiang ; Chrisanthus, Anitha

RE: [PATCH 09/22] drm/kmb: Use GEM DMA fbdev emulation

2023-03-06 Thread Chrisanthus, Anitha
.pa...@oss.nxp.com; l.st...@pengutronix.de; > shawn...@kernel.org; s.ha...@pengutronix.de; ker...@pengutronix.de; > feste...@gmail.com; linux-...@nxp.com; p.za...@pengutronix.de; > Chrisanthus, Anitha ; > edmund.j@intel.com; khil...@baylibre.com; jbru...@baylibre.com; > martin.blume