Re: [PATCH v13 6/6] drm/mediatek: set dpi pin mode to gpio low to avoid leakage current

2020-03-11 Thread Chun-Kuang Hu
Jitao Shi 於 2020年3月11日 週三 下午3:19寫道: > Config dpi pins mode to output and pull low when dpi is disabled. > Aovid leakage current from some dpi pins (Hsync Vsync DE ... ). > > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/me

Re: [PATCH v13 2/6] dt-bindings: display: mediatek: control dpi pins mode to avoid leakage

2020-03-11 Thread Chun-Kuang Hu
Jitao Shi 於 2020年3月11日 週三 下午3:18寫道: > Add property "pinctrl-names" to swap pin mode between gpio and dpi mode. > Set > the dpi pins to gpio mode and output-low to avoid leakage current when dpi > disabled. > Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Jit

Re: [PATCH v5 4/4] drm/mediatek: config mipitx impedance with calibration data

2020-04-10 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年4月10日 週五 下午12:33寫道: > > Read calibration data from nvmem, and config mipitx impedance with > calibration data to make sure their impedance are 100ohm. > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_mipi_tx.c| 40 +++ >

Re: [PATCH v6 4/4] drm/mediatek: config mipitx impedance with calibration data

2020-04-11 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年4月11日 週六 下午3:45寫道: > > Read calibration data from nvmem, and config mipitx impedance with > calibration data to make sure their impedance are 100ohm. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/m

Re: [PATCH v12 4/5] soc / drm: mediatek: Move routing control to mmsys device

2020-04-16 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2020年3月26日 週四 下午11:45寫道: > > > > On 26/03/2020 15:51, CK Hu wrote: > > Hi, Matthias: > > > > On Thu, 2020-03-26 at 12:54 +0100, Matthias Brugger wrote: > >> Hi CK, > >> > >> On 26/03/2020 00:05, CK Hu wrote: > >>> Hi, Matthias: > >>> > >>> On Wed, 2020-03-25 at

Re: [PATCH] drm: mediatek: fix device passed to cmdq

2020-04-06 Thread Chun-Kuang Hu
.748721] mediatek-drm mediatek-drm.1.auto: error -2 can't parse > gce-client-reg property (0) > ... > [2.659645] mediatek-drm mediatek-drm.1.auto: failed to request channel > [2.666270] mediatek-drm mediatek-drm.1.auto: failed to request channel Reviewed-by: Chun-Kuang Hu &g

Re: [PATCH v15 1/3] dt-bindings: display: mediatek: control dpi pins mode to avoid leakage

2020-04-18 Thread Chun-Kuang Hu
git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Acked-by: Rob Herring > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Jitao Shi > --- > Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt | 6

Re: [PATCH v15 3/3] drm/mediatek: set dpi pin mode to gpio low to avoid leakage current

2020-04-18 Thread Chun-Kuang Hu
nkuang.hu/linux.git/log/?h=mediatek-drm-next Regards,Chun-Kuang. > > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 31 +++ > 1 file changed, 31 insertions(+) > > diff --git a/drivers/gpu/drm/me

Re: [PATCH v6 1/4] dt-bindings: display: mediatek: add property to control mipi tx drive current

2020-04-18 Thread Chun-Kuang Hu
Hi, Rob: How do you think about this patch? This patch looks good to me. Regards, Chun-Kuang. Jitao Shi 於 2020年4月11日 週六 下午3:44寫道: > > Add a property to control mipi tx drive current: > "drive-strength-microamp" > > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Jitao

Re: [PATCH v2] drm: mediatek: fix device passed to cmdq

2020-04-09 Thread Chun-Kuang Hu
.748721] mediatek-drm mediatek-drm.1.auto: error -2 can't parse > gce-client-reg property (0) > ... > [2.659645] mediatek-drm mediatek-drm.1.auto: failed to request channel > [2.666270] mediatek-drm mediatek-drm.1.auto: failed to request channel Reviewed-by: Chun-Kuang Hu &g

Re: [PATCH v3 1/4] drm/mediatek: Move tz_disabled from mtk_hdmi_phy to mtk_hdmi driver

2020-04-02 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2020年4月1日 週三 下午11:53寫道: > > > > On 01/04/2020 04:16, Chunfeng Yun wrote: > > On Tue, 2020-03-31 at 23:57 +0800, Chun-Kuang Hu wrote: > >> From: CK Hu > >> > >> tz_disabled is used to control mtk_hdmi ou

Re: [PATCH v14 1/3] dt-bindings: display: mediatek: control dpi pins mode to avoid leakage

2020-04-04 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年4月3日 週五 下午4:04寫道: > > Add property "pinctrl-names" to swap pin mode between gpio and dpi mode. Set > the dpi pins to gpio mode and output-low to avoid leakage current when dpi > disabled. > Reviewed-by: Chun-Kuang Hu &

Re: [PATCH v4 4/4] drm/mediatek: config mipitx impedance with calibration data

2020-04-04 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年3月31日 週二 下午4:28寫道: > > Read calibration data from nvmem, and config mipitx impedance with > calibration data to make sure their impedance are 100ohm. > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_mt8183_mipi_tx.c | 57 +++ > 1

Re: [PATCH v14 3/3] drm/mediatek: set dpi pin mode to gpio low to avoid leakage current

2020-04-04 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年4月3日 週五 下午4:04寫道: > > Config dpi pins mode to output and pull low when dpi is disabled. > Aovid leakage current from some dpi pins (Hsync Vsync DE ... ). Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/me

Re: [PATCH v4 2/4] dt-bindings: display: mediatek: get mipitx calibration data from nvmem

2020-04-04 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年3月31日 週二 下午4:28寫道: > > Add properties to get get mipitx calibration data. Reviewed-by: Chun-Kuang Hu > > Reviewed-by: Rob Herring > Signed-off-by: Jitao Shi > --- > .../devicetree/bindings/display/mediatek/mediatek,dsi.txt| 5 +

Re: [PATCH v4 1/4] dt-bindings: display: mediatek: add property to control mipi tx drive current

2020-04-04 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年3月31日 週二 下午4:28寫道: > > Add a property to control mipi tx drive current: > "drive-strength-microamp" Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Jitao Shi > --- > .../devicetree/bindings/display/mediatek/mediatek,dsi.txt

Re: [PATCH v4 3/4] drm/mediatek: add the mipitx driving control

2020-04-04 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年3月31日 週二 下午4:28寫道: > > Add a property in device tree to control the driving by different > board. Reviewed-by: Chun-Kuang Hu > > Reviewed-by: Matthias Brugger > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/m

Re: [PATCH v4 4/4] drm/mediatek: config mipitx impedance with calibration data

2020-04-05 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年4月5日 週日 下午9:39寫道: > > > On Sat, 2020-04-04 at 22:26 +0800, Chun-Kuang Hu wrote: > > Hi, Jitao: > > > > Jitao Shi 於 2020年3月31日 週二 下午4:28寫道: > > > > > > Read calibration data from nvmem, and config mipitx imped

Re: [PATCH v3 1/4] drm/mediatek: Move tz_disabled from mtk_hdmi_phy to mtk_hdmi driver

2020-04-03 Thread Chun-Kuang Hu
Chunfeng Yun 於 2020年4月3日 週五 上午10:59寫道: > > On Thu, 2020-04-02 at 20:49 +0800, Chun-Kuang Hu wrote: > > Hi, Matthias: > > > > Matthias Brugger 於 2020年4月1日 週三 下午11:53寫道: > > > > > > > > > > > > On 01/04/2020 04:16, Chunfeng Yun wrote: &g

Re: [PATCH v12 3/5] clk / soc: mediatek: Move mt8173 MMSYS to platform driver

2020-03-25 Thread Chun-Kuang Hu
Stephen Boyd 於 2020年3月21日 週六 上午7:14寫道: > > Quoting Enric Balletbo i Serra (2020-03-11 09:53:20) > > From: Matthias Brugger > > > > There is no strong reason for this to use CLK_OF_DECLARE instead of > > being a platform driver. Plus, MMSYS provides clocks but also a shared > > register space for

Re: [PATCH v2 3/4] drm/mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder

2020-03-31 Thread Chun-Kuang Hu
Hi, Neil: Neil Armstrong 於 2020年3月31日 週二 下午4:05寫道: > > Hi, > > On 30/03/2020 16:12, Chun-Kuang Hu wrote: > > From: CK Hu > > > > mtk_hdmi_phy is currently placed inside mediatek drm driver, but it's > > more suitable to place a phy driver into phy driver fol

[PATCH v3 4/4] MAINTAINERS: add files for Mediatek DRM drivers

2020-03-31 Thread Chun-Kuang Hu
Mediatek HDMI phy driver is moved from drivers/gpu/drm/mediatek to drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers' information. Signed-off-by: Chun-Kuang Hu --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 38fe2f3f7b6f

[PATCH v3 0/4] Move Mediatek HDMI PHY driver from DRM folder to PHY folder

2020-03-31 Thread Chun-Kuang Hu
/mediatek: Move tz_disabled from mtk_hdmi_phy to mtk_hdmi driver drm/mediatek: Separate mtk_hdmi_phy to an independent module phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder Chun-Kuang Hu (1): MAINTAINERS: add files for Mediatek DRM drivers MAINTAINERS

[PATCH v3 1/4] drm/mediatek: Move tz_disabled from mtk_hdmi_phy to mtk_hdmi driver

2020-03-31 Thread Chun-Kuang Hu
From: CK Hu tz_disabled is used to control mtk_hdmi output signal, but this variable is stored in mtk_hdmi_phy and mtk_hdmi_phy does not use it. So move tz_disabled to mtk_hdmi where it's used. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_hdmi.c

[PATCH v3 3/4] phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder

2020-03-31 Thread Chun-Kuang Hu
From: CK Hu mtk_hdmi_phy is currently placed inside mediatek drm driver, but it's more suitable to place a phy driver into phy driver folder, so move mtk_hdmi_phy driver into phy driver folder. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Kconfig

[PATCH v3 2/4] drm/mediatek: Separate mtk_hdmi_phy to an independent module

2020-03-31 Thread Chun-Kuang Hu
From: CK Hu mtk_hdmi_phy is a part of mtk_hdmi module, but phy driver should be an independent module rather than be part of drm module, so separate the phy driver to an independent module. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Kconfig| 9

[PATCH v2 1/4] drm/mediatek: Move tz_disabled from mtk_hdmi_phy to mtk_hdmi driver

2020-03-30 Thread Chun-Kuang Hu
From: CK Hu tz_disabled is used to control mtk_hdmi output signal, but this variable is stored in mtk_hdmi_phy and mtk_hdmi_phy does not use it. So move tz_disabled to mtk_hdmi where it's used. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_hdmi.c

[PATCH v2 4/4] MAINTAINERS: add files for Mediatek DRM drivers

2020-03-30 Thread Chun-Kuang Hu
Mediatek HDMI phy driver is moved from drivers/gpu/drm/mediatek to drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers' information. Signed-off-by: Chun-Kuang Hu --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 38fe2f3f7b6f

[PATCH v2 0/4] Move Mediatek HDMI PHY driver from DRM folder to PHY folder

2020-03-30 Thread Chun-Kuang Hu
to mtk_hdmi driver drm/mediatek: Separate mtk_hdmi_phy to an independent module drm/mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder Chun-Kuang Hu (1): MAINTAINERS: add files for Mediatek DRM drivers MAINTAINERS | 1 + drivers/gpu/drm

[PATCH v2 2/4] drm/mediatek: Separate mtk_hdmi_phy to an independent module

2020-03-30 Thread Chun-Kuang Hu
From: CK Hu mtk_hdmi_phy is a part of mtk_hdmi module, but phy driver should be an independent module rather than be part of drm module, so separate the phy driver to an independent module. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Kconfig| 9

[PATCH v2 3/4] drm/mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder

2020-03-30 Thread Chun-Kuang Hu
From: CK Hu mtk_hdmi_phy is currently placed inside mediatek drm driver, but it's more suitable to place a phy driver into phy driver folder, so move mtk_hdmi_phy driver into phy driver folder. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Kconfig

Re: [PATCH -next] drm/mediatek: Fix Kconfig warning

2020-04-28 Thread Chun-Kuang Hu
Daniel Vetter 於 2020年4月28日 週二 下午10:55寫道: > > On Sun, Apr 26, 2020 at 04:20:39PM +0800, Chun-Kuang Hu wrote: > > Hi, YueHaibing: > > > > YueHaibing 於 2020年4月20日 週一 下午10:04寫道: > > > > > > WARNING: unmet direct dependencies detected for MTK_MMSYS

Re: [PATCH] drm/mediatek: stop iterating dma addresses when sg_dma_len() == 0

2020-04-28 Thread Chun-Kuang Hu
Hi, Anand, Anand K. Mistry 於 2020年4月28日 週二 上午9:54寫道: > > On Sun, 26 Apr 2020 at 18:04, Chun-Kuang Hu wrote: > > > > Hi, Anand: > > > > Anand K Mistry 於 2020年4月20日 週一 下午2:09寫道: > > > > > > If dma_map_sg() merges pages when creating the mapping

Re: [PATCH] drm/mediatek: stop iterating dma addresses when sg_dma_len() == 0

2020-04-26 Thread Chun-Kuang Hu
Hi, Anand: Anand K Mistry 於 2020年4月20日 週一 下午2:09寫道: > > If dma_map_sg() merges pages when creating the mapping, only the first > entries will have a valid sg_dma_address() and sg_dma_len(), followed by > entries with sg_dma_len() == 0. > > Signed-off-by: Anand K Mistry > --- >

Re: [PATCH -next] drm/mediatek: Fix Kconfig warning

2020-04-26 Thread Chun-Kuang Hu
Hi, YueHaibing: YueHaibing 於 2020年4月20日 週一 下午10:04寫道: > > WARNING: unmet direct dependencies detected for MTK_MMSYS > Depends on [n]: (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) && > COMMON_CLK_MT8173_MMSYS [=n] > Selected by [y]: > - DRM_MEDIATEK [=y] && HAS_IOMEM [=y] && DRM [=y] &&

Re: [PATCH] drm/mediatek: Remove debug messages for function calls

2020-04-25 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年2月26日 週三 下午7:27寫道: > > Equivalent information can be nowadays obtained using function tracer. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards,

Re: [PATCH v6 0/4] Config mipi tx current and impedance

2020-04-21 Thread Chun-Kuang Hu
Hi, Jitao: For this series, applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. Jitao Shi 於 2020年4月11日 週六 下午3:44寫道: > > Changes since v5: > - remove memset() > - add return to

Re: [PATCH v15 2/3] dt-bindings: display: mediatek: convert the document format from txt to yaml

2020-04-21 Thread Chun-Kuang Hu
Hi, Jitao: Please fixup these checkpatch warnings. WARNING: Missing commit description - Add an appropriate one WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.txt WARNING: DT binding docs and includes should be a

Re: [PATCH v12 4/5] soc / drm: mediatek: Move routing control to mmsys device

2020-04-21 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2020年4月21日 週二 下午5:31寫道: > > > > On 4/16/20 6:22 PM, Chun-Kuang Hu wrote: > > Hi, Matthias: > > > > Matthias Brugger 於 2020年3月26日 週四 下午11:45寫道: > >> > >> > >> > >> On 26/03/2020 15:51, CK Hu wrote:

Re: [PATCH v3 -next] drm/mediatek: Fix Kconfig warning

2020-04-29 Thread Chun-Kuang Hu
mp;& HAS_IOMEM [=y] && DRM [=y] && (ARCH_MEDIATEK [=y] || > ARM && COMPILE_TEST [=n]) && COMMON_CLK [=y] && HAVE_ARM_SMCCC [=y] && OF [=y] > > Make DRM_MEDIATEK depend on MTK_MMSYS to fix this. Reviewed-by: Chun-Kuang Hu > > Fixes: 2c758e30

Re: [PATCH] drm/mediatek: cleanup coding style in mediatek a bit

2020-04-29 Thread Chun-Kuang Hu
Hi, Bernard: Bernard Zhao 於 2020年4月27日 週一 下午3:53寫道: > > This code change is to make code bit more readable. > Optimise array size align to HDMI macro define. > Add check if len is overange. One patch should just do one thing, but this do three things. So break this into three patches. Regards,

Re: [PATCH v3 6/7] drm/mediatek: mtk_dsi: Use the drm_panel_bridge API

2020-05-01 Thread Chun-Kuang Hu
Enric Balletbo i Serra 於 2020年4月17日 週五 下午11:06寫道: > > Replace the manual panel handling code by a drm_panel_bridge. This > simplifies the driver and allows all components in the display pipeline > to be treated as bridges, paving the way to generic connector handling. > > Signed-off-by: Enric

Re: [PATCH v3 6/7] drm/mediatek: mtk_dsi: Use the drm_panel_bridge API

2020-05-01 Thread Chun-Kuang Hu
> Reviewed-by: Chun-Kuang Hu > Signed-off-by: Enric Balletbo i Serra > Reviewed-by: Laurent Pinchart > --- > > Changes in v3: > - Use next_bridge field to store the panel bridge. (Laurent Pinchart) > - Add the bridge.type field. (Laurent Pinchart) > - This patch requir

Re: [PATCH v3 5/7] drm/mediatek: mtk_dsi: Use simple encoder

2020-05-01 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年4月17日 週五 下午11:06寫道: > > The mtk_dsi driver uses an empty implementation for its encoder. Replace > the code with the generic simple encoder. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Enric Balletbo i Serra > Reviewed-by

Re: [PATCH v3 4/7] drm/mediatek: mtk_dsi: Convert to bridge driver

2020-05-01 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年4月17日 週五 下午11:06寫道: > > Convert mtk_dsi to a bridge driver with built-in encoder support for > compatibility with existing component drivers. > > Signed-off-by: Enric Balletbo i Serra > --- > > Changes in v3: > - Add the bridge.type. (Laurent Pinchart) >

Re: [PATCH v3 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-01 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年4月17日 週五 下午11:06寫道: > > Use the drm_bridge_connector helper to create a connector for pipelines > that use drm_bridge. This allows splitting connector operations across > multiple bridges when necessary, instead of having the last bridge in > the chain

Re: Re: [PATCH] drm/mediatek: cleanup coding style in mediatek a bit

2020-04-30 Thread Chun-Kuang Hu
Hi, Bernard: Bernard 於 2020年4月30日 週四 下午2:32寫道: > > > > 发件人:Chun-Kuang Hu > 发送日期:2020-04-29 22:22:50 > 收件人:Bernard Zhao > 抄送人:Chun-Kuang Hu ,Philipp Zabel > ,David Airlie ,Daniel Vetter > ,Matthias Brugger ,DRI Development > ,Linux ARM > ,"moderated li

Re: [PATCH v4 4/7] drm/mediatek: mtk_dsi: Convert to bridge driver

2020-05-01 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月1日 週五 下午11:23寫道: > > Convert mtk_dsi to a bridge driver with built-in encoder support for > compatibility with existing component drivers. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Enric Balletbo i Serra > Acke

Re: [PATCH v4 3/7] drm/mediatek: mtk_dsi: Rename bridge to next_bridge

2020-05-01 Thread Chun-Kuang Hu
l be > named next_bridge. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Enric Balletbo i Serra > Reviewed-by: Laurent Pinchart > Acked-by: Sam Ravnborg > --- > > Changes in v4: None > Changes in v3: > - Replace s/bridge/next bridge/ for comment. (Laurent Pinchart) &g

Re: [PATCH v3 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-01 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月1日 週五 下午10:59寫道: > > Hi Chun-Kuang, > > Thank you for your review. > > On 1/5/20 16:26, Chun-Kuang Hu wrote: > > Hi, Enric: > > > > Enric Balletbo i Serra 於 2020年4月17日 週五 > > 下午11:06寫道: > >>

Re: [PATCH 0/3] Convert mtk-dpi to drm_bridge API

2020-05-09 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月4日 週一 下午10:14寫道: > > The mtk-dpi driver still uses the drm_encoder API which is now somehow > deprecated. We started to move all the Mediatek drivers to the drm_bridge API, > like we did for the mtk-dsi driver [1], this is another small step to be able

Re: [PATCH v2] drm/mediatek: cleanup coding style in mediatek a bit

2020-05-09 Thread Chun-Kuang Hu
Hi, Bernard: Bernard Zhao 於 2020年5月6日 週三 下午8:34寫道: > > This code change is to make code bit more readable. > Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang > Signed-off-by:

Re: [PATCH] drm/mediatek: eliminate the magic number in array size

2020-05-09 Thread Chun-Kuang Hu
Hi, Bernard: Bernard Zhao 於 2020年5月6日 週三 下午8:43寫道: > > Eiminate the magic number in array size, there macro defines in > hdmi.h. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang

[GIT PULL] mediatek drm next for 5.8

2020-05-13 Thread Chun-Kuang Hu
atek a bit drm/mediatek: Eliminate the magic number in array size Chun-Kuang Hu (1): Merge tag 'v5.7-next-drm-stable' of ssh://gitolite.kernel.org/.../matthias.bgg/linux into mediatek-drm-next Enric Balletbo i Serra (7): dt-bindings: mediatek: Update mmsys binding to reflect it is a sy

[GIT PULL v2] mediatek drm next for 5.8

2020-05-17 Thread Chun-Kuang Hu
atek a bit drm/mediatek: Eliminate the magic number in array size Chun-Kuang Hu (1): Merge tag 'v5.7-next-drm-stable' of ssh://gitolite.kernel.org/.../matthias.bgg/linux into mediatek-drm-next Enric Balletbo i Serra (4): dt-bindings: mediatek: Update mmsys binding to reflect it is a sy

Re: [PATCH 2/3] drm/mediatek: mtk_dpi: Convert to bridge driver

2020-05-05 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月4日 週一 下午10:14寫道: > > Convert mtk_dpi to a bridge driver with built-in encoder support for > compatibility with existing component drivers. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Enric Balletbo i Serra > --- > >

Re: [PATCH 3/3] drm/mediatek: mtk_dpi: Use simple encoder

2020-05-05 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月4日 週一 下午10:14寫道: > > The mtk_dpi driver uses an empty implementation for its encoder. Replace > the code with the generic simple encoder. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Enric Balletbo i Serra > --- > >

Re: [PATCH v3 -next] drm/mediatek: Fix Kconfig warning

2020-05-05 Thread Chun-Kuang Hu
Hi, YueHaibing: Chun-Kuang Hu 於 2020年4月29日 週三 下午10:15寫道: > > Hi, YueHaibing: > > YueHaibing 於 2020年4月29日 週三 下午3:14寫道: > > > > WARNING: unmet direct dependencies detected for MTK_MMSYS > > Depends on [n]: (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) &

Re: [PATCH] drm/mediatek: stop iterating dma addresses when sg_dma_len() == 0

2020-05-05 Thread Chun-Kuang Hu
Hi, Anand, Chun-Kuang Hu 於 2020年4月29日 週三 上午12:37寫道: > > Hi, Anand, > > Anand K. Mistry 於 2020年4月28日 週二 上午9:54寫道: > > > > On Sun, 26 Apr 2020 at 18:04, Chun-Kuang Hu wrote: > > > > > > Hi, Anand: > > > > > > Anand K Mistry 於 2020年4月2

Re: [PATCH 20/36] drm/mediatek: remove _unlocked suffix in drm_object_put_unlocked

2020-05-09 Thread Chun-Kuang Hu
gt; Just drop the suffix. It makes the API cleaner. > > Done via the following script: > > __from=drm_gem_object_put_unlocked > __to=drm_gem_object_put > for __file in $(git grep --name-only $__from); do > sed -i "s/$__from/$__to/g" $__file; > done Acked-by: Chun-K

Re: [PATCH] drm/mediatek: stop iterating dma addresses when sg_dma_len() == 0

2020-05-09 Thread Chun-Kuang Hu
Hi, Anand: Anand Mistry 於 2020年5月7日 週四 下午7:56寫道: > > On Wed, May 6, 2020 at 10:59 PM Chun-Kuang Hu wrote: > > > > Hi, Anand: > > > > Anand Mistry 於 2020年5月6日 週三 下午7:03寫道: > > > > > > On Wed, May 6, 2020 at 10:25 AM Chun-Kuang Hu > > &g

Re: [GIT PULL] mediatek drm next for 5.8

2020-05-13 Thread Chun-Kuang Hu
Hi, Daniel: Daniel Vetter 於 2020年5月14日 週四 上午3:45寫道: > > On Thu, May 14, 2020 at 12:16:59AM +0800, Chun-Kuang Hu wrote: > > Hi, Dave & Daniel: > > > > This include dpi pin mode swap, config mipi_tx current and impedance, > > convert mtk-dpi to drm_bridge API, and

Re: [PATCH 0/3] Convert mtk-dpi to drm_bridge API

2020-05-16 Thread Chun-Kuang Hu
Hi, Enric: Chun-Kuang Hu 於 2020年5月10日 週日 上午9:24寫道: > > Hi, Enric: > > Enric Balletbo i Serra 於 2020年5月4日 週一 > 下午10:14寫道: > > > > The mtk-dpi driver still uses the drm_encoder API which is now somehow > > deprecated. We started to move all the Mediatek d

Re: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-16 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月15日 週五 上午1:35寫道: > > Hi again, > > On 14/5/20 19:12, Enric Balletbo i Serra wrote: > > Hi Chun-Kuang, > > > > On 14/5/20 18:44, Chun-Kuang Hu wrote: > >> Hi, Enric: > >> > >> Enric Balletbo i Se

Re: [PATCH] drm/mediatek: Delete not used of_device_get_match_data

2020-05-18 Thread Chun-Kuang Hu
just delete the call to > of_device_get_match_data. > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Matthias Brugger > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c >

Re: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-14 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo Serra 於 2020年5月14日 週四 上午12:41寫道: > > Hi Chun-Kuang, > > Missatge de Enric Balletbo i Serra del > dia dv., 1 de maig 2020 a les 17:25: > > > > Use the drm_bridge_connector helper to create a connector for pipelines > > that use drm_bridge. This allows splitting

Re: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges

2020-05-14 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月14日 週四 下午11:42寫道: > > Hi Chun-Kuang, > > On 14/5/20 16:28, Chun-Kuang Hu wrote: > > Hi, Enric: > > > > Enric Balletbo Serra 於 2020年5月14日 週四 上午12:41寫道: > >> > >> Hi Chun-Kuang, > >> > >&g

Re: [PATCH v13 1/6] dt-bindings: media: add pclk-sample dual edge property

2020-03-17 Thread Chun-Kuang Hu
Hi, Jitao: I agree with Neil, so please base on Boris' effort to negotiate with bridge. Regards, Chun-Kuang Hu Neil Armstrong 於 2020年3月11日 週三 下午9:53寫道: > > Hi, > > On 11/03/2020 08:18, Jitao Shi wrote: > > Some chips's sample mode are rising, falling and dual edge (both >

[PATCH 0/4] Move Mediatek HDMI PHY driver from DRM folder to PHY folder

2020-03-22 Thread Chun-Kuang Hu
mtk_hdmi_phy to an independent module drm/mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder Chun-Kuang Hu (1): MAINTAINERS: add files for Mediatek DRM drivers MAINTAINERS | 1 + drivers/gpu/drm/mediatek/Kconfig | 2 +- drivers/gpu

[PATCH 2/4] drm/mediatek: Separate mtk_hdmi_phy to an independent module

2020-03-22 Thread Chun-Kuang Hu
From: CK Hu mtk_hdmi_phy is a part of mtk_hdmi module, but phy driver should be an independent module rather than be part of drm module, so separate the phy driver to an independent module. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Kconfig| 9

[PATCH 1/4] drm/mediatek: Move tz_disabled from mtk_hdmi_phy to mtk_hdmi driver

2020-03-22 Thread Chun-Kuang Hu
From: CK Hu tz_disabled is used to control mtk_hdmi output signal, but this variable is stored in mtk_hdmi_phy and mtk_hdmi_phy does not use it. So move tz_disabled to mtk_hdmi where it's used. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_hdmi.c

[PATCH 4/4] MAINTAINERS: add files for Mediatek DRM drivers

2020-03-22 Thread Chun-Kuang Hu
Mediatek HDMI phy driver is moved from drivers/gpu/drm/mediatek to drivers/phy/mediatek, so add the new folder to the Mediatek DRM drivers' information. Signed-off-by: Chun-Kuang Hu --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 38fe2f3f7b6f

[PATCH 3/4] drm/mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder

2020-03-22 Thread Chun-Kuang Hu
From: CK Hu mtk_hdmi_phy is currently placed inside mediatek drm driver, but it's more suitable to place a phy driver into phy driver folder, so move mtk_hdmi_phy driver into phy driver folder. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Kconfig

Re: [PATCH 40/51] drm/mtk: Drop explicit drm_mode_config_cleanup call

2020-03-23 Thread Chun-Kuang Hu
m_device > cleanup is check the new error code for _init(). > > Aside: Another driver with a bit much devm_kzalloc, which should > probably use drmm_kzalloc instead ... > > v2: Explain why this cleanup is possible (Laurent). > > v3: Use drmm_mode_config_init() for more clarit

[PATCH] MAINTAINERS: Update Chun-Kuang Hu's email address

2020-03-07 Thread Chun-Kuang Hu
Update my email address to @kernel.org Signed-off-by: Chun-Kuang Hu --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 38fe2f3f7b6f..dceaeebce52a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5607,7 +5607,7 @@ F:include

Re: [PATCH 1/3] drm/mediatek: mtk_dpi: Rename bridge to next_bridge

2020-05-05 Thread Chun-Kuang Hu
l be > named next_bridge. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Enric Balletbo i Serra > --- > > drivers/gpu/drm/mediatek/mtk_dpi.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c > b/drivers/gpu/d

Re: [PATCH v2] drm/mediatek: cleanup coding style in mediatek a bit

2020-05-06 Thread Chun-Kuang Hu
Hi, Bernard: Bernard Zhao 於 2020年5月6日 週三 下午8:34寫道: > > This code change is to make code bit more readable. > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Bernard Zhao > --- > drivers/gpu/drm/mediatek/mtk_hdmi.c | 12 > 1 file changed, 4 insertions(+), 8

Re: [PATCH] drm/mediatek: stop iterating dma addresses when sg_dma_len() == 0

2020-05-06 Thread Chun-Kuang Hu
Hi, Anand: Anand Mistry 於 2020年5月6日 週三 下午7:03寫道: > > On Wed, May 6, 2020 at 10:25 AM Chun-Kuang Hu wrote: > > > > Hi, Anand, > > > > Chun-Kuang Hu 於 2020年4月29日 週三 上午12:37寫道: > > > > > > Hi, Anand, > > > > > > Anand K. Mistry 於

Re: [PATCH] drm/mediatek: eliminate the magic number in array size

2020-05-06 Thread Chun-Kuang Hu
Hi, Bernard: Bernard Zhao 於 2020年5月6日 週三 下午8:43寫道: > > Eiminate the magic number in array size, there macro defines in > hdmi.h. Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Bernard Zhao > --- > drivers/gpu/drm/mediatek/mtk_hdmi.c | 6 +++--- > 1 file changed, 3 in

Re: [PATCH] drm/mediatek: mtk_hdmi: Remove debug messages for function calls

2020-05-19 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月19日 週二 下午5:41寫道: > > Equivalent information can be nowadays obtained using function tracer > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Enric Balletbo i Serra > --- > > drivers/gpu/drm/mediatek/mtk_hdmi.c| 12 +-

Re: [PATCH] drm/mediatek: mtk_mt8173_hdmi_phy: Remove unnused const variables

2020-05-19 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年5月19日 週二 下午5:40寫道: > > There are some `static const u8` variables that are not used, this > triggers a warning building with `make W=1`, it is safe to remove them, > so do it and make the compiler more happy. > Reviewed-by: Chun-Kuang Hu

[GIT PULL v3] mediatek drm next for 5.8

2020-05-20 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This include dpi pin mode swap, config mipi_tx current and impedance, and some fixup. I drop backmerge patches and related fixup in this version. The following changes since commit 8f3d9f354286745c751374f5f1fcafee6b3f3136: Linux 5.7-rc1 (2020-04-12 12:35:55 -0700) are

Re: [GIT PULL v2] mediatek drm next for 5.8

2020-05-21 Thread Chun-Kuang Hu
Hi, Dave: Dave Airlie 於 2020年5月20日 週三 下午1:47寫道: > > On Wed, 20 May 2020 at 15:44, Dave Airlie wrote: > > > > On Mon, 18 May 2020 at 10:06, Chun-Kuang Hu wrote: > > > > > > Hi, Dave & Daniel: > > > > > > This include dpi pin mode swap,

Re: [GIT PULL v2] mediatek drm next for 5.8

2020-05-21 Thread Chun-Kuang Hu
Hi, Dave: Dave Airlie 於 2020年5月20日 週三 下午1:44寫道: > > On Mon, 18 May 2020 at 10:06, Chun-Kuang Hu wrote: > > > > Hi, Dave & Daniel: > > > > This include dpi pin mode swap, config mipi_tx current and impedance, > > and some fixup. I drop drm_bridge patche

Re: [PATCH] drm/mediatek: dsi: fix scrolling of panel with small hfp or hbp

2020-05-27 Thread Chun-Kuang Hu
Hi, Jitao: Jitao Shi 於 2020年5月22日 週五 下午6:12寫道: > > If panel has too small hfp or hbp, horizontal_frontporch_byte or > horizontal_backporch_byte may become very small value or negative > value. This patch adjusts their values so that they are greater > than minimum value and keep total of them

Re: [PATCH v5 10/13] soc: mediatek: cmdq: export finalize function

2020-05-24 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2020年5月17日 週日 上午2:22寫道: > > > > On 08/03/2020 11:52, Dennis YC Hsieh wrote: > > Export finalize function to client which helps append eoc and jump > > command to pkt. Let client decide call finalize or not. > > > > Signed-off-by: Dennis YC Hsieh > > Reviewed-by:

Re: [PATCH v5 10/13] soc: mediatek: cmdq: export finalize function

2020-05-25 Thread Chun-Kuang Hu
Hi, Matthias: Matthias Brugger 於 2020年5月25日 週一 下午4:38寫道: > > > > On 25/05/2020 02:23, Chun-Kuang Hu wrote: > > Hi, Matthias: > > > > Matthias Brugger 於 2020年5月17日 週日 上午2:22寫道: > >> > >> > >> > >> On 08/03/2020 11:52, Dennis YC

Re: [PATCH 4/8] drm/mtk: Use __drm_atomic_helper_crtc_reset

2020-06-23 Thread Chun-Kuang Hu
Hi, Daniel: Daniel Vetter 於 2020年6月13日 週六 上午12:01寫道: > > Now also comes with the added benefit of doing a drm_crtc_vblank_off(), > which means vblank state isn't ill-defined and fail-y at driver load > before the first modeset on each crtc. > Acked-by: Chun-Kuang Hu > Sig

Re: [PATCH v4] drm/mediatek: check plane visibility in atomic_update

2020-06-26 Thread Chun-Kuang Hu
x/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Chun-Kuang Hu > Reviewed-by: Tomasz Figa > --- > v4: fix commit

Re: [PATCH] drm/mediatek: remove unnecessary conversion to bool

2020-06-15 Thread Chun-Kuang Hu
Joe Perches 於 2020年6月15日 週一 上午4:41寫道: > > On Fri, 2020-06-12 at 20:40 +0800, Bernard Zhao wrote: > > In function mtk_dsi_clk_hs_state, remove unnecessary conversion > > to bool return, this change is to make the code a bit readable. > [] > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c > >

Re: [PATCH] drm/mediatek: check plane visibility in atomic_update

2020-06-22 Thread Chun-Kuang Hu
Hi, Hsin-Yi: Hsin-Yi Wang 於 2020年6月22日 週一 下午1:32寫道: > > Disable the plane if it's not visible. Otherwise mtk_ovl_layer_config() > would proceed with invalid plane and we may see vblank timeout. Except the Fixes tag, Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Hsin-Yi Wang &

Re: [PATCH v2] drm/mediatek: remove unnecessary conversion to bool

2020-06-28 Thread Chun-Kuang Hu
Hi, Bernard: Bernard Zhao 於 2020年6月16日 週二 下午2:51寫道: > > In function mtk_dsi_clk_hs_state, remove unnecessary conversion > to bool return, this change is to make the code a bit readable. Applied to mediatek-drm-fixes [1], thanks. [1]

Re: [RESEND PATCH v4 0/7] Convert mtk-dsi to drm_bridge API and get EDID for ps8640 bridge

2020-06-30 Thread Chun-Kuang Hu
ge API > >> unconditionally. > >> > >> The patches has been tested on a Acer Chromebook R13 (Elm) running a > >> Chrome OS userspace and checking that the valid EDID mode reported by > >> the bridge is selected. > >> > >> Changes

Re: [PATCH v3 8/9] soc: mediatek: cmdq: add clear option in cmdq_pkt_wfe api

2020-07-07 Thread Chun-Kuang Hu
Hi, Dennis: Dennis YC Hsieh 於 2020年7月7日 週二 下午11:47寫道: > > Add clear parameter to let client decide if > event should be clear to 0 after GCE receive it. For DRM part, Acked-by: Chun-Kuang Hu > > Change since v2: > - Keep behavior in drm crtc driver and > separate bug

Re: [PATCH v3 9/9] drm/mediatek: reduce clear event

2020-07-07 Thread Chun-Kuang Hu
Hi, Dennis: Dennis YC Hsieh 於 2020年7月7日 週二 下午11:47寫道: > > No need to clear event again since event always clear before wait. > This fix depend on patch: > "soc: mediatek: cmdq: add clear option in cmdq_pkt_wfe api" Acked-by: Chun-Kuang Hu > > Fixes: 2f965be7f900

[GIT PULL] mediatek drm fixes for 5.8

2020-07-07 Thread Chun-Kuang Hu
Hi, Dave & David: This include fixup for cmdq, mmsys, visibility checking and some refinement. Regards, Chun-Kuang. The following changes since commit b3a9e3b9622ae10064826dccb4f7a52bd88c7407: Linux 5.8-rc1 (2020-06-14 12:45:04 -0700) are available in the Git repository at:

Re: [GIT PULL] mediatek drm fixes for 5.8

2020-07-07 Thread Chun-Kuang Hu
Hi, Daniel: Chun-Kuang Hu 於 2020年7月7日 週二 下午11:39寫道: > > Hi, Dave & David: Sorry for your name. > > This include fixup for cmdq, mmsys, visibility checking and some refinement. > > Regards, > Chun-Kuang. > > > The following changes since commit b3a9e3

Re: [RESEND PATCH v4 5/7] drm/mediatek: mtk_dsi: Use simple encoder

2020-07-04 Thread Chun-Kuang Hu
nkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Signed-off-by: Enric Balletbo i Serra > Reviewed-by: Laurent Pinchart > Acked-by: Sam Ravnborg > Reviewed-by: Chun-Kuang Hu > --- > > Changes in v4: None > Changes in v3: None > Changes in v2: None

Re: [PATCH] drm/mediatek: Delete not used of_device_get_match_data

2020-07-04 Thread Chun-Kuang Hu
Hi, Matthias: 於 2020年5月18日 週一 下午7:23寫道: > > From: Matthias Brugger > > The driver will be loaded by via a platform device. So we > will need to get the device_node from the parent device. > Depending on this we will set the driver data. > As all this is done later already, just delete the call

Re: [PATCH] drm/mediatek: mtk_mt8173_hdmi_phy: Remove unnused const variables

2020-07-04 Thread Chun-Kuang Hu
Hi, Enric: Chun-Kuang Hu 於 2020年5月19日 週二 下午11:12寫道: > > Hi, Enric: > > Enric Balletbo i Serra 於 2020年5月19日 週二 > 下午5:40寫道: > > > > There are some `static const u8` variables that are not used, this > > triggers a warning building with `make W=1`, it is safe to r

  1   2   >